[GitHub] commons-fileupload pull request #17: Move static analysis plugins from repor...

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/commons-fileupload/pull/17

Move static analysis plugins from reporting to build

Moving the static code analysis plugins maven-checkstyle-plugin and
maven-pmd-plugin from the reporting to the build section and executing
them in the validate phase has the advantage to actively prevent code
style issues to ever be committed rather then passively react to them
after the report section has been run (not part of the current CI
script and build instructions anyway).

Some notes:
  * PMD's `RedundantThrows` is no longer available. I can research the 
stackoverflow.com post again if you absolutely need a reference.
  * Renaming tests ending in `TestCase` to `Test` and making the prefix 
`Mock` a suffix has been done for convenience.
  * Some Javadoc comments in the form of "The [field name]" are poor. Leave 
a line comment is you have suggestions.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/commons-fileupload checkstyle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/17.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #17


commit b33c20cab9e96ad89168569de08916a0b1539f38
Author: Karl-Philipp Richter 
Date:   2018-05-21T17:06:33Z

Move static analysis plugins from reporting to build

Moving the static code analysis plugins maven-checkstyle-plugin and
maven-pmd-plugin from the reporting to the build section and executing
them in the validate phase has the advantage to actively prevent code
style issues to ever be committed rather then passively react to them
after the report section has been run (not part of the current CI
script and build instructions anyway).




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-fileupload/pull/16


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #16: Use Apache Commons I/O in tests

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/commons-fileupload/pull/16

Use Apache Commons I/O in tests

Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils
equivalent which throw IOException instead of returning false which
reduces the change to miss unexpected failures and removed assertions
testing the function of Apache Commons I/O which is not our job.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/commons-fileupload commons-io

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 41694d54cf4fc2d8db1d3cb2651e52ed72aab166
Author: Karl-Philipp Richter 
Date:   2018-05-21T18:12:53Z

Use Apache Commons I/O in tests

Replace File.delete and File.mkdir with Apache Commons I/O's FileUtils
equivalent which throw IOException instead of returning false which
reduces the change to miss unexpected failures and removed assertions
testing the function of Apache Commons I/O which is not our job.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters

[krichter722]

Github user krichter722 closed the pull request at:

https://github.com/apache/commons-fileupload/pull/15


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #15: pom.xml: Remove tab characters

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/commons-fileupload/pull/15

pom.xml: Remove tab characters

pom.xml contains a mixture of spaces and tab characters in order
to indent markup which is confusing. Spaces should be used instead where
applicable.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/commons-fileupload pom-tabs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #15


commit e23e2aab745ccb6c63d2b54c894d3ab64c5b0a96
Author: Karl-Philipp Richter 
Date:   2018-05-21T15:57:24Z

pom.xml: Remove tab characters

pom.xml contains a mixture of spaces and tab characters in order
to indent markup which is confusing. Spaces should be used instead where
applicable.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #14: Add missing @Override annotations

[krichter722]

Github user krichter722 closed the pull request at:

https://github.com/apache/commons-fileupload/pull/14


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #14: Add missing @Override annotations

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/commons-fileupload/pull/14

Add missing @Override annotations

@Override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/commons-fileupload override

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #14


commit 6377a58148c7a24d890007df13ee202a818f4a34
Author: Karl-Philipp Richter 
Date:   2018-05-21T03:16:05Z

Add missing @Override annotations

@Override annotations help to detect architectural errors and respond
quicker to method changes. Unclear why the checkstyle configuration
which includes MissingOverride passes the validation if they're missing.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #13: FileItem.java: remove throwing of Excep...

[krichter722]

GitHub user krichter722 opened a pull request:

https://github.com/apache/commons-fileupload/pull/13

FileItem.java: remove throwing of Exception

Indicating that an interface method throws Exception is overly broad and
hides design issues after inheritance changes.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/krichter722/commons-fileupload 
throws-exception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit 77d68a7ce0d15c05d93ef56f8bd28d0cd454a131
Author: Karl-Philipp Richter 
Date:   2018-05-21T01:20:47Z

FileItem.java: remove throwing of Exception

Indicating that an interface method throws Exception is overly broad and
hides design issues after inheritance changes.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #:

[fangwentong]

Github user fangwentong commented on the pull request:


https://github.com/apache/commons-fileupload/commit/180f6138b185a03ae1ee154b8048d67cf23af181#commitcomment-25838427
  
In src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java:
In src/main/java/org/apache/commons/fileupload/disk/DiskFileItem.java on 
line 418:
It should be: 
```
if (outputFile != null && !isInMemory()  && outputFile.exists()) {
```


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #12: FILEUPLOAD-288: detect file only if the...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-fileupload/pull/12


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #12: FILEUPLOAD-288: detect file only if the...

[fangwentong]

GitHub user fangwentong opened a pull request:

https://github.com/apache/commons-fileupload/pull/12

FILEUPLOAD-288: detect file only if the file written to disk.

see https://issues.apache.org/jira/browse/FILEUPLOAD-288

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fangwentong/commons-fileupload master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/12.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #12


commit b28019b27ab06847815de02ed69fffdfa6bf18d1
Author: fangwentong 
Date:   2017-11-23T05:26:05Z

FILEUPLOAD-288: detect file only if the file written to disk.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #11: travis: fix buffer overflow in Java_jav...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-fileupload/pull/11


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #11: travis: fix buffer overflow in Java_jav...

[PascalSchumacher]

GitHub user PascalSchumacher opened a pull request:

https://github.com/apache/commons-fileupload/pull/11

travis: fix buffer overflow in Java_java_net_Inet4AddressImpl_getLoca…

…lHostName of OpenJDK6 and OpenJDK7 when using precise distribution

To fix this use the current (trusty) distribution and manually install 
openjdk-6-jdk and a java 6 compatible maven version.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PascalSchumacher/commons-fileupload fix_travis

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #11


commit 6fdb82e5040e058f8a67929579bf88f60fa41986
Author: Pascal Schumacher 
Date:   2017-10-08T09:34:18Z

travis: fix buffer overflow in 
Java_java_net_Inet4AddressImpl_getLocalHostName of OpenJDK6 and OpenJDK7 when 
using precise distribution

To fix this use the current (trusty) distribution and manually install 
openjdk-6-jdk and a java 6 compatible maven version.




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

[maxxedev]

Github user maxxedev closed the pull request at:

https://github.com/apache/commons-fileupload/pull/10


---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #10: FILEUPLOAD-286: allow default charset t...

[maxxedev]

GitHub user maxxedev opened a pull request:

https://github.com/apache/commons-fileupload/pull/10

FILEUPLOAD-286: allow default charset to be overridden.

useful in cases where form-data is utf-8 encoded but
not encoding is not explicitly specified

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxxedev/commons-fileupload master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 6b3ac5aea05876e355ed3a0ecc60ab685b5d2810
Author: maxxedev 
Date:   2017-10-06T18:35:34Z

FILEUPLOAD-286: allow default charset to be overridden.

useful in cases where form-data is utf-8 encoded but
not encoding is not explicitly specified




---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #9: Msamery commons fileupload 1.3.2 patch 1

[MSAmery]

GitHub user MSAmery opened a pull request:

https://github.com/apache/commons-fileupload/pull/9

Msamery commons fileupload 1.3.2 patch 1



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSAmery/commons-fileupload 
MSAmery-commons-fileupload-1.3.2-patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #9


commit 459aaa93e02182fd7653d852fba4739529741182
Author: Mark Thomas 
Date:   2014-02-06T17:01:34Z

Tagging 1.3.1-RC1

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/tags/FILEUPLOAD_1_3_1_RC1@1565352
 13f79535-47bb-0310-9956-ffa450edef68

commit e19f0d04ff9d28e5e0d7bc6a4e98b6f04cec6bf8
Author: Mark Thomas 
Date:   2014-02-07T15:07:48Z

FileUpload 1.3.1 RC1 release vote passed

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/tags/FILEUPLOAD_1_3_1@1565671
 13f79535-47bb-0310-9956-ffa450edef68

commit b495a3408f0386156628be46e491afef2134ce79
Author: Jochen Wiedmann 
Date:   2016-01-28T09:11:39Z

Creating a 1.3 branch by copying the 1.3.1 release

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/FILEUPLOAD_1_3_1@1727283
 13f79535-47bb-0310-9956-ffa450edef68

commit 5d9ffbb277c538134f2cbf4a09d491fb933ba6fc
Author: Jochen Wiedmann 
Date:   2016-01-28T09:12:08Z

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1727284
 13f79535-47bb-0310-9956-ffa450edef68

commit bff2e09bbb065a60702150ccef28600e3bc5fd78
Author: Jochen Wiedmann 
Date:   2016-05-12T13:53:05Z

Preparing 1.3.2 release.


git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743507
 13f79535-47bb-0310-9956-ffa450edef68

commit dba92f451d20f68ba17aa5b387739f40e74466af
Author: Jochen Wiedmann 
Date:   2016-05-13T08:55:25Z

[maven-release-plugin] prepare release commons-fileupload-1.3.2

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743624
 13f79535-47bb-0310-9956-ffa450edef68

commit d79a361a0f83ee6d2937b64996976430c1b4ad19
Author: Jochen Wiedmann 
Date:   2016-05-13T08:55:44Z

[maven-release-plugin] prepare for next development iteration

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743626
 13f79535-47bb-0310-9956-ffa450edef68

commit f262cfa6bad41bc136c3ab10099bc8f8051cee39
Author: Jochen Wiedmann 
Date:   2016-05-13T09:05:55Z

[maven-release-plugin] rollback the release of commons-fileupload-1.3.2

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743628
 13f79535-47bb-0310-9956-ffa450edef68

commit 11fa058829e5a46fd293fd71c169006979e295c0
Author: Jochen Wiedmann 
Date:   2016-05-13T09:08:04Z

Upgrading to latest parent POM, so that javadocs work as is.


git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743629
 13f79535-47bb-0310-9956-ffa450edef68

commit e6c6b206b4f8cbd032d1061c5534ef989398095d
Author: Jochen Wiedmann 
Date:   2016-05-13T09:20:45Z

Minor fixes, to make maven-javadoc-plugin happy.


git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743630
 13f79535-47bb-0310-9956-ffa450edef68

commit 72c89e5ccdce9a2a1c88fc1df7993f040ee20138
Author: Jochen Wiedmann 
Date:   2016-05-13T09:25:46Z

[maven-release-plugin] rollback the release of commons-fileupload-1.3.2

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743631
 13f79535-47bb-0310-9956-ffa450edef68

commit 3f8311c0eee9a5e4e423a521e7eb3f691a6fd03b
Author: Jochen Wiedmann 
Date:   2016-05-13T09:26:58Z

Fixing SCM Information: trunk => branches/b1_3


git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743632
 13f79535-47bb-0310-9956-ffa450edef68

commit 75af23d90a79bbbcd06da70a22f7bcd398071983
Author: Jochen Wiedmann 
Date:   2016-05-13T09:28:15Z

[maven-release-plugin] prepare release commons-fileupload-1.3.2

git-svn-id: 
https://svn.apache.org/repos/asf/commons/proper/fileupload/branches/b1_3@1743633
 13f79535-47bb-0310-9956-ffa450edef68

commit 0a7a2cd671e2f9662e4752d7b4fc769e22af29b5
Author: Jochen Wiedmann 
Date:   2016-05-13T09:28:39Z

[maven-release-plugin] prepare for next development iteration

git-svn-id: 

[GitHub] commons-fileupload pull request #:

[PascalSchumacher]

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23494230
  
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java:
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java on 
line 80:
Thanks! Build on travis is now green again. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #:

[kinow]

Github user kinow commented on the pull request:


https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23490295
  
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java:
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java on 
line 80:
You are completely right. Updated my Eclipse configuration to prevent it in 
the future, and fixed in 
https://github.com/apache/commons-fileupload/commit/422caf46e5b7a950c639b8ba9fe41e16279b3aa9

Thanks!!! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #:

[PascalSchumacher]

Github user PascalSchumacher commented on the pull request:


https://github.com/apache/commons-fileupload/commit/86a79bceac4a267819de986ca814f11b48d81da3#commitcomment-23482473
  
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java:
In src/test/java/org/apache/commons/fileupload/ProgressListenerTest.java on 
line 80:
`StandardCharset` is java 7+ and I think commons-fileupload is still java 
6, correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-fileupload/pull/8


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #1: Commons fileupload headerfix

[developerSid]

Github user developerSid closed the pull request at:

https://github.com/apache/commons-fileupload/pull/1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #8: FILEUPLOAD-283: add tests for the portle...

[kinow]

GitHub user kinow opened a pull request:

https://github.com/apache/commons-fileupload/pull/8

FILEUPLOAD-283: add tests for the portlet package

Initial tests for the portlet package. I believe there have been updates to 
the portlet specification(s) that have not been applied to Commons FileUpload 
yet. Hopefully, having unit tests will help us later when changing the package.

Removed strings like "US-ASCII" using the `StandardCharsets` class from 
Java 7.

There was a class -`FileUploadTestCase`- that was extended by other tests. 
But it became problematic as there were tests that would be common to any 
implementation of `FileUpload`, while other tests were specific to 
`ServletFileUpload`.

This pull request removed the inheritance from the tests, by a `Util` class 
(open to other suggestions) with methods for parsing uploads and for tests.

Tests related to `ServletFileUpload` are now in `ServletFileUploadTest`, in 
the `.servlet` package in the test sources.

Tests related to `PortletFileUpload` are now in `PortletFileUploadTest`, in 
the `.portlet` package in the test sources.

There are no functional changes in the tests. Coverage remained the same 
for other classes. For the `.portlet` package, it went from 0% to 60% in my 
local working copy.

There are lots of other parts that need better coverage, but at least I 
think having tests in separated classes will make it slightly easier to add 
more.

Cheers
Bruno

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kinow/commons-fileupload FILEUPLOAD-283

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #8


commit f8f529ee0baecc9262317cc5375af1eb42aadab4
Author: Bruno P. Kinoshita 
Date:   2017-06-11T05:23:07Z

FILEUPLOAD-283: add tests for the portlet package




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

[kinow]

Github user kinow closed the pull request at:

https://github.com/apache/commons-fileupload/pull/7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #7: FILEUPLOAD-238: add tests for the portle...

[kinow]

GitHub user kinow opened a pull request:

https://github.com/apache/commons-fileupload/pull/7

FILEUPLOAD-238: add tests for the portlet package

Initial tests for the portlet package. I believe there have been updates to 
the portlet specification(s) that have not been applied to Commons FileUpload 
yet. Hopefully, having unit tests will help us later when changing the package.

Removed strings like "US-ASCII" using the StandardCharsets class from Java 
7.

There was a class FileUploadTestCase that was extended by other tests. But 
it became problematic as there were tests that would be common to any 
implementation of FileUpload, while other tests were specific to 
ServletFileUpload.

This pull request removed the inheritance from the tests, by a Util class 
(open to other suggestions) with methods for parsing uploads and for tests.

Tests related to ServletFileUpload are now in ServletFileUploadTest, in the 
.servlet package in the test sources.

Tests related to PortletFileUpload are now in PortletFileUploadTest, in the 
.portlet package in the test sources.

There are no functional changes in the tests. Coverage remained the same 
for other classes. For the .portlet package, it went from 0% to 60% in my local 
working copy.

There are lots of other parts that need better coverage, but at least I 
think having tests in separated classes will make it slightly easier to add 
more.

Cheers
Bruno

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kinow/commons-fileupload FILEUPLOAD-238

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/7.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #7


commit 5adc6aefc39aaa39987e909259ef7f1e6bc38e72
Author: Bruno P. Kinoshita 
Date:   2017-06-11T05:23:07Z

FILEUPLOAD-238: add tests for the portlet package




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #:

[kinow]

Github user kinow commented on the pull request:


https://github.com/apache/commons-fileupload/commit/94e5e1a77e4319c98dea22c051e19c1e57c58c00#commitcomment-22573680
  
:clap: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #4: FILEUPLOAD-256 Added null pointer handli...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-fileupload/pull/4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #6: improve GC by avoiding FileInput/Output-...

[alexander-riss]

GitHub user alexander-riss opened a pull request:

https://github.com/apache/commons-fileupload/pull/6

improve GC by avoiding FileInput/Output-Streams

bump compiler target from 1.5 to 1.7

see:  https://bugs.openjdk.java.net/browse/JDK-8080225

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alexander-riss/commons-fileupload 
FileInputStream

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #6


commit 70ef42ab6c77d81ad51a87a1b0fa7bcb06d6a25d
Author: Alexander Riss 
Date:   2017-04-18T13:11:31Z

improve GC by avoiding FileInput/Output-Streams. bump compiler target from 
1.5 to 1.7
see:  https://bugs.openjdk.java.net/browse/JDK-8080225




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-fileupload pull request #5: Update DiskFileItem.java: Avoiding NPE w...

[OleHornischer]

GitHub user OleHornischer opened a pull request:

https://github.com/apache/commons-fileupload/pull/5

Update DiskFileItem.java: Avoiding NPE when not explicitely initializ…

…ing the outputstream

When accessing e.g. getSize() on a DiskFileItem before having called 
getOutputStream() a NullPointerException would be thrown. Consequent use of the 
"intelligent" getter already in place avoids this issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OleHornischer/commons-fileupload trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-fileupload/pull/5.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #5


commit 07b66bb1ebf9ab6b1077c453895e4f0dd62163d7
Author: OleHornischer 
Date:   2016-11-25T09:40:06Z

Update DiskFileItem.java: Avoiding NPE when not explicitely initializing 
the outputstream

When accessing e.g. getSize() on a DiskFileItem before having called 
getOutputStream() a NullPointerException would be thrown. Consequent use of the 
"intelligent" getter already in place avoids this issue.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org