[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/48 ```isDelimiter``` is simply the method to identify if codePoint or char is present in given second parameter which is array. ofcource if array is empty it means first param is not present in array and should return false, I think overall behaviour of ```capitalizeFully``` is correct now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/48 Should we add to `public static boolean isDelimiter(final char ch, final char[] delimiters)` or `isDelimiter` generally, documentation stating that if an empty array is passed in we always return false? I'm torn on this. What are your thoughts @ameyjadiye? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/48 [![Coverage Status](https://coveralls.io/builds/12236812/badge)](https://coveralls.io/builds/12236812) Coverage decreased (-0.002%) to 97.302% when pulling **6323af50bb751a725ab47545c95572703fe1310d on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/48 [![Coverage Status](https://coveralls.io/builds/12236812/badge)](https://coveralls.io/builds/12236812) Coverage decreased (-0.002%) to 97.302% when pulling **6323af50bb751a725ab47545c95572703fe1310d on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/48 I think we are good to merge this as per discussion here [TEXT-88](https://issues.apache.org/jira/browse/TEXT-88) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/48 [![Coverage Status](https://coveralls.io/builds/12224670/badge)](https://coveralls.io/builds/12224670) Coverage decreased (-0.002%) to 97.302% when pulling **3f5dfd4b1cc24fa31446a9ea5821cf267375e552 on ameyjadiye:TEXT-88** into **5e479dcd74dab262e5080991796395c3e29222b9 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #48: TEXT-88: Fixed issue with empty delimiters array wit...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/48 @ameyjadiye The agreed upon fix as of now should be: WordUtils.capitalizeFully("i am fine", new char[]{}) --> I am fine We shouldn't take space as the delimiter as the user explicitly passes an empty array for delimiter . Anyways we are still discussing on that and I guess you can make the required changes once we have an agreement on this . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org