[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/57 Will get to this today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/57 @chtompki Please review and merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user coveralls commented on the issue: https://github.com/apache/commons-text/pull/57 [](https://coveralls.io/builds/12640859) Coverage decreased (-0.2%) to 98.021% when pulling **fb6d5935451397c561bd52cf1d483975f83b2c7b on arunvinudss:TEXT-98** into **998764ebe38113eb51e6850058ca01936625dd92 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/57 @chtompki , I think whichever items are piled up for 2.x are not too critical, we should wait for 2.x release. If we are releasing some major improvement or fix we can release all queued items in that. ATM I don't see anything. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user chtompki commented on the issue: https://github.com/apache/commons-text/pull/57 This all opens the question about going `2.x`. I think we have a couple of things that would warrant a 2.x move. Do we want to attempt that in the fall, or is it still too premature? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user ameyjadiye commented on the issue: https://github.com/apache/commons-text/pull/57 @arunvinudss , just addition to @PascalSchumacher comment , at this point we don't know other than Commons text who else having dependancy on `isDelimiter` so better we can make it depricated and we can remove code all together in 2.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user PascalSchumacher commented on the issue: https://github.com/apache/commons-text/pull/57 @arunvinudss While I agree that `isDelimiter` should have been private, it is public and was released with commons-text `1.1`. Due to the strict binary compatibilities promise of commons it can not be removed before `2.0`. For now the best we can do is mark it as deprecated and explain that it will be removed in version `2.0`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[GitHub] commons-text issue #57: TEXT-98: Remove isDelimiter and use HashSets for del...
Github user arunvinudss commented on the issue: https://github.com/apache/commons-text/pull/57 @ameyjadiye I want to remove the isDelimiter method. I would be surprised if someone uses isDelimiter separately because all it does is to check if a given element is present in an array or not. Moreover the isDelimiter char version is already dead code as we don't use it anymore. I would say the scope of the isDelimiter should have been private. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
