[VOTE] Release Commons Codec 1.7-RC1
Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.commons.codec.binary.Base64InputStreamTest.testInputStreamReader(Base64InputStreamTest.java:110) --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files: https://repository.apache.org/content/repositories/orgapachecommons-046/ The tag: https://svn.apache.org/repos/asf/commons/proper/codec/tags/1.7-RC1 The site: https://people.apache.org/builds/commons/commons-codec/1.7/RC1/ Note that the JIRA report is empty and it is a known issue in the Maven JIRA plugin and that requires a new plugin version. Thank you, Gary Gregory -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory http://twitter.com/GaryGregory
Re: [VOTE] Release Commons Codec 1.7-RC1
Hi Gary, how you manage the non-maven assemblies? I mean, if the vote passes, you just download them from Nexus to the dist machine? TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 3:59 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.commons.codec.binary.Base64InputStreamTest.testInputStreamReader(Base64InputStreamTest.java:110) --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files: https://repository.apache.org/content/repositories/orgapachecommons-046/ The tag: https://svn.apache.org/repos/asf/commons/proper/codec/tags/1.7-RC1 The site: https://people.apache.org/builds/commons/commons-codec/1.7/RC1/ Note that the JIRA report is empty and it is a known issue in the Maven JIRA plugin and that requires a new plugin version. Thank you, Gary Gregory -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory http://twitter.com/GaryGregory
Re: [VOTE] Release Commons Codec 1.7-RC1
On Mon, Sep 10, 2012 at 10:36 AM, Simone Tripodi simonetrip...@apache.orgwrote: Hi Gary, how you manage the non-maven assemblies? I mean, if the vote passes, you just download them from Nexus to the dist machine? Yes, the process is manual. Gary TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 3:59 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.commons.codec.binary.Base64InputStreamTest.testInputStreamReader(Base64InputStreamTest.java:110) --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files: https://repository.apache.org/content/repositories/orgapachecommons-046/ The tag: https://svn.apache.org/repos/asf/commons/proper/codec/tags/1.7-RC1 The site: https://people.apache.org/builds/commons/commons-codec/1.7/RC1/ Note that the JIRA report is empty and it is a known issue in the Maven JIRA plugin and that requires a new plugin version. Thank you, Gary Gregory -- E-Mail: garydgreg...@gmail.com |
Re: [VOTE] Release Commons Codec 1.7-RC1
Hi again Gary, Not a blocker at all, but * RAT plugin shows Sha2CryptTest class does not have the ALv2 license header; * question: Clirr plugin shows some breakage, they all look like internal stuff, did you discuss about these breakage? Apologize but I didn't follow the [codec] thread; Trivial: * CPD shows some code redundancies - arrays initialization can be safely ignored, maybe redundant code invocations could be improved * a couple of minor findbugs[4] notification. I repeat, not blocker at all, but maybe the RAT issue worths another RC, since what e really release at ASF are sources. +1 anyway and thanks a lot for cutting the RC! all the best, -Simo [1] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/rat-report.html [2] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/clirr-report.html [3] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/cpd.html [4] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/findbugs.html http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 5:14 PM, Gary Gregory garydgreg...@gmail.com wrote: On Mon, Sep 10, 2012 at 10:36 AM, Simone Tripodi simonetrip...@apache.orgwrote: Hi Gary, how you manage the non-maven assemblies? I mean, if the vote passes, you just download them from Nexus to the dist machine? Yes, the process is manual. Gary TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 3:59 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at
Re: [VOTE] Release Commons Codec 1.7-RC1
Build works fine with Maven and ant on Windows 7 with JDK 1.6. Artifacts look good, site, too, except for the following very minor points (in addition to the things Simone already discovered): - The JIRA report is just a blank page (I think during build an exception is thrown - maybe an incompatible plug-in version?). - The surefire report says that the tests were not to 100% successful. The release notes mention an issue with IBM Java 1.5.0. But is [codec] compatible with Java 1.5 at all? Maybe I got this wrong. All minor things, maybe the missing ASL header should be fixed. But you have my +1. Oliver Am 10.09.2012 15:59, schrieb Gary Gregory: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.commons.codec.binary.Base64InputStreamTest.testInputStreamReader(Base64InputStreamTest.java:110) --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files: https://repository.apache.org/content/repositories/orgapachecommons-046/ The tag: https://svn.apache.org/repos/asf/commons/proper/codec/tags/1.7-RC1 The site: https://people.apache.org/builds/commons/commons-codec/1.7/RC1/ Note that the JIRA report is empty and it is a known issue in the Maven JIRA plugin and that requires a new plugin version. Thank you, Gary Gregory
Re: [VOTE] Release Commons Codec 1.7-RC1
On 2012-09-10 22:01, Oliver Heger wrote: Build works fine with Maven and ant on Windows 7 with JDK 1.6. Artifacts look good, site, too, except for the following very minor points (in addition to the things Simone already discovered): - The JIRA report is just a blank page (I think during build an exception is thrown - maybe an incompatible plug-in version?). This is due to a bug in the Changes Plugin. I've applied a patch that fixes this and I'm working on getting a release out. Hopefully later this week. I've tried the latest SNAPSHOT on commons-codec and it solves this problem. - The surefire report says that the tests were not to 100% successful. The release notes mention an issue with IBM Java 1.5.0. But is [codec] compatible with Java 1.5 at all? Maybe I got this wrong. All minor things, maybe the missing ASL header should be fixed. But you have my +1. Oliver Am 10.09.2012 15:59, schrieb Gary Gregory: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.apache.commons.codec.binary.Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$ConverterSD.convertInto(StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$ConverterSD.implRead(StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(StreamDecoder.java:252) at java.io.InputStreamReader.read(InputStreamReader.java:212) at java.io.BufferedReader.fill(BufferedReader.java:157) at java.io.BufferedReader.readLine(BufferedReader.java:320) at java.io.BufferedReader.readLine(BufferedReader.java:383) at org.apache.commons.codec.binary.Base64InputStreamTest.testInputStreamReader(Base64InputStreamTest.java:110) --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files:
Re: [VOTE] Release Commons Codec 1.7-RC1
Thank you for the review. See below. On Mon, Sep 10, 2012 at 2:25 PM, Simone Tripodi simonetrip...@apache.orgwrote: Hi again Gary, Not a blocker at all, but * RAT plugin shows Sha2CryptTest class does not have the ALv2 license header; This is a bad one and would be a -1 from me. Fixed in SVN. I'll do an RC2 tomorrow. * question: Clirr plugin shows some breakage, they all look like internal stuff, did you discuss about these breakage? Apologize but I didn't follow the [codec] thread; Yes, this is internal. See: CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. Trivial: * CPD shows some code redundancies - arrays initialization can be safely ignored, maybe redundant code invocations could be improved I'll not deal with that. I am not sure these are worth refactoring the code. * a couple of minor findbugs[4] notification. Unread field: Can't fix w/o breaking BC. BaseNCodec$Context: False positive. Thank you for the detailed review! Gary I repeat, not blocker at all, but maybe the RAT issue worths another RC, since what e really release at ASF are sources. +1 anyway and thanks a lot for cutting the RC! all the best, -Simo [1] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/rat-report.html [2] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/clirr-report.html [3] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/cpd.html [4] https://people.apache.org/builds/commons/commons-codec/1.7/RC1/findbugs.html http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 5:14 PM, Gary Gregory garydgreg...@gmail.com wrote: On Mon, Sep 10, 2012 at 10:36 AM, Simone Tripodi simonetrip...@apache.orgwrote: Hi Gary, how you manage the non-maven assemblies? I mean, if the vote passes, you just download them from Nexus to the dist machine? Yes, the process is manual. Gary TIA, -Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Mon, Sep 10, 2012 at 3:59 PM, Gary Gregory ggreg...@apache.org wrote: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --- Test set: org.apache.commons.codec.binary.Base64InputStreamTest
Re: [VOTE] Release Commons Codec 1.7-RC1
On Mon, Sep 10, 2012 at 4:01 PM, Oliver Heger oliver.he...@oliver-heger.dewrote: Build works fine with Maven and ant on Windows 7 with JDK 1.6. Artifacts look good, site, too, except for the following very minor points (in addition to the things Simone already discovered): - The JIRA report is just a blank page (I think during build an exception is thrown - maybe an incompatible plug-in version?). - The surefire report says that the tests were not to 100% successful. What failed for you? Can you debug? VM? OS? etc. The release notes mention an issue with IBM Java 1.5.0. But is [codec] compatible with Java 1.5 at all? Maybe I got this wrong. Can someone test this on an IBM Java 6 VM? Thank you for the review! Gary All minor things, maybe the missing ASL header should be fixed. But you have my +1. Oliver Am 10.09.2012 15:59, schrieb Gary Gregory: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/**PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --**--** --- Test set: org.apache.commons.codec.**binary.Base64InputStreamTest --**--** --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.**apache.commons.codec.binary.** Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(**ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$**ConverterSD.convertInto(** StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$**ConverterSD.implRead(**StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(**StreamDecoder.java:252) at java.io.InputStreamReader.**read(InputStreamReader.java:**212) at java.io.BufferedReader.fill(**BufferedReader.java:157) at java.io.BufferedReader.**readLine(BufferedReader.java:**320) at java.io.BufferedReader.**readLine(BufferedReader.java:**383) at org.apache.commons.codec.**binary.Base64InputStreamTest.** testInputStreamReader(**Base64InputStreamTest.java:**110) --**--** --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --**--** --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files: https://repository.apache.org/**content/repositories/**
Re: [VOTE] Release Commons Codec 1.7-RC1
On Mon, Sep 10, 2012 at 4:01 PM, Oliver Heger oliver.he...@oliver-heger.dewrote: Build works fine with Maven and ant on Windows 7 with JDK 1.6. Artifacts look good, site, too, except for the following very minor points (in addition to the things Simone already discovered): - The JIRA report is just a blank page (I think during build an exception is thrown - maybe an incompatible plug-in version?). - The surefire report says that the tests were not to 100% successful. The release notes mention an issue with IBM Java 1.5.0. But is [codec] compatible with Java 1.5 at all? Maybe I got this wrong. Codec 1.7 requires Java 6 but I cannot test a Java 6 IBM JVM. I hesitate to remove the note. If someone cannot test, I'll rephrase it as a warning. Thank you, Gary All minor things, maybe the missing ASL header should be fixed. But you have my +1. Oliver Am 10.09.2012 15:59, schrieb Gary Gregory: Hello All: This is a VOTE to release Commons Codec 1.7-RC1. Changes in this version include: New features: o CODEC-157: DigestUtils: Add MD2 APIs. Thanks to ggregory. o CODEC-156: DigestUtils: add APIs named after standard algorithm name SHA-1. Thanks to ggregory. o CODEC-155: DigestUtils.getDigest(String) should throw IllegalArgumentException instead of RuntimeException. Thanks to ggregory. o CODEC-153: Create a class MessageDigestAlgorithms to define standard algorithm names. Thanks to ggregory. o CODEC-152: DigestUtils.getDigest(String) loses the original exception. Thanks to ggregory. o CODEC-151: Remove unnecessary attempt to fill up the salt variable in UnixCrypt. Thanks to lathspell. o CODEC-150: Remove unnecessary call to Math.abs(). Thanks to lathspell. o CODEC-148: More tests and minor things. Thanks to lathspell. o CODEC-146: Added regression tests for PhoneticEngine based on Solr-3.6.0. Thanks to Julius Davies. o CODEC-139: DigestUtils: add updateDigest methods and make methods public. Thanks to dsebastien. o CODEC-133: Add classes for MD5/SHA1/SHA-512-based Unix crypt(3) hash variants. Thanks to lathspell. o CODEC-130: Base64InputStream.skip skips underlying stream, not output. Thanks to tn. o CODEC-63: Implement NYSIIS phonetic encoder. Thanks to bayard. Fixed Bugs: o CODEC-96: Base64 encode() method is no longer thread-safe, breaking clients using it as a shared BinaryEncoder. Note: the fix breaks binary compatibility, however the changes are to a class (BaseNCodec) which is intended for internal use. Thanks to sebb. o CODEC-138: Complete FilterInputStream interface for BaseNCodecInputStream. o CODEC-136: Use Charset objects when possible, create Charsets for required character encodings. o CODEC-132: BeiderMorseEncoder OOM issues. Thanks to rcmuir. o CODEC-131: DoubleMetaphone javadoc contains dead links. Thanks to smolav. Changes: o CODEC-147: BeiderMorseEncoder/**PhoneticEngine: make results deterministic by using a LinkedHashSet instead of a HashSet. o CODEC-143: StringBuffer could be replaced by StringBuilder for local variables. Known issue only on IBM Java 5: --**--** --- Test set: org.apache.commons.codec.**binary.Base64InputStreamTest --**--** --- Tests run: 15, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.287 sec FAILURE! testInputStreamReader(org.**apache.commons.codec.binary.** Base64InputStreamTest) Time elapsed: 0.004 sec ERROR! sun.io.MalformedInputException at sun.io.ByteToCharUTF8.convert(**ByteToCharUTF8.java:310) at sun.nio.cs.StreamDecoder$**ConverterSD.convertInto(** StreamDecoder.java:316) at sun.nio.cs.StreamDecoder$**ConverterSD.implRead(**StreamDecoder.java:366) at sun.nio.cs.StreamDecoder.read(**StreamDecoder.java:252) at java.io.InputStreamReader.**read(InputStreamReader.java:**212) at java.io.BufferedReader.fill(**BufferedReader.java:157) at java.io.BufferedReader.**readLine(BufferedReader.java:**320) at java.io.BufferedReader.**readLine(BufferedReader.java:**383) at org.apache.commons.codec.**binary.Base64InputStreamTest.** testInputStreamReader(**Base64InputStreamTest.java:**110) --**--** --- $ java -version java version 1.5.0 Java(TM) 2 Runtime Environment, Standard Edition (build pxa64devifx-20110627 (SR12 FP5 )) IBM J9 VM (build 2.3, J2RE 1.5.0 IBM J9 2.3 Linux amd64-64 j9vmxa6423ifx-20110624 (JIT enabled) J9VM - 20110623_85457_LHdSMr JIT - 20100623_16197ifx10_r8 GC - FP22011_06) JCL - 20110627 --**--** --- This VOTE is open for at least 72 hours until September 13 2012 at 10:00 AM EST. The files:
Re: [VOTE] Release Commons Codec 1.7-RC1
With IBM Java 1.6: java version 1.6.0 Java(TM) SE Runtime Environment (build pwi3260-20071123_01) IBM J9 VM (build 2.4, J2RE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260-20071121_15015 (JIT enabled) J9VM - 20071121_015015_lHdSMR JIT - r9_20071121_1330 GC - 20071031_AA) JCL - 20071118_01 [This is quite an old IBM Java, IIRC I got it as part of an Eclipse download from IBM] I get the following failures --- Test set: org.apache.commons.codec.binary.StringUtilsTest --- Failed tests: testNewStringUtf16Be(org.apache.commons.codec.binary.StringUtilsTest): expected:?[] but was:?[?] testNewStringUtf16Le(org.apache.commons.codec.binary.StringUtilsTest): expected:?[] but was:?[?] Note that it's not possible to run Maven 2.2.1 with that version of Java; however Maven 3.0.4 works OK - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
[CANCEL][VOTE] Release Commons Codec 1.7-RC1
This VOTE is canceled to fix: - test failures on the IBM JVM - release notes (for the above), - and a missing ASF header. I will reload an RC2 tomorrow. Thank you all and especially Sebb for your diligence. Gary On Mon, Sep 10, 2012 at 7:02 PM, sebb seb...@gmail.com wrote: With IBM Java 1.6: java version 1.6.0 Java(TM) SE Runtime Environment (build pwi3260-20071123_01) IBM J9 VM (build 2.4, J2RE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260-20071121_15015 (JIT enabled) J9VM - 20071121_015015_lHdSMR JIT - r9_20071121_1330 GC - 20071031_AA) JCL - 20071118_01 [This is quite an old IBM Java, IIRC I got it as part of an Eclipse download from IBM] I get the following failures --- Test set: org.apache.commons.codec.binary.StringUtilsTest --- Failed tests: testNewStringUtf16Be(org.apache.commons.codec.binary.StringUtilsTest): expected:?[] but was:?[?] testNewStringUtf16Le(org.apache.commons.codec.binary.StringUtilsTest): expected:?[] but was:?[?] Note that it's not possible to run Maven 2.2.1 with that version of Java; however Maven 3.0.4 works OK - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org -- E-Mail: garydgreg...@gmail.com | ggreg...@apache.org JUnit in Action, 2nd Ed: http://goog_1249600977http://bit.ly/ECvg0 Spring Batch in Action: http://s.apache.org/HOqhttp://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
