Re: [ALL] pom.xml should not contain RM details
On Thu, 5 Oct 2023 at 00:13, Phil Steitz wrote: > > On Tue, Oct 3, 2023 at 1:26 AM sebb wrote: > > > > The properties are used by the release plugin. > > > > But since they are unique to the user, they do not belong in the shared pom. > > So they should be blank in the component pom? No, they must be absent. > Why do they need to be there at all? It seems they are used by the vote-text goal. > Can't they just be provided on the command line? Yes. > I detest settings.xml, btw. Not under source control, throw-back to the old > special local voodoo build days. Most (all?) of it can be provided on the command line. However, that gets tedious; settings.xml provides useful short-cuts. It should only be used for settings specific to the user. It cannot therefore be added to shared source control. However, you could always keep your copy under source control. > Phil > > > > On Tue, 3 Oct 2023 at 02:33, Phil Steitz wrote: > > > > > > +1 but why then are those properties there? > > > > > > Phil > > > > > > > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > > > > > > > As the subject says, please do not use the pom to store RM details > > > > such as > > > > > > > > commons.releaseManagerName > > > > commons.releaseManagerKey > > > > > > > > These properties are personal to the user, and should be defined in > > > > ~/.m2/settings.xml. > > > > See https://commons.apache.org/proper/commons-release-plugin/index.html > > > > > > > > Or you can define them on the command line. > > > > > > > > If the RM details are stored in the pom, then it is all too easy for > > > > the wrong values to be used. > > > > > > > > Thanks, > > > > Sebb > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] pom.xml should not contain RM details
On Tue, Oct 3, 2023 at 1:26 AM sebb wrote: > > The properties are used by the release plugin. > > But since they are unique to the user, they do not belong in the shared pom. So they should be blank in the component pom? Why do they need to be there at all? Can't they just be provided on the command line? I detest settings.xml, btw. Not under source control, throw-back to the old special local voodoo build days. Phil > > On Tue, 3 Oct 2023 at 02:33, Phil Steitz wrote: > > > > +1 but why then are those properties there? > > > > Phil > > > > > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > > > > > As the subject says, please do not use the pom to store RM details such > > > as > > > > > > commons.releaseManagerName > > > commons.releaseManagerKey > > > > > > These properties are personal to the user, and should be defined in > > > ~/.m2/settings.xml. > > > See https://commons.apache.org/proper/commons-release-plugin/index.html > > > > > > Or you can define them on the command line. > > > > > > If the RM details are stored in the pom, then it is all too easy for > > > the wrong values to be used. > > > > > > Thanks, > > > Sebb > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] pom.xml should not contain RM details
I've already made a start on that. I'm replacing the entries with comments so people know where to defined them. On Tue, 3 Oct 2023 at 12:44, Bruno Kinoshita wrote: > > Thank you Sebb and thank you Gary! > > On Tue, 3 Oct 2023 at 13:42, Gary Gregory wrote: > > > FYI, I'll do a pass over all poms and remove those properties... > > > > Gary > > > > On Mon, Oct 2, 2023, 6:58 PM sebb wrote: > > > > > As the subject says, please do not use the pom to store RM details such > > as > > > > > > commons.releaseManagerName > > > commons.releaseManagerKey > > > > > > These properties are personal to the user, and should be defined in > > > ~/.m2/settings.xml. > > > See https://commons.apache.org/proper/commons-release-plugin/index.html > > > > > > Or you can define them on the command line. > > > > > > If the RM details are stored in the pom, then it is all too easy for > > > the wrong values to be used. > > > > > > Thanks, > > > Sebb > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] pom.xml should not contain RM details
Thank you Sebb and thank you Gary! On Tue, 3 Oct 2023 at 13:42, Gary Gregory wrote: > FYI, I'll do a pass over all poms and remove those properties... > > Gary > > On Mon, Oct 2, 2023, 6:58 PM sebb wrote: > > > As the subject says, please do not use the pom to store RM details such > as > > > > commons.releaseManagerName > > commons.releaseManagerKey > > > > These properties are personal to the user, and should be defined in > > ~/.m2/settings.xml. > > See https://commons.apache.org/proper/commons-release-plugin/index.html > > > > Or you can define them on the command line. > > > > If the RM details are stored in the pom, then it is all too easy for > > the wrong values to be used. > > > > Thanks, > > Sebb > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > >
Re: [ALL] pom.xml should not contain RM details
FYI, I'll do a pass over all poms and remove those properties... Gary On Mon, Oct 2, 2023, 6:58 PM sebb wrote: > As the subject says, please do not use the pom to store RM details such as > > commons.releaseManagerName > commons.releaseManagerKey > > These properties are personal to the user, and should be defined in > ~/.m2/settings.xml. > See https://commons.apache.org/proper/commons-release-plugin/index.html > > Or you can define them on the command line. > > If the RM details are stored in the pom, then it is all too easy for > the wrong values to be used. > > Thanks, > Sebb > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [ALL] pom.xml should not contain RM details
On Tue, 3 Oct 2023 at 09:48, Bruno Kinoshita wrote: > > I recall seeing these properties in the commons-release-plugin docs I use > as reference whenever I need to release a component (which the last time > was a long time ago, sorry). > > The commons-release-plugin links to this page: > > https://commons.apache.org/releases/prepare.html That disagrees with the page linked at the start of the thread. > Maybe we need to update that page too to explain these properties must not > be persisted. Indeed, will do. > On Tue, 3 Oct 2023 at 10:26, sebb wrote: > > > The properties are used by the release plugin. > > > > But since they are unique to the user, they do not belong in the shared > > pom. > > > > On Tue, 3 Oct 2023 at 02:33, Phil Steitz wrote: > > > > > > +1 but why then are those properties there? > > > > > > Phil > > > > > > > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > > > > > > > As the subject says, please do not use the pom to store RM details > > such as > > > > > > > > commons.releaseManagerName > > > > commons.releaseManagerKey > > > > > > > > These properties are personal to the user, and should be defined in > > > > ~/.m2/settings.xml. > > > > See > > https://commons.apache.org/proper/commons-release-plugin/index.html > > > > > > > > Or you can define them on the command line. > > > > > > > > If the RM details are stored in the pom, then it is all too easy for > > > > the wrong values to be used. > > > > > > > > Thanks, > > > > Sebb > > > > > > > > - > > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] pom.xml should not contain RM details
I recall seeing these properties in the commons-release-plugin docs I use as reference whenever I need to release a component (which the last time was a long time ago, sorry). The commons-release-plugin links to this page: https://commons.apache.org/releases/prepare.html Maybe we need to update that page too to explain these properties must not be persisted. On Tue, 3 Oct 2023 at 10:26, sebb wrote: > The properties are used by the release plugin. > > But since they are unique to the user, they do not belong in the shared > pom. > > On Tue, 3 Oct 2023 at 02:33, Phil Steitz wrote: > > > > +1 but why then are those properties there? > > > > Phil > > > > > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > > > > > As the subject says, please do not use the pom to store RM details > such as > > > > > > commons.releaseManagerName > > > commons.releaseManagerKey > > > > > > These properties are personal to the user, and should be defined in > > > ~/.m2/settings.xml. > > > See > https://commons.apache.org/proper/commons-release-plugin/index.html > > > > > > Or you can define them on the command line. > > > > > > If the RM details are stored in the pom, then it is all too easy for > > > the wrong values to be used. > > > > > > Thanks, > > > Sebb > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > >
Re: [ALL] pom.xml should not contain RM details
The properties are used by the release plugin. But since they are unique to the user, they do not belong in the shared pom. On Tue, 3 Oct 2023 at 02:33, Phil Steitz wrote: > > +1 but why then are those properties there? > > Phil > > > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > > > As the subject says, please do not use the pom to store RM details such as > > > > commons.releaseManagerName > > commons.releaseManagerKey > > > > These properties are personal to the user, and should be defined in > > ~/.m2/settings.xml. > > See https://commons.apache.org/proper/commons-release-plugin/index.html > > > > Or you can define them on the command line. > > > > If the RM details are stored in the pom, then it is all too easy for > > the wrong values to be used. > > > > Thanks, > > Sebb > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > > For additional commands, e-mail: dev-h...@commons.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [ALL] pom.xml should not contain RM details
+1 but why then are those properties there? Phil > On Oct 2, 2023, at 3:58 PM, sebb wrote: > > As the subject says, please do not use the pom to store RM details such as > > commons.releaseManagerName > commons.releaseManagerKey > > These properties are personal to the user, and should be defined in > ~/.m2/settings.xml. > See https://commons.apache.org/proper/commons-release-plugin/index.html > > Or you can define them on the command line. > > If the RM details are stored in the pom, then it is all too easy for > the wrong values to be used. > > Thanks, > Sebb > > - > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org > For additional commands, e-mail: dev-h...@commons.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
