Re: [LOGGING] OSGi Meta data is the same for adapters and api jar Was: [VOTE] Release of Commons Logging 1.1.2 based on RC2
Am 16.03.2013 19:43, schrieb Benedikt Ritter: Hi Oliver 2013/3/16 Oliver Heger oliver.he...@oliver-heger.de Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site look good. One thing I noticed, not sure whether this is actually a problem: The artifacts for adapters and api have the same manifest information as the main jar. Are they intended to be used in an OSGi environment? Could this cause problems? Logging can not be used without additional setup in an OSGi environment. This is for historical reasons. The library was not designed with OSGi in mind and making it OSGi ready would require to change packaging. Have a look LOGGING-124 [1] for more information about this. I have tried to sum up what we have learned about [logging] and OSGi in the wiki (see bottom of [2]). Feel free to comment or add something :) Hm, I have difficulties with understanding both your statement and the WIKI documentation. IIUC, you basically say that OSGi meta data does not really matter because [logging] does not work in an OSGi environment anyway. Wouldn't it then be better to drop it completely? The WIKI says, it is difficult to get commons-logging working in OSGi environments. This is not really helpful. If it is possible to make it work with OSGi, it should be described how this is done. Otherwise, it should be clearly stated. Oliver Regards, Benedikt [1] https://issues.apache.org/jira/browse/LOGGING-124 [2] http://wiki.apache.org/commons/Logging/FrequentlyAskedQuestions Oliver Am 16.03.2013 14:06, schrieb Thomas Neidhart: Hi, I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC2. This release candidate has the following changes compared to RC1: * Fix deployment process to include also missing bin/src assemblies * Disable reference release test for WeakHashtable as it was unreliable on various JVMs * Fix several unit tests related to security permissions when run with IBM JVM 6 The files: The artifacts are deployed to Nexus: https://repository.apache.org/**content/repositories/** orgapachecommons-007/commons-**logging/commons-logging/1.1.2/https://repository.apache.org/content/repositories/orgapachecommons-007/commons-logging/commons-logging/1.1.2/ The tag: https://svn.apache.org/repos/**asf/commons/proper/logging/** tags/LOGGING_1_1_2_RC2/https://svn.apache.org/repos/asf/commons/proper/logging/tags/LOGGING_1_1_2_RC2/ The site: http://people.apache.org/**builds/commons/logging/1.1.2/**RC2/http://people.apache.org/builds/commons/logging/1.1.2/RC2/ Additional Notes: o the download page and api links to older releases only work on the published site and will be corrected after release. Please take a look at the commons-logging-1.1.2 artifacts and vote! --**-- [ ] +1 release it. [ ] +0 go ahead; I don't care. [ ] -0 there are a few minor glitches: ... [ ] -1 no, do not release it because ... --**-- Vote will remain open for at least 72 hours. Thanks in advance, Thomas --**--**- To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.orgdev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org --**--**- To unsubscribe, e-mail: dev-unsubscribe@commons.**apache.orgdev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [LOGGING] OSGi Meta data is the same for adapters and api jar Was: [VOTE] Release of Commons Logging 1.1.2 based on RC2
Hi Oliver, Many thanks for your feedback! I've requests feedback from the ML [1] but nobody responded (I forgot to ping that thread to get some more attention...). Please see my comments inline. 2013/3/18 Oliver Heger oliver.he...@oliver-heger.de Am 16.03.2013 19:43, schrieb Benedikt Ritter: Hi Oliver 2013/3/16 Oliver Heger oliver.he...@oliver-heger.de Build works fine on Windows 7 with Java 1.5 and 1.7, artifacts and site look good. One thing I noticed, not sure whether this is actually a problem: The artifacts for adapters and api have the same manifest information as the main jar. Are they intended to be used in an OSGi environment? Could this cause problems? Logging can not be used without additional setup in an OSGi environment. This is for historical reasons. The library was not designed with OSGi in mind and making it OSGi ready would require to change packaging. Have a look LOGGING-124 [1] for more information about this. I have tried to sum up what we have learned about [logging] and OSGi in the wiki (see bottom of [2]). Feel free to comment or add something :) Hm, I have difficulties with understanding both your statement and the WIKI documentation. IIUC, you basically say that OSGi meta data does not really matter because [logging] does not work in an OSGi environment anyway. Wouldn't it then be better to drop it completely? I don't say that (at least it was not my attention to say that :). We have discussed this here on the ML, on the felix ML and in jira. The quint essence was, that it is not possible to create correct OSGi meta data without breaking BC. Creating correct OSGi meta data would require us to provide different artifacts than we now do (clean separation of API and implementation). Furthermore there are some technical reasons that make it hard to get [logging] working in an OSGi environment (described in the wiki). This is, why we came to the conclusion that it is better to let OSGi meta data as is and point users to alternatives. The WIKI says, it is difficult to get commons-logging working in OSGi environments. This is not really helpful. If it is possible to make it work with OSGi, it should be described how this is done. Otherwise, it should be clearly stated. It is described. The paragraph at the very bottom of the page states two alternatives: pax logging and rebundles versions of [logging]. I'm no expert when it comes to OSGi and I just stepped in and did the documentation part of this issue because I have the feeling people around here are not too motivated when it comes to documentation in the wiki :) If you see something that can be improved, feel free to change to docs! Benedikt [1] http://markmail.org/message/4znoshjmstnmos37 Oliver Regards, Benedikt [1] https://issues.apache.org/**jira/browse/LOGGING-124https://issues.apache.org/jira/browse/LOGGING-124 [2] http://wiki.apache.org/**commons/Logging/**FrequentlyAskedQuestionshttp://wiki.apache.org/commons/Logging/FrequentlyAskedQuestions Oliver Am 16.03.2013 14:06, schrieb Thomas Neidhart: Hi, I'd like to call a vote for releasing Commons Logging 1.1.2 based on RC2. This release candidate has the following changes compared to RC1: * Fix deployment process to include also missing bin/src assemblies * Disable reference release test for WeakHashtable as it was unreliable on various JVMs * Fix several unit tests related to security permissions when run with IBM JVM 6 The files: The artifacts are deployed to Nexus: https://repository.apache.org/content/repositories/**https://repository.apache.org/**content/repositories/** orgapachecommons-007/commons-logging/commons-logging/1.1.**2/ https://repository.apache.**org/content/repositories/** orgapachecommons-007/commons-**logging/commons-logging/1.1.2/https://repository.apache.org/content/repositories/orgapachecommons-007/commons-logging/commons-logging/1.1.2/ ** The tag: https://svn.apache.org/repos/asf/commons/proper/logging/**https://svn.apache.org/repos/**asf/commons/proper/logging/** tags/LOGGING_1_1_2_RC2/https:**//svn.apache.org/repos/asf/** commons/proper/logging/tags/**LOGGING_1_1_2_RC2/https://svn.apache.org/repos/asf/commons/proper/logging/tags/LOGGING_1_1_2_RC2/ The site: http://people.apache.org/builds/commons/logging/1.1.2/RC2/http://people.apache.org/**builds/commons/logging/1.1.2/**RC2/ http://people.apache.**org/builds/commons/logging/1.**1.2/RC2/http://people.apache.org/builds/commons/logging/1.1.2/RC2/ Additional Notes: o the download page and api links to older releases only work on the published site and will be corrected after release. Please take a look at the commons-logging-1.1.2 artifacts and vote! ---- [ ] +1 release it. [ ] +0 go ahead; I don't care. [ ] -0 there are a few minor glitches: ... [ ] -1 no, do not release it because ...