Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Rob Tompkins]

+1 everything looks good. Nits, coverage a tad low, cpd, pmd, todo’s

Send it

-Rob

> On Dec 3, 2023, at 11:33 AM, Gary Gregory  wrote:
> 
> We have fixed a few bugs and added some enhancements since Apache
> Commons BCEL 6.7.0 was released, so I would like to release Apache
> Commons BCEL 6.8.0.
> 
> Apache Commons BCEL 6.8.0 RC1 is available for review here:
>https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> revision 65804)
> 
> The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> You may checkout this tag using:
>git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> 
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> 
> These are the artifacts and their hashes:
> 
> #Release SHA-512s
> #Sun Dec 03 11:17:12 EST 2023
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> 
> I have tested this with:
> 
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
> 
> Using:
> 
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> 
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> 
> Details of changes since 6.7.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
> 
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
>(note some *relative* links are broken and the 6.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
> 
> JApiCmp Report (compared to 6.7.0):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
> 
>Note that the above report notes one issue:
>MODIFIED (Serializable incompatible(!): field changed from
> nontransient to transient) public class
> org.apache.bcel.util.ClassVector
>Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> is not serializable in the first place because JavaClass is not
> serializable.
> 
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html
> 
> KEYS:
>  https://downloads.apache.org/commons/KEYS
> 
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
> 
>  [ ] +1 Release these artifacts
>  [ ] +0 OK, but...
>  [ ] -0 OK, but really should fix...
>  [ ] -1 I oppose this release because...
> 
> Thank you,
> 
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
> 
> For following is intended as a helper and refresher for reviewers.
> 
> Validating a release candidate
> 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Henri Biestro]

[ +1 ]

Built locally using: mvn -s "$HOME/.m2/commons-settings.xml" -P jacoco -P 
japicmp clean package site
On: Darwin henrib-MBP16 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 
21:27:24 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6000 arm64
With: OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-macos-aarch64) (build 
1.8.0_352-b08)
OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-macos-aarch64) (build 25.352-b08, 
mixed mode)

Compile, tests and generates site.
Not precluding release but release notes are *not* 6.8.0 but still 6.7 and test 
coverage is a tad low (hopefully, it goes up with versions...).

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Gary Gregory]

Build instructions are rooted here:

https://commons.apache.org/releases/index.html

These could be partially out of date but do mention our release plug-in.

Gary


On Tue, Dec 5, 2023, 7:37 AM Elliotte Rusty Harold 
wrote:

> OK, so bc means binary compatibility, not BCEL. That makes sense,
> though abbreviations are still confusing.
>
> Not urgent, but it would be worth adding build and release
> instructions to the repo some time. As is, I don't see any reference
> to the commons release plugin in the BCEL repo or docs. Release
> processes can be really painful to reverse engineer if everything is
> not written down in an obvious location and kept up to date. I've had
> to do that more than once in my career. :-(
>
> On Sun, Dec 3, 2023 at 5:18 PM Gary Gregory 
> wrote:
> >
> > No, it should NOT be removed: It is used by the build/release plugins
> > to know which version to check for binary compatibility when the
> > default Maven goal runs the BC check and when the site report is
> > generated.
> >
> > Gary
> >
> > On Sun, Dec 3, 2023 at 12:13 PM Elliotte Rusty Harold
> >  wrote:
> > >
> > > pom.xml has this strange variable:
> > >
> > > 6.7.0
> > >
> > > Is that supposed to be the commons bcel version? If so, update it to
> > > 6.8.0. However, it doesn't seem to be used anywhere so perhaps just
> > > delete the line.
> > >
> > >
> > > On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory 
> wrote:
> > > >
> > > > We have fixed a few bugs and added some enhancements since Apache
> > > > Commons BCEL 6.7.0 was released, so I would like to release Apache
> > > > Commons BCEL 6.8.0.
> > > >
> > > > Apache Commons BCEL 6.8.0 RC1 is available for review here:
> > > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1
> (svn
> > > > revision 65804)
> > > >
> > > > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> > > > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> > > >
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> > > > You may checkout this tag using:
> > > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > > > --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> > > >
> > > > Maven artifacts are here:
> > > >
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> > > >
> > > > These are the artifacts and their hashes:
> > > >
> > > > #Release SHA-512s
> > > > #Sun Dec 03 11:17:12 EST 2023
> > > >
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> > > >
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> > > >
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> > > >
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> > > >
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> > > >
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> > > >
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> > > >
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> > > >
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> > > >
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> > > >
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> > > >
> > > > I have tested this with:
> > > >
> > > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package
> site deploy
> > > >
> > > > Using:
> > > >
> > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > > > Java version: 21.0.1, vendor: Homebrew, runtime:
> > > > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > > > Default locale: en_US, platform encoding: UTF-8
> > > > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> > > >
> > > > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > > > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Elliotte Rusty Harold]

OK, so bc means binary compatibility, not BCEL. That makes sense,
though abbreviations are still confusing.

Not urgent, but it would be worth adding build and release
instructions to the repo some time. As is, I don't see any reference
to the commons release plugin in the BCEL repo or docs. Release
processes can be really painful to reverse engineer if everything is
not written down in an obvious location and kept up to date. I've had
to do that more than once in my career. :-(

On Sun, Dec 3, 2023 at 5:18 PM Gary Gregory  wrote:
>
> No, it should NOT be removed: It is used by the build/release plugins
> to know which version to check for binary compatibility when the
> default Maven goal runs the BC check and when the site report is
> generated.
>
> Gary
>
> On Sun, Dec 3, 2023 at 12:13 PM Elliotte Rusty Harold
>  wrote:
> >
> > pom.xml has this strange variable:
> >
> > 6.7.0
> >
> > Is that supposed to be the commons bcel version? If so, update it to
> > 6.8.0. However, it doesn't seem to be used anywhere so perhaps just
> > delete the line.
> >
> >
> > On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory  wrote:
> > >
> > > We have fixed a few bugs and added some enhancements since Apache
> > > Commons BCEL 6.7.0 was released, so I would like to release Apache
> > > Commons BCEL 6.8.0.
> > >
> > > Apache Commons BCEL 6.8.0 RC1 is available for review here:
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> > > revision 65804)
> > >
> > > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> > > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> > > 
> > > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> > > You may checkout this tag using:
> > > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > > --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> > >
> > > Maven artifacts are here:
> > > 
> > > https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> > >
> > > These are the artifacts and their hashes:
> > >
> > > #Release SHA-512s
> > > #Sun Dec 03 11:17:12 EST 2023
> > > bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> > > bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> > > bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> > > bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> > > bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> > > bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> > > bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> > > bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> > > bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> > > bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> > > org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> > >
> > > I have tested this with:
> > >
> > > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > > deploy
> > >
> > > Using:
> > >
> > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > > Java version: 21.0.1, vendor: Homebrew, runtime:
> > > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > > Default locale: en_US, platform encoding: UTF-8
> > > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> > >
> > > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> > >
> > > Details of changes since 6.7.0 are in the release notes:
> > > 
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> > > 
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
> > >
> > > Site:
> > > 
> > > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> > > 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Gary Gregory]

My +1

Gary

On Mon, Dec 4, 2023, 5:38 PM Bruno Kinoshita 
wrote:

>[X] +1 Release these artifacts
>
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: /opt/apache-maven-3.8.5
> Java version: 17.0.9, vendor: Private Build, runtime:
> /usr/lib/jvm/java-17-openjdk-amd64
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "5.15.0-89-generic", arch: "amd64", family:
> "unix"
>
>
>
> On Sun, 3 Dec 2023 at 17:35, Gary Gregory  wrote:
>
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons BCEL 6.7.0 was released, so I would like to release Apache
> > Commons BCEL 6.8.0.
> >
> > Apache Commons BCEL 6.8.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> > revision 65804)
> >
> > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> >
> >
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > --branch 
> > commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> >
> > Maven artifacts are here:
> >
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sun Dec 03 11:17:12 EST 2023
> >
> >
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> >
> >
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> >
> >
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> >
> >
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> >
> >
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> >
> >
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> >
> >
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> >
> >
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> >
> >
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> >
> >
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> >
> >
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> >
> > I have tested this with:
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 6.7.0 are in the release notes:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
> >
> > Site:
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> > (note some *relative* links are broken and the 6.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 6.7.0):
> >
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
> >
> > Note that the above report notes one issue:
> > MODIFIED (Serializable incompatible(!): field changed from
> > nontransient to transient) public class
> > org.apache.bcel.util.ClassVector
> > Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> > is not serializable in the first place because JavaClass is not
> > serializable.
> >
> > 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Bruno Kinoshita]

   [X] +1 Release these artifacts

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/apache-maven-3.8.5
Java version: 17.0.9, vendor: Private Build, runtime:
/usr/lib/jvm/java-17-openjdk-amd64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "5.15.0-89-generic", arch: "amd64", family:
"unix"



On Sun, 3 Dec 2023 at 17:35, Gary Gregory  wrote:

> We have fixed a few bugs and added some enhancements since Apache
> Commons BCEL 6.7.0 was released, so I would like to release Apache
> Commons BCEL 6.8.0.
>
> Apache Commons BCEL 6.8.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> revision 65804)
>
> The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
>
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch 
> commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
>
> Maven artifacts are here:
>
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Dec 03 11:17:12 EST 2023
>
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
>
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
>
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
>
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
>
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
>
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
>
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
>
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
>
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
>
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
>
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
>
> I have tested this with:
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> deploy
>
> Using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
>
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
>
> Details of changes since 6.7.0 are in the release notes:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
>
> Site:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> (note some *relative* links are broken and the 6.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 6.7.0):
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
>
> Note that the above report notes one issue:
> MODIFIED (Serializable incompatible(!): field changed from
> nontransient to transient) public class
> org.apache.bcel.util.ClassVector
> Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> is not serializable in the first place because JavaClass is not
> serializable.
>
> RAT Report:
>
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Mark Roberts]

Issues I opened marked resolved fixed: 287, 294, 295, 296, 297, 329, 330,
333, 334, 335, 340
Issue I opened that has fix available: 361


On Sun, Dec 3, 2023 at 9:10 AM Elliotte Rusty Harold 
wrote:

> https://issues.apache.org/jira/projects/BCEL/issues/BCEL-337 looks
> like it's fixed and should be closed prior to release. Might be worth
> doing a quick pass through the issue tracker to see if there's
> anything else in there that needs to be closed or addressed.
>
> On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory 
> wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons BCEL 6.7.0 was released, so I would like to release Apache
> > Commons BCEL 6.8.0.
> >
> > Apache Commons BCEL 6.8.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> > revision 65804)
> >
> > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> >
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> >
> > Maven artifacts are here:
> >
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sun Dec 03 11:17:12 EST 2023
> >
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> >
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> >
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> >
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> >
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> >
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> >
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> >
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> >
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> >
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> >
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> >
> > I have tested this with:
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site
> deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 6.7.0 are in the release notes:
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
> >
> > Site:
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> > (note some *relative* links are broken and the 6.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 6.7.0):
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
> >
> > Note that the above report notes one issue:
> > MODIFIED (Serializable incompatible(!): field changed from
> > nontransient to transient) public class
> > org.apache.bcel.util.ClassVector
> > Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> > is not serializable in the first place because JavaClass is not
> > serializable.
> >
> > RAT Report:
> >
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Gary Gregory]

No, it should NOT be removed: It is used by the build/release plugins
to know which version to check for binary compatibility when the
default Maven goal runs the BC check and when the site report is
generated.

Gary

On Sun, Dec 3, 2023 at 12:13 PM Elliotte Rusty Harold
 wrote:
>
> pom.xml has this strange variable:
>
> 6.7.0
>
> Is that supposed to be the commons bcel version? If so, update it to
> 6.8.0. However, it doesn't seem to be used anywhere so perhaps just
> delete the line.
>
>
> On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory  wrote:
> >
> > We have fixed a few bugs and added some enhancements since Apache
> > Commons BCEL 6.7.0 was released, so I would like to release Apache
> > Commons BCEL 6.8.0.
> >
> > Apache Commons BCEL 6.8.0 RC1 is available for review here:
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> > revision 65804)
> >
> > The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> > cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> > 
> > https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> > You may checkout this tag using:
> > git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> > --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
> >
> > Maven artifacts are here:
> > 
> > https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
> >
> > These are the artifacts and their hashes:
> >
> > #Release SHA-512s
> > #Sun Dec 03 11:17:12 EST 2023
> > bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> > bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> > bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> > bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> > bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> > bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> > bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> > bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> > bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> > bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> > org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
> >
> > I have tested this with:
> >
> > mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site 
> > deploy
> >
> > Using:
> >
> > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> > Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> > Java version: 21.0.1, vendor: Homebrew, runtime:
> > /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> > Default locale: en_US, platform encoding: UTF-8
> > OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
> >
> > Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> > PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
> >
> > Details of changes since 6.7.0 are in the release notes:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> > 
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
> >
> > Site:
> > 
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> > (note some *relative* links are broken and the 6.8.0 directories
> > are not yet created - these will be OK once the site is deployed.)
> >
> > JApiCmp Report (compared to 6.7.0):
> > 
> > https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
> >
> > Note that the above report notes one issue:
> > MODIFIED (Serializable incompatible(!): field changed from
> > nontransient to transient) public class
> > org.apache.bcel.util.ClassVector
> > Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> > is not serializable in the first place because JavaClass is not
> > serializable.
> >
> > RAT Report:
> > 
> > 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Elliotte Rusty Harold]

pom.xml has this strange variable:

6.7.0

Is that supposed to be the commons bcel version? If so, update it to
6.8.0. However, it doesn't seem to be used anywhere so perhaps just
delete the line.


On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory  wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons BCEL 6.7.0 was released, so I would like to release Apache
> Commons BCEL 6.8.0.
>
> Apache Commons BCEL 6.8.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> revision 65804)
>
> The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Dec 03 11:17:12 EST 2023
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
>
> I have tested this with:
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
>
> Using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
>
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
>
> Details of changes since 6.7.0 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> (note some *relative* links are broken and the 6.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 6.7.0):
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
>
> Note that the above report notes one issue:
> MODIFIED (Serializable incompatible(!): field changed from
> nontransient to transient) public class
> org.apache.bcel.util.ClassVector
> Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> is not serializable in the first place because JavaClass is not
> serializable.
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
> Release Manager (using key 86fdc7e2a11262cb)
>
> For following is 

Re: [VOTE] Release Apache Commons BCEL 6.8.0 based on RC1

[Elliotte Rusty Harold]

https://issues.apache.org/jira/projects/BCEL/issues/BCEL-337 looks
like it's fixed and should be closed prior to release. Might be worth
doing a quick pass through the issue tracker to see if there's
anything else in there that needs to be closed or addressed.

On Sun, Dec 3, 2023 at 4:33 PM Gary Gregory  wrote:
>
> We have fixed a few bugs and added some enhancements since Apache
> Commons BCEL 6.7.0 was released, so I would like to release Apache
> Commons BCEL 6.8.0.
>
> Apache Commons BCEL 6.8.0 RC1 is available for review here:
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1 (svn
> revision 65804)
>
> The Git tag commons-bcel-6.8.0-RC1 commit for this RC is
> cf6f7e710abf4eda2e0aa9aa914aa17878999583 which you can browse here:
> 
> https://gitbox.apache.org/repos/asf?p=commons-bcel.git;a=commit;h=cf6f7e710abf4eda2e0aa9aa914aa17878999583
> You may checkout this tag using:
> git clone https://gitbox.apache.org/repos/asf/commons-bcel.git
> --branch commons-bcel-6.8.0-RC1 commons-bcel-6.8.0-RC1
>
> Maven artifacts are here:
> 
> https://repository.apache.org/content/repositories/orgapachecommons-1678/org/apache/bcel/bcel/6.8.0/
>
> These are the artifacts and their hashes:
>
> #Release SHA-512s
> #Sun Dec 03 11:17:12 EST 2023
> bcel-6.8.0-bin.tar.gz=955d66a5a34d25c90c71273467a2f876f3b3fb3437fc533f7a7583ea0390474817aefbb9a9b4190973011ad053e145c9c0bac42832f8198b562e693a25b2803f
> bcel-6.8.0-bin.zip=04e5fe2830127add83108de8df61aab185e38a5117dddfa348533260b5d355da1fb0db56b0b5361e680308d2feea6a3b04acc99d6a93b9ad2dfdb943893cb583
> bcel-6.8.0-bom.json=1555e608b267a74adc10938377f8eb60f1b2fa477c1834582ded805530d3cf676ac14d6f1966bdd5d9ccef4cc9f2a32ff1ce6d9b6963fc1d288f8263585b639f
> bcel-6.8.0-bom.xml=e1bb499766046147619dd1f1443089b043ee11bf09234c19f14b15261ae54e186c51bd2f7f9f622a71dac1d6a6712bef4c504bd21e975550bef6cfe886c607ba
> bcel-6.8.0-javadoc.jar=5fdaa3d79e57a6fcff8e3dfd9295e4681d3f7b35ae6f248b6bee292e46f0f7cff6b80a88f198c6eed6a966be1e59d272e68f3d8dd39cee0b48ce8920e4ef7495
> bcel-6.8.0-sources.jar=a55973bc87409c525860709ff94055808cb46ce13f236f5a119e763ee4a024b9c0c3ac78c80c6e8489f6fc9c535aff8468f09a796889d5dc5c4f9dd593bb337e
> bcel-6.8.0-src.tar.gz=fcec4920f841b9b22b7fe05190ed09a31e2edd32dbc9bc6217981af34fecab0725249bbaf0e5810e0c7ef8a347dbe07fa1dfc1a80a7b651368ad4ea852f54f6e
> bcel-6.8.0-src.zip=4d7c00f9400b206db48823a77cb09bbb2b25074108e8980c84c701d6b73f77290cf3bed56e392d270c8e084d7c2306ac3fb9b4a4f7f1e6cb883b683f7b3d972e
> bcel-6.8.0-test-sources.jar=8924279acde0fc8d101cc27b9e69b514b98a69793c990cadaae193da0fe5913630b99ebfd10568a3baa5e79bd4d93f8020202accf12a6a0e14ef07deb31736db
> bcel-6.8.0-tests.jar=4d7715acb6d38d50f8a9e4cbef232190fd3d7efaf54ade772d677e129c89af69a528a1bff6dae6300058f2e1c1393acf18a554c85ac0a6f6d95f0aad4680426c
> org.apache.bcel_bcel-6.8.0.spdx.json=dc47d97c197e3e0ce124b7f3a03e74552b6764e46195058d47daca19a597fb49469119115a58e7f3dc951cb851c031e60840e09d94632c4687332049dc305c10
>
> I have tested this with:
>
> mvn -V -Prelease -Ptest-deploy -P jacoco -P japicmp clean package site deploy
>
> Using:
>
> Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: /usr/local/Cellar/maven/3.9.6/libexec
> Java version: 21.0.1, vendor: Homebrew, runtime:
> /usr/local/Cellar/openjdk/21.0.1/libexec/openjdk.jdk/Contents/Home
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "14.1.1", arch: "x86_64", family: "mac"
>
> Darwin  23.1.0 Darwin Kernel Version 23.1.0: Mon Oct  9 21:27:27
> PDT 2023; root:xnu-10002.41.9~6/RELEASE_X86_64 x86_64
>
> Details of changes since 6.7.0 are in the release notes:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/RELEASE-NOTES.txt
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/changes-report.html
>
> Site:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/index.html
> (note some *relative* links are broken and the 6.8.0 directories
> are not yet created - these will be OK once the site is deployed.)
>
> JApiCmp Report (compared to 6.7.0):
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/japicmp.html
>
> Note that the above report notes one issue:
> MODIFIED (Serializable incompatible(!): field changed from
> nontransient to transient) public class
> org.apache.bcel.util.ClassVector
> Note that a java.util.List of org.apache.bcel.classfile.JavaClass
> is not serializable in the first place because JavaClass is not
> serializable.
>
> RAT Report:
> 
> https://dist.apache.org/repos/dist/dev/commons/bcel/6.8.0-RC1/site/rat-report.html
>
> KEYS:
>   https://downloads.apache.org/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner than 72 hours from now.
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
> Thank you,
>
> Gary Gregory,
>