Re: [math] @Ignores

2013-03-31 Thread Luc Maisonobe 
Hi Phil,

Le 31/03/2013 18:49, Phil Steitz a écrit :
 It was a little painful for me to vote +1 just now, since we had to
 disable some tests in the released sources to work around brokenness
 in the parent pom (can't disable cobertura).

Yes. I think we should really remove cobertura (and use jacoco for [math]).

 
 It looks like only the BOBYQAOptimizerTest was @Ignored just for the
 release.

Yes, it was in order to reduce the time to build the site. It still
takes about 4 hours on my computer without these two tests ...

 But grepping for @Ignore in the release sources shows some
 others with no comments to shed light on why they are disabled.  Can
 we either re-enable these in trunk or explain why they are disabled?

We should give it a try. I don't remember either when the tests were
disabled and the reason for that. We should at least try, decide what to
do (fix the code, fix the test, remove the test, or reactivate the test).

best regards,
Luc

 
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-   
 @Test
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java:   
 @Ignore
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-   
 public void testRandomUnsymmetricMatrix() {
 --
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-   
 @Test
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java:   
 @Ignore
 src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-   
 public void testNormalDistributionUnsymmetricMatrix() {
 --
 src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java-

 @Test
 src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java:

 @Ignore
 src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java-

 public void testParseSimpleWithClosingRowSeparator() {
 --
 src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java-

 // Test is skipped because it fails with the latest code update.
 src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java:

 @Ignore@Test
 src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java-

 public void testMath199() {
 --
 src/test/java/org/apache/commons/math3/util/FastMathTest.java:   
 @Ignore
 src/test/java/org/apache/commons/math3/util/FastMathTest.java-@Test
 src/test/java/org/apache/commons/math3/util/FastMathTest.java-   
 public void checkExtraFastMathClasses() {
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
 For additional commands, e-mail: dev-h...@commons.apache.org
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [math] @Ignores

2013-03-31 Thread Gilles 

Hi.


[...]

src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java-

// Test is skipped because it fails with the latest code update.

src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java:

@Ignore@Test

src/test/java/org/apache/commons/math3/optimization/general/LevenbergMarquardtOptimizerTest.java-

public void testMath199() {


We can forget about tests that relate to a deprecated package.

Gilles


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [math] @Ignores

2013-03-31 Thread Gilles 

[...]

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-
@Test

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java:
@Ignore

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-
public void testRandomUnsymmetricMatrix() {
--

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-
@Test

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java:
@Ignore

src/test/java/org/apache/commons/math3/linear/EigenDecompositionTest.java-
public void testNormalDistributionUnsymmetricMatrix() {


Those two uses a RNG with no fixed seed.
I guess they were failing... randomly.

Gilles


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [math] @Ignores

2013-03-31 Thread Gilles 



[...]

src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java-

@Test

src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java:

@Ignore

src/test/java/org/apache/commons/math3/linear/RealMatrixFormatAbstractTest.java-

public void testParseSimpleWithClosingRowSeparator() {


This one is broken:

testParseSimpleWithClosingRowSeparator(org.apache.commons.math3.linear.RealMatrixFormatTest) 
 Time elapsed: 0.004 sec   FAILURE!
java.lang.AssertionError: 
expected:Array2DRowRealMatrix{{1.0,1.0,1.0},{1.0,1.0,1.0}} but 
was:null



Gilles


-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org