Re: svn commit: r1364676 - in /commons/proper/functor/trunk/src: changes/ main/java/org/apache/commons/functor/core/comparator/ test/java/org/apache/commons/functor/core/comparator/

2012-07-28 Thread Matt Benson 
On Fri, Jul 27, 2012 at 9:40 PM, sebb seb...@gmail.com wrote:
 On 23 July 2012 16:21,  ki...@apache.org wrote:
 Author: kinow
 Date: Mon Jul 23 15:21:25 2012
 New Revision: 1364676

 URL: http://svn.apache.org/viewvc?rev=1364676view=rev
 Log:
 [FUNCTOR-22] Added generics to ComparableComparator. Few other classes that 
 used the ComparableComparator were updated too. Tests were also updated 
 accordingly.

 Modified:
 commons/proper/functor/trunk/src/changes/changes.xml
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparatorFunction.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Max.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Min.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparableComparator.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java

 Modified: commons/proper/functor/trunk/src/changes/changes.xml
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/changes/changes.xml?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- commons/proper/functor/trunk/src/changes/changes.xml (original)
 +++ commons/proper/functor/trunk/src/changes/changes.xml Mon Jul 23 15:21:25 
 2012
 @@ -23,6 +23,9 @@
/properties
body
  release version=1.0 date=2012-??-?? description=First release.
 +  action dev=kinow issue=FUNCTOR-22
 +Generify ComparableComparator.
 +  /action
action dev=kinow issue=FUNCTOR-3
  Reduce the use of raw types in test classes.
/action

 Modified: 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  (original)
 +++ 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  Mon Jul 23 15:21:25 2012
 @@ -20,33 +20,37 @@ import java.io.Serializable;
  import java.util.Comparator;

  /**
 - * See Commons-Collections for a public version
 - * of this class.
 + * A {@link Comparator Comparator} that compares {@link Comparable 
 Comparable}
 + * objects.
 + * p
 + * This class was created based on commons-collection's 
 ComparableComparator.
   *
 + * @param E the comparable type
   * @version $Revision$ $Date$
   */
 -@SuppressWarnings({ unchecked, rawtypes })
 -final class ComparableComparator implements Comparator, Serializable {
 +final class ComparableComparatorE extends Comparable? super E 
 implements ComparatorE, Serializable {

  /** Singleton. */
 -public static final ComparableComparator INSTANCE = new 
 ComparableComparator();
 +@SuppressWarnings(rawtypes)
 +public

Re: svn commit: r1364676 - in /commons/proper/functor/trunk/src: changes/ main/java/org/apache/commons/functor/core/comparator/ test/java/org/apache/commons/functor/core/comparator/

2012-07-28 Thread Bruno P. Kinoshita 


 From: sebb seb...@gmail.com
To: dev@commons.apache.org 
Sent: Friday, 27 July 2012 11:40 PM
Subject: Re: svn commit: r1364676 - in /commons/proper/functor/trunk/src: 
changes/ main/java/org/apache/commons/functor/core/comparator/ 
test/java/org/apache/commons/functor/core/comparator/
 
On 23 July 2012 16:21,  ki...@apache.org wrote:
 Author: kinow
 Date: Mon Jul 23 15:21:25 2012
 New Revision: 1364676

 URL: http://svn.apache.org/viewvc?rev=1364676view=rev
 Log:
 [FUNCTOR-22] Added generics to ComparableComparator. Few other classes that 
 used the ComparableComparator were updated too. Tests were also updated 
 accordingly.

 Modified:
     commons/proper/functor/trunk/src/changes/changes.xml
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparatorFunction.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Max.java
     
commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Min.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparableComparator.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java
     
commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java

 Modified: commons/proper/functor/trunk/src/changes/changes.xml
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/changes/changes.xml?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- commons/proper/functor/trunk/src/changes/changes.xml (original)
 +++ commons/proper/functor/trunk/src/changes/changes.xml Mon Jul 23 15:21:25 
 2012
 @@ -23,6 +23,9 @@
    /properties
    body
      release version=1.0 date=2012-??-?? description=First release.
 +      action dev=kinow issue=FUNCTOR-22
 +        Generify ComparableComparator.
 +      /action
        action dev=kinow issue=FUNCTOR-3
          Reduce the use of raw types in test classes.
        /action

 Modified: 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  (original)
 +++ 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  Mon Jul 23 15:21:25 2012
 @@ -20,33 +20,37 @@ import java.io.Serializable;
  import java.util.Comparator;

  /**
 - * See Commons-Collections for a public version
 - * of this class.
 + * A {@link Comparator Comparator} that compares {@link Comparable 
 Comparable}
 + * objects.
 + * p
 + * This class was created based on commons-collection's 
 ComparableComparator.
   *
 + * @param E the comparable type
   * @version $Revision$ $Date$
   */
 -@SuppressWarnings({ unchecked, rawtypes })
 -final class ComparableComparator implements Comparator, Serializable {
 +final class

Re: svn commit: r1364676 - in /commons/proper/functor/trunk/src: changes/ main/java/org/apache/commons/functor/core/comparator/ test/java/org/apache/commons/functor/core/comparator/

2012-07-27 Thread sebb 
On 23 July 2012 16:21,  ki...@apache.org wrote:
 Author: kinow
 Date: Mon Jul 23 15:21:25 2012
 New Revision: 1364676

 URL: http://svn.apache.org/viewvc?rev=1364676view=rev
 Log:
 [FUNCTOR-22] Added generics to ComparableComparator. Few other classes that 
 used the ComparableComparator were updated too. Tests were also updated 
 accordingly.

 Modified:
 commons/proper/functor/trunk/src/changes/changes.xml
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparatorFunction.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Max.java
 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Min.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparableComparator.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java
 
 commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java

 Modified: commons/proper/functor/trunk/src/changes/changes.xml
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/changes/changes.xml?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- commons/proper/functor/trunk/src/changes/changes.xml (original)
 +++ commons/proper/functor/trunk/src/changes/changes.xml Mon Jul 23 15:21:25 
 2012
 @@ -23,6 +23,9 @@
/properties
body
  release version=1.0 date=2012-??-?? description=First release.
 +  action dev=kinow issue=FUNCTOR-22
 +Generify ComparableComparator.
 +  /action
action dev=kinow issue=FUNCTOR-3
  Reduce the use of raw types in test classes.
/action

 Modified: 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
 URL: 
 http://svn.apache.org/viewvc/commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java?rev=1364676r1=1364675r2=1364676view=diff
 ==
 --- 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  (original)
 +++ 
 commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
  Mon Jul 23 15:21:25 2012
 @@ -20,33 +20,37 @@ import java.io.Serializable;
  import java.util.Comparator;

  /**
 - * See Commons-Collections for a public version
 - * of this class.
 + * A {@link Comparator Comparator} that compares {@link Comparable 
 Comparable}
 + * objects.
 + * p
 + * This class was created based on commons-collection's ComparableComparator.
   *
 + * @param E the comparable type
   * @version $Revision$ $Date$
   */
 -@SuppressWarnings({ unchecked, rawtypes })
 -final class ComparableComparator implements Comparator, Serializable {
 +final class ComparableComparatorE extends Comparable? super E implements 
 ComparatorE, Serializable {

  /** Singleton. */
 -public static final ComparableComparator INSTANCE = new 
 ComparableComparator();
 +@SuppressWarnings(rawtypes)
 +public static final ComparableComparator? INSTANCE = new