JDK 9 EA Build 178 & JDK 8u152 b05 are available on jdk.java.net

[Rory O'Donnell]

Hi Benedikt,

*JDK 9 Early Access*  build 178  is available at : - jdk.java.net/9/

A summary of all the changes in this build are listed here 
.


Changes which were introduced since the last availability email that may 
be of interest :


 * b175 - Module system implementation refresh**(6/2017 update)
 * b175 - no longer has "-ea" in the version string and the system
   property "java version" is now simply "9"
 o

   *java -version*

>java version "9"
>Java(TM) SE Runtime Environment (build 9+175)
>Java HotSpot(TM) 64-Bit Server VM (build 9+175, mixed mode)
 o

   *Bundle name changes:*  e.g. jdk-9+175_linux-x86_bin.tar.gz


*JDK 8u152 Early Access*  build 05 is available at : - jdk.java.net/8/ 



A summary of all the changes in this build are listed here 
.


Rgds,Rory

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

Re: [daemon] moving to git ? and bump java version.

[Amey Jadiye]

Hi Gary,

I will take a look at pending issues if something is blocker to release, I
see already 9 issues are done for 1.1.0 release .  if we are ok with these
9, anyone can release it. BTW how do you guys decide that "this is a time
to release!"  for any component ?

Regards,
Amey

On Jul 16, 2017 10:38 PM, "Gary Gregory"  wrote:

> If someone here is really going to put time and energy into daemon, it
> would be fantastic to start with a release. It's been so long...  Then
> fiddle away on tweaks, and release again.
>
> Gary
>
> On Jul 16, 2017 08:49, "Matt Sicker"  wrote:
>
> > C quality somewhat depends on which version of C you're trying to remain
> > compatible with (I'm guessing C89 due to Windows, though I could be
> wrong).
> > Valgrind and other tracing tools are typically used. I'd take a look at
> > what OpenOffice is doing for local examples (though they have a crazy
> build
> > system last I heard), or the FSF, Linux, Xorg, FreeDesktop, GNOME, KDE,
> or
> > other major users of C and C++.
> >
> > On the modern front, it'd be interesting if it were written in Rust,
> though
> > I don't know enough about the language to say if it's worth porting to
> > eventually.
> >
> > On 15 July 2017 at 09:26, sebb  wrote:
> >
> > > On 15 July 2017 at 15:21, Amey Jadiye  wrote:
> > > > Yes, that's mentioned  in my previous mail, I was also curious to
> know
> > > from
> > > > the C developers here in dev-list that how can we make *that* C code
> > > > better? basically I'm looking findbug, checkstyle, jococo, junit
> > > >  *equivalent* for C code.
> > >
> > > No idea on automated tools.
> > > However when I last looked there was plenty of scope for better
> > > documentation.
> > >
> > > Also I did wonder if the Prunmgr GUI might be better coded as a
> > > (mainly) Java application.
> > >
> > > The procrun stuff has to remain as C.
> > >
> > > > Regards,
> > > > Amey
> > > >
> > > > On Sat, Jul 15, 2017 at 7:44 PM, sebb  wrote:
> > > >
> > > >> Also note that there is hardly any Java code; most of it is written
> in
> > > C.
> > > >>
> > > >> On 14 July 2017 at 00:43, Gary Gregory 
> > wrote:
> > > >> > It seems OK to me to update to Java 6 for now and get this to
> > compile
> > > >> under
> > > >> > java 9 for those folks who will try...
> > > >> >
> > > >> > Gary
> > > >> >
> > > >> > On Wed, Jul 12, 2017 at 9:09 AM, Amey Jadiye <
> ameyjad...@gmail.com>
> > > >> wrote:
> > > >> >
> > > >> >> Thanks for great insights Mark.
> > > >> >>
> > > >> >> On Wed, Jul 12, 2017, 9:28 PM Mark Thomas 
> > wrote:
> > > >> >>
> > > >> >> > On 12 July 2017 16:33:01 CEST, Matt Sicker 
> > > wrote:
> > > >> >> > >Are there plans to require 1.7 for Tomcat anytime? Otherwise,
> it
> > > >> might
> > > >> >> > >be
> > > >> >> > >necessary to make a new major version of daemon eventually for
> > > Java 8
> > > >> >> > >or 9.
> > > >> >> >
> > > >> >> > Tomcat major versions are aligned with Java EE versions which
> in
> > > turn
> > > >> >> have
> > > >> >> > a minimum Java version.
> > > >> >> >
> > > >> >> > Tomcat supports 3 current versions in parallel so we currently
> > > have:
> > > >> >> >
> > > >> >> > Tomcat 9 - Java EE 8 - Java 8
> > > >> >> > Tomcat 8 - Java EE 7 - Java 7
> > > >> >> > Tomcat 7 - Java EE 6 - Java 6
> > > >> >> >
> > > >> >> > Tomcat 7 support will continue until at least Java EE 9 is
> > > released.
> > > >> That
> > > >> >> > is meant to be next year but there are no firm dates yet and
> > > >> experience
> > > >> >> > suggests the Java EE 9 release date will slip.
> > > >> >> >
> > > >> >> > On that basis I expect Tomcat to need a Daemon that supports
> > Java 6
> > > >> for
> > > >> >> at
> > > >> >> > least 2 more years.
> > > >> >> >
> > > >> >> > Is there a user requirement driving an increase in the minimum
> > Java
> > > >> >> > version? If not, I suggest we stick with 6 for now.
> > > >> >> >
> > > >> >>
> > > >> >> There is no user requirement , Commons daemon is still keeping
> > > minimum
> > > >> >> dependency on java 1.5, we were thinking to move on minimum 1.6,
> > > nice to
> > > >> >> hear there won't be any issue with tomcat since it's already on
> 1.6
> > > >> >>
> > > >> >> For moving to much higher i.e. java 1.7 I'm sure daemon will take
> > > >> another
> > > >> >> 2-3 year for keeping stability across projects.
> > > >> >>
> > > >> >> Regards,
> > > >> >> Amey
> > > >> >>
> > > >> >> Mark
> > > >> >> >
> > > >> >> >
> > > >> >> > >
> > > >> >> > >Anyways, 1.6 minimum makes sense to me mainly due to Java 9's
> > > >> compiler
> > > >> >> > >not
> > > >> >> > >supporting Java 5 targets anymore.
> > > >> >> > >
> > > >> >> > >On 12 July 2017 at 09:19, Mark Thomas 
> wrote:
> > > >> >> > >
> > > >> >> > >> On 11 July 2017 21:02:54 CEST, Amey Jadiye <
> > > ameyjad...@gmail.com>
> > > >> >> > >wrote:
> 

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

[sebb]

Note: it's worth running the following:

mvn versions:display-dependency-updates -U
and
mvn versions:display-plugin-updates -U

to check for possible version updates

These give:

[INFO] The following dependencies in Dependencies have newer versions:
[INFO]   junit:junit . 4.11 -> 4.12
[INFO]   org.mockito:mockito-core . 1.9.5 -> 2.8.47

and

[INFO] The following plugin updates are available:
[INFO]   maven-changes-plugin . 2.12 -> 2.12.1
[INFO]
[WARNING] The following plugins do not have their version specified:
[WARNING]   maven-checkstyle-plugin . 2.17
[WARNING]   maven-pmd-plugin . 3.8
[WARNING]   org.codehaus.mojo:findbugs-maven-plugin  3.0.4

The mockito version is a big change and will need checking to ensure
it's compatible.


On 17 July 2017 at 03:08, Gary Gregory  wrote:
> I noticed it during
>
> mvn clean verify site
>
> Gary
>
> On Jul 16, 2017 18:34, "Carl Hall"  wrote:
>
>> Great feedback!  Thanks so much.
>>
>> Would you please let me know how you're running PMD?  I've tried `mvn
>> pmd:pmd`.  I'm not seeing issues locally and would like to make sure the
>> build is bulletproof.
>>
>>
>> On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory 
>> wrote:
>>
>> > +1
>> >
>> > From src zip: ASC, MD5, and SHA1 OK.
>> >
>> > RAT and CLIRR check OK.
>> >
>> > Reports look OK.
>> >
>> > Issues to address but not blockers:
>> > - PMD blows up during the build and there is no resulting PMD report.
>> > - The POM uses an old version of commons-parent.
>> >
>> > Gary
>> >
>> >
>> > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall  wrote:
>> >
>> > > Hi,
>> > >
>> > > It's been almost 3 years to the day since we've had a DbUtils release.
>> > > We've fixed several important bugs and added some new features, so I
>> > would
>> > > like to release DbUtils 1.7.
>> > >
>> > > Furthermore, we have fixed these issues for RC2, which were discovered
>> in
>> > > RC1:
>> > > - resource leaks as found by FindBugs
>> > > - updated links & text in generated texts and site
>> > >
>> > > DbUtils 1.7 RC2 is available for review here:
>> > >https://dist.apache.org/repos/dist/dev/commons/dbutils/
>> > DBUTILS_1_7_RC2/
>> > > (svn
>> > > revision 20455)
>> > >
>> > > The tag is here:
>> > >*https://git-wip-us.apache.org/repos/asf?p=commons-
>> > dbutils.git;a=tag;h=
>> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a
>> > > > dbutils.git;a=tag;h=
>> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
>> > >
>> > > Maven artifacts are here:
>> > >https://repository.apache.org/content/repositories/
>> > > orgapachecommons-1254
>> > >
>> > > These are the Maven Artifacts and their hashes:
>> > >
>> > > commons-dbutils-1.7-javadoc.jar
>> > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
>> > > commons-dbutils-1.7-javadoc.jar.asc
>> > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
>> > > commons-dbutils-1.7-javadoc.jar.md5
>> > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
>> > > commons-dbutils-1.7-javadoc.jar.sha1
>> > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
>> > > commons-dbutils-1.7-sources.jar
>> > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
>> > > commons-dbutils-1.7-sources.jar.asc
>> > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
>> > > commons-dbutils-1.7-sources.jar.md5
>> > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
>> > > commons-dbutils-1.7-sources.jar.sha1
>> > > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
>> > > commons-dbutils-1.7-test-sources.jar
>> > > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
>> > > commons-dbutils-1.7-test-sources.jar.asc
>> > > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
>> > > commons-dbutils-1.7-test-sources.jar.md5
>> > > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
>> > > commons-dbutils-1.7-test-sources.jar.sha1
>> > > (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
>> > > commons-dbutils-1.7-tests.jar
>> > > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
>> > > commons-dbutils-1.7-tests.jar.asc
>> > > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
>> > > commons-dbutils-1.7-tests.jar.md5
>> > > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
>> > > commons-dbutils-1.7-tests.jar.sha1
>> > > (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
>> > > commons-dbutils-1.7.jar
>> > > (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
>> > > commons-dbutils-1.7.jar.asc
>> > > (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
>> > > commons-dbutils-1.7.jar.md5
>> > > (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
>> > > commons-dbutils-1.7.jar.sha1
>> > > (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
>> > > commons-dbutils-1.7.pom
>> > > (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
>> > > 

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

[Carl Hall]

Thanks for pointing those out, sebb.  I'll be sure to get all of those
committed to master.  Hopefully the Mockito jump isn't too much work.  :)

On Mon, Jul 17, 2017 at 1:48 AM, sebb  wrote:

> Note: it's worth running the following:
>
> mvn versions:display-dependency-updates -U
> and
> mvn versions:display-plugin-updates -U
>
> to check for possible version updates
>
> These give:
>
> [INFO] The following dependencies in Dependencies have newer versions:
> [INFO]   junit:junit . 4.11
> -> 4.12
> [INFO]   org.mockito:mockito-core . 1.9.5 ->
> 2.8.47
>
> and
>
> [INFO] The following plugin updates are available:
> [INFO]   maven-changes-plugin . 2.12 ->
> 2.12.1
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING]   maven-checkstyle-plugin .
> 2.17
> [WARNING]   maven-pmd-plugin .
> 3.8
> [WARNING]   org.codehaus.mojo:findbugs-maven-plugin 
> 3.0.4
>
> The mockito version is a big change and will need checking to ensure
> it's compatible.
>
>
> On 17 July 2017 at 03:08, Gary Gregory  wrote:
> > I noticed it during
> >
> > mvn clean verify site
> >
> > Gary
> >
> > On Jul 16, 2017 18:34, "Carl Hall"  wrote:
> >
> >> Great feedback!  Thanks so much.
> >>
> >> Would you please let me know how you're running PMD?  I've tried `mvn
> >> pmd:pmd`.  I'm not seeing issues locally and would like to make sure the
> >> build is bulletproof.
> >>
> >>
> >> On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory 
> >> wrote:
> >>
> >> > +1
> >> >
> >> > From src zip: ASC, MD5, and SHA1 OK.
> >> >
> >> > RAT and CLIRR check OK.
> >> >
> >> > Reports look OK.
> >> >
> >> > Issues to address but not blockers:
> >> > - PMD blows up during the build and there is no resulting PMD report.
> >> > - The POM uses an old version of commons-parent.
> >> >
> >> > Gary
> >> >
> >> >
> >> > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall 
> wrote:
> >> >
> >> > > Hi,
> >> > >
> >> > > It's been almost 3 years to the day since we've had a DbUtils
> release.
> >> > > We've fixed several important bugs and added some new features, so I
> >> > would
> >> > > like to release DbUtils 1.7.
> >> > >
> >> > > Furthermore, we have fixed these issues for RC2, which were
> discovered
> >> in
> >> > > RC1:
> >> > > - resource leaks as found by FindBugs
> >> > > - updated links & text in generated texts and site
> >> > >
> >> > > DbUtils 1.7 RC2 is available for review here:
> >> > >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> >> > DBUTILS_1_7_RC2/
> >> > > (svn
> >> > > revision 20455)
> >> > >
> >> > > The tag is here:
> >> > >*https://git-wip-us.apache.org/repos/asf?p=commons-
> >> > dbutils.git;a=tag;h=
> >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a
> >> > >  >> dbutils.git;a=tag;h=
> >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> >> > >
> >> > > Maven artifacts are here:
> >> > >https://repository.apache.org/content/repositories/
> >> > > orgapachecommons-1254
> >> > >
> >> > > These are the Maven Artifacts and their hashes:
> >> > >
> >> > > commons-dbutils-1.7-javadoc.jar
> >> > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> >> > > commons-dbutils-1.7-javadoc.jar.asc
> >> > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> >> > > commons-dbutils-1.7-javadoc.jar.md5
> >> > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> >> > > commons-dbutils-1.7-javadoc.jar.sha1
> >> > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> >> > > commons-dbutils-1.7-sources.jar
> >> > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> >> > > commons-dbutils-1.7-sources.jar.asc
> >> > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> >> > > commons-dbutils-1.7-sources.jar.md5
> >> > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> >> > > commons-dbutils-1.7-sources.jar.sha1
> >> > > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> >> > > commons-dbutils-1.7-test-sources.jar
> >> > > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> >> > > commons-dbutils-1.7-test-sources.jar.asc
> >> > > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> >> > > commons-dbutils-1.7-test-sources.jar.md5
> >> > > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> >> > > commons-dbutils-1.7-test-sources.jar.sha1
> >> > > (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> >> > > commons-dbutils-1.7-tests.jar
> >> > > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> >> > > commons-dbutils-1.7-tests.jar.asc
> >> > > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> >> > > commons-dbutils-1.7-tests.jar.md5
> >> > > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> >> > > commons-dbutils-1.7-tests.jar.sha1
> >> > > (SHA: 

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

[Carl Hall]

Thanks!  Looks like PMD moved the Java rulesets to rulesets/java/*.  I'll
update that in master and make sure it's ready for the next release.  fwiw,
fixing that did not raise any new issues or warnings.

On Sun, Jul 16, 2017 at 7:08 PM, Gary Gregory 
wrote:

> I noticed it during
>
> mvn clean verify site
>
> Gary
>
> On Jul 16, 2017 18:34, "Carl Hall"  wrote:
>
> > Great feedback!  Thanks so much.
> >
> > Would you please let me know how you're running PMD?  I've tried `mvn
> > pmd:pmd`.  I'm not seeing issues locally and would like to make sure the
> > build is bulletproof.
> >
> >
> > On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory 
> > wrote:
> >
> > > +1
> > >
> > > From src zip: ASC, MD5, and SHA1 OK.
> > >
> > > RAT and CLIRR check OK.
> > >
> > > Reports look OK.
> > >
> > > Issues to address but not blockers:
> > > - PMD blows up during the build and there is no resulting PMD report.
> > > - The POM uses an old version of commons-parent.
> > >
> > > Gary
> > >
> > >
> > > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall 
> wrote:
> > >
> > > > Hi,
> > > >
> > > > It's been almost 3 years to the day since we've had a DbUtils
> release.
> > > > We've fixed several important bugs and added some new features, so I
> > > would
> > > > like to release DbUtils 1.7.
> > > >
> > > > Furthermore, we have fixed these issues for RC2, which were
> discovered
> > in
> > > > RC1:
> > > > - resource leaks as found by FindBugs
> > > > - updated links & text in generated texts and site
> > > >
> > > > DbUtils 1.7 RC2 is available for review here:
> > > >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> > > DBUTILS_1_7_RC2/
> > > > (svn
> > > > revision 20455)
> > > >
> > > > The tag is here:
> > > >*https://git-wip-us.apache.org/repos/asf?p=commons-
> > > dbutils.git;a=tag;h=
> > > > c7b9d1229aeacd1884c9ca126c5d65af0221404a
> > > >  > dbutils.git;a=tag;h=
> > > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> > > >
> > > > Maven artifacts are here:
> > > >https://repository.apache.org/content/repositories/
> > > > orgapachecommons-1254
> > > >
> > > > These are the Maven Artifacts and their hashes:
> > > >
> > > > commons-dbutils-1.7-javadoc.jar
> > > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> > > > commons-dbutils-1.7-javadoc.jar.asc
> > > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> > > > commons-dbutils-1.7-javadoc.jar.md5
> > > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> > > > commons-dbutils-1.7-javadoc.jar.sha1
> > > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> > > > commons-dbutils-1.7-sources.jar
> > > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> > > > commons-dbutils-1.7-sources.jar.asc
> > > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> > > > commons-dbutils-1.7-sources.jar.md5
> > > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> > > > commons-dbutils-1.7-sources.jar.sha1
> > > > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> > > > commons-dbutils-1.7-test-sources.jar
> > > > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> > > > commons-dbutils-1.7-test-sources.jar.asc
> > > > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> > > > commons-dbutils-1.7-test-sources.jar.md5
> > > > (SHA: 135c8c5dd7c868c116d17dc694731ff6230270f7)
> > > > commons-dbutils-1.7-test-sources.jar.sha1
> > > > (SHA: 38d6480819b9d813ad18307349a19603ed53f453)
> > > > commons-dbutils-1.7-tests.jar
> > > > (SHA: be58f64000d4b5a5932f5c18afbb847b3fe6caf3)
> > > > commons-dbutils-1.7-tests.jar.asc
> > > > (SHA: b93e9d1b23bbf051630b60ba917af03f0fd2a8cc)
> > > > commons-dbutils-1.7-tests.jar.md5
> > > > (SHA: beb09dfdd239b5a09d96132546e6a9cb5899617e)
> > > > commons-dbutils-1.7-tests.jar.sha1
> > > > (SHA: d25629f7ea7d3e352ad98f6d955ce473606d3ecf)
> > > > commons-dbutils-1.7.jar
> > > > (SHA: 8b750837334b0c92f3f09a481ff6638aa0a7e370)
> > > > commons-dbutils-1.7.jar.asc
> > > > (SHA: bbd4a9cdb128233e2bf67c252789385091576a6c)
> > > > commons-dbutils-1.7.jar.md5
> > > > (SHA: 5b90d74d0967dcb3ba4422489910730c3ff396b5)
> > > > commons-dbutils-1.7.jar.sha1
> > > > (SHA: ecb00abbc04548398986b80d1f0e48373d55c2b8)
> > > > commons-dbutils-1.7.pom
> > > > (SHA: dcaebe462df8501f14d764f2bece496e942586eb)
> > > > commons-dbutils-1.7.pom.asc
> > > > (SHA: 0547d14d07117cc496c018ef7fd320ae32884287)
> > > > commons-dbutils-1.7.pom.md5
> > > > (SHA: c5a32289a952a40202461528eeffcad474d0ef6c)
> > > > commons-dbutils-1.7.pom.sha1
> > > > (SHA: 0aa622dc6fa860ceeaf86fcb3e1a48f9530c3398)
> > > >
> > > > Details of changes since 1.6 are in the release notes:
> > > >
> > > > https://dist.apache.org/repos/dist/dev/commons/dbutils/
> > > > DBUTILS_1_7_RC2/RELEASE-NOTES.txt
> > > >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> > > > changes-report.html
> > > >
> > > > Site:
> > > >https://home.apache.org/~thecarlhall/dbutils-1.7-RC2/
> > > >
> > > 

Re: [daemon] moving to git ? and bump java version.

[Gary Gregory]

There is no fixed process to determine when it is releases time. Sometimes
a component has momentum and a release manager is picked and leads the way,
sometimes a committer needs a release and volunteers to manage a release.

Gary

On Jul 17, 2017 06:00, "Amey Jadiye"  wrote:

> Hi Gary,
>
> I will take a look at pending issues if something is blocker to release, I
> see already 9 issues are done for 1.1.0 release .  if we are ok with these
> 9, anyone can release it. BTW how do you guys decide that "this is a time
> to release!"  for any component ?
>
> Regards,
> Amey
>
> On Jul 16, 2017 10:38 PM, "Gary Gregory"  wrote:
>
> > If someone here is really going to put time and energy into daemon, it
> > would be fantastic to start with a release. It's been so long...  Then
> > fiddle away on tweaks, and release again.
> >
> > Gary
> >
> > On Jul 16, 2017 08:49, "Matt Sicker"  wrote:
> >
> > > C quality somewhat depends on which version of C you're trying to
> remain
> > > compatible with (I'm guessing C89 due to Windows, though I could be
> > wrong).
> > > Valgrind and other tracing tools are typically used. I'd take a look at
> > > what OpenOffice is doing for local examples (though they have a crazy
> > build
> > > system last I heard), or the FSF, Linux, Xorg, FreeDesktop, GNOME, KDE,
> > or
> > > other major users of C and C++.
> > >
> > > On the modern front, it'd be interesting if it were written in Rust,
> > though
> > > I don't know enough about the language to say if it's worth porting to
> > > eventually.
> > >
> > > On 15 July 2017 at 09:26, sebb  wrote:
> > >
> > > > On 15 July 2017 at 15:21, Amey Jadiye  wrote:
> > > > > Yes, that's mentioned  in my previous mail, I was also curious to
> > know
> > > > from
> > > > > the C developers here in dev-list that how can we make *that* C
> code
> > > > > better? basically I'm looking findbug, checkstyle, jococo, junit
> > > > >  *equivalent* for C code.
> > > >
> > > > No idea on automated tools.
> > > > However when I last looked there was plenty of scope for better
> > > > documentation.
> > > >
> > > > Also I did wonder if the Prunmgr GUI might be better coded as a
> > > > (mainly) Java application.
> > > >
> > > > The procrun stuff has to remain as C.
> > > >
> > > > > Regards,
> > > > > Amey
> > > > >
> > > > > On Sat, Jul 15, 2017 at 7:44 PM, sebb  wrote:
> > > > >
> > > > >> Also note that there is hardly any Java code; most of it is
> written
> > in
> > > > C.
> > > > >>
> > > > >> On 14 July 2017 at 00:43, Gary Gregory 
> > > wrote:
> > > > >> > It seems OK to me to update to Java 6 for now and get this to
> > > compile
> > > > >> under
> > > > >> > java 9 for those folks who will try...
> > > > >> >
> > > > >> > Gary
> > > > >> >
> > > > >> > On Wed, Jul 12, 2017 at 9:09 AM, Amey Jadiye <
> > ameyjad...@gmail.com>
> > > > >> wrote:
> > > > >> >
> > > > >> >> Thanks for great insights Mark.
> > > > >> >>
> > > > >> >> On Wed, Jul 12, 2017, 9:28 PM Mark Thomas 
> > > wrote:
> > > > >> >>
> > > > >> >> > On 12 July 2017 16:33:01 CEST, Matt Sicker  >
> > > > wrote:
> > > > >> >> > >Are there plans to require 1.7 for Tomcat anytime?
> Otherwise,
> > it
> > > > >> might
> > > > >> >> > >be
> > > > >> >> > >necessary to make a new major version of daemon eventually
> for
> > > > Java 8
> > > > >> >> > >or 9.
> > > > >> >> >
> > > > >> >> > Tomcat major versions are aligned with Java EE versions which
> > in
> > > > turn
> > > > >> >> have
> > > > >> >> > a minimum Java version.
> > > > >> >> >
> > > > >> >> > Tomcat supports 3 current versions in parallel so we
> currently
> > > > have:
> > > > >> >> >
> > > > >> >> > Tomcat 9 - Java EE 8 - Java 8
> > > > >> >> > Tomcat 8 - Java EE 7 - Java 7
> > > > >> >> > Tomcat 7 - Java EE 6 - Java 6
> > > > >> >> >
> > > > >> >> > Tomcat 7 support will continue until at least Java EE 9 is
> > > > released.
> > > > >> That
> > > > >> >> > is meant to be next year but there are no firm dates yet and
> > > > >> experience
> > > > >> >> > suggests the Java EE 9 release date will slip.
> > > > >> >> >
> > > > >> >> > On that basis I expect Tomcat to need a Daemon that supports
> > > Java 6
> > > > >> for
> > > > >> >> at
> > > > >> >> > least 2 more years.
> > > > >> >> >
> > > > >> >> > Is there a user requirement driving an increase in the
> minimum
> > > Java
> > > > >> >> > version? If not, I suggest we stick with 6 for now.
> > > > >> >> >
> > > > >> >>
> > > > >> >> There is no user requirement , Commons daemon is still keeping
> > > > minimum
> > > > >> >> dependency on java 1.5, we were thinking to move on minimum
> 1.6,
> > > > nice to
> > > > >> >> hear there won't be any issue with tomcat since it's already on
> > 1.6
> > > > >> >>
> > > > >> >> For moving to much higher i.e. java 1.7 I'm sure daemon will
> take
> > > > >> 

[GitHub] commons-imaging issue #27: Increase code coverage one

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/commons-imaging/pull/27
  
Yes, you want a fresh PR.

Gary

On Mon, Jul 17, 2017 at 9:59 AM, TheRealHaui 
wrote:

> As the pull request is already closed shall I reopen another with the same
> name?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127770520
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.formats.pnm;
+
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link PbmFileInfo}.
+ *
+ * @date 13.07.2017
+ * @see PbmFileInfo
+ *
+ **/
+public class PbmFileInfoTest{
+
+
+  @Test
+  public void testGetRGBThrowsIOException() throws IOException {
+
+  PbmFileInfo pbmFileInfo = new PbmFileInfo(2764, 354, true);
+  byte[] byteArray = new byte[2];
+  ByteArrayInputStream byteArrayInputStream = new 
ByteArrayInputStream(byteArray);
--- End diff --

Changed to interface.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-imaging/pull/27
  
As the pull request is already closed shall I reopen another with the same 
name?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127768831
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
@@ -66,6 +64,22 @@ protected File createTempFile(final byte src[]) throws 
IOException {
 }
 final byte longArray[] = (baos.toByteArray());
 
-return new byte[][] { emptyArray, single, simple, zeroes, 
longArray, };
+return new byte[][]{emptyArray, single, simple, zeroes, 
longArray,};
+}
+
+@Test
--- End diff --

Yes, I know.
However, for what reason ever I experienced a lot of people preferring the 
try/catch notation over the annotation approach.
That's why I write/wrote it this way.
In the hope to have to rewrite as less code in the end as possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127770670
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/pnm/PbmFileInfoTest.java ---
@@ -0,0 +1,41 @@
+package org.apache.commons.imaging.formats.pnm;
+
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link PbmFileInfo}.
+ *
+ * @date 13.07.2017
+ * @see PbmFileInfo
+ *
+ **/
+public class PbmFileInfoTest{
+
+
+  @Test
+  public void testGetRGBThrowsIOException() throws IOException {
+
+  PbmFileInfo pbmFileInfo = new PbmFileInfo(2764, 354, true);
+  byte[] byteArray = new byte[2];
+  ByteArrayInputStream byteArrayInputStream = new 
ByteArrayInputStream(byteArray);
+  byteArrayInputStream.read(byteArray);
+
+  try { 
+pbmFileInfo.getRGB((InputStream) byteArrayInputStream);
--- End diff --

Changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

[Matt Sicker]

I've migrated Mockito code before, and the migration is pretty simple
depending on how complex your usage is. It could be as simple as changing
an import or two.

On 17 July 2017 at 10:11, Carl Hall  wrote:

> Thanks for pointing those out, sebb.  I'll be sure to get all of those
> committed to master.  Hopefully the Mockito jump isn't too much work.  :)
>
> On Mon, Jul 17, 2017 at 1:48 AM, sebb  wrote:
>
> > Note: it's worth running the following:
> >
> > mvn versions:display-dependency-updates -U
> > and
> > mvn versions:display-plugin-updates -U
> >
> > to check for possible version updates
> >
> > These give:
> >
> > [INFO] The following dependencies in Dependencies have newer versions:
> > [INFO]   junit:junit . 4.11
> > -> 4.12
> > [INFO]   org.mockito:mockito-core . 1.9.5 ->
> > 2.8.47
> >
> > and
> >
> > [INFO] The following plugin updates are available:
> > [INFO]   maven-changes-plugin . 2.12 ->
> > 2.12.1
> > [INFO]
> > [WARNING] The following plugins do not have their version specified:
> > [WARNING]   maven-checkstyle-plugin ..
> ...
> > 2.17
> > [WARNING]   maven-pmd-plugin ..
> ...
> > 3.8
> > [WARNING]   org.codehaus.mojo:findbugs-maven-plugin 
> > 3.0.4
> >
> > The mockito version is a big change and will need checking to ensure
> > it's compatible.
> >
> >
> > On 17 July 2017 at 03:08, Gary Gregory  wrote:
> > > I noticed it during
> > >
> > > mvn clean verify site
> > >
> > > Gary
> > >
> > > On Jul 16, 2017 18:34, "Carl Hall"  wrote:
> > >
> > >> Great feedback!  Thanks so much.
> > >>
> > >> Would you please let me know how you're running PMD?  I've tried `mvn
> > >> pmd:pmd`.  I'm not seeing issues locally and would like to make sure
> the
> > >> build is bulletproof.
> > >>
> > >>
> > >> On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory  >
> > >> wrote:
> > >>
> > >> > +1
> > >> >
> > >> > From src zip: ASC, MD5, and SHA1 OK.
> > >> >
> > >> > RAT and CLIRR check OK.
> > >> >
> > >> > Reports look OK.
> > >> >
> > >> > Issues to address but not blockers:
> > >> > - PMD blows up during the build and there is no resulting PMD
> report.
> > >> > - The POM uses an old version of commons-parent.
> > >> >
> > >> > Gary
> > >> >
> > >> >
> > >> > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall 
> > wrote:
> > >> >
> > >> > > Hi,
> > >> > >
> > >> > > It's been almost 3 years to the day since we've had a DbUtils
> > release.
> > >> > > We've fixed several important bugs and added some new features,
> so I
> > >> > would
> > >> > > like to release DbUtils 1.7.
> > >> > >
> > >> > > Furthermore, we have fixed these issues for RC2, which were
> > discovered
> > >> in
> > >> > > RC1:
> > >> > > - resource leaks as found by FindBugs
> > >> > > - updated links & text in generated texts and site
> > >> > >
> > >> > > DbUtils 1.7 RC2 is available for review here:
> > >> > >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> > >> > DBUTILS_1_7_RC2/
> > >> > > (svn
> > >> > > revision 20455)
> > >> > >
> > >> > > The tag is here:
> > >> > >*https://git-wip-us.apache.org/repos/asf?p=commons-
> > >> > dbutils.git;a=tag;h=
> > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a
> > >> > >  > >> dbutils.git;a=tag;h=
> > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> > >> > >
> > >> > > Maven artifacts are here:
> > >> > >https://repository.apache.org/content/repositories/
> > >> > > orgapachecommons-1254
> > >> > >
> > >> > > These are the Maven Artifacts and their hashes:
> > >> > >
> > >> > > commons-dbutils-1.7-javadoc.jar
> > >> > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> > >> > > commons-dbutils-1.7-javadoc.jar.asc
> > >> > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> > >> > > commons-dbutils-1.7-javadoc.jar.md5
> > >> > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> > >> > > commons-dbutils-1.7-javadoc.jar.sha1
> > >> > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> > >> > > commons-dbutils-1.7-sources.jar
> > >> > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> > >> > > commons-dbutils-1.7-sources.jar.asc
> > >> > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> > >> > > commons-dbutils-1.7-sources.jar.md5
> > >> > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> > >> > > commons-dbutils-1.7-sources.jar.sha1
> > >> > > (SHA: 198663d496d62b4f78ab8edf85c7125e79213f32)
> > >> > > commons-dbutils-1.7-test-sources.jar
> > >> > > (SHA: 6c61c9324218009db50415bfdf8b1c6675dcbbf0)
> > >> > > commons-dbutils-1.7-test-sources.jar.asc
> > >> > > (SHA: 120cd3f4f4d673eb49cd976f814110a74bde438f)
> > >> > > commons-dbutils-1.7-test-sources.jar.md5
> > >> > > (SHA: 

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127761190
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.bmp;
+
+import org.junit.Test;
+
+import java.awt.image.BufferedImage;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link BmpWriterRgb}.
+ *
+ * @date 13.07.2017
--- End diff --

Good idea.
Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127768274
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.bmp;
+
+import org.junit.Test;
+
+import java.awt.image.BufferedImage;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link BmpWriterRgb}.
+ *
+ * @date 13.07.2017
+ * @see BmpWriterRgb
+ *
+ **/
+public class BmpWriterRgbTest{
+
+
+@Test
+public void testGetImageData() {
+
+BmpWriterRgb bmpWriterRgb = new BmpWriterRgb();
+BufferedImage bufferedImage = new BufferedImage(2, 2, 5);
+byte[] byteArray = bmpWriterRgb.getImageData(bufferedImage);
+
+assertEquals( 24, bmpWriterRgb.getBitsPerPixel() );
+assertEquals( 0, bmpWriterRgb.getPaletteSize() );
+assertEquals( 16, byteArray.length );
+assertEquals( "[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]", 
Arrays.toString(byteArray) );
--- End diff --

Done.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127769590
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/jpeg/segments/JfifSegmentTest.java
 ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.jpeg.segments;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link JfifSegment}.
+ *
+ * @date 13.07.2017
+ * @see JfifSegment
+ *
+ **/
+public class JfifSegmentTest{
+
+
+  @Test
+  public void testCreatesJfifSegment() {
+
+  byte[] byteArray = new byte[25];
+  JfifSegment jfifSegment = null;
+
+  try {
+jfifSegment = new JfifSegment((-2275), byteArray);
+fail("Expecting exception: Exception");
+  } catch(Throwable e) {
--- End diff --

Had to do with the fact that at the beginning the test class resided in a 
different hierarchical folder structure than the original class ...
Corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782716
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
@@ -17,24 +17,22 @@
 
 package org.apache.commons.imaging.common.bytesource;
 
-import static org.junit.Assert.assertTrue;
+import org.apache.commons.imaging.ImagingTest;
+import org.junit.Test;
 
-import java.io.BufferedOutputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.OutputStream;
+import java.io.*;
 
-import org.apache.commons.imaging.ImagingTest;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 public abstract class ByteSourceTest extends ImagingTest {
 protected File createTempFile(final byte src[]) throws IOException {
 final File file = createTempFile("raw_", ".bin");
 
 // write test bytes to file.
 try (FileOutputStream fos = new FileOutputStream(file);
-OutputStream os = new BufferedOutputStream(fos)) {
+ OutputStream os = new BufferedOutputStream(fos)) {
--- End diff --

No need to un-tab this line AFAICT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781644
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
+public class ImageDumpTest{
+
+
+@Test
+public void testDumpColorSpace() {
+
+ImageDump imageDump = new ImageDump();
+ColorSpace colorSpace = ColorSpace.getInstance(1004);
+imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);
+
+assertEquals(3, colorSpace.getNumComponents());
+
+}
+
+
+@Test
+public void testDump() {
+
+ImageDump imageDump = new ImageDump();
+BufferedImage bufferedImage = new BufferedImage(10, 10, 10);
+imageDump.dump(bufferedImage);
+
+assertEquals(10, bufferedImage.getHeight());
+
+}
+
+
--- End diff --

Having two blank lines here seems to be inconsistent with the other test 
classes in commons-imaging. I suggest shortening it to one or zero blank lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127780455
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
+public class ImageDumpTest{
--- End diff --

The `{` seems to be joined directly with the class name to its left. This 
is inconsistent with all the other test classes AFAICT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782811
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
@@ -66,6 +64,22 @@ protected File createTempFile(final byte src[]) throws 
IOException {
 }
 final byte longArray[] = (baos.toByteArray());
 
-return new byte[][] { emptyArray, single, simple, zeroes, 
longArray, };
+return new byte[][]{emptyArray, single, simple, zeroes, 
longArray,};
--- End diff --

No need to remove spaces here AFAICT.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127780127
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
--- End diff --

I question the presence of Javadoc in this class and all the other classes 
affected by this PR. AFAICT not all the tests (if any) even have Javadocs, so 
why should javadocs be added for this class and the others?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782170
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
 ---
@@ -0,0 +1,36 @@
+package org.apache.commons.imaging.common;
+
+import org.junit.Test;
+
+import java.awt.image.DirectColorModel;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link RgbBufferedImageFactory}.
+ *
+ * @date 2017-07-13
+ * @see RgbBufferedImageFactory
+ *
+ **/
+public class RgbBufferedImageFactoryTest{
+
+
+@Test
+public void testGetColorBufferedImageThrowsIllegalArgumentException() {
+
+RgbBufferedImageFactory rgbBufferedImageFactory = new 
RgbBufferedImageFactory();
+
+try {
+rgbBufferedImageFactory.getColorBufferedImage(0, 0, true);
+fail("Expecting exception: IllegalArgumentException");
+} catch(IllegalArgumentException e) {
+assertEquals("Width (0) and height (0) cannot be <= 
0",e.getMessage());
+assertEquals(DirectColorModel.class.getName(), 
e.getStackTrace()[0].getClassName());
+}
+
--- End diff --

Ditto regarding blank lines. Please shorten them for all other classes as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127783301
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/jpeg/iptc/IptcTypeLookupTest.java
 ---
@@ -0,0 +1,28 @@
+package org.apache.commons.imaging.formats.jpeg.iptc;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link IptcTypeLookup}.
+ *
+ * @date 2017-07-13
+ * @see IptcTypeLookup
+ *
+ **/
+public class IptcTypeLookupTest{
+
+
+@Test
+public void testGetIptcTypeWithPositive() {
+
+IptcType iptcType = IptcTypeLookup.getIptcType(1117);
+
+assertEquals( 1117, iptcType.getType() );
+assertEquals( "Unknown", iptcType.getName() );
--- End diff --

Ditto regarding spaces at start and end of parameter lists.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127783226
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/bmp/BmpWriterRgbTest.java ---
@@ -0,0 +1,35 @@
+package org.apache.commons.imaging.formats.bmp;
+
+import org.junit.Test;
+
+import java.awt.image.BufferedImage;
+import java.util.Arrays;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link BmpWriterRgb}.
+ *
+ * @date 2017-07-13
+ * @see BmpWriterRgb
+ *
+ **/
+public class BmpWriterRgbTest{
+
+
+@Test
+public void testGetImageData() {
+
+BmpWriterRgb bmpWriterRgb = new BmpWriterRgb();
+BufferedImage bufferedImage = new BufferedImage(2, 2, 5);
+byte[] byteArray = bmpWriterRgb.getImageData(bufferedImage);
+
+assertEquals( 24, bmpWriterRgb.getBitsPerPixel() );
+assertEquals( 0, bmpWriterRgb.getPaletteSize() );
+assertEquals( 16, byteArray.length );
+assertEquals( "[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]", 
Arrays.toString(byteArray) );
--- End diff --

Spaces at start and end of parameter lists seem unnecessary here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-imaging/pull/27
  
Improvements made in #28.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127778422
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
@@ -66,6 +64,22 @@ protected File createTempFile(final byte src[]) throws 
IOException {
 }
 final byte longArray[] = (baos.toByteArray());
 
-return new byte[][] { emptyArray, single, simple, zeroes, 
longArray, };
+return new byte[][]{emptyArray, single, simple, zeroes, 
longArray,};
+}
+
+@Test
--- End diff --

@onealj @TheRealHaui If I were maintaining this code, I'd be happy with 
either pattern.

`@Test(expected=NullPointerException.class)` would be a little shorter and 
equivalent to the `try..catch` construct used here in this case.

However, the reason people tend to prefer `try..catch` is because in a lot 
of cases it is not granular enough. Take this (admittedly contrived) example:

```java
@Test(expected=NullPointerException.class)
public void doSomething() {
  String s = null;
  assertTrue(s.isEmpty());
  try {
somethingWhichThrowsNullPointerException():
  } catch (NullPointerException e) {
assertNull(s);
  }
}
```

In this case, rather than `somethingWhichThrowsNullPointerException(s1)` 
throwing `NullPointerException` (which we expect), it will be `s.isEmpty()` 
that throws it instead, which isn't what we intended, since it means the test 
will always "pass".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127775941
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
 ---
@@ -0,0 +1,37 @@
+package org.apache.commons.imaging.formats.tiff.fieldtypes;
+
+import org.junit.Test;
+
+import java.nio.ByteOrder;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link FieldTypeByte}.
+ *
+ * @date 13.07.2017
+ * @see FieldTypeByte
+ *
+ **/
+public class FieldTypeByteTest{
+
+
+  @Test
+  public void testWriteDataWithNull() {
+
+  FieldTypeByte fieldTypeByte = FieldType.UNDEFINED;
+  ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
+
+  try { 
+fieldTypeByte.writeData( null, byteOrder);
+fail("Expecting exception: Exception");
+  } catch(Exception e) {
+ assertEquals("Invalid data: null (null)",e.getMessage());
+ assertEquals(FieldTypeByte.class.getName(), 
e.getStackTrace()[0].getClassName());
--- End diff --

You're right.
Omitting the stack trace is definitely shorter and more intuitive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[TheRealHaui]

GitHub user TheRealHaui opened a pull request:

https://github.com/apache/commons-imaging/pull/28

Increase code coverage one

Added various improvements to selected Unit Tests.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TheRealHaui/commons-imaging 
increase-code-coverage-one

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-imaging/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #28


commit 127469460ab0ae0d12d35b4e0b5056af6debdea2
Author: Michael Hausegger 
Date:   2017-07-13T20:12:46Z

increase-code-coverage-one Added Unit Tests to increase code coverage.

commit 8e48087803a12106f1d8b88803a94557f031ec62
Author: Michael Hausegger 
Date:   2017-07-13T21:00:31Z

increase-code-coverage-one Added Unit Tests to increase code coverage.

commit 66b929d15a0f03441b58c7cadd42e58da831d5bb
Author: Michael Hausegger 
Date:   2017-07-13T21:14:08Z

increase-code-coverage-one Fixed failing test.

commit 10c8babeff6d0115d4fa440f226e716eaa3bbf79
Author: Michael Hausegger 
Date:   2017-07-15T21:39:54Z

increase-code-coverage-one Fix directory hierarchy problem.

commit 48a365d24fecf2a29213f16468d3c165f9f34d1e
Author: Michael Hausegger 
Date:   2017-07-17T16:51:29Z

increase-code-coverage-one Changed date format in comments.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [daemon] moving to git ? and bump java version.

[Simon Spero]

On Jul 16, 2017 11:49 AM, "Matt Sicker"  wrote:

C quality somewhat depends on which version of C you're trying to remain
compatible with (I'm guessing C89 due to Windows, though I could be wrong).
Valgrind and other tracing tools are typically used.


Valgrind is a default choice (though then you still have plenty of
configuration choices to make :)

A similar set of functionality is available using the various sanitizers
available in clang (and recent versions of gcc, though I haven't tried
that). These are described in the clang user manual:

http://clang.llvm.org/docs/UsersManual.html#controlling-code-generation

Clang also supports static analysis, which can, um, detect errors
statically. This can sometimes generate a bunch of false positives,
depending on the coding  style. The analyzer typically produces an html
report.  These analyzers can be run using scan build.

There are quite a lot more static analyzers available via clang-tidy, which
may or  may not  require installing an extra package.

CppUnit is a sensible choice for unit tests, but does require that tests be
written in C++, which might be a problem if you are sent back in time (tip:
write to Bjarne at AT Bell Laboratories, and ask for a tape).

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781676
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
 ---
@@ -0,0 +1,36 @@
+package org.apache.commons.imaging.common;
+
+import org.junit.Test;
+
+import java.awt.image.DirectColorModel;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link RgbBufferedImageFactory}.
+ *
+ * @date 2017-07-13
+ * @see RgbBufferedImageFactory
+ *
+ **/
--- End diff --

Ditto regarding javadoc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782199
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
 ---
@@ -0,0 +1,36 @@
+package org.apache.commons.imaging.common;
+
+import org.junit.Test;
+
+import java.awt.image.DirectColorModel;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link RgbBufferedImageFactory}.
+ *
+ * @date 2017-07-13
+ * @see RgbBufferedImageFactory
+ *
+ **/
+public class RgbBufferedImageFactoryTest{
+
+
+@Test
+public void testGetColorBufferedImageThrowsIllegalArgumentException() {
+
+RgbBufferedImageFactory rgbBufferedImageFactory = new 
RgbBufferedImageFactory();
+
+try {
+rgbBufferedImageFactory.getColorBufferedImage(0, 0, true);
+fail("Expecting exception: IllegalArgumentException");
+} catch(IllegalArgumentException e) {
+assertEquals("Width (0) and height (0) cannot be <= 
0",e.getMessage());
+assertEquals(DirectColorModel.class.getName(), 
e.getStackTrace()[0].getClassName());
+}
+
+}
+
+
--- End diff --

Ditto regarding blank lines. Please shorten them for all other classes as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781398
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
+public class ImageDumpTest{
+
+
--- End diff --

Having two blank lines here seems to be inconsistent with the other test 
classes in commons-imaging. I suggest shortening it to one blank line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782141
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
 ---
@@ -0,0 +1,36 @@
+package org.apache.commons.imaging.common;
+
+import org.junit.Test;
+
+import java.awt.image.DirectColorModel;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link RgbBufferedImageFactory}.
+ *
+ * @date 2017-07-13
+ * @see RgbBufferedImageFactory
+ *
+ **/
+public class RgbBufferedImageFactoryTest{
+
+
+@Test
+public void testGetColorBufferedImageThrowsIllegalArgumentException() {
+
--- End diff --

Ditto regarding blank lines. Please shorten them for all other classes as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127782622
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/bytesource/ByteSourceTest.java 
---
@@ -17,24 +17,22 @@
 
 package org.apache.commons.imaging.common.bytesource;
 
-import static org.junit.Assert.assertTrue;
+import org.apache.commons.imaging.ImagingTest;
+import org.junit.Test;
 
-import java.io.BufferedOutputStream;
-import java.io.ByteArrayOutputStream;
-import java.io.File;
-import java.io.FileOutputStream;
-import java.io.IOException;
-import java.io.OutputStream;
+import java.io.*;
 
-import org.apache.commons.imaging.ImagingTest;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
--- End diff --

I'd keep the ordering and style of the imports as before; no need to 
rearrange them just to import `assertEquals` and `fail`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781095
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
+public class ImageDumpTest{
+
+
+@Test
+public void testDumpColorSpace() {
+
+ImageDump imageDump = new ImageDump();
+ColorSpace colorSpace = ColorSpace.getInstance(1004);
+imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);
+
+assertEquals(3, colorSpace.getNumComponents());
+
+}
+
+
+@Test
+public void testDump() {
+
+ImageDump imageDump = new ImageDump();
+BufferedImage bufferedImage = new BufferedImage(10, 10, 10);
+imageDump.dump(bufferedImage);
+
+assertEquals(10, bufferedImage.getHeight());
+
+}
--- End diff --

Ditto regarding blank lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781035
  
--- Diff: src/test/java/org/apache/commons/imaging/ImageDumpTest.java ---
@@ -0,0 +1,44 @@
+package org.apache.commons.imaging;
+
+import org.junit.Test;
+
+import java.awt.color.ColorSpace;
+import java.awt.image.BufferedImage;
+
+import static org.junit.Assert.assertEquals;
+
+/**
+ * Unit tests for class {@link ImageDump}.
+ *
+ * @date 2017-07-13
+ * @see ImageDump
+ *
+ **/
+public class ImageDumpTest{
+
+
+@Test
+public void testDumpColorSpace() {
+
+ImageDump imageDump = new ImageDump();
+ColorSpace colorSpace = ColorSpace.getInstance(1004);
+imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);
+
+assertEquals(3, colorSpace.getNumComponents());
+
+}
--- End diff --

Most test methods I've seen in commons-imaging prefer to have no blank 
lines at the start and end of the test method body. I suggest removing the 
blank lines at the start and end of `testDumpColorSpace`'s body here for 
consistency, so like this:

```java
@Test 
public void testDumpColorSpace() {
ImageDump imageDump = new ImageDump();
ColorSpace colorSpace = ColorSpace.getInstance(1004);
imageDump.dumpColorSpace("Ku&]N>!4'C#Jzn+", colorSpace);

assertEquals(3, colorSpace.getNumComponents());
}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #28: Increase code coverage one

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/28#discussion_r127781871
  
--- Diff: 
src/test/java/org/apache/commons/imaging/common/RgbBufferedImageFactoryTest.java
 ---
@@ -0,0 +1,36 @@
+package org.apache.commons.imaging.common;
+
+import org.junit.Test;
+
+import java.awt.image.DirectColorModel;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link RgbBufferedImageFactory}.
+ *
+ * @date 2017-07-13
+ * @see RgbBufferedImageFactory
+ *
+ **/
+public class RgbBufferedImageFactoryTest{
+
+
--- End diff --

Ditto regarding blank lines. Please shorten them for all other classes as 
well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #5: gitignore and CollectionUtils improveme...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #18: COLLECTIONS-586 PatriciaTrie prefixMap...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #9: COLLECTIONS-551

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #15: Allow minus index

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #12: [COLLECTIONS-573] Add CollectionUtils#...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #13: [COLLECTIONS-574] Improve ListUtils#lo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #3: Added MultiValuedLinkedHashMap to prese...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #21: Add VI[M] temporary files to .gitignor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #18: COLLECTIONS-586 PatriciaTrie prefixMap...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/18


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #13: [COLLECTIONS-574] Improve ListUtils#lo...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/13


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #15: Allow minus index

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/15


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #9: COLLECTIONS-551

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/9


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #10: Add CollectionUtils#containsQuietly me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #21: Add VI[M] temporary files to .gitignor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/21


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #12: [COLLECTIONS-573] Add CollectionUtils#...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/12


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #3: Added MultiValuedLinkedHashMap to prese...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/3


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #5: gitignore and CollectionUtils improveme...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #22: [COLLECTIONS-600] Null-safe implementa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #10: Add CollectionUtils#containsQuietly me...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #24: add-some-Unit-Tests Added some Unit Te...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #19: COLLECTIONS-575: Add synchronized queu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #22: [COLLECTIONS-600] Null-safe implementa...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/22


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections pull request #19: COLLECTIONS-575: Add synchronized queu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/commons-collections/pull/19


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [daemon] moving to git ? and bump java version.

[Gary Gregory]

At thus point I would like to see:
- A release
- Go through JIRA and fix issues
- A release

We can update to Java 6 to allow the project to be built by Java 9 at any
time, no big deal IMO. Crud, the oldest Java I have installed is Java 6.
Hm, I'll push out Java 6 as the req and get that out of the way.

Gary


On Mon, Jul 17, 2017 at 11:19 AM, Simon Spero  wrote:

> On Jul 16, 2017 11:49 AM, "Matt Sicker"  wrote:
>
> C quality somewhat depends on which version of C you're trying to remain
> compatible with (I'm guessing C89 due to Windows, though I could be wrong).
> Valgrind and other tracing tools are typically used.
>
>
> Valgrind is a default choice (though then you still have plenty of
> configuration choices to make :)
>
> A similar set of functionality is available using the various sanitizers
> available in clang (and recent versions of gcc, though I haven't tried
> that). These are described in the clang user manual:
>
> http://clang.llvm.org/docs/UsersManual.html#controlling-code-generation
>
> Clang also supports static analysis, which can, um, detect errors
> statically. This can sometimes generate a bunch of false positives,
> depending on the coding  style. The analyzer typically produces an html
> report.  These analyzers can be run using scan build.
>
> There are quite a lot more static analyzers available via clang-tidy, which
> may or  may not  require installing an extra package.
>
> CppUnit is a sensible choice for unit tests, but does require that tests be
> written in C++, which might be a problem if you are sent back in time (tip:
> write to Bjarne at AT Bell Laboratories, and ask for a tape).
>

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-collections/pull/24
  
What does it mean that the asfgit bot closed my pull request?
Was it accepted or rejected?
Or even worse - ignored completely?
As there is no reaction in this pull request than from the bot I don't have 
a glue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-collections/pull/24
  
@jvz 
Thanks for your answer!
I really haven't got any glue as I am not so much experienced with the 
habits here at Github and Open Source development conventions in general!
However, now I know a little bit better.

Beside that, we assume I suppose that it was NO accident! :-D
As it's not my first contribution to Apache software too.
Thanks for your answer again!
Was a little bit annoyed about stumbling completely in the dark.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

[jvz]

Github user jvz commented on the issue:

https://github.com/apache/commons-collections/pull/24
  
It usually means it was merged manually and closed via a commit message, 
though it could've been an accident.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

[chtompki]

Github user chtompki commented on the issue:

https://github.com/apache/commons-collections/pull/24
  
Actually that's not true today. It's a side effect of my moving collections 
to git, but I will look at this and try to pull it in tomorrow morning (UTC-4).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

[TheRealHaui]

Github user TheRealHaui commented on the issue:

https://github.com/apache/commons-collections/pull/24
  
Okay ...
Now it's getting definitely a little bit wired. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging issue #28: Increase code coverage one

[garydgregory]

Github user garydgregory commented on the issue:

https://github.com/apache/commons-imaging/pull/28
  
You want a fresh PR, yes, but you still need to base it off of git master, 
not just continue the previous patch please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release Apache Commons DbUtils 1.7 based on RC2

[Gary Gregory]

Let's not get side-tracked here, this is a [VOTE] thread ;-)

Gary

On Mon, Jul 17, 2017 at 8:46 AM, Matt Sicker  wrote:

> I've migrated Mockito code before, and the migration is pretty simple
> depending on how complex your usage is. It could be as simple as changing
> an import or two.
>
> On 17 July 2017 at 10:11, Carl Hall  wrote:
>
> > Thanks for pointing those out, sebb.  I'll be sure to get all of those
> > committed to master.  Hopefully the Mockito jump isn't too much work.  :)
> >
> > On Mon, Jul 17, 2017 at 1:48 AM, sebb  wrote:
> >
> > > Note: it's worth running the following:
> > >
> > > mvn versions:display-dependency-updates -U
> > > and
> > > mvn versions:display-plugin-updates -U
> > >
> > > to check for possible version updates
> > >
> > > These give:
> > >
> > > [INFO] The following dependencies in Dependencies have newer versions:
> > > [INFO]   junit:junit .
> 4.11
> > > -> 4.12
> > > [INFO]   org.mockito:mockito-core . 1.9.5
> ->
> > > 2.8.47
> > >
> > > and
> > >
> > > [INFO] The following plugin updates are available:
> > > [INFO]   maven-changes-plugin . 2.12
> ->
> > > 2.12.1
> > > [INFO]
> > > [WARNING] The following plugins do not have their version specified:
> > > [WARNING]   maven-checkstyle-plugin ..
> > ...
> > > 2.17
> > > [WARNING]   maven-pmd-plugin ..
> > ...
> > > 3.8
> > > [WARNING]   org.codehaus.mojo:findbugs-maven-plugin
> 
> > > 3.0.4
> > >
> > > The mockito version is a big change and will need checking to ensure
> > > it's compatible.
> > >
> > >
> > > On 17 July 2017 at 03:08, Gary Gregory  wrote:
> > > > I noticed it during
> > > >
> > > > mvn clean verify site
> > > >
> > > > Gary
> > > >
> > > > On Jul 16, 2017 18:34, "Carl Hall"  wrote:
> > > >
> > > >> Great feedback!  Thanks so much.
> > > >>
> > > >> Would you please let me know how you're running PMD?  I've tried
> `mvn
> > > >> pmd:pmd`.  I'm not seeing issues locally and would like to make sure
> > the
> > > >> build is bulletproof.
> > > >>
> > > >>
> > > >> On Sun, Jul 16, 2017 at 6:08 PM, Gary Gregory <
> garydgreg...@gmail.com
> > >
> > > >> wrote:
> > > >>
> > > >> > +1
> > > >> >
> > > >> > From src zip: ASC, MD5, and SHA1 OK.
> > > >> >
> > > >> > RAT and CLIRR check OK.
> > > >> >
> > > >> > Reports look OK.
> > > >> >
> > > >> > Issues to address but not blockers:
> > > >> > - PMD blows up during the build and there is no resulting PMD
> > report.
> > > >> > - The POM uses an old version of commons-parent.
> > > >> >
> > > >> > Gary
> > > >> >
> > > >> >
> > > >> > On Sun, Jul 16, 2017 at 3:41 PM, Carl Hall 
> > > wrote:
> > > >> >
> > > >> > > Hi,
> > > >> > >
> > > >> > > It's been almost 3 years to the day since we've had a DbUtils
> > > release.
> > > >> > > We've fixed several important bugs and added some new features,
> > so I
> > > >> > would
> > > >> > > like to release DbUtils 1.7.
> > > >> > >
> > > >> > > Furthermore, we have fixed these issues for RC2, which were
> > > discovered
> > > >> in
> > > >> > > RC1:
> > > >> > > - resource leaks as found by FindBugs
> > > >> > > - updated links & text in generated texts and site
> > > >> > >
> > > >> > > DbUtils 1.7 RC2 is available for review here:
> > > >> > >https://dist.apache.org/repos/dist/dev/commons/dbutils/
> > > >> > DBUTILS_1_7_RC2/
> > > >> > > (svn
> > > >> > > revision 20455)
> > > >> > >
> > > >> > > The tag is here:
> > > >> > >*https://git-wip-us.apache.org/repos/asf?p=commons-
> > > >> > dbutils.git;a=tag;h=
> > > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a
> > > >> > >  > > >> dbutils.git;a=tag;h=
> > > >> > > c7b9d1229aeacd1884c9ca126c5d65af0221404a>*
> > > >> > >
> > > >> > > Maven artifacts are here:
> > > >> > >https://repository.apache.org/content/repositories/
> > > >> > > orgapachecommons-1254
> > > >> > >
> > > >> > > These are the Maven Artifacts and their hashes:
> > > >> > >
> > > >> > > commons-dbutils-1.7-javadoc.jar
> > > >> > > (SHA: 23ba15ea4ff18419fb17715e8956846b863c2d9d)
> > > >> > > commons-dbutils-1.7-javadoc.jar.asc
> > > >> > > (SHA: fb5f36b61e056c31ea3181c0a67c9bf395cd56e0)
> > > >> > > commons-dbutils-1.7-javadoc.jar.md5
> > > >> > > (SHA: daae48f032e6f96a63c8b47241de7fae7c53e176)
> > > >> > > commons-dbutils-1.7-javadoc.jar.sha1
> > > >> > > (SHA: 092fbb145d61a4d93dd645a529e212fe01099d14)
> > > >> > > commons-dbutils-1.7-sources.jar
> > > >> > > (SHA: 38e00df900c6c0dd01dec42ad411ff44de10ac0b)
> > > >> > > commons-dbutils-1.7-sources.jar.asc
> > > >> > > (SHA: 601b900b1a6079c09a81da903f0bd418dc552f09)
> > > >> > > commons-dbutils-1.7-sources.jar.md5
> > > >> > > (SHA: 1fce7ad72fc18d639705a1573c34cc012e076a25)
> 

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854991
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String pattern, 
final Map fmtRe
 /**
  * Create an ExtendedMessageFormat for the specified pattern and 
locale and check the
  * formated output matches the expected result for the parameters.
- * @param pattern string
+ *
+ * @param patternstring
  * @param registryUnused map (currently unused)
- * @param args Object[]
- * @param locale Locale
+ * @param args   Object[]
+ * @param locale Locale
--- End diff --

Ditto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854299
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -55,11 +55,11 @@ public void testExtendedFormats() {
 final String pattern = "Lower: {0,lower} Upper: {1,upper}";
 final ExtendedMessageFormat emf = new 
ExtendedMessageFormat(pattern, registry);
 assertEquals("TOPATTERN", pattern, emf.toPattern());
-assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] 
{"foo", "bar"}));
-assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] 
{"Foo", "Bar"}));
-assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] 
{"FOO", "BAR"}));
-assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] 
{"FOO", "bar"}));
-assertEquals("Lower: foo Upper: BAR", emf.format(new Object[] 
{"foo", "BAR"}));
+assertEquals("Lower: foo Upper: BAR", emf.format(new 
Object[]{"foo", "bar"}));
+assertEquals("Lower: foo Upper: BAR", emf.format(new 
Object[]{"Foo", "Bar"}));
+assertEquals("Lower: foo Upper: BAR", emf.format(new 
Object[]{"FOO", "BAR"}));
+assertEquals("Lower: foo Upper: BAR", emf.format(new 
Object[]{"FOO", "bar"}));
+assertEquals("Lower: foo Upper: BAR", emf.format(new 
Object[]{"foo", "BAR"}));
--- End diff --

Unless whitespace changes like this one are required by Checkstyle, please 
consider reverting them to prevent polluting the Git history.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854120
  
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java 
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars, 
final Character[] encodingCha
 Assert.assertEquals("Encoded '" + s + "' into '" + encoded + 
"', but decoded into '" + decoded + "'", s, decoded);
 }
 }
+
+@Test
+public void testCreateConverterFromCharsWithNullAndNull() {
+
+Character[] characterArray = new Character[2];
+characterArray[0] = Character.valueOf('$');
+characterArray[1] = characterArray[0];
+
+try {
+AlphabetConverter.createConverterFromChars(characterArray, 
null, null);
+fail("Expecting exception: IllegalArgumentException");
+} catch (IllegalArgumentException e) {
+assertEquals(AlphabetConverter.class.getName(), 
e.getStackTrace()[0].getClassName());
+}
+
--- End diff --

Blank lines at the end of methods, like this one, seem inconsistent with 
the rest of the code base.

Please consider removing them from _all_ methods which you've created and 
touched.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127855372
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -426,10 +517,13 @@ public void testSetFormatsByArgumentIndex() {
 
 @Override
 public StringBuffer format(final Object obj, final StringBuffer 
toAppendTo, final FieldPosition pos) {
-return toAppendTo.append(((String)obj).toLowerCase());
+return toAppendTo.append(((String) obj).toLowerCase());
--- End diff --

Whitespace changes like this are _good_ IMO, as they improve code clarity. 
Well done! 👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127856024
  
--- Diff: 
src/test/java/org/apache/commons/text/similarity/LevenshteinResultsTest.java ---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.text.similarity;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Unit tests for class {@link LevenshteinResults}.
+ *
+ * @date 2017-07-17
+ * @see LevenshteinResults
+ **/
--- End diff --

I struggle to see how this Javadoc is useful. Please consider removing it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127855540
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -476,8 +578,8 @@ public Format getFormat(final String name, final String 
arguments, final Locale
 public Format getFormat(final String name, final String arguments, 
final Locale locale) {
 return !"short".equals(arguments) ? null
 : locale == null ? DateFormat
-.getDateInstance(DateFormat.DEFAULT) : 
DateFormat
-.getDateInstance(DateFormat.DEFAULT, locale);
+.getDateInstance(DateFormat.DEFAULT) : DateFormat
+.getDateInstance(DateFormat.DEFAULT, locale);
--- End diff --

I think these lines were reasonably indented before. Unless Checkstyle 
complains, please consider reverting these lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127855137
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -373,14 +376,15 @@ private void checkBuiltInFormat(final String pattern, 
final Map regis
 } else {
 emf = new ExtendedMessageFormat(pattern, locale);
 }
-assertEquals("format "+ buffer.toString(), mf.format(args), 
emf.format(args));
+assertEquals("format " + buffer.toString(), mf.format(args), 
emf.format(args));
 assertEquals("toPattern " + buffer.toString(), mf.toPattern(), 
emf.toPattern());
 }
 
 /**
  * Replace MessageFormat(String, Locale) constructor (not available 
until JDK 1.4).
+ *
  * @param pattern string
- * @param locale Locale
+ * @param locale  Locale
--- End diff --

Ditto.

Please consider reverting whitespace changes for _all_ `@param` lines where 
you only inserted whitespaces between the parameter name and its description.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854930
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String pattern, 
final Object[] args, final
 
 /**
  * Test a built in format for the specified Locales, plus 
null Locale.
- * @param pattern MessageFormat pattern
+ *
+ * @param pattern MessageFormat pattern
--- End diff --

I think this line was fine before, please consider reverting it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854888
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -338,10 +339,11 @@ private void checkBuiltInFormat(final String pattern, 
final Object[] args, final
 
 /**
  * Test a built in format for the specified Locales, plus 
null Locale.
- * @param pattern MessageFormat pattern
+ *
+ * @param pattern MessageFormat pattern
  * @param fmtRegistry FormatFactory registry to use
- * @param args MessageFormat arguments
- * @param locales to test
+ * @param argsMessageFormat arguments
+ * @param locales to test
--- End diff --

I think the lines were fine before, please consider reverting them.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127855769
  
--- Diff: src/test/java/org/apache/commons/text/StrSubstitutorTest.java ---
@@ -17,21 +17,16 @@
 
 package org.apache.commons.text;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertFalse;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertSame;
-import static org.junit.Assert.assertTrue;
-import static org.junit.Assert.fail;
+import org.apache.commons.lang3.mutable.MutableObject;
+import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
 
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
 
-import org.apache.commons.lang3.mutable.MutableObject;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
+import static org.junit.Assert.*;
--- End diff --

I think the use of non-wildcard `Assert.assert*` imports was fine before. 
Please consider expanding these imports back into proper ones.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854963
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -353,10 +355,11 @@ private void checkBuiltInFormat(final String pattern, 
final Map fmtRe
 /**
  * Create an ExtendedMessageFormat for the specified pattern and 
locale and check the
  * formated output matches the expected result for the parameters.
- * @param pattern string
+ *
+ * @param patternstring
--- End diff --

Ditto.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

[coveralls]

Github user coveralls commented on the issue:

https://github.com/apache/commons-text/pull/56
  

[![Coverage 
Status](https://coveralls.io/builds/12432497/badge)](https://coveralls.io/builds/12432497)

Coverage increased (+1.04%) to 98.34% when pulling 
**91039cb23f79921238afebbb4bff3ccbbd049e6a on TheRealHaui:add-some-Unit-Tests** 
into **aaf4aba369ed0b97d17bc9343f763b0d099dbc2f on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854015
  
--- Diff: src/test/java/org/apache/commons/text/AlphabetConverterTest.java 
---
@@ -201,4 +207,97 @@ private void test(final Character[] originalChars, 
final Character[] encodingCha
 Assert.assertEquals("Encoded '" + s + "' into '" + encoded + 
"', but decoded into '" + decoded + "'", s, decoded);
 }
 }
+
+@Test
+public void testCreateConverterFromCharsWithNullAndNull() {
+
--- End diff --

Blank lines at the start of methods, like this one, seem inconsistent with 
the rest of the code base.

Please consider removing them from _all_ methods which you've created and 
touched.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127854827
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -295,41 +295,42 @@ public void testEqualsHashcode() {
 ExtendedMessageFormat other = null;
 
 // Same object
-assertTrue("same, equals()",   emf.equals(emf));
+assertTrue("same, equals()", emf.equals(emf));
 assertTrue("same, hashcode()", emf.hashCode() == emf.hashCode());
 
 assertFalse("null, equals", emf.equals(null));
 
 // Equal Object
 other = new ExtendedMessageFormat(pattern, Locale.US, fmtRegistry);
-assertTrue("equal, equals()",   emf.equals(other));
+assertTrue("equal, equals()", emf.equals(other));
 assertTrue("equal, hashcode()", emf.hashCode() == 
other.hashCode());
 
 // Different Class
 other = new OtherExtendedMessageFormat(pattern, Locale.US, 
fmtRegistry);
-assertFalse("class, equals()",  emf.equals(other));
+assertFalse("class, equals()", emf.equals(other));
 assertTrue("class, hashcode()", emf.hashCode() == 
other.hashCode()); // same hashcode
 
 // Different pattern
 other = new ExtendedMessageFormat("X" + pattern, Locale.US, 
fmtRegistry);
-assertFalse("pattern, equals()",   emf.equals(other));
+assertFalse("pattern, equals()", emf.equals(other));
 assertFalse("pattern, hashcode()", emf.hashCode() == 
other.hashCode());
 
 // Different registry
 other = new ExtendedMessageFormat(pattern, Locale.US, 
otherRegitry);
-assertFalse("registry, equals()",   emf.equals(other));
+assertFalse("registry, equals()", emf.equals(other));
 assertFalse("registry, hashcode()", emf.hashCode() == 
other.hashCode());
 
 // Different Locale
 other = new ExtendedMessageFormat(pattern, Locale.FRANCE, 
fmtRegistry);
-assertFalse("locale, equals()",  emf.equals(other));
+assertFalse("locale, equals()", emf.equals(other));
 assertTrue("locale, hashcode()", emf.hashCode() == 
other.hashCode()); // same hashcode
 }
 
 /**
  * Test a built in format for the specified Locales, plus 
null Locale.
+ *
  * @param pattern MessageFormat pattern
- * @param args MessageFormat arguments
+ * @param argsMessageFormat arguments
--- End diff --

I think this line was fine before. Please consider reverting it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on a diff in the pull request:

https://github.com/apache/commons-text/pull/56#discussion_r127855604
  
--- Diff: 
src/test/java/org/apache/commons/text/ExtendedMessageFormatTest.java ---
@@ -488,10 +590,10 @@ public Format getFormat(final String name, final 
String arguments, final Locale
 private static final long serialVersionUID = 1L;
 
 public OtherExtendedMessageFormat(final String pattern, final 
Locale locale,
-final Map registry) {
+  final Map registry) {
--- End diff --

I think these lines were reasonably indented before. Unless Checkstyle 
complains, please consider reverting these lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text issue #56: add-some-Unit Tests

[jbduncan]

Github user jbduncan commented on the issue:

https://github.com/apache/commons-text/pull/56
  
Oh sorry @TheRealHaui, I just reread my main comment in my review from a 
few minutes ago, and I realise that I may have sounded confrontational. I had 
not meant to come across as such, so I wish to apologise if it sounded that 
way. 🙇 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-text pull request #56: add-some-Unit Tests

[TheRealHaui]

GitHub user TheRealHaui opened a pull request:

https://github.com/apache/commons-text/pull/56

add-some-Unit Tests

I have created new Unit Tests which cover previously untested lines of code 
which I want to contribute.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TheRealHaui/commons-text add-some-Unit-Tests

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/commons-text/pull/56.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #56


commit acad335ca6c2c08644063ab0dc0be1e8233d430e
Author: Michael Hausegger 
Date:   2017-07-17T23:26:06Z

add-some-Unit Tests Created Unit Tests to increase code coverage.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-imaging pull request #27: Increase code coverage one

[TheRealHaui]

Github user TheRealHaui commented on a diff in the pull request:

https://github.com/apache/commons-imaging/pull/27#discussion_r127843760
  
--- Diff: 
src/test/java/org/apache/commons/imaging/formats/tiff/fieldtypes/FieldTypeByteTest.java
 ---
@@ -0,0 +1,37 @@
+package org.apache.commons.imaging.formats.tiff.fieldtypes;
+
+import org.junit.Test;
+
+import java.nio.ByteOrder;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.fail;
+
+/**
+ * Unit tests for class {@link FieldTypeByte}.
+ *
+ * @date 13.07.2017
+ * @see FieldTypeByte
+ *
+ **/
+public class FieldTypeByteTest{
+
+
+  @Test
+  public void testWriteDataWithNull() {
+
+  FieldTypeByte fieldTypeByte = FieldType.UNDEFINED;
+  ByteOrder byteOrder = ByteOrder.BIG_ENDIAN;
+
+  try { 
+fieldTypeByte.writeData( null, byteOrder);
+fail("Expecting exception: Exception");
+  } catch(Exception e) {
+ assertEquals("Invalid data: null (null)",e.getMessage());
+ assertEquals(FieldTypeByte.class.getName(), 
e.getStackTrace()[0].getClassName());
--- End diff --

No, you're not right!
Obviously, became already dizzy ...

The difference is that the approach with the stack trace - of course - 
verifies which class the exception originated from.
The verification which exception was thrown and before more over if an 
exception was thrown gets already verified in the catch clause.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h...@commons.apache.org

Re: [lang] - Remove RandomStringUtils deprecation / move it to [text]?

[Amey Jadiye]

Thanks, I will raise PR soon, and for this we don't have to wait for 2.x ,
that's good part.

Regards,
Amey

On Sun, Jul 16, 2017, 3:41 PM Pascal Schumacher 
wrote:

> Hello Amey,
>
> that seems to be the cleanest solution (although the one requiring the
> most work).
>
> Cheers,
> Pascal
>
> Am 14.07.2017 um 18:59 schrieb Amey Jadiye:
> > Hello Pascal,
> >
> > Thanks for putting this on table, I too think that users need some short
> > code to show up output really quick.
> >
> > How about this plan :-
> >
> > 1. Keep RandomStringUtils deprecated in commons-lang.
> > 2. Move RandomStringUtils class to commons-text.
> > 3. Remove all existing code from methods of RandomStringUtils and call
> our
> > brand new RandomStringGenerator in them. to return respective values i.e.
> > randomNumeric, randomAlphabetic, randomAlphanumeric etc
> >
> > Its obvious question "what we will achieve with this ?"
> >
> > So, we are still promoting the RandomStringGenerator this should be the
> > base of all random string generator methods.
> > since RandomStringGenerator very flexible we can keep the functionalities
> > from RandomStringUtils untouched and can retain users who are still
> > addicted to same class and API of RandomStringUtils, else users will not
> > accept new and bit cumbersome (with their perspective)
> > RandomStringGenerator and stick to old code.
> >
> > The user who want bit more flexibility are still welcome to use
> > RandomStringGenerator anyway.
> >
> > Regards,
> > Amey
> >
> >
> > On Fri, Jul 14, 2017 at 1:32 AM, Pascal Schumacher <
> pascalschumac...@gmx.net>
> > wrote:
> >> Hello everybody,
> >>
> >> with 3.5 we deprecated RandomStringUtils in favor of
> > RandomStringGenerator in commons-text.
> >> https://issues.apache.org/jira/browse/TEXT-96 complains that
> > "RandomStringGenerator is extremely verbose compared to the deprecated
> > commons.lang3 RandomStringUtils."
> >>  From my experience taking a look at migrating a project from
> > RandomStringUtils to RandomStringGenerator I have to agree. Some
> > convenience methods will be added with the next commons text release, but
> > it still won't be as easy to use as RandomStringUtils. For course
> > RandomStringGenerator gives the user more options, but most usage of
> > RandomStringUtils I have seen was just for tests or other simple
> use-cases
> > where these option are not required.
> >> Maybe we should just remove the RandomStringUtils deprecation or add the
> > whole class untouched to commons-text?
> >> What do you think?
> >>
> >> Cheers,
> >>
> >> Pascal
> >>
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> > For additional commands, e-mail: dev-h...@commons.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
> For additional commands, e-mail: dev-h...@commons.apache.org
>
>