[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1637624924 @sagarmiglani Thanks for the clarification, makes sense to me. But as I am not a committer you would need @cziegeler's approval and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1633837561 I think this comment referred only to the topmost add icon (not bound to an item, compare with the screenshot). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623038983 I think the best UX would be - one delete button per item - one add button per list - possibility to reorder (maybe leveraging https://jqueryui.com/draggable/#sortable) The "+" per item is very uncommon and is IMHO not needed if there is a possibility to reorder. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [felix-dev] kwin commented on pull request #212: FELIX-6614 WebConsole configMgr saves an empty value in list properites
kwin commented on PR #212: URL: https://github.com/apache/felix-dev/pull/212#issuecomment-1623035491 @cziegeler Can you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@felix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
