[jira] [Commented] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
[
https://issues.apache.org/jira/browse/HAMA-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015345#comment-15015345
]
Edward J. Yoon commented on HAMA-980:
-
+1
> Modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class"
> --
>
> Key: HAMA-980
> URL: https://issues.apache.org/jira/browse/HAMA-980
> Project: Hama
> Issue Type: Bug
> Components: test
>Affects Versions: 0.7.0
>Reporter: Minho Kim
>Assignee: Minho Kim
>Priority: Blocker
> Fix For: 0.7.1
>
>
> Configuration value, "hama.sync.client.class", is never used. Because
> configuration value to run test code is not "hama.sync.client.classe" but
> "hama.sync.peer.class".
> In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to
> initialize syncClient. But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's
> no use setting "hama.sync.client.class".
> {code:title=SyncServiceFactory.java}
> public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
> public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
> public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";
> /**
>* Returns a sync client via reflection based on what was configured.
>*/
> public static PeerSyncClient getPeerSyncClient(Configuration conf)
> throws ClassNotFoundException {
> return (PeerSyncClient) ReflectionUtils.newInstance(conf
> .getClassByName(conf.get(SYNC_PEER_CLASS,
> ZooKeeperSyncClientImpl.class.getName())), conf);
> }
> {code}
> We need to modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class" in test codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
[
https://issues.apache.org/jira/browse/HAMA-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015173#comment-15015173
]
Minho Kim edited comment on HAMA-980 at 11/20/15 4:01 AM:
--
Hi, [~udanax]
I see what you say.
I think constant value modify from SYNC_PEER_CLASS to SYNC_CLIENT_CLASS like
below:
{code}
public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
- public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
+ public static final String SYNC_CLIENT_CLASS = "hama.sync.client.class";
{code}
What do you think of this?
was (Author: conquestor):
Hi, [~udanax]
I see you say what it is.
I think constant value modify from SYNC_PEER_CLASS to SYNC_CLIENT_CLASS like
below:
{code}
public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
- public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
+ public static final String SYNC_CLIENT_CLASS = "hama.sync.client.class";
{code}
What do you think of this?
> Modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class"
> --
>
> Key: HAMA-980
> URL: https://issues.apache.org/jira/browse/HAMA-980
> Project: Hama
> Issue Type: Bug
> Components: test
>Affects Versions: 0.7.0
>Reporter: Minho Kim
>Assignee: Minho Kim
>Priority: Blocker
> Fix For: 0.7.1
>
>
> Configuration value, "hama.sync.client.class", is never used. Because
> configuration value to run test code is not "hama.sync.client.classe" but
> "hama.sync.peer.class".
> In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to
> initialize syncClient. But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's
> no use setting "hama.sync.client.class".
> {code:title=SyncServiceFactory.java}
> public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
> public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
> public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";
> /**
>* Returns a sync client via reflection based on what was configured.
>*/
> public static PeerSyncClient getPeerSyncClient(Configuration conf)
> throws ClassNotFoundException {
> return (PeerSyncClient) ReflectionUtils.newInstance(conf
> .getClassByName(conf.get(SYNC_PEER_CLASS,
> ZooKeeperSyncClientImpl.class.getName())), conf);
> }
> {code}
> We need to modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class" in test codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
[
https://issues.apache.org/jira/browse/HAMA-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015173#comment-15015173
]
Minho Kim commented on HAMA-980:
Hi, [~udanax]
I see you say what it is.
I think constant value modify from SYNC_PEER_CLASS to SYNC_CLIENT_CLASS like
below:
{code}
public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
- public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
+ public static final String SYNC_CLIENT_CLASS = "hama.sync.client.class";
{code}
What do you think of this?
> Modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class"
> --
>
> Key: HAMA-980
> URL: https://issues.apache.org/jira/browse/HAMA-980
> Project: Hama
> Issue Type: Bug
> Components: test
>Affects Versions: 0.7.0
>Reporter: Minho Kim
>Assignee: Minho Kim
>Priority: Blocker
> Fix For: 0.7.1
>
>
> Configuration value, "hama.sync.client.class", is never used. Because
> configuration value to run test code is not "hama.sync.client.classe" but
> "hama.sync.peer.class".
> In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to
> initialize syncClient. But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's
> no use setting "hama.sync.client.class".
> {code:title=SyncServiceFactory.java}
> public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
> public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
> public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";
> /**
>* Returns a sync client via reflection based on what was configured.
>*/
> public static PeerSyncClient getPeerSyncClient(Configuration conf)
> throws ClassNotFoundException {
> return (PeerSyncClient) ReflectionUtils.newInstance(conf
> .getClassByName(conf.get(SYNC_PEER_CLASS,
> ZooKeeperSyncClientImpl.class.getName())), conf);
> }
> {code}
> We need to modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class" in test codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
[
https://issues.apache.org/jira/browse/HAMA-980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Edward J. Yoon updated HAMA-980:
Priority: Blocker (was: Minor)
> Modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class"
> --
>
> Key: HAMA-980
> URL: https://issues.apache.org/jira/browse/HAMA-980
> Project: Hama
> Issue Type: Bug
> Components: test
>Affects Versions: 0.7.0
>Reporter: Minho Kim
>Assignee: Minho Kim
>Priority: Blocker
> Fix For: 0.7.1
>
>
> Configuration value, "hama.sync.client.class", is never used. Because
> configuration value to run test code is not "hama.sync.client.classe" but
> "hama.sync.peer.class".
> In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to
> initialize syncClient. But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's
> no use setting "hama.sync.client.class".
> {code:title=SyncServiceFactory.java}
> public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
> public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
> public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";
> /**
>* Returns a sync client via reflection based on what was configured.
>*/
> public static PeerSyncClient getPeerSyncClient(Configuration conf)
> throws ClassNotFoundException {
> return (PeerSyncClient) ReflectionUtils.newInstance(conf
> .getClassByName(conf.get(SYNC_PEER_CLASS,
> ZooKeeperSyncClientImpl.class.getName())), conf);
> }
> {code}
> We need to modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class" in test codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [ANNOUNCE] Hama New PMC Chair - Edward J. Yoon
Thanks guys :-) Let's improve our community more! On Fri, Nov 20, 2015 at 9:29 AM, Anastasis Andronidis wrote: > Congratulations! > > Cheers, > Anastasios > >> On 20 Nov, 2015, at 00:14, Minho Kim wrote: >> >> Congratulation. Edward! :-) >> >> 2015-11-19 20:33 GMT+09:00 Chia-Hung Lin : >> >>> On behalf of the Apache Hama PMC, I'm pleased to announce that Apache >>> Board has approved the nomination of Edward J. Yoon as Hama's new PMC >>> Chair! >>> >>> Congratulation! >>> > -- Best Regards, Edward J. Yoon
[jira] [Commented] (HAMA-980) Modify configuration value from "hama.sync.client.class" to "hama.sync.peer.class"
[
https://issues.apache.org/jira/browse/HAMA-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015132#comment-15015132
]
Edward J. Yoon commented on HAMA-980:
-
Hi,
really nice catch! BTW, why don't we change the SyncServiceFactory like below:
{code}
public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
- public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
+ public static final String SYNC_PEER_CLASS = "hama.sync.client.class";
{code}
Server and Client are always pair.
> Modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class"
> --
>
> Key: HAMA-980
> URL: https://issues.apache.org/jira/browse/HAMA-980
> Project: Hama
> Issue Type: Bug
> Components: test
>Affects Versions: 0.7.0
>Reporter: Minho Kim
>Assignee: Minho Kim
>Priority: Minor
> Fix For: 0.7.1
>
>
> Configuration value, "hama.sync.client.class", is never used. Because
> configuration value to run test code is not "hama.sync.client.classe" but
> "hama.sync.peer.class".
> In BSPPeerImpl.java, configuration value refer to SYNC_PEER_CLASS so as to
> initialize syncClient. But SYNC_PEER_CLASS is "hama.sync.peer.class" so it's
> no use setting "hama.sync.client.class".
> {code:title=SyncServiceFactory.java}
> public static final String SYNC_SERVER_CLASS = "hama.sync.server.class";
> public static final String SYNC_PEER_CLASS = "hama.sync.peer.class";
> public static final String SYNC_MASTER_CLASS = "hama.sync.master.class";
> /**
>* Returns a sync client via reflection based on what was configured.
>*/
> public static PeerSyncClient getPeerSyncClient(Configuration conf)
> throws ClassNotFoundException {
> return (PeerSyncClient) ReflectionUtils.newInstance(conf
> .getClassByName(conf.get(SYNC_PEER_CLASS,
> ZooKeeperSyncClientImpl.class.getName())), conf);
> }
> {code}
> We need to modify configuration value from "hama.sync.client.class" to
> "hama.sync.peer.class" in test codes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] hama pull request: Modify Hama configuration value for synchronous...
GitHub user eoriented opened a pull request: https://github.com/apache/hama/pull/5 Modify Hama configuration value for synchronous client class Fixed Hama configuration value for synchronous From "hama.sync.client.class" to "hama.sync.peer.class". You can merge this pull request into a Git repository by running: $ git pull https://github.com/eoriented/hama HAMA-980 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hama/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 commit 18af5e33bdb70d16d48cf890369dc52351ca46d2 Author: Minho Kim Date: 2015-11-20T01:32:44Z Modify Hama configuration value for synchronous client class from "hama.sync.client.class" to "hama.sync.peer.class" --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [ANNOUNCE] Hama New PMC Chair - Edward J. Yoon
Congratulations! Cheers, Anastasios > On 20 Nov, 2015, at 00:14, Minho Kim wrote: > > Congratulation. Edward! :-) > > 2015-11-19 20:33 GMT+09:00 Chia-Hung Lin : > >> On behalf of the Apache Hama PMC, I'm pleased to announce that Apache >> Board has approved the nomination of Edward J. Yoon as Hama's new PMC >> Chair! >> >> Congratulation! >>
Re: [ANNOUNCE] Hama New PMC Chair - Edward J. Yoon
Congratulation. Edward! :-) 2015-11-19 20:33 GMT+09:00 Chia-Hung Lin : > On behalf of the Apache Hama PMC, I'm pleased to announce that Apache > Board has approved the nomination of Edward J. Yoon as Hama's new PMC > Chair! > > Congratulation! >
[ANNOUNCE] Hama New PMC Chair - Edward J. Yoon
On behalf of the Apache Hama PMC, I'm pleased to announce that Apache Board has approved the nomination of Edward J. Yoon as Hama's new PMC Chair! Congratulation!
[jira] [Commented] (HAMA-961) Remove ANN package
[ https://issues.apache.org/jira/browse/HAMA-961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013224#comment-15013224 ] Edward J. Yoon commented on HAMA-961: - As we decided, this efforts moved to Apache Horn podling. > Remove ANN package > -- > > Key: HAMA-961 > URL: https://issues.apache.org/jira/browse/HAMA-961 > Project: Hama > Issue Type: Improvement > Components: machine learning >Affects Versions: 0.7.0 >Reporter: Edward J. Yoon >Assignee: Edward J. Yoon > Fix For: 0.8.0 > > > I've recently started to review the MLP source codes closely, and I'm > thinking about some improvement and API refactoring e.g., APIs for > user-defined neuron and synapse models, data structure, ..., etc. > This issue is one of them, and related to train large models. I'm considering > distributed parameter server (http://parameterserver.org) for managing > parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HAMA-961) Remove ANN package
[ https://issues.apache.org/jira/browse/HAMA-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edward J. Yoon updated HAMA-961: Summary: Remove ANN package (was: Parameter Server for large scale MLP) > Remove ANN package > -- > > Key: HAMA-961 > URL: https://issues.apache.org/jira/browse/HAMA-961 > Project: Hama > Issue Type: Improvement > Components: machine learning >Affects Versions: 0.7.0 >Reporter: Edward J. Yoon >Assignee: Edward J. Yoon > Fix For: 0.8.0 > > > I've recently started to review the MLP source codes closely, and I'm > thinking about some improvement and API refactoring e.g., APIs for > user-defined neuron and synapse models, data structure, ..., etc. > This issue is one of them, and related to train large models. I'm considering > distributed parameter server (http://parameterserver.org) for managing > parameters. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
