Re: [jira] [Created] (HAMA-1002) Add junit dependency to commons to compile with Hadoop 2.8+

2017-12-28 Thread Chia-Hung Lin 
I'll look into this, but it may be slow. So feel free to pick this up if
the progress appears to be stalled.

On Thursday, 28 December 2017, Edward J. Yoon  wrote:
> Can someone review and commit this patch? :)
>
> 2017. 12. 26. 오후 5:04에 "ASF GitHub Bot (JIRA)" 님이 작성:
>
>>
>> [ https://issues.apache.org/jira/browse/HAMA-1002?page=
>> com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel=16303626#comment-16303626 ]
>>
>> ASF GitHub Bot commented on HAMA-1002:
>> --
>>
>> GitHub user youngwookim opened a pull request:
>>
>> https://github.com/apache/hama/pull/17
>>
>> HAMA-1002: Add junit dependency to commons to compile with Hadoop
2.8+
>>
>>
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/youngwookim/hama HAMA-1002
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/hama/pull/17.patch
>>
>> To close this pull request, make a commit to your master/trunk branch
>> with (at least) the following in the commit message:
>>
>> This closes #17
>>
>> 
>> commit fe57a39cc5a576d11d9137fbae156a79d4d7a8a1
>> Author: Youngwoo Kim 
>> Date:   2017-12-26T06:07:12Z
>>
>> HAMA-1002: Add junit dependency to commons to compile with Hadoop
2.8+
>>
>> 
>>
>>
>> > Add junit dependency to commons to compile with Hadoop 2.8+
>> > ---
>> >
>> > Key: HAMA-1002
>> > URL: https://issues.apache.org/jira/browse/HAMA-1002
>> > Project: Hama
>> >  Issue Type: Bug
>> >  Components: build
>> >Affects Versions: 0.7.1
>> >Reporter: YoungWoo Kim
>> > Fix For: 0.7.2
>> >
>> > Attachments: HAMA-1002.0.patch
>> >
>> >
>> > Compilation with Hadoop 2.8+ does not work because transitive
>> dependencies for Hadoop have been changed:
>> > {noformat}
>> > $ mvn clean package -Phadoop2 -Dhadoop.version=2.8.1 -DskipTests
>> > (snip)
>> > [INFO] Apache Hama parent POM . SUCCESS [
>> 23.797 s]
>> > [INFO] pipes .. SUCCESS [
>> 22.680 s]
>> > [INFO] commons  FAILURE [
>> 6.662 s]
>> > [INFO] core ... SKIPPED
>> > [INFO] graph .. SKIPPED
>> > [INFO] machine learning ... SKIPPED
>> > [INFO] examples ... SKIPPED
>> > [INFO] mesos .. SKIPPED
>> > [INFO] yarn ... SKIPPED
>> > [INFO] hama-dist .. SKIPPED
>> > [INFO] 
>> 
>> > [INFO] BUILD FAILURE
>> > [INFO] 
>> 
>> > [INFO] Total time: 53.544 s
>> > [INFO] Finished at: 2017-12-26T14:55:24+09:00
>> > [INFO] Final Memory: 62M/568M
>> > [INFO] 
>> 
>> > [ERROR] Failed to execute goal org.apache.maven.plugins:
>> maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project
>> hama-commons: Compilation failure: Compilation failure:
>> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
>> apache/hama/commons/math/TestDenseDoubleVector.java:[20,23] error:
>> package org.junit does not exist
>> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
>> apache/hama/commons/math/TestDenseDoubleVector.java:[20,0] error: static
>> import only from classes and interfaces
>> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
>> apache/hama/commons/math/TestDenseDoubleVector.java:[21,23] error:
>> package org.junit does not exist
>> > (snip)
>> > {noformat}
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.4.14#64029)
>>
>

Re: [jira] [Commented] (HAMA-1002) Add junit dependency to commons to compile with Hadoop 2.8+

2017-12-28 Thread Edward J. Yoon 
Can someone review and commit this patch? :)

2017. 12. 26. 오후 5:04에 "ASF GitHub Bot (JIRA)" 님이 작성:

>
> [ https://issues.apache.org/jira/browse/HAMA-1002?page=
> com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=16303626#comment-16303626 ]
>
> ASF GitHub Bot commented on HAMA-1002:
> --
>
> GitHub user youngwookim opened a pull request:
>
> https://github.com/apache/hama/pull/17
>
> HAMA-1002: Add junit dependency to commons to compile with Hadoop 2.8+
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/youngwookim/hama HAMA-1002
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/hama/pull/17.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #17
>
> 
> commit fe57a39cc5a576d11d9137fbae156a79d4d7a8a1
> Author: Youngwoo Kim 
> Date:   2017-12-26T06:07:12Z
>
> HAMA-1002: Add junit dependency to commons to compile with Hadoop 2.8+
>
> 
>
>
> > Add junit dependency to commons to compile with Hadoop 2.8+
> > ---
> >
> > Key: HAMA-1002
> > URL: https://issues.apache.org/jira/browse/HAMA-1002
> > Project: Hama
> >  Issue Type: Bug
> >  Components: build
> >Affects Versions: 0.7.1
> >Reporter: YoungWoo Kim
> > Fix For: 0.7.2
> >
> > Attachments: HAMA-1002.0.patch
> >
> >
> > Compilation with Hadoop 2.8+ does not work because transitive
> dependencies for Hadoop have been changed:
> > {noformat}
> > $ mvn clean package -Phadoop2 -Dhadoop.version=2.8.1 -DskipTests
> > (snip)
> > [INFO] Apache Hama parent POM . SUCCESS [
> 23.797 s]
> > [INFO] pipes .. SUCCESS [
> 22.680 s]
> > [INFO] commons  FAILURE [
> 6.662 s]
> > [INFO] core ... SKIPPED
> > [INFO] graph .. SKIPPED
> > [INFO] machine learning ... SKIPPED
> > [INFO] examples ... SKIPPED
> > [INFO] mesos .. SKIPPED
> > [INFO] yarn ... SKIPPED
> > [INFO] hama-dist .. SKIPPED
> > [INFO] 
> 
> > [INFO] BUILD FAILURE
> > [INFO] 
> 
> > [INFO] Total time: 53.544 s
> > [INFO] Finished at: 2017-12-26T14:55:24+09:00
> > [INFO] Final Memory: 62M/568M
> > [INFO] 
> 
> > [ERROR] Failed to execute goal org.apache.maven.plugins:
> maven-compiler-plugin:2.3.2:testCompile (default-testCompile) on project
> hama-commons: Compilation failure: Compilation failure:
> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
> apache/hama/commons/math/TestDenseDoubleVector.java:[20,23] error:
> package org.junit does not exist
> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
> apache/hama/commons/math/TestDenseDoubleVector.java:[20,0] error: static
> import only from classes and interfaces
> > [ERROR] /Users/ywkim/workspace/hama/commons/src/test/java/org/
> apache/hama/commons/math/TestDenseDoubleVector.java:[21,23] error:
> package org.junit does not exist
> > (snip)
> > {noformat}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.4.14#64029)
>