[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261589#comment-15261589 ] Hudson commented on HAMA-989: - SUCCESS: Integrated in Hama-Nightly-for-Hadoop-1.x #1729 (See [https://builds.apache.org/job/Hama-Nightly-for-Hadoop-1.x/1729/]) HAMA-989: Build fails on non-Linux systems (edwardyoon: rev 83f906c23c5ac1ff0e9f4c04991253cd21b612f7) * core/src/test/java/org/apache/hama/ipc/TestAsyncRPC.java * core/src/test/java/org/apache/hama/ipc/TestAsyncIPC.java * CHANGES.txt * core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261578#comment-15261578 ] Hudson commented on HAMA-989: - SUCCESS: Integrated in Hama-Nightly-for-Hadoop-2.x #726 (See [https://builds.apache.org/job/Hama-Nightly-for-Hadoop-2.x/726/]) HAMA-989: Build fails on non-Linux systems (edwardyoon: rev 83f906c23c5ac1ff0e9f4c04991253cd21b612f7) * core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java * core/src/test/java/org/apache/hama/ipc/TestAsyncRPC.java * core/src/test/java/org/apache/hama/ipc/TestAsyncIPC.java * CHANGES.txt > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261560#comment-15261560 ] Hudson commented on HAMA-989: - SUCCESS: Integrated in Hama-trunk #477 (See [https://builds.apache.org/job/Hama-trunk/477/]) HAMA-989: Build fails on non-Linux systems (edwardyoon: rev 83f906c23c5ac1ff0e9f4c04991253cd21b612f7) * core/src/test/java/org/apache/hama/ipc/TestAsyncIPC.java * core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java * core/src/test/java/org/apache/hama/ipc/TestAsyncRPC.java * CHANGES.txt > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261553#comment-15261553 ] Edward J. Yoon commented on HAMA-989: - When you write commit log, you should follow below format: HAMA-989: commitlog Then, apache infra and github will be integrated automatically by issue ID. Also, you have to merge into 1 commit before pull request. You can use rebase command for example, git rebase -i HEAD~3. Thanks. > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258112#comment-15258112 ] Behroz Sikander commented on HAMA-989: -- Yes, it could work. I will make the changes and will submit the pull request. > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[
https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257343#comment-15257343
]
Edward J. Yoon commented on HAMA-989:
-
We can catch and ignore exceptions or, SystemUtils.
{code}
diff --git
a/core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java
b/core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java
index f4f89b9..b7bc9c8 100644
---
a/core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java
+++
b/core/src/test/java/org/apache/hama/bsp/message/TestHamaAsyncMessageManager.java
@@ -23,6 +23,7 @@
import junit.framework.TestCase;
+import org.apache.commons.lang.SystemUtils;
import org.apache.hadoop.fs.FileSystem;
import org.apache.hadoop.io.IntWritable;
import org.apache.hadoop.io.NullWritable;
@@ -45,10 +46,14 @@
public static volatile int increment = 1;
public void testMemoryMessaging() throws Exception {
-HamaConfiguration conf = new HamaConfiguration();
-conf.setClass(MessageManager.RECEIVE_QUEUE_TYPE_CLASS, MemoryQueue.class,
-MessageQueue.class);
-messagingInternal(conf);
+if (SystemUtils.IS_OS_LINUX) {
+ HamaConfiguration conf = new HamaConfiguration();
+ conf.setClass(MessageManager.RECEIVE_QUEUE_TYPE_CLASS, MemoryQueue.class,
+ MessageQueue.class);
+ messagingInternal(conf);
+} else {
+ // we skip this test bc AsyncRPC is currently support only linux
+}
}
private static void messagingInternal(HamaConfiguration conf)
{code}
WDYT?
> Build fails on non-Linux systems
>
>
> Key: HAMA-989
> URL: https://issues.apache.org/jira/browse/HAMA-989
> Project: Hama
> Issue Type: Bug
> Components: bsp core, build
>Affects Versions: 0.7.1
>Reporter: Edward J. Yoon
> Fix For: 0.7.2
>
>
> http://markmail.org/message/ipgc5fjs57xdmtr2
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256262#comment-15256262 ] Behroz Sikander commented on HAMA-989: -- The alternative to Assume could be if(!isLinuxOS()) return; > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256249#comment-15256249 ] Behroz Sikander commented on HAMA-989: -- Some details about Assume not being part of Junit 3 https://issues.gradle.org/browse/GRADLE-1879 > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HAMA-989) Build fails on non-Linux systems
[ https://issues.apache.org/jira/browse/HAMA-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256238#comment-15256238 ] Behroz Sikander commented on HAMA-989: -- My idea for the solution to this bug was to add Assume.assumeTrue(isLinuxOS()); statement to all the Async testcases. The only problem is that Assume (or assumptions) were introduced in Junit 4. Even though we are using the latest Junit 4.8.1 but all of our testcases are using Junit 3 style (all testcases extend TestCase class where as in Junit 4 we just add the @Test annotation). For these 3 testcases which are causing the problem, can I move to Junit4 style (which will give me access to Assume.assumeTrue) or should I find some alternative ? > Build fails on non-Linux systems > > > Key: HAMA-989 > URL: https://issues.apache.org/jira/browse/HAMA-989 > Project: Hama > Issue Type: Bug > Components: bsp core, build >Affects Versions: 0.7.1 >Reporter: Edward J. Yoon > Fix For: 0.7.2 > > > http://markmail.org/message/ipgc5fjs57xdmtr2 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
