Re: Run httpd's testsuite

2018-09-02 Thread Jim Jagielski
FWIW, I've never run 'make check' but always run the test suite explicitly. 

> On Sep 2, 2018, at 6:49 AM, Danesh Daroui  wrote:
> 
> Hi all,
> 
> I would like to be bale to run Apache https's testsuite. I have clones
> Apache-Test and configures the project with the given path and then
> built the httpd server, but when I execute "make cheek", all tests for
> "all.t" are skipped. The logs show that the test scripts runs the
> server with some isolated configurations on a specific port but it
> apparently cannot find "mod_perl.c" for instance. This is the last
> part of the log that I get when I run the test:
> 
> waiting 60 seconds for server to start: .
> waiting 60 seconds for server to start: ok (waited 0 secs)
> server localhost:8529 started
> [   info] adding source lib
> /home/danesh/open/github/Apache-Test/../Apache-Test/lib to @INC
> t/alltest/all.t . skipped: testing all.t
> t/alltest2/all.t  skipped: testing more than one all.t
> t/bad_coding.t .. ok
> t/cookies.t . skipped: cannot find module 'CGI',
> cannot find module 'CGI::Cookie'
> t/import.t .. ok
> t/log_watch.t ... ok
> t/log_watch_for_broken_lines.t .. ok
> t/more/all.t  skipped: cannot find module 'mod_perl.c'
> t/next_available_port.t . ok
> t/ping.t  ok
> t/redirect.t  ok
> t/request.t . ok
> t/sok.t . ok
> All tests successful.
> Files=13, Tests=91,  4 wallclock secs ( 0.05 usr  0.01 sys +  2.17
> cusr  0.56 csys =  2.79 CPU)
> Result: PASS
> [warning] server localhost:8529 shutdown
> 
> There are also some unit tests under "test" directory that they are
> all passed when I run the executable. I would like to know what is the
> difference between these two tests? Also I expected the tests that are
> triggered with "make check" to be much more extensive than some small
> tests that are run quickly. Something like night-run tests! Am I
> missing something?
> 
> Regards,
> 
> Danesh Daroui



Re: Run httpd's testsuite

2018-09-02 Thread Danesh Daroui
Hi Daniel,

Thank you for your clarification. I actually configured the server
with --with-modules=reallyall and even --enable-load-all-modules and
executed the tests but the result was same. Same tests didn't ran at
all. The reason that I am a bit surprised with the small number of
tests is that, there can be lots of parameters and conditions that can
be testes. Moreover, performance of the server can also be tested
which is not here as far as I know. This is quite crucial to ensure
when you hack the server or when you intend to write a new patch for
the server to improve or fix a bug.

Regards,

Danesh

On Sun, Sep 2, 2018 at 6:08 PM Daniel Ruggeri  wrote:
>
> Hi, Danesh;
> Actually, that output looks correct for a very limited server configuration. 
> The test suite will detect the configured modules and run tests for only 
> those modules. As you noticed, for example, since mod_perl is not installed 
> in your server, those tests are skipped. If you built the server with all 
> modules (--with-modules=reallyall, if memory serves me correctly), you would 
> see many more tests run. Also, do not be alarmed if the test suite doesn't 
> take a full night to run. That is also normal :-)
> --
> Daniel Ruggeri
>
> On September 2, 2018 5:49:46 AM CDT, Danesh Daroui  
> wrote:
>>
>> Hi all,
>>
>> I would like to be bale to run Apache https's testsuite. I have clones
>> Apache-Test and configures the project with the given path and then
>> built the httpd server, but when I execute "make cheek", all tests for
>> "all.t" are skipped. The logs show that the test scripts runs the
>> server with some isolated configurations on a specific port but it
>> apparently cannot find "mod_perl.c" for instance. This is the last
>> part of the log that I get when I run the test:
>>
>> waiting 60 seconds for server to start: .
>> waiting 60 seconds for server to start: ok (waited 0 secs)
>> server localhost:8529 started
>> [   info] adding source lib
>> /home/danesh/open/github/Apache-Test/../Apache-Test/lib to @INC
>> t/alltest/all.t . skipped: testing all.t
>> t/alltest2/all.t  skipped: testing more than one all.t
>> t/bad_coding.t .. ok
>> t/cookies.t . skipped: cannot find module 'CGI',
>> cannot find module 'CGI::Cookie'
>> t/import.t .. ok
>> t/log_watch.t ... ok
>> t/log_watch_for_broken_lines.t .. ok
>> t/more/all.t  skipped: cannot find module 'mod_perl.c'
>> t/next_available_port.t . ok
>> t/ping.t  ok
>> t/redirect.t  ok
>> t/request.t . ok
>> t/sok.t . ok
>> All tests successful.
>> Files=13, Tests=91,  4 wallclock secs ( 0.05 usr  0.01 sys +  2.17
>> cusr  0.56 csys =  2.79 CPU)
>> Result: PASS
>> [warning] server localhost:8529 shutdown
>>
>> There are also some unit tests under "test" directory that they are
>> all passed when I run the executable. I would like to know what is the
>> difference between these two tests? Also I expected the tests that are
>> triggered with "make check" to be much more extensive than some small
>> tests that are run quickly. Something like night-run tests! Am I
>> missing something?
>>
>> Regards,
>>
>> Danesh Daroui


Re: Run httpd's testsuite

2018-09-02 Thread Daniel Ruggeri
Hi, Danesh;
   Actually, that output looks correct for a very limited server configuration. 
The test suite will detect the configured modules and run tests for only those 
modules. As you noticed, for example, since mod_perl is not installed in your 
server, those tests are skipped. If you built the server with all modules 
(--with-modules=reallyall, if memory serves me correctly), you would see many 
more tests run. Also, do not be alarmed if the test suite doesn't take a full 
night to run. That is also normal :-)
-- 
Daniel Ruggeri

On September 2, 2018 5:49:46 AM CDT, Danesh Daroui  
wrote:
>Hi all,
>
>I would like to be bale to run Apache https's testsuite. I have clones
>Apache-Test and configures the project with the given path and then
>built the httpd server, but when I execute "make cheek", all tests for
>"all.t" are skipped. The logs show that the test scripts runs the
>server with some isolated configurations on a specific port but it
>apparently cannot find "mod_perl.c" for instance. This is the last
>part of the log that I get when I run the test:
>
>waiting 60 seconds for server to start: .
>waiting 60 seconds for server to start: ok (waited 0 secs)
>server localhost:8529 started
>[   info] adding source lib
>/home/danesh/open/github/Apache-Test/../Apache-Test/lib to @INC
>t/alltest/all.t . skipped: testing all.t
>t/alltest2/all.t  skipped: testing more than one all.t
>t/bad_coding.t .. ok
>t/cookies.t . skipped: cannot find module 'CGI',
>cannot find module 'CGI::Cookie'
>t/import.t .. ok
>t/log_watch.t ... ok
>t/log_watch_for_broken_lines.t .. ok
>t/more/all.t  skipped: cannot find module
>'mod_perl.c'
>t/next_available_port.t . ok
>t/ping.t  ok
>t/redirect.t  ok
>t/request.t . ok
>t/sok.t . ok
>All tests successful.
>Files=13, Tests=91,  4 wallclock secs ( 0.05 usr  0.01 sys +  2.17
>cusr  0.56 csys =  2.79 CPU)
>Result: PASS
>[warning] server localhost:8529 shutdown
>
>There are also some unit tests under "test" directory that they are
>all passed when I run the executable. I would like to know what is the
>difference between these two tests? Also I expected the tests that are
>triggered with "make check" to be much more extensive than some small
>tests that are run quickly. Something like night-run tests! Am I
>missing something?
>
>Regards,
>
>Danesh Daroui


Re: Is it interesting to add some filepath checks to apachectl -t ?

2018-09-02 Thread Daniel Ferradal
but httpd is invoked from it and already checks if document root exists and
if does not it does not start, and log directory is always writable unless
selinux is involved because those are written with root. So I am not sure
what is the gain here.

El dom., 2 sept. 2018 13:41, Yann Ylavic  escribió:

> Hi Stéphane,
>
> sorry for the delay.
>
> >
> > On 03/07/2018 22:57, Stéphane Blondon wrote:
> > > Hello,
> > >
> > > `apachectl -t` checks the configuration files. The documentation
> > > explains it's not complete.
> > > It seems paths (for DocumentRoot for example) or the write access for
> > > log directory are not checked. (tested with apache v.2.4.25.)
> > >
> > > Are you interested by such a feature?
>
> Sure, improvements are always welcome!
>
> > > If I understand the code properly, the check is done by
> > > ap_run_test_config(), called in main.c. However, I don't find the
> > > definition of the function in the httpd-2.4.33 archive.
>
> apr_run_*() functions run the hooks registered with ap_hook_*(), so
> you may want to search for "test_config" in the sources and see how
> such functions are implemented/hooked (and how hooks mechanism work in
> general for that case).
> Then possibly add your code in one of the hooks or create a new hook
> if that fits better.
>
> > >
> > > I have no idea if I have the skills to implement that in C but I can
> > > look for it.
>
> Thanks!
>
> Regards,
> Yann.
>


Re: Is it interesting to add some filepath checks to apachectl -t ?

2018-09-02 Thread Yann Ylavic
Hi Stéphane,

sorry for the delay.

>
> On 03/07/2018 22:57, Stéphane Blondon wrote:
> > Hello,
> >
> > `apachectl -t` checks the configuration files. The documentation
> > explains it's not complete.
> > It seems paths (for DocumentRoot for example) or the write access for
> > log directory are not checked. (tested with apache v.2.4.25.)
> >
> > Are you interested by such a feature?

Sure, improvements are always welcome!

> > If I understand the code properly, the check is done by
> > ap_run_test_config(), called in main.c. However, I don't find the
> > definition of the function in the httpd-2.4.33 archive.

apr_run_*() functions run the hooks registered with ap_hook_*(), so
you may want to search for "test_config" in the sources and see how
such functions are implemented/hooked (and how hooks mechanism work in
general for that case).
Then possibly add your code in one of the hooks or create a new hook
if that fits better.

> >
> > I have no idea if I have the skills to implement that in C but I can
> > look for it.

Thanks!

Regards,
Yann.


Re: Is it interesting to add some filepath checks to apachectl -t ?

2018-09-02 Thread Stéphane Blondon
Hello,

sorry to come back but I get no replies so I don't know if it has been ignored
because considered as not good or you were too busy with the last release.


Regards,
Stéphane

On 03/07/2018 22:57, Stéphane Blondon wrote:
> Hello,
> 
> `apachectl -t` checks the configuration files. The documentation
> explains it's not complete.
> It seems paths (for DocumentRoot for example) or the write access for
> log directory are not checked. (tested with apache v.2.4.25.)
> 
> Are you interested by such a feature?
> If I understand the code properly, the check is done by
> ap_run_test_config(), called in main.c. However, I don't find the
> definition of the function in the httpd-2.4.33 archive. I downloaded the
> archive at:
> 
> http://apache.mirrors.ovh.net/ftp.apache.org/dist//httpd/httpd-2.4.33.tar.bz2
> 
> I have no idea if I have the skills to implement that in C but I can
> look for it.
> 
> I susbcribed to the mailing list.
> 
> Regards,
> Stéphane
> 



signature.asc
Description: OpenPGP digital signature


Run httpd's testsuite

2018-09-02 Thread Danesh Daroui
Hi all,

I would like to be bale to run Apache https's testsuite. I have clones
Apache-Test and configures the project with the given path and then
built the httpd server, but when I execute "make cheek", all tests for
"all.t" are skipped. The logs show that the test scripts runs the
server with some isolated configurations on a specific port but it
apparently cannot find "mod_perl.c" for instance. This is the last
part of the log that I get when I run the test:

waiting 60 seconds for server to start: .
waiting 60 seconds for server to start: ok (waited 0 secs)
server localhost:8529 started
[   info] adding source lib
/home/danesh/open/github/Apache-Test/../Apache-Test/lib to @INC
t/alltest/all.t . skipped: testing all.t
t/alltest2/all.t  skipped: testing more than one all.t
t/bad_coding.t .. ok
t/cookies.t . skipped: cannot find module 'CGI',
cannot find module 'CGI::Cookie'
t/import.t .. ok
t/log_watch.t ... ok
t/log_watch_for_broken_lines.t .. ok
t/more/all.t  skipped: cannot find module 'mod_perl.c'
t/next_available_port.t . ok
t/ping.t  ok
t/redirect.t  ok
t/request.t . ok
t/sok.t . ok
All tests successful.
Files=13, Tests=91,  4 wallclock secs ( 0.05 usr  0.01 sys +  2.17
cusr  0.56 csys =  2.79 CPU)
Result: PASS
[warning] server localhost:8529 shutdown

There are also some unit tests under "test" directory that they are
all passed when I run the executable. I would like to know what is the
difference between these two tests? Also I expected the tests that are
triggered with "make check" to be much more extensive than some small
tests that are run quickly. Something like night-run tests! Am I
missing something?

Regards,

Danesh Daroui


Bug report for Apache httpd-2 [2018/09/02]

2018-09-02 Thread bugzilla
+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 8713|Inf|Min|2002-05-01|No Errorlog on PROPFIND/Depth:Infinity|
| 8867|Opn|Cri|2002-05-07|exports.c generation fails when using a symlink to|
|10747|New|Maj|2002-07-12|ftp SIZE command and 'smart' ftp servers results i|
|11294|New|Enh|2002-07-30|desired vhost_alias option|
|11580|Opn|Enh|2002-08-09|generate Content-Location headers |
|12033|Opn|Nor|2002-08-26|Graceful restart immediately result in [warn] long|
|13599|Inf|Nor|2002-10-14|autoindex formating broken for multibyte sequences|
|13661|Ass|Enh|2002-10-15|Apache cannot not handle dynamic IP reallocation  |
|14104|Opn|Enh|2002-10-30|not documented: must restart server to load new CR|
|14496|New|Enh|2002-11-13|Cannot upgrade any version on Windows. Must uninst|
|14922|Inf|Enh|2002-11-28| is currently hardcoded to 'apache2'  |
|15719|Inf|Nor|2002-12-30|WebDAV MOVE to destination URI which is content-ne|
|16761|Inf|Nor|2003-02-04|CustomLog with pipe spawns process during config  |
|16811|Ass|Maj|2003-02-05|mod_autoindex always return webpages in UTF-8.|
|17107|New|Min|2003-02-16|Windows should not install printenv   |
|17114|New|Enh|2003-02-17|Please add strip and install-strip targets to Make|
|17244|Ass|Nor|2003-02-20|./configure --help gives false information regardi|
|17497|Opn|Nor|2003-02-27|mod_mime_magic generates incorrect response header|
|18325|New|Enh|2003-03-25|PAM support for suEXEC|
|18334|Inf|Cri|2003-03-25|Server crashes when authenticating users against L|
|19670|New|Enh|2003-05-05|content type header supplied upon PUT is thrown aw|
|20036|Ass|Nor|2003-05-19|Trailing Dots stripped from PATH_INFO environment |
|21260|New|Nor|2003-07-02|CacheMaxExpire directive not enforced !   |
|21533|Ass|Cri|2003-07-11|Multiple levels of htacces files can cause mod_aut|
|22484|Opn|Maj|2003-08-16|semaphore problem takes httpd down|
|22686|Opn|Nor|2003-08-25|ab: apr_poll: The timeout specified has expired (7|
|22898|Opn|Nor|2003-09-02|nph scripts with two HTTP header  |
|23167|Inf|Cri|2003-09-14|--enable-layout never goes to apr apr-util|
|23181|New|Nor|2003-09-15|Status 304 (Not modified) and chunking leads to an|
|23238|New|Cri|2003-09-18|non-async-signal-safe operations from signal handl|
|23330|New|Enh|2003-09-22|Enhance ApacheMonitor to view and control Tomcat s|
|23911|Opn|Cri|2003-10-18|CGI processes left defunct/zombie under 2.0.54|
|24031|New|Enh|2003-10-23|Passphrase protected private key in SSLProxyMachin|
|24095|Opn|Cri|2003-10-24|ERROR "Parent: child process exited with status 32|
|24437|Opn|Nor|2003-11-05|mod_auth_ldap doubly-escapes backslash (\) charact|
|24890|Opn|Nor|2003-11-21|Apache config parser should not be local aware ( g|
|25014|New|Enh|2003-11-26|A flexible interface for mod_log_config   |
|25201|New|Enh|2003-12-04|Provide Cache Purge operation |
|25240|Inf|Enh|2003-12-05|SSL Library Error: 336105671 logged as information|
|25435|New|Enh|2003-12-11|sethandler and directoryindex not playing nice|
|25469|Opn|Enh|2003-12-12|create AuthRoot for defining paths to auth files  |
|25484|Ass|Nor|2003-12-12|Non-service Apache cannot be stopped in WinXP |
|25543|Inf|Nor|2003-12-15|mod_proxy_ajp overwrites existing response headers|
|25667|New|Nor|2003-12-19|Memory leak in function ssl_scache_dbm_retrieve().|
|25863|New|Enh|2004-01-02|new per-host initialization hooks |
|26142|New|Maj|2004-01-14|EnableSendFile Off for Windows XP Home|
|26153|Opn|Cri|2004-01-15|Apache cygwin directory traversal vulnerability   |
|26368|New|Min|2004-01-23|File extensions in AddDescription treated as part |
|26446|New|Nor|2004-01-26|flush buckets followed by eos bucket emit multiple|
|26478|New|Enh|2004-01-28|mod_dav does not expose a method for setting the D|
|26835|New|Enh|2004-02-10|[PATCH] Mod_status Readability & Browser Side Tabl|