Re: Preferred service for patch
Hello Luca, thank you for your reply! On 08/04/2020 18:26, Luca Toscano wrote: > maybe the best path would > be to open a bugzilla task explaining the problem etc.. and > referencing any github pull requests in there (as opposed to attach > the patch directly for example). Ok, this way to contribute is more or less like for cpython: https://devguide.python.org/pullrequest/#quick-guide Regards, Stéphane signature.asc Description: OpenPGP digital signature
Preferred service for patch
Hello, it's possible to provide patch for httpd via bugzilla [1] or Pull Request via github [2]. What is the favorite place to contribute? 1: https://bz.apache.org/bugzilla/ 2: https://github.com/apache/httpd Regards, Stéphane signature.asc Description: OpenPGP digital signature
Request for code review
Hello, I've created a bug report (#63079)[1] and attached a patch to fix it. Christophe Jaillet helped me about it but he currently lacks of free time. Could someone code review the last version of the patch? It's not complicated but it's my first real one on httpd (previous one was spellchecking). I subscribed to this mailing list. 1: https://bz.apache.org/bugzilla/show_bug.cgi?id=63079 Regards, Stéphane
Re: Trying to compile httpd trunk
Le dim. 29 déc. 2019 à 03:17, Tom Donovan a écrit : > I built successfully from the trunk on a Debian 11 (Bullseye) system using > the commands below. Thank you Tom! It works. :) In case it helps someone, there were some missing packages (libnghttp2-dev and some libprcre* libraries) and the '--enable-mods-shared=most' option compared to my commands. -- Stéphane
Re: Trying to compile httpd trunk
Le ven. 20 déc. 2019 à 19:02, Nick Kew a écrit : > I take it you have a good reason to want that rather than a packaged version > such as Debian's? I'd like to provide a patch to a (whishlist) bug report I've done (#63079). > What did buildconf tell you? > > > According to the INSTALL file, I check outed `apr` trunk in > > srclib/apr. After adding several lacking packages, it seems > > ./configure is ok. (The full output is in attachment.) > > Attachment TLDR. Was that apr configure or httpd configure? It was httpd configure. -- Stéphane
Re: Trying to compile httpd trunk
Le ven. 20 déc. 2019 à 11:32, Pluem, Ruediger, Vodafone Group a écrit : > > make extraclean > > ./buildconf > > ./configure > > make > > make install Thanks for `make extraclean` but the error is still there. I tried with ./buildconf in srclib/apr/ ans srclib/apr-util/ before ./builconf in http-trunk directory (like Mike Rumph suggests) but the behaviour is the same. :( $ LANG=C make Making all in srclib make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib' make[1]: *** No rule to make target 'all'. Stop. make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib' make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75: all-recursive] Error 1 > in the top-level directory with either APR trunk or APR 1.x and APR-UTIL 1.x > in srclib as apr and / or apr-util directory should do the trick. My current tree is: $ tree -L 1 srclib srclib ├── apr ├── apr-util └── Makefile The 'Makefile' has been generated and, as the error said, contains no target: $ cat srclib/Makefile top_srcdir = /home/stephane/src/httpd-trunk top_builddir = /home/stephane/src/httpd-trunk srcdir = /home/stephane/src/httpd-trunk/srclib builddir = /home/stephane/src/httpd-trunk/srclib VPATH= /home/stephane/src/httpd-trunk/srclib > Keep in mind that for buildconf further tools are required that are not > needed for normal builds like Python, autoconf and libtool. Yes, I installed several packages before getting the ./configure script works properly: Python 2 and 3, 'autoconf', 'build-essential', 'libtool', 'libtool-bin', 'pcre-utils', 'libpcre2-dev' packages are installed. I uninstalled 'apache2-utils' in case it was the cause of the compilation failure. I will try next year with the 2.4 branch to compare (I will not have access to the used machine to compile Apache). Regards -- Stéphane
Re: Trying to compile httpd trunk
Le mar. 17 déc. 2019 à 19:05, Michal Karm Babacek a écrit : > > The last time I did this (a week or so ago on RHEL 7.6), > I had to checkout both apr and apr-util, their 1.x branches, not trunk. > Thanks for your help! I tried with branches 1.x but it fails with the same error: $ rm -rf srclib/ $ make clean $ svn co http://svn.apache.org/repos/asf/apr/apr/branches/1.7.x srclib/apr $ svn co http://svn.apache.org/repos/asf/apr/apr-util/branches/1.6.x srclib/apr-util $ ./buildconf $ ./configure --prefix=/home/stephane/bin/http --with-included-apr $ LANG=C make Output of `make` command: Making all in srclib make[1]: Entering directory '/home/stephane/src/httpd-trunk/srclib' make[1]: *** No rule to make target 'all'. Stop. make[1]: Leaving directory '/home/stephane/src/httpd-trunk/srclib' make: *** [/home/stephane/src/httpd-trunk/build/rules.mk:75: all-recursive] Error 1 Regards -- Stéphane
Re: Is it interesting to add some filepath checks to apachectl -t ?
Le lun. 14 janv. 2019 à 18:33, William A Rowe Jr a écrit : > > There should not be a 'warn' level emit for a non-existent directory. Unlike > the > DocumentRoot or Alias, which are searched, blocks describe > protection. It's entirely reasonable to protect paths which aren't physically > on > the system at the current moment or in the current deployment. Something > at the 'debug' level would be entirely reasonable, perhaps even at 'info' > level. `apachectl -t -e DEBUG` does not display a message about the non-existent directory. So I guess this check is not done. I will see if I can code the check (as debug or info level) or I will add a wishlist bug in the bugtracker. Regards -- Stéphane
Re: Is it interesting to add some filepath checks to apachectl -t ?
Hello,
sorry for the huge delay :/
>>> On 03/07/2018 22:57, Stéphane Blondon wrote:
>>>> Hello,
>>>>
>>>> `apachectl -t` checks the configuration files. The documentation
>>>> explains it's not complete.
>>>> It seems paths (for DocumentRoot for example) or the write access for
>>>> log directory are not checked. (tested with apache v.2.4.25.)
On 02/09/2018 13:56, Daniel Ferradal wrote:
> but httpd is invoked from it and already checks if document root exists and
> if does not it does not start, and log directory is always writable
You're right: I tested with a more recent version (2.4.37) and
'DocumentRoot' path and logs directories ('ErrorLog' and 'CustomLog')
are checked.
I wonder if `apachectl -t` should provide a warning if the path for
'Directory' directive does not exist.
For example,
if /var/www/demo does not exist, `apachectl -t` does not complain. I
though it would display a warning like AH00112 for DocumentRoot:
Warning: DocumentRoot [/var/www/demo] does not exist
Regards,
Stéphane
signature.asc
Description: OpenPGP digital signature
Re: Is it interesting to add some filepath checks to apachectl -t ?
Hello, sorry to come back but I get no replies so I don't know if it has been ignored because considered as not good or you were too busy with the last release. Regards, Stéphane On 03/07/2018 22:57, Stéphane Blondon wrote: > Hello, > > `apachectl -t` checks the configuration files. The documentation > explains it's not complete. > It seems paths (for DocumentRoot for example) or the write access for > log directory are not checked. (tested with apache v.2.4.25.) > > Are you interested by such a feature? > If I understand the code properly, the check is done by > ap_run_test_config(), called in main.c. However, I don't find the > definition of the function in the httpd-2.4.33 archive. I downloaded the > archive at: > > http://apache.mirrors.ovh.net/ftp.apache.org/dist//httpd/httpd-2.4.33.tar.bz2 > > I have no idea if I have the skills to implement that in C but I can > look for it. > > I susbcribed to the mailing list. > > Regards, > Stéphane > signature.asc Description: OpenPGP digital signature
Is it interesting to add some filepath checks to apachectl -t ?
Hello, `apachectl -t` checks the configuration files. The documentation explains it's not complete. It seems paths (for DocumentRoot for example) or the write access for log directory are not checked. (tested with apache v.2.4.25.) Are you interested by such a feature? If I understand the code properly, the check is done by ap_run_test_config(), called in main.c. However, I don't find the definition of the function in the httpd-2.4.33 archive. I downloaded the archive at: http://apache.mirrors.ovh.net/ftp.apache.org/dist//httpd/httpd-2.4.33.tar.bz2 I have no idea if I have the skills to implement that in C but I can look for it. I susbcribed to the mailing list. Regards, Stéphane signature.asc Description: OpenPGP digital signature
