Re: [RESULT] Was: [VOTE] Release Apache httpd 2.4.18 as GA

[Stefan Eissing]

Thanks for RMing, Jim!

> Am 11.12.2015 um 23:23 schrieb Jim Jagielski :
> 
> With more than the required 3 +1 (binding) votes, I call
> the VOTE closed with the result that the VOTE PASSES.
> 
> I will start moving the artifacts so the mirrors can collect
> them over the weekend.
> 
>> On Dec 8, 2015, at 3:38 PM, Jim Jagielski  wrote:
>> 
>> The pre-release test tarballs for Apache httpd 2.4.18 can be found
>> at the usual place:
>> 
>>  http://httpd.apache.org/dev/dist/
>> 
>> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
>> 
>> [ ] +1: Good to go
>> [ ] +0: meh
>> [ ] -1: Danger Will Robinson. And why.
>> 
>> Vote will last the normal 72 hrs.
>> 
>> NOTE: The *-deps are only there for convenience.
>> 
>> Thx!
> 

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Yann Ylavic]

On Tue, Dec 8, 2015 at 9:38 PM, Jim Jagielski  wrote:
>
> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
>
> [X] +1: Good to go

md5/sha1/pgp OK

Tested on:

* Debian 8.2 (Jessie)
=> All tests passed.

* Debian 7.9 (Wheezy)
=> All tests passed.

* Debian 6.0.10 (Squeeze)
=> No regression.

Thanks Jim from RMing.

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Gregg Smith]

+1 Various flavors of VC/Windows


On 12/8/2015 12:38 PM, Jim Jagielski wrote:

The pre-release test tarballs for Apache httpd 2.4.18 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

[RESULT] Was: [VOTE] Release Apache httpd 2.4.18 as GA

[Jim Jagielski]

With more than the required 3 +1 (binding) votes, I call
the VOTE closed with the result that the VOTE PASSES.

I will start moving the artifacts so the mirrors can collect
them over the weekend.

> On Dec 8, 2015, at 3:38 PM, Jim Jagielski  wrote:
> 
> The pre-release test tarballs for Apache httpd 2.4.18 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Yann Ylavic]

On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung  wrote:
>
>   - three compiler warning (2 regressions, one old)
[]
>   modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' set
> but not used [-Wunused-but-set-variable]

This one is harmless ('hssc' redeclared and used below in inner scope).
But I checked twice since handshakeserver (there) is not checked
against NULL like at the initialization.
Fortunately the !ssl path above handles the case, so this is simply a
double initialization (to the same value), likely optimized away
finally...

-Wunused-but-set-variable does its job, though.

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Yann Ylavic]

On Fri, Dec 11, 2015 at 10:57 PM, Yann Ylavic  wrote:
> On Fri, Dec 11, 2015 at 10:39 PM, Yann Ylavic  wrote:
>> On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung  wrote:
>>>
>>>   - three compiler warning (2 regressions, one old)
>> []
>>>   modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' set
>>> but not used [-Wunused-but-set-variable]
>>
>> This one is harmless ('hssc' redeclared and used below in inner scope).
>> But I checked twice since handshakeserver (there) is not checked
>> against NULL like at the initialization.
>> Fortunately the !ssl path above handles the case, so this is simply a
>> double initialization (to the same value), likely optimized away
>> finally...
>>
>> -Wunused-but-set-variable does its job, though.
>
> The original commit in trunk (r1709995) contained:
> @@ -529,7 +672,6 @@ int ssl_hook_Access(request_rec *r)
>   */
>  if ((dc->nVerifyClient != SSL_CVERIFY_UNSET) ||
>  (sc->server->auth.verify_mode != SSL_CVERIFY_UNSET)) {
> -SSLSrvConfigRec *hssc = mySrvConfig(handshakeserver);
>
>  /* remember old state */
>  verify_old = SSL_get_verify_mode(ssl);
> --

This turned into (r1712567, 2.4.17-protocols-changes):
@@ -554,6 +697,7 @@ int ssl_hook_Access(request_rec *r)
  */
 if ((dc->nVerifyClient != SSL_CVERIFY_UNSET) ||
 (sc->server->auth.verify_mode != SSL_CVERIFY_UNSET)) {
+
 /* remember old state */
 verify_old = SSL_get_verify_mode(ssl);
 /* configure new state */
--
which was then merged in 2.4.x.

This is the only change which "failed" in r1712567, and trunk and
2.4.x are in sync wrt the changes in 2.4.18, so finally not an issue.

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Yann Ylavic]

On Fri, Dec 11, 2015 at 10:39 PM, Yann Ylavic  wrote:
> On Fri, Dec 11, 2015 at 9:21 PM, Rainer Jung  wrote:
>>
>>   - three compiler warning (2 regressions, one old)
> []
>>   modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' set
>> but not used [-Wunused-but-set-variable]
>
> This one is harmless ('hssc' redeclared and used below in inner scope).
> But I checked twice since handshakeserver (there) is not checked
> against NULL like at the initialization.
> Fortunately the !ssl path above handles the case, so this is simply a
> double initialization (to the same value), likely optimized away
> finally...
>
> -Wunused-but-set-variable does its job, though.

The original commit in trunk (r1709995) contained:
@@ -529,7 +672,6 @@ int ssl_hook_Access(request_rec *r)
  */
 if ((dc->nVerifyClient != SSL_CVERIFY_UNSET) ||
 (sc->server->auth.verify_mode != SSL_CVERIFY_UNSET)) {
-SSLSrvConfigRec *hssc = mySrvConfig(handshakeserver);

 /* remember old state */
 verify_old = SSL_get_verify_mode(ssl);
--

But somehow the merge in 2.4.x (r1715255, from
2.4.17-protocols-changes branch?) does not.

Looks like a merge issue :/
Comparing files now...

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Rainer Canavan]

2015-12-11 19:59 GMT+01:00 Jim Jagielski :
> Just a quick reminder that the voting closes in about 90mins.
>
> tia!

builds and works according to my casual tests on IRIX mips as n32.

rainer

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Rainer Jung]

Am 08.12.2015 um 21:38 schrieb Jim Jagielski:

The pre-release test tarballs for Apache httpd 2.4.18 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

[X] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.


+1 to release and thank a bunch for RMing.

In short: No regressions found.

Detailed report:

- Sigs and hashes OK
- contents of tarballs identical
- contents of tag and tarballs identical
  except for expected deltas
  (we could cleanup some m4 files in apr-util/xml/expat/conftools
   at the end of buildconf, no regression)

Built on

- Solaris 8+10 Sparc as 32 Bit Binaries
- SLES 10+11 (64 Bits)
- RHEL 6 (64 Bits)

For all platforms built

- with default (shared), shared and static modules
- with module sets none, few, most, all, reallyall and default
  (always mod_privileges disabled)
- using --enable-load-all-modules
- against "included" APR/APU from deps tarball,
  plus external APR/APU 1.5.2/1.5.4

- using external libraries
  - expat 2.1.0 plus patch
  - pcre 8.37
  - openssl 1.0.2e
  - lua 5.2.4
  - distcache 1.5.1
  - libxml2 2.9.3
  - libnghttp2 1.5.0

- Tool chain:
- platform gcc except for Solaris
  (gcc 4.4.4 for Solaris 8 and 4.9.2 for Solaris 10)
- CFLAGS: -O2 -g -Wall -fno-strict-aliasing
  (and -mpcu=v9 on Solaris)

All builds succeeded
  - three compiler warning (2 regressions, one old)
  modules/http2/h2_conn_io.c:401:2: warning: no newline at end of file
  modules/ssl/ssl_engine_kernel.c:414:22: warning: variable 'hssc' 
set but not used [-Wunused-but-set-variable]
  modules/ssl/ssl_util_stapling.c:686: warning: 'ok' may be used 
uninitialized in this function


Tested for

- 343 build combinations
- Solaris 8+10 (32), SLES 10+11 (64), RHEL 6 (64)
- MPMs prefork, worker, event
  (except event on Solaris8, unsupported)
- default, shared and static modules
- log levels info, debug and trace8
- module set reallyall (122 modules plus MPMs)
- SLES 10 and RHEL 6 still ongoing but so far OK

The tests sometimes produce perl warnings:

- Use of uninitialized value in length at
  .../lib/perl5/Protocol/HTTP2/Stream.pm line 366.
  Printed at the start of the http2 test runs.
  Only on the Linux platform.

- Status read failed: at
  .../lib/perl5/Net/HTTP/Methods.pm line 289.
  Printed for test 1 and 3 of t/ssl/verify.t

The following test failures were seen:

a Test 4 or 5 in t/modules/dav.t:
  Happens for 37 out of 343 runs (14 on SLES 10, 13 on SLES 11,
  7 on RHEL 6, 2 on Solaris 8, 1 on Solaris 10).
  Creation, modified and now times not in the correct order.
  This seems to be a system issue, all tests done on NFS,
  many tested on virtualized guests.
  Not a regression.

b Various tests in t/apache/expr_string.t: (6, 11, 14, 17, 20 ,23)
  Happens for 50 out of 343 runs (45 on SLES 10, 3 on RHEL6,
  2 on Solaris 10).
  The failure is always on line 68, where the error_log contents
  are checked.
  Not a regression.

c Test 59 of t/modules/include.t only and always on
  Solaris.
  This is due to a bug in the test, which uses strftime()
  with a "%s" pattern that is not supported on Solaris.
  Until recently the server and the test client both returned
  verbatim "%s" and the test succeeded. After updating some
  Perl modules for the http2 tests, the perl client even
  on Solaris now supports "%s" in strftime and the test starts
  to fail. It seems we have to fix the test. Not a regression.

d Failure of t/modules/session.t on SLES 10.
  Warning: Use of "shift" without parentheses is ambiguous at line 39.
  Perl version is 5.8.8. The script uses a somewhat advances
  $x = shift // "NOTFOUND";
  construct, which seems to be ambiguous for old Perl (I had
  to look in the fine perl docs for the // operator).
  We could probably use a less elegant but more compatible
  construct instead. Not a regression.

e Failure of t/modules/http2.t: tests 11, 12, 15, 16, 45, 46
  Only 4 out of 343 runs fail, 3 on Solaris 8 one on RHEL 6.

  The failure always seems to be related with
  [cgid:error] End of script output before headers: necho.pl

Details for the 4 cases of http2 failures (I do have full logs incl. 
trace8 logs for two cases):


event-trace8-rhel6.x86_64-shared:

test case: TC0009, necho.pl without arguments: GET 
http://localhost:8544/modules/h2/necho.pl

# testing : response status
# expected: 400
# received: '500'
not ok 11
# testing : content comparision
# expected: '
# No query was specified.
# 
# '
# received: '
# 
# 500 Internal Server Error
# 
# Internal Server Error
# The server encountered an internal error or
# misconfiguration and was unable to complete
# your request.
# Please contact the server administrator at
#  y...@example.com to inform them of the time this error occurred,
#  and the actions you performed just before this error.
# More information about this error may be available
# in the 

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Jim Jagielski]

Just a quick reminder that the voting closes in about 90mins.

tia!

> On Dec 8, 2015, at 3:38 PM, Jim Jagielski  wrote:
> 
> The pre-release test tarballs for Apache httpd 2.4.18 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Steffen]

Running on AL for a few days, no issues/regressions seen on all the 
windows VC/OS flavors.


Also no crashes anymore with mod_http2 (discussed off-list with Stefan 
E)


Thanks dev's,

Steffen


On Tuesday 08/12/2015 at 21:38, Jim Jagielski  wrote:

The pre-release test tarballs for Apache httpd 2.4.18 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Stefan Eissing]

+1: 14.04.1-Ubuntu SMP, gcc 4.8.4
worker, event, prefork

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Leif Hedstrom]

> On Dec 8, 2015, at 1:38 PM, Jim Jagielski  wrote:
> 
> The pre-release test tarballs for Apache httpd 2.4.18 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.


+1. Built, tested and run on Fedora 21 - 64-bit with PHP 5.6.4.

— leif

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Jim Jagielski]

+1:
 o OSX 10.11.2, Xcode 7.2: x64
 o CentOS6: x64
 o CentOS7: x64

> On Dec 8, 2015, at 3:38 PM, Jim Jagielski  wrote:
> 
> The pre-release test tarballs for Apache httpd 2.4.18 can be found
> at the usual place:
> 
>   http://httpd.apache.org/dev/dist/
> 
> I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
> 
> [ ] +1: Good to go
> [ ] +0: meh
> [ ] -1: Danger Will Robinson. And why.
> 
> Vote will last the normal 72 hrs.
> 
> NOTE: The *-deps are only there for convenience.
> 
> Thx!

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[William A Rowe Jr]

On Wed, Dec 9, 2015 at 1:02 PM, Jan Ehrhardt  wrote:

> Jim Jagielski in gmane.comp.apache.devel (Tue, 8 Dec 2015 15:38:41 -0500):
> >The pre-release test tarballs for Apache httpd 2.4.18 can be found
> >at the usual place:
> >
> >   http://httpd.apache.org/dev/dist/
> >
> >I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.
>
> No idea who has voting rights, but I am
>
> +1 Build on Windows 7 Pro (VC9 / VC11 / VC14, x86 / x64)
>Tested on Windows 2008 R2 SP1
>

Everyone's votes are valued, whether they are 'weighed' or not!
Both positive and negative feedback from non-PMC members
strongly influence the RM and the PMC member's votes.

Thanks for testing :)

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Jan Ehrhardt]

Jim Jagielski in gmane.comp.apache.devel (Tue, 8 Dec 2015 15:38:41 -0500):
>The pre-release test tarballs for Apache httpd 2.4.18 can be found
>at the usual place:
>
>   http://httpd.apache.org/dev/dist/
>
>I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

No idea who has voting rights, but I am

+1 Build on Windows 7 Pro (VC9 / VC11 / VC14, x86 / x64)
   Tested on Windows 2008 R2 SP1
-- 
Jan

Re: [VOTE] Release Apache httpd 2.4.18 as GA

[Reindl Harald]

Am 08.12.2015 um 21:38 schrieb Jim Jagielski:

The pre-release test tarballs for Apache httpd 2.4.18 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs


+1 Fedora 23 x86_64 with mod_security 2.9 and PHP 5.6.16
without HTTP2 part of the game the same most likely for Fedora 22



signature.asc
Description: OpenPGP digital signature

[VOTE] Release Apache httpd 2.4.18 as GA

[Jim Jagielski]

The pre-release test tarballs for Apache httpd 2.4.18 can be found
at the usual place:

http://httpd.apache.org/dev/dist/

I'm calling a VOTE on releasing these as Apache httpd 2.4.18 GA.

[ ] +1: Good to go
[ ] +0: meh
[ ] -1: Danger Will Robinson. And why.

Vote will last the normal 72 hrs.

NOTE: The *-deps are only there for convenience.

Thx!