Re: [RFC] http_log functions to log buffers
On Tue, Aug 6, 2013 at 1:39 AM, Michael Felt mamf...@gmail.com wrote: I have not studied logging in httpd. The only logs I have ever looked at are the error_logs and access_logs. These look like something different. For systems security I like to use syslog as a place to collect data. If apr already supports, please excuse my ignorance and ignore this. If not, please take my feedback to be: would be very nice to be able to (also) direct this to syslog mechanism. For syslog support you can route all of the error log to syslog with something like ErrorLog syslog:user Michael On Mon, Aug 5, 2013 at 9:32 AM, Jeff Trawick traw...@gmail.com wrote: Any thoughts on the API below? For mod_ssl as an example, at least a couple of additions would be needed to replace ssl_io_data_dump(): 1. a processing flag that converted the printable form to EBCDIC in an EBCDIC environment 2. the ap_log_csdata() variation This doesn't currently implement the optimization to check the configured log level before calling the function. /** * Processing flags for ap_log_data() et al * * AP_LOG_DATA_DEFAULT - default formatting * AP_LOG_DATA_SHOW_OFFSET - prefix each line with hex offset from the start * of the buffer */ #define AP_LOG_DATA_DEFAULT 0 #define AP_LOG_DATA_SHOW_OFFSET 1 /** * ap_log_data() - log buffers which are not related to a particular request * or connection. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param s The server on which we are logging * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_data(const char *file, int line, int module_index, int level, const server_rec *s, const char *label, const char *data, apr_size_t len, unsigned int flags); /** * ap_log_rdata() - log buffers which are related to a particular request. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param r The request which we are logging for * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_rdata(const char *file, int line, int module_index, int level, const request_rec *r, const char *label, const char *data, apr_size_t len, unsigned int flags); /** * ap_log_cdata() - log buffers which are related to a particular connection. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param c The connection which we are logging for * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_cdata(const char *file, int line, int module_index, int level, const conn_rec *c, const char *label, const char *data, apr_size_t len, unsigned int flags); Sample output with AP_LOG_DATA_SHOW_OFFSET and non-default ErrorLogFormat: [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): FastCGI data sent (8 bytes) [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): :
Re: [RFC] http_log functions to log buffers
I have not studied logging in httpd. The only logs I have ever looked at are the error_logs and access_logs. These look like something different. For systems security I like to use syslog as a place to collect data. If apr already supports, please excuse my ignorance and ignore this. If not, please take my feedback to be: would be very nice to be able to (also) direct this to syslog mechanism. Michael On Mon, Aug 5, 2013 at 9:32 AM, Jeff Trawick traw...@gmail.com wrote: Any thoughts on the API below? For mod_ssl as an example, at least a couple of additions would be needed to replace ssl_io_data_dump(): 1. a processing flag that converted the printable form to EBCDIC in an EBCDIC environment 2. the ap_log_csdata() variation This doesn't currently implement the optimization to check the configured log level before calling the function. /** * Processing flags for ap_log_data() et al * * AP_LOG_DATA_DEFAULT - default formatting * AP_LOG_DATA_SHOW_OFFSET - prefix each line with hex offset from the start * of the buffer */ #define AP_LOG_DATA_DEFAULT 0 #define AP_LOG_DATA_SHOW_OFFSET 1 /** * ap_log_data() - log buffers which are not related to a particular request * or connection. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param s The server on which we are logging * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_data(const char *file, int line, int module_index, int level, const server_rec *s, const char *label, const char *data, apr_size_t len, unsigned int flags); /** * ap_log_rdata() - log buffers which are related to a particular request. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param r The request which we are logging for * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_rdata(const char *file, int line, int module_index, int level, const request_rec *r, const char *label, const char *data, apr_size_t len, unsigned int flags); /** * ap_log_cdata() - log buffers which are related to a particular connection. * @param file The file in which this function is called * @param line The line number on which this function is called * @param module_index The module_index of the module logging this buffer * @param level The log level * @param c The connection which we are logging for * @param label A label for the buffer, to be logged preceding the buffer * @param data The buffer to be logged * @param len The length of the buffer * @param flags Special processing flags like AP_LOG_DATA_SHOW_OFFSET * @note Use APLOG_MARK to fill out file, line, and module_index * @note If a request_rec is available, use that with ap_log_rerror() * in preference to calling this function. Otherwise, if a conn_rec is * available, use that with ap_log_cerror() in preference to calling * this function. */ AP_DECLARE(void) ap_log_cdata(const char *file, int line, int module_index, int level, const conn_rec *c, const char *label, const char *data, apr_size_t len, unsigned int flags); Sample output with AP_LOG_DATA_SHOW_OFFSET and non-default ErrorLogFormat: [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): FastCGI data sent (8 bytes) [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): : 0104000103a8 [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): FastCGI data sent (936 bytes) [authnz_fcgi:trace1] mod_authnz_fcgi.c(127): : ..UNIQUE_IDUf76O 0918554e495155455f4944556637364f
