Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-04 Thread Jim Jagielski
Resolved in r1428916

On Jan 3, 2013, at 4:12 PM, Jim Jagielski j...@jagunet.com wrote:

 I'll work on it tomorrow... a quick look indicates
 its a simple patch.
 
 On Jan 3, 2013, at 4:05 PM, Eric Covener cove...@gmail.com wrote:
 
 On Thu, Jan 3, 2013 at 3:39 PM, Jim Jagielski j...@jagunet.com wrote:
 We should be able to defer that until we actually
 *need* to start, as we do with other settings in trunk.
 
 I can work on that in trunk and the propose a backport
 to 2.4...
 
 
 
 That would be great, I probably won't bother with any interim doc
 unless someone else reports it or follows up.
 
 



Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-04 Thread Eric Covener
On Fri, Jan 4, 2013 at 10:14 AM, Jim Jagielski j...@jagunet.com wrote:
 Resolved in r1428916

thanks, that did the trick for me w/ the ProxySet $othermethod scenario.


Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-04 Thread Jim Jagielski
great! Thx for the quick verification.

On Jan 4, 2013, at 10:37 AM, Eric Covener cove...@gmail.com wrote:

 On Fri, Jan 4, 2013 at 10:14 AM, Jim Jagielski j...@jagunet.com wrote:
 Resolved in r1428916
 
 thanks, that did the trick for me w/ the ProxySet $othermethod scenario.
 



Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-03 Thread Jim Jagielski
We should be able to defer that until we actually
*need* to start, as we do with other settings in trunk.

I can work on that in trunk and the propose a backport
to 2.4...

On Dec 28, 2012, at 11:11 AM, Eric Covener cove...@gmail.com wrote:

 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.
 
 I am curious how others feel about this:
 
 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [ ] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available
 
 --
 Eric Covener
 cove...@gmail.com
 



Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-03 Thread Eric Covener
On Thu, Jan 3, 2013 at 3:39 PM, Jim Jagielski j...@jagunet.com wrote:
 We should be able to defer that until we actually
 *need* to start, as we do with other settings in trunk.

 I can work on that in trunk and the propose a backport
 to 2.4...



That would be great, I probably won't bother with any interim doc
unless someone else reports it or follows up.


Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-03 Thread Jim Jagielski
I'll work on it tomorrow... a quick look indicates
its a simple patch.

On Jan 3, 2013, at 4:05 PM, Eric Covener cove...@gmail.com wrote:

 On Thu, Jan 3, 2013 at 3:39 PM, Jim Jagielski j...@jagunet.com wrote:
 We should be able to defer that until we actually
 *need* to start, as we do with other settings in trunk.
 
 I can work on that in trunk and the propose a backport
 to 2.4...
 
 
 
 That would be great, I probably won't bother with any interim doc
 unless someone else reports it or follows up.
 



Re: mod_lbmethod_byrequests required to define a BalancerMember

2013-01-02 Thread Ruediger Pluem


Eric Covener wrote:
 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.
 
 I am curious how others feel about this:
 
 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [X] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available
 

Regards

Rüdiger


Re: mod_lbmethod_byrequests required to define a BalancerMember

2012-12-30 Thread Daniel Ruggeri
On 12/28/2012 10:11 AM, Eric Covener wrote:
 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.

 I am curious how others feel about this:

 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [X] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available

This seems to be the best option to me also. Refactoring the code into
mod_proxy(_balancer) defeats the purpose of loadable balancer modules
and documenting the requirement sounds like working around the issue.

--
Daniel Ruggeri



Re: mod_lbmethod_byrequests required to define a BalancerMember

2012-12-28 Thread Tim Bannister
On 28 Dec 2012, at 16:11, Eric Covener cove...@gmail.com wrote:

 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.
 
 I am curious how others feel about this:
 
 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [x] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available

…I like that one and would also like the moon on a stick please.

Maybe there could be a very simple lbmethod that isn't byrequests, and is 
always available? For example, purely random allocation using a poor quality 
PRNG?

-- 
Tim Bannister – is...@jellybaby.net



smime.p7s
Description: S/MIME cryptographic signature


Re: mod_lbmethod_byrequests required to define a BalancerMember

2012-12-28 Thread Eric Covener
On Fri, Dec 28, 2012 at 11:42 AM, Tim Bannister is...@jellybaby.net wrote:
 On 28 Dec 2012, at 16:11, Eric Covener cove...@gmail.com wrote:

 When defining a balancer, mod_lbmethod_byrequests is always looked up
 explicitly and used as the initial LB method.

 I am curious how others feel about this:

 [ ] document that mod_lbmethod_byrequests needs to be loaded and
 improve the error
 [ ] make it work if ProxySet lbmethod=other occurs before BalancerMember
 [x] make it work if  ProxySet lbmethod=other occurs after BalancerMember
 [ ] refactor byrequests back into mod_proxy or mod_proxy_balancer so
 it's always available

 …I like that one and would also like the moon on a stick please.

 Maybe there could be a very simple lbmethod that isn't byrequests, and is 
 always available? For example, purely random allocation using a poor quality 
 PRNG?

I considered that, but byrequests has no real dependencies and is
already under 200 lines of physical code.