Re: svn move modules/http2 modules/h2 ?

[Yann Ylavic]

Thanks Stefan.

The "issue" now is that we still have mod_h2.so only (and h2_module as
identifier, based on the module being declared in file mod_h2.c), I'm
not sure having both names helps finally...
Maybe one would expect using "LoadModule http2_module
modules/mod_http2.so" when using --enable-http2.


On Wed, Sep 23, 2015 at 2:18 PM, Stefan Eissing
 wrote:
> Done in r1704826, merged into branches/2.4.17-protocols-http2.
>
>> Am 23.09.2015 um 02:02 schrieb William A Rowe Jr :
>>
>> +1 - mostly because --enable-http2 is easier to grok than --enable-h2, not 
>> because I object to the old name :)
>>
>> On Sep 22, 2015 12:39, "Greg Stein"  wrote:
>> Yeah... if anything, rename to mod_http2.
>>
>> On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith  wrote:
>> http2 is more descriptive for the module's purpose, even if the name is 
>> mod_h2. I like it where it is.
>> - 0
>>
>>
>> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
>> +0.5
>>
>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really 
>> feel strongly about this)
>>
>> Am 22.09.2015 um 14:05 schrieb Yann Ylavic:
>>
>> I'm confused about the sources being in modules/http2 and the module
>> being mod_h2 (configured with --enable-h2, ...), it seems to be the
>> only one like this.
>>
>> +1 for me...
>> bytes GmbH
>> Hafenweg 16, 48155 Münster, Germany
>> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
>>
>>
>>
>>
>>
>
> bytes GmbH
> Hafenweg 16, 48155 Münster, Germany
> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
>
>
>

Re: svn move modules/http2 modules/h2 ?

[Stefan Eissing]

Done in r1704826, merged into branches/2.4.17-protocols-http2.

> Am 23.09.2015 um 02:02 schrieb William A Rowe Jr :
> 
> +1 - mostly because --enable-http2 is easier to grok than --enable-h2, not 
> because I object to the old name :)
> 
> On Sep 22, 2015 12:39, "Greg Stein"  wrote:
> Yeah... if anything, rename to mod_http2.
> 
> On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith  wrote:
> http2 is more descriptive for the module's purpose, even if the name is 
> mod_h2. I like it where it is.
> - 0
> 
> 
> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
> +0.5
> 
> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really 
> feel strongly about this)
> 
> Am 22.09.2015 um 14:05 schrieb Yann Ylavic:
> 
> I'm confused about the sources being in modules/http2 and the module
> being mod_h2 (configured with --enable-h2, ...), it seems to be the
> only one like this.
> 
> +1 for me...
> bytes GmbH
> Hafenweg 16, 48155 Münster, Germany
> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
> 
> 
> 
> 
> 

bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: svn move modules/http2 modules/h2 ?

[Jim Jagielski]

IMO, we should keep it where it is (modules/http2 to complement
modules/http) but change the configure to --enable-http2 (but
also allow --enable-h2 as well)... After all, we enable http/1
via --enable-http 

Re: svn move modules/http2 modules/h2 ?

[Jim Jagielski]

+1

> On Sep 22, 2015, at 1:01 PM, Gregg Smith  wrote:
> 
> http2 is more descriptive for the module's purpose, even if the name is 
> mod_h2. I like it where it is.
> - 0
> 
> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
>> +0.5
>> 
>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really 
>> feel strongly about this)
>> 
>>> Am 22.09.2015 um 14:05 schrieb Yann Ylavic:
>>> 
>>> I'm confused about the sources being in modules/http2 and the module
>>> being mod_h2 (configured with --enable-h2, ...), it seems to be the
>>> only one like this.
>>> 
>>> +1 for me...
>> bytes GmbH
>> Hafenweg 16, 48155 Münster, Germany
>> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
>> 
>> 
>> 
> 

Re: svn move modules/http2 modules/h2 ?

[Stefan Eissing]

That quickly went the wrong way... ;-)

> Am 22.09.2015 um 19:39 schrieb Greg Stein :
> 
> Yeah... if anything, rename to mod_http2.
> 
>> On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith  wrote:
>> http2 is more descriptive for the module's purpose, even if the name is 
>> mod_h2. I like it where it is.
>> - 0
>> 
>> 
>>> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
>>> +0.5
>>> 
>>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really 
>>> feel strongly about this)
>>> 
 Am 22.09.2015 um 14:05 schrieb Yann Ylavic:
 
 I'm confused about the sources being in modules/http2 and the module
 being mod_h2 (configured with --enable-h2, ...), it seems to be the
 only one like this.
 
 +1 for me...
>>> bytes GmbH
>>> Hafenweg 16, 48155 Münster, Germany
>>> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
> 

Re: svn move modules/http2 modules/h2 ?

[Gregg Smith]

http2 is more descriptive for the module's purpose, even if the name is 
mod_h2. I like it where it is.

- 0

On 9/22/2015 5:08 AM, Stefan Eissing wrote:

+0.5

h2 ftw! (but there is also a mod_mime in the http dir, so I do not really feel 
strongly about this)


Am 22.09.2015 um 14:05 schrieb Yann Ylavic:

I'm confused about the sources being in modules/http2 and the module
being mod_h2 (configured with --enable-h2, ...), it seems to be the
only one like this.

+1 for me...

bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: svn move modules/http2 modules/h2 ?

[Greg Stein]

Yeah... if anything, rename to mod_http2.

On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith  wrote:

> http2 is more descriptive for the module's purpose, even if the name is
> mod_h2. I like it where it is.
> - 0
>
>
> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
>
>> +0.5
>>
>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not really
>> feel strongly about this)
>>
>> Am 22.09.2015 um 14:05 schrieb Yann Ylavic:
>>>
>>> I'm confused about the sources being in modules/http2 and the module
>>> being mod_h2 (configured with --enable-h2, ...), it seems to be the
>>> only one like this.
>>>
>>> +1 for me...
>>>
>> bytes GmbH
>> Hafenweg 16, 48155 Münster, Germany
>> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
>>
>>
>>
>>
>

Re: svn move modules/http2 modules/h2 ?

[Yann Ylavic]

On Tue, Sep 22, 2015 at 9:52 PM, Jim Jagielski  wrote:
> IMO, we should keep it where it is (modules/http2 to complement
> modules/http) but change the configure to --enable-http2 (but
> also allow --enable-h2 as well)... After all, we enable http/1
> via --enable-http

I'm fine with this too, +1

Re: svn move modules/http2 modules/h2 ?

[William A Rowe Jr]

+1 - mostly because --enable-http2 is easier to grok than --enable-h2, not
because I object to the old name :)
On Sep 22, 2015 12:39, "Greg Stein"  wrote:

> Yeah... if anything, rename to mod_http2.
>
> On Tue, Sep 22, 2015 at 12:01 PM, Gregg Smith  wrote:
>
>> http2 is more descriptive for the module's purpose, even if the name is
>> mod_h2. I like it where it is.
>> - 0
>>
>>
>> On 9/22/2015 5:08 AM, Stefan Eissing wrote:
>>
>>> +0.5
>>>
>>> h2 ftw! (but there is also a mod_mime in the http dir, so I do not
>>> really feel strongly about this)
>>>
>>> Am 22.09.2015 um 14:05 schrieb Yann Ylavic:

 I'm confused about the sources being in modules/http2 and the module
 being mod_h2 (configured with --enable-h2, ...), it seems to be the
 only one like this.

 +1 for me...

>>> bytes GmbH
>>> Hafenweg 16, 48155 Münster, Germany
>>> Phone: +49 251 2807760. Amtsgericht Münster: HRB5782
>>>
>>>
>>>
>>>
>>
>

Re: svn move modules/http2 modules/h2 ?

[Stefan Eissing]

+0.5

h2 ftw! (but there is also a mod_mime in the http dir, so I do not really feel 
strongly about this)

> Am 22.09.2015 um 14:05 schrieb Yann Ylavic :
> 
> I'm confused about the sources being in modules/http2 and the module
> being mod_h2 (configured with --enable-h2, ...), it seems to be the
> only one like this.
> 
> +1 for me...

bytes GmbH
Hafenweg 16, 48155 Münster, Germany
Phone: +49 251 2807760. Amtsgericht Münster: HRB5782