Re: [VOTE] Release JMeter 2.5.1 RC3

2011-09-30 Thread Philippe Mouawad
I don't think I can vote, but +1 for me as an unofficial vote :-)

On Fri, Sep 30, 2011 at 5:47 PM, sebb seb...@gmail.com wrote:

 On 29 September 2011 21:37, Philippe Mouawad philippe.moua...@gmail.com
 wrote:
  Hello Milamber, All,
  Thank you Milamber for your release and thanks message..
 
  I may have a bad news regarding release.
  Working on new issue
  https://issues.apache.org/bugzilla/show_bug.cgi?id=51918
  I discovered a synchronization issue I think related to Pool of Executor
  that enables concurrent download of resources.
  There seems to be a corruption on CookieManager because I get randomly:
  2011/09/29 21:59:12 WARN  - jmeter.protocol.http.sampler.HTTPSamplerBase:
  Execution issue when fetching embedded resources
  java.util.concurrent.ExecutionException: java.util.NoSuchElementException
 at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222)
 at java.util.concurrent.FutureTask.get(FutureTask.java:83)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.downloadPageResources(HTTPSamplerBase.java:1213)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.resultProcessing(HTTPSamplerBase.java:1428)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPAbstractImpl.resultProcessing(HTTPAbstractImpl.java:244)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.sample(HTTPHC3Impl.java:327)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:62)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1019)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1005)
 at
 
 org.apache.jmeter.threads.JMeterThread.process_sampler(JMeterThread.java:411)
 at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:297)
 at java.lang.Thread.run(Thread.java:680)
  Caused by: java.util.NoSuchElementException
 at java.util.AbstractList$Itr.next(AbstractList.java:350)
 at
 
 org.apache.jmeter.testelement.property.PropertyIteratorImpl.next(PropertyIteratorImpl.java:39)
 at
 
 org.apache.jmeter.protocol.http.control.CookieManager.removeMatchingCookies(CookieManager.java:466)
 at
 
 org.apache.jmeter.protocol.http.control.CookieManager.add(CookieManager.java:258)
 at
 
 org.apache.jmeter.protocol.http.control.CookieManager.addCookieFromHeader(CookieManager.java:430)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.saveConnectionCookies(HTTPHC3Impl.java:1071)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.sample(HTTPHC3Impl.java:319)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:62)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase$ASyncSample.call(HTTPSamplerBase.java:1709)
 at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase$ASyncSample.call(HTTPSamplerBase.java:1)
 at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
 at java.util.concurrent.FutureTask.run(FutureTask.java:138)
 at
 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
 at
 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
 ... 1 more
 
 
  I have created a new Issue:
  https://issues.apache.org/bugzilla/show_bug.cgi?id=51919
 
  Note that this issue also exists in 2.5 release so maybe it's not a
 blocker

 I agree, not a blocker on its own.

 The reason we abandoned the previous release vote was the problems
 were either much more serious, or were regressions from a previous
 release.

 I think we should continue with this release vote.
 We need to get this release out if at all possible.

 We can do another one in a month or so.

  for release, although it can happen wery simply:
  - With One thread
  - Put a breakpoint in CookieManager#removeMatchingCookies
  - Let first thread go
  - then you will get parallel calls to function
  - enter loop
  - make one thread remove
  - the second one will get ConcurrentModificationException
 
  I will propose a patch as soon as possible to this.
  But this parallel download may happen on other shared component, maybe
 you
  or sebb know better than me which components may be concerned.
 
  Regards
  Philippe
 
  On Thu, Sep 29, 2011 at 1:54 AM, Milamber milam...@apache.org wrote:
 
  My vote :
  +1
 
  Le 28/09/2011 23:52, Milamber a ecrit :
   Hello,
  
   The third release candidate for JMeter 2.5.1 has been prepared, and
 your
   votes are solicited.
  
   This release fixes mainly some bugs appeared since JMeter 2.5, and
   contains few improvements.
  
   Tests (load tests and/or functional tests) with JVM 5/6/7 on
   Linux/Windows/Mac OS on functionality changes are welcomes (HttpClient
   4.1 request, Http request with parallels embedded resources, View
   results tree, WebServices (SOAP) request, Async sample sending mode,
  etc.)
  
   List of changes:
   

Re: [VOTE] Release JMeter 2.5.1 RC3

2011-09-30 Thread sebb
On 30 September 2011 16:52, Philippe Mouawad philippe.moua...@gmail.com wrote:
 I don't think I can vote, but +1 for me as an unofficial vote :-)

Anyone can vote.

Only PMC votes are binding, however all votes are read and recorded in
the result e-mail.


 On Fri, Sep 30, 2011 at 5:47 PM, sebb seb...@gmail.com wrote:

 On 29 September 2011 21:37, Philippe Mouawad philippe.moua...@gmail.com
 wrote:
  Hello Milamber, All,
  Thank you Milamber for your release and thanks message..
 
  I may have a bad news regarding release.
  Working on new issue
  https://issues.apache.org/bugzilla/show_bug.cgi?id=51918
  I discovered a synchronization issue I think related to Pool of Executor
  that enables concurrent download of resources.
  There seems to be a corruption on CookieManager because I get randomly:
  2011/09/29 21:59:12 WARN  - jmeter.protocol.http.sampler.HTTPSamplerBase:
  Execution issue when fetching embedded resources
  java.util.concurrent.ExecutionException: java.util.NoSuchElementException
     at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:222)
     at java.util.concurrent.FutureTask.get(FutureTask.java:83)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.downloadPageResources(HTTPSamplerBase.java:1213)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.resultProcessing(HTTPSamplerBase.java:1428)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPAbstractImpl.resultProcessing(HTTPAbstractImpl.java:244)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.sample(HTTPHC3Impl.java:327)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:62)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1019)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase.sample(HTTPSamplerBase.java:1005)
     at
 
 org.apache.jmeter.threads.JMeterThread.process_sampler(JMeterThread.java:411)
     at org.apache.jmeter.threads.JMeterThread.run(JMeterThread.java:297)
     at java.lang.Thread.run(Thread.java:680)
  Caused by: java.util.NoSuchElementException
     at java.util.AbstractList$Itr.next(AbstractList.java:350)
     at
 
 org.apache.jmeter.testelement.property.PropertyIteratorImpl.next(PropertyIteratorImpl.java:39)
     at
 
 org.apache.jmeter.protocol.http.control.CookieManager.removeMatchingCookies(CookieManager.java:466)
     at
 
 org.apache.jmeter.protocol.http.control.CookieManager.add(CookieManager.java:258)
     at
 
 org.apache.jmeter.protocol.http.control.CookieManager.addCookieFromHeader(CookieManager.java:430)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.saveConnectionCookies(HTTPHC3Impl.java:1071)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPHC3Impl.sample(HTTPHC3Impl.java:319)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerProxy.sample(HTTPSamplerProxy.java:62)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase$ASyncSample.call(HTTPSamplerBase.java:1709)
     at
 
 org.apache.jmeter.protocol.http.sampler.HTTPSamplerBase$ASyncSample.call(HTTPSamplerBase.java:1)
     at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
     at java.util.concurrent.FutureTask.run(FutureTask.java:138)
     at
 
 java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
     at
 
 java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
     ... 1 more
 
 
  I have created a new Issue:
  https://issues.apache.org/bugzilla/show_bug.cgi?id=51919
 
  Note that this issue also exists in 2.5 release so maybe it's not a
 blocker

 I agree, not a blocker on its own.

 The reason we abandoned the previous release vote was the problems
 were either much more serious, or were regressions from a previous
 release.

 I think we should continue with this release vote.
 We need to get this release out if at all possible.

 We can do another one in a month or so.

  for release, although it can happen wery simply:
  - With One thread
  - Put a breakpoint in CookieManager#removeMatchingCookies
  - Let first thread go
  - then you will get parallel calls to function
  - enter loop
  - make one thread remove
  - the second one will get ConcurrentModificationException
 
  I will propose a patch as soon as possible to this.
  But this parallel download may happen on other shared component, maybe
 you
  or sebb know better than me which components may be concerned.
 
  Regards
  Philippe
 
  On Thu, Sep 29, 2011 at 1:54 AM, Milamber milam...@apache.org wrote:
 
  My vote :
  +1
 
  Le 28/09/2011 23:52, Milamber a ecrit :
   Hello,
  
   The third release candidate for JMeter 2.5.1 has been prepared, and
 your
   votes are solicited.
  
   This release fixes mainly some bugs appeared since JMeter 2.5, and
   contains few improvements.
  
   Tests (load tests and/or functional tests) with JVM 5/6/7 on
   Linux/Windows/Mac OS on functionality changes are