Re: [VOTE] Release JMeter 2.5 RC1
Le 02/08/2011 20:38, sebb a ecrit : On 2 August 2011 19:53, Milamber milam...@apache.org wrote: Le 02/08/2011 13:05, sebb a ecrit : * ApacheJMeter.jar should probably not contain the tird party notice and licenses but only the ASF ones as the files inside the jar only apply to the jar and not the binary distribution. No biggy for me. Probably should be fixed. For next RC2, I can fix this? Presumably all the JMeter*.jar files should just contain the standard NOTICE header; only the binary archive needs the additional details of the other code. Ditto for the LICENSE file. Done. (tomcat-like). Next step for me: prepare JMeter 2.5RC2 Milamber - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [VOTE] Release JMeter 2.5 RC1
On 2 August 2011 14:05, sebb seb...@gmail.com wrote: On 1 August 2011 06:46, Stefan Bodewig bode...@apache.org wrote: On 2011-08-01, Milamber wrote: The first release candidate for JMeter 2.5 has been prepared, and your votes are solicited. I haven't performed any sort of test, not even tried to build JMeter. * hashes and sigs are fine * source tarball and svn tag differ in some ways, some minor like no checkstyle.xml in the source archive but at least one that might be significant: We ought to include checkstyle.xml in the source archive - I think that must be new since 2.4. I see that Milamber has fixed that. diff -ur v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java --- v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java 2011-08-01 07:26:20.174097342 +0200 +++ jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java 2011-08-01 01:18:26.0 +0200 @@ -44,7 +44,7 @@ * This ensures that JMeterUtils always gets the correct * version, even if JMeterUtils is not re-compiled during the build. */ - private static final String VERSION = 2.5; + private static final String VERSION = 2.5 r1152655; For me this is not big enough to cast a negative vote, this really depends on how closely the JMeter devs want the tag and the released code to match. This is tricky. The idea is that the displayed version includes the SVN revision number from which the binary was built. The file would need to be updated when creating the tag so it gets the same id as the tag. The existing post-tag update phase could be changed to check that the correct rev number had been included. I'll see if I can get this working, but it may take a while as I don't have access to my normal build PC at present. Looks like it can be made to work. The procedure that worked for me was: Update the file containing the $Revision keyword. It's not sufficient to edit the text within the keywork field, as SVN does not consider that to be an update. Probably the easiest would be to add the current date as a comment to the version file. The SVN tag can then be created using svn copy from the workspace. See my test commit: URL: http://svn.apache.org/viewvc?rev=1153135view=rev Log: Test tag / keyword creation There's a bit more work still needed to incorporate this into the JMeter build process. For example, the keyword expansion produces $Revision: 1153135 $, but ideally we only want the revision number. I can make a start on this. * in addition the source distribution is missing the docs subdirectory. Is this intentional? The docs subdirectory is generated from xdocs, so is not needed in the source archive. It's only stored in SVN for use when updating the website. * RAT only flags some testfiles, which is good enough for me * NOTICE should contain 2011 rather than 2010 Good point; needs to be fixed. I see Milamber has done that too. * ApacheJMeter.jar should probably not contain the tird party notice and licenses but only the ASF ones as the files inside the jar only apply to the jar and not the binary distribution. No biggy for me. Probably should be fixed. Not a +1, yet. Stefan - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [VOTE] Release JMeter 2.5 RC1
Le 02/08/2011 13:05, sebb a ecrit : * ApacheJMeter.jar should probably not contain the tird party notice and licenses but only the ASF ones as the files inside the jar only apply to the jar and not the binary distribution. No biggy for me. Probably should be fixed. For next RC2, I can fix this? Milamber - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [VOTE] Release JMeter 2.5 RC1
On 2 August 2011 19:53, Milamber milam...@apache.org wrote: Le 02/08/2011 13:05, sebb a ecrit : * ApacheJMeter.jar should probably not contain the tird party notice and licenses but only the ASF ones as the files inside the jar only apply to the jar and not the binary distribution. No biggy for me. Probably should be fixed. For next RC2, I can fix this? Presumably all the JMeter*.jar files should just contain the standard NOTICE header; only the binary archive needs the additional details of the other code. Ditto for the LICENSE file. Milamber - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [VOTE] Release JMeter 2.5 RC1
Re-Hello, My vote : +1 I support this release Milamber Le 01/08/2011 00:04, Milamber a ecrit : Hello, The first release candidate for JMeter 2.5 has been prepared, and your votes are solicited. JMeter is a Java desktop application designed to load test functional behavior and measure performance. The current version is targeted at Java 1.5+. Archives/hashes/sigs: http://people.apache.org/~milamber/jmeter-2.5RC1/dist MD5 hashes of archives for this vote: e4a149d26d3d97a1cd3d2e522bf81bcc *jakarta-jmeter-2.5.tgz ee23051242750ddd860e22ce28ce17dd *jakarta-jmeter-2.5.zip 94fe7cbbe9391e4b09869d06526daed4 *jakarta-jmeter-2.5_src.tgz 2692be7676c7174eef743ddb366dd9d4 *jakarta-jmeter-2.5_src.zip Site Docs are here: http://people.apache.org/~milamber/jmeter-2.5RC1/docs Tag: http://svn.apache.org/repos/asf/jakarta/jmeter/tags/v2_5_RC1 (r1152614) Keys are here: http://svn.apache.org/repos/asf/jakarta/site/dist/jmeter/ also http://people.apache.org/~milamber/ N.B. To download the dependencies: ant download_jars To create the jars and test JMeter: ant package test. JMeter 2.5 requires Java 1.5 or later. Note that there is a bug in Java on some Linux systems that manifests itself as the following error when running the test cases or JMeter itself: [java] WARNING: Couldn't flush user prefs: java.util.prefs.BackingStoreException: java.lang.IllegalArgumentException: Not supported: indent-number This does not affect JMeter operation. All feedback (and votes!) welcome. [ ] +1 I support this release [ ] +0 I am OK with this release [ ] -0 OK, but [ ] -1 I do not support this release (please indicate why) The vote will remain open for at least 72 hours. Note: If the vote passes, the intention is to release the archive files and rename the RC tag as the release tag. Thanks in advance! Milamber - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
Re: [VOTE] Release JMeter 2.5 RC1
On 2011-08-01, Milamber wrote: The first release candidate for JMeter 2.5 has been prepared, and your votes are solicited. I haven't performed any sort of test, not even tried to build JMeter. * hashes and sigs are fine * source tarball and svn tag differ in some ways, some minor like no checkstyle.xml in the source archive but at least one that might be significant: diff -ur v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java --- v2_5_RC1/src/core/org/apache/jmeter/util/JMeterVersion.java 2011-08-01 07:26:20.174097342 +0200 +++ jakarta-jmeter-2.5/src/core/org/apache/jmeter/util/JMeterVersion.java 2011-08-01 01:18:26.0 +0200 @@ -44,7 +44,7 @@ * This ensures that JMeterUtils always gets the correct * version, even if JMeterUtils is not re-compiled during the build. */ -private static final String VERSION = 2.5; +private static final String VERSION = 2.5 r1152655; For me this is not big enough to cast a negative vote, this really depends on how closely the JMeter devs want the tag and the released code to match. * in addition the source distribution is missing the docs subdirectory. Is this intentional? * RAT only flags some testfiles, which is good enough for me * NOTICE should contain 2011 rather than 2010 * ApacheJMeter.jar should probably not contain the tird party notice and licenses but only the ASF ones as the files inside the jar only apply to the jar and not the binary distribution. No biggy for me. Not a +1, yet. Stefan - To unsubscribe, e-mail: dev-unsubscr...@jakarta.apache.org For additional commands, e-mail: dev-h...@jakarta.apache.org
