[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time Hi Christopher, thanks for the update. I'm quite puzzled by the difference between Maven and Ant. The logic of the timeout matching is entirely external to either, being in the StoryManager. Can you offer more information or a reproduceable example? As for the behaviour in presence of slashes, could you please see if you can reproduce at unit level in the StoryManagerBehaviour? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Mauro, Overall its working very well when directories are not involved in storyTimeoutInSecsByPath. When directories are involved, running from the pom.xml works well, but running from ant like we do in our company does not. I've attached a new Word Doc (JBEHAVE-833_TestFindings.docx) with specific examples of what worked/didn't work for me. In my opinion, we should leave this as is now. When I originally started this patch, I didn't realize the storyTimeoutInSecsByPath would be matched against the story path name only i.e. and_step.story. Personally, I would be fine with not putting directories in storyTimeoutInSecsByPath as a user. We would just need to update all the examples/documentation to not include directory names so users aren't confused as to what works/what doesn't. On the plus side, the users still have the flexibility to use stars only or dot stars which is nice. Let me know what you think. If you do agree to stick with what we currently have, then I can submit a patch to update the examples/comments/unit tests with ones that reflect what works well. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together.
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time Hi Christopher, I've committed a fix to support both ant-style patterns (a la StoryFinder) and regex patterns. I've also updated the core examples pom.xml with story timeouts. Can you please give it a whirl and let me know if we can resolve this issue? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre updated an issue JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time Change By: Christopher Aguirre Attachment: storyTimeoutInSecsByPath_inAction.JPG Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Mauro, I've updated the pom.xml and added the changes to this pull request: https://github.com/jbehave/jbehave-core/pull/74 It actually works pretty well in the examples' CoreStories context - as I originally expected and described in # 1 of my Word Doc. I did have to use dot stars though which you can see in the pom.xml. The example in the pom.xml is sufficient to give a user an idea of how to use storyTimeoutInSecsByPath. I have also included a screen shot (storyTimeoutInSecsByPath_inAction.JPG) of the console statements which show what timeouts each story run were using based on the pom.xml. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time Hi Christopher, you can set it either in CoreStories or in the pom.xml but be aware that the pom.xml overrides what is set in the embedded Java configuration. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Mauro, As I work on this pull request, I want to confirm that I am making the changes in the correct place. I am adding the example usage for storyTimeoutInSecsByPath in jbehave-examples/core/pom.xml - is this what you are expecting? I want to confirm because I tried updating CoreStories.java but its inherently using UnmodifiableEmbedderControls which doesn't allow me to set my own timeout values. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time I think it'd be much easier to modifiy the examples' CoreStories configuration to reproduce the behaviour in the doc. Can you provide such pull request please? I'd be interested in understanding what works and what does not for you. Thanks Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre updated an issue JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time Post Implementation Discussion Between Mauro and Chris Aguirre Change By: Christopher Aguirre Attachment: JBEHAVE-833_Explanation.docx Add Comment This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Mauro, I have uploaded a Word Doc named JBEHAVE-833_Explanation.docx to this issue in order to avoid formatting mistakes here in JIRA. Please let me know if you have issues opening the doc and I can send in another format or via another means. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre edited a comment on an issue Re: Provide a configurable timeout value for each story running time HiMauro,Itsworkingverywell-Itestedthoroughlyanddon'tseeanyadditionalissues.Givenyoursimplifiedregexpatternsolution,IthinkitwouldbebesttoupdateallplacesincodewhereIgiveexamplesofhowtousethisnewstoryTimeoutInSecsByPath.Inmyfirstcommit,allofmyexamples/comments/unittestsusedthisformat:E.g. \* /long/\*.story:5000, \* /short/\*.story:200Atthetime,Iwasthinkingofascenariowheresomeonemightwanttoassignaspecifictimeouttoawholesuiteoftestsunderapackagesuchaslongorshort.Butafterreviewingyourchanges,Ithinkitwouldbeclearertousethisformatfortheexamples:E.g..\*Long.\*.story:5000,.\*Short.\*.story:200ThisnewexamplewouldshowthatitsfairlyeasytoassignatimeouttoanytestswithLongorShortintheirnames.Essentiallykeepingtheexampleassimpleaspossibleandshowingusersthattheycansimplyuse.*formatchingwithstorypath.Thoughts? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre edited a comment on an issue Re: Provide a configurable timeout value for each story running time HiMauro,Itsworkingverywell-Itestedthoroughlyanddon'tseeanyadditionalissues.Givenyoursimplifiedregexpatternsolution,IthinkitwouldbebesttoupdateallplacesincodewhereIgiveexamplesofhowtousethisnewstoryTimeoutInSecsByPath.Inmyfirstcommit,allofmyexamples/comments/unittestsusedthisformat:E.g.*/long/*.story:5000,*/short/*.story:200Atthetime,Iwasthinkingofascenariowheresomeonemightwanttoassignaspecifictimeouttoawholesuiteoftestsunderapackagesuchaslongorshort.Butafterreviewingyourchanges,Ithinkitwouldbeclearertousethisformatfortheexamples:E.g.. / *Long.*.story:5000,.*Short.*.story:200ThisnewexamplewouldshowthatitsfairlyeasytoassignatimeouttoanytestswithLongorShortintheirnames.Essentiallykeepingtheexampleassimpleaspossibleandshowingusersthattheycansimplyuse.*formatchingwithstorypath.Thoughts? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre edited a comment on an issue Re: Provide a configurable timeout value for each story running time HiMauro,Itsworkingverywell-Itestedthoroughlyanddon'tseeanyadditionalissues.Givenyoursimplifiedregexpatternsolution,IthinkitwouldbebesttoupdateallplacesincodewhereIgiveexamplesofhowtousethisnewstoryTimeoutInSecsByPath.Inmyfirstcommit,allofmyexamples/comments/unittestsusedthisformat:E.g. * /long/ \ *.story:5000, * /short/ \ *.story:200Atthetime,Iwasthinkingofascenariowheresomeonemightwanttoassignaspecifictimeouttoawholesuiteoftestsunderapackagesuchaslongorshort.Butafterreviewingyourchanges,Ithinkitwouldbeclearertousethisformatfortheexamples:E.g.. / \ *Long. \ *.story:5000,. \ *Short. \ *.story:200ThisnewexamplewouldshowthatitsfairlyeasytoassignatimeouttoanytestswithLongorShortintheirnames.Essentiallykeepingtheexampleassimpleaspossibleandshowingusersthattheycansimplyuse.*formatchingwithstorypath.Thoughts? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time You're mixing two very different concerns here, configuration and monitoring. What matters is whether the path of the story we're running matches the regex patterns provided in the CSV of story timeouts. I'm looking into simplify your solution. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time After parsing the new Ant Task property useStoryTimeoutInSecsByPath, I want to ensure that each story path specified is a valid path. For example, suppose useStoryTimeoutInSecsByPath=*/test1.story:15,*/test2.story:77 and in this case test2.story is not a valid path (that story doesn't exist). To do this check, I used StoryFinder.findPaths(String searchIn, String include, String exclude) on line 325 of StoryManager.java. In order to use this method, I had to pass in the correct path to searchIn, which was already being conveniently determined in AbstractEmbedderTask.searchDirectory(), line 180. So in summary, I introduced this method in order to take advantage of AbstractEmbedderTask.searchDirectory(), which is accessible via the embedderMonitor field in StoryManager.java. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time Hi Christopher, finally got around to the patch. Can you please explain why you need to introduce the method public String getSearchDirectory() in the EmbedderMonitor? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title
Mauro Talevi edited a comment on an issue
Re: Provide a configurable timeout value for each story running time
HiChristopher,finallygotaroundtothepatch.Canyoupleaseexplainwhyyouneedtointroducethemethod{code}publicStringgetSearchDirectory(){code}intheEmbedderMonitor? Ifyouneedtoconfigureanything,itshouldnotbeinthemonitorclass.
Add Comment
JBehave / JBEHAVE-833
Provide a configurable timeout value for each story running time
When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together.
This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
-
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time no problem - no rush. thanks for confirming. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time Hi Christopher, yes, I've seen it thanks. I'll get to it by the end of this week. Cheers Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Mauro , just want to ensure you are aware of this Pull Request. No rush though - our team will eventually use this but it won't be right away. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Pull Request Sent for this!: https://github.com/jbehave/jbehave-core/pull/74 Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time FYI: I have been working on this for some time and am close to completion/submitting a pull request. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time How about if I implement this using a new Ant task such as: specificStoryTimeoutInSecs=*/Class1.java-500,/Class2.java-700,*/Class3.java-1. Format: specificStoryTimeoutInSecs=CSV of className-timeInSec Thoughts about this design? I cannot subscribe to the mailing lists so had to discuss here. I also thought about adding this somehow to the Config/Runner class for a specific story, but it would be easier to configure via a build.xml or pom. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time This features requires two main elements: configuration: add a configuration element similar to storyTimeoutInSecs, which we may call storyTimeoutInSecsByPath, which will override the default value in storyTimeoutInSecs, and can be expressed as a CSV of regex expressions matching story paths. E.g. */long/.story:5000,*/short/.story:200. Note that there are several places where the storyTimeoutInSecs is configured and an equivalent element needs to be added for storyTimeoutInSecsByPath (using the type String in place of long). implementation of logic: in StoryManager the story timeouts by paths need to be parsed and matched according to the story path being executed Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c)
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time To subscribe to the mailing lists you need to create a Codehaus account and then subscribe via the project site: http://xircles.codehaus.org/projects/jbehave Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Christopher Aguirre commented on an issue Re: Provide a configurable timeout value for each story running time Has this been resolved with JBEHAVE-1037 ? Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Title: Message Title Mauro Talevi commented on an issue Re: Provide a configurable timeout value for each story running time No, there is currently only one configured timeout value. Add Comment JBehave / JBEHAVE-833 Provide a configurable timeout value for each story running time When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. This message was sent by Atlassian JIRA (v6.1.6#6162-sha1:7af547c) - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
[jbehave-dev] [jira] (JBEHAVE-833) Provide a configurable timeout value for each story running time
Alexander Lehmann created JBEHAVE-833 Provide a configurable timeout value for each story running time Issue Type: Improvement Affects Versions: 4.x Assignee: Unassigned Components: Core Created: 10/Sep/12 6:16 PM Description: When running stories that may take a bit longer, e.g. web tests, a timeout value for each story would be useful as opposed to a timeout for all stories together. Project: JBehave Priority: Major Reporter: Alexander Lehmann This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
