Re: [PLEASE TEST] Apache Maven 3.0.2-RC1
In 6245a072-ee21-4b6a-87cf-1ce84ea4e...@apache.org Brett Porter wrote: http://jira.codehaus.org/browse/SCM-581 It isn't clear from the issue whether this is in the SCM provider (which is independent of Maven releases), or in Maven (in which case this is filed in the wrong place). Right. A few weeks ago I made a weak attempt to look into the source code of the scm module, but I found nothing obvious there that did something wrong with the url. Which component is it that actually parses the pom.xml and extracts the string from the scm/connection element? What is the difference in behaviour between Maven 2.2.1 and Maven 3.0? Is there a relevant MNG issue for that? In maven 2.2.1 you can use a scm url for mercurial that contains a absolute file path reference. In maven 3.x the absolute path is incorrectly converted to a relative path before it is handed over to hg. Mercurial then looks for the project in the wrong place and the release build checkout fails. Mercurial has a special non-standard url annotation of two consecutive slashes after the hostname, to separate relative paths from absolute paths: For example this scm url works in 2.2.1 but fails in 3.x: scm connectionscm:hg:ssh://localhost//opt/foo/connection /scm Above the double slashes after 'localhost' tells hg that the file path is absolute and in the file system located at '/opt/foo'. If the double slash is removed hg will instead search for the directory 'opt/foo' relative to the home directory of the user on the server, perhaps '/home/luser/opt/foo'. -- Fredrik Jonson - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PLEASE TEST] Apache Maven 3.0.2-RC1
Brett Porter wrote: http://jira.codehaus.org/browse/SCM-581 It isn't clear from the issue whether this is in the SCM provider (which is independent of Maven releases), or in Maven (in which case this is filed in the wrong place). I think I've actually tracked it down now, to the DefaultUrlNormalizer class in the module maven-model-builder, that indeed is a part of maven-core. The DefaultUrlNormalizer does the following to the element scm/connection: result = result.replaceAll( (?![:/])/+, / ); Which removes any double slash after the hostname part of a url. The normalization occurs when the release plugin doesn't find a ScmSourceUrl in the plugin descriptor. Instead MavenProject.getScm().getConnection() is used to retrieve a scm url. When that method returns the scm connection url is normalized and that all so important double slash is removed. It is also here somewhere I'm lost in the maze of maven-core again, sorry I can't pinpoint the issue better! -- Fredrik Jonson - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [PLEASE TEST] Apache Maven 3.0.2-RC1
So... about the double slashes issue SCM-581... I've opened a MNG-issue that contains a simplistic patch and a fix for the relevant test case too. The fix might be a bit invasive as it affects all url:s, not only the scm connection url. The alternative is perhaps to have a separate UrlNormalizer specificly for the scm connection. http://jira.codehaus.org/browse/MNG-4966 All other normal tests passes. I suppose the original code that removes the double slashes is there for a reason, avoiding http redirects perhaps? Anyone know? Oh, and the documentation mentions a profile for integration tests (-P run-its), but maven 3.0 tells me there is no such profile. http://maven.apache.org/guides/development/guide-building-m2.htm -- Fredrik Jonson - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[VOTE] Release Apache Maven 3.0.2
Hi, We solved 25 issues since 3.0.1: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=16952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-011/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-011/org/apache/maven/apache-maven/3.0.2/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [VOTE] Release Apache Maven 3.0.2
+1 On Sun, Jan 9, 2011 at 04:20, Benjamin Bentmann benjamin.bentm...@udo.eduwrote: Hi, We solved 25 issues since 3.0.1: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=16952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-011/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-011/org/apache/maven/apache-maven/3.0.2/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Best regards, Evgeny Mandrikov aka Godin http://godin.net.ru http://twitter.com/_godin_
Re: [VOTE] Release Apache Maven 3.0.2
+1 from me - everything seems to be looking good. -- Great artists are extremely selfish and arrogant things — Steven Wilson, Porcupine Tree On Sun, Jan 9, 2011 at 2:20 PM, Benjamin Bentmann benjamin.bentm...@udo.edu wrote: Hi, We solved 25 issues since 3.0.1: http://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500version=16952 There are still a couple of issues left in JIRA: http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=truepid=10500status=1 Staging repo: https://repository.apache.org/content/repositories/maven-011/ Staged source and binary distros: https://repository.apache.org/content/repositories/maven-011/org/apache/maven/apache-maven/3.0.2/ Guide to testing staged releases: http://maven.apache.org/guides/development/guide-testing-releases.html Vote open for 72 hours. [ ] +1 [ ] +0 [ ] -1 +1 from me Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
