Re: [VOTE] Release Apache Maven Release Plugin version 2.4.2

2013-10-30 Thread Sascha Vogt
Hi all,

Am 23.10.2013 21:52, schrieb Robert Scholte:
 Staging site:
 http://maven.apache.org/maven-release-archives/maven-release-2.4.2/maven-release-plugin/

As the plugin is released, shouldn't the site also be promoted?
http://maven.apache.org/maven-release/maven-release-plugin/ still schows
2.4.1

Greetings
-Sascha-

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Release Plugin version 2.4.2

2013-10-30 Thread Robert Scholte

I haven't finished the complete release process yet.
There seems to be some misconfiguration to publish/copy the staged docs to  
production.
So I need to fix that first before I'll update the plugins page and send  
the announcement.


I'm working on it.

Robert

Op Wed, 30 Oct 2013 16:48:02 +0100 schreef Sascha Vogt  
sascha.v...@gmail.com:



Hi all,

Am 23.10.2013 21:52, schrieb Robert Scholte:

Staging site:
http://maven.apache.org/maven-release-archives/maven-release-2.4.2/maven-release-plugin/


As the plugin is released, shouldn't the site also be promoted?
http://maven.apache.org/maven-release/maven-release-plugin/ still schows
2.4.1

Greetings
-Sascha-

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java

2013-10-30 Thread Olivier Lamy
On 31 October 2013 08:01,  tche...@apache.org wrote:
 Author: tchemit
 Date: Wed Oct 30 21:01:01 2013
 New Revision: 1537302

 URL: http://svn.apache.org/r1537302
 Log:
 MRAR-34 - provide skip parameter for the plugin

 Modified:
 
 maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java

 Modified: 
 maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
 URL: 
 http://svn.apache.org/viewvc/maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java?rev=1537302r1=1537301r2=1537302view=diff
 ==
 --- 
 maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
  (original)
 +++ 
 maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
  Wed Oct 30 21:01:01 2013
 @@ -265,12 +265,26 @@ public class RarMojo
  @Parameter( property = warnOnMissingRaXml, defaultValue = true )
  protected boolean warnOnMissingRaXml = true;

 +/**
 + * To skip execution of the rar mojo.
 + *
 + * @since 2.4
 + */
 +@Parameter( property = maven.rar.skip )
 +private boolean skip;
 +
  private File buildDir;


  public void execute()
  throws MojoExecutionException
  {
 +
 +if ( skip )
 +{
 +getLog().info( Skipping rar generation. );
 +}
 +

really skipping? :-)

  getLog().debug(  === RarMojo settings === );
  getLog().debug( rarSourceDirectory[ + rarSourceDirectory + ] );
  getLog().debug( manifestFile[ + manifestFile + ] );





-- 
Olivier Lamy
Ecetera: http://ecetera.com.au
http://twitter.com/olamy | http://linkedin.com/in/olamy

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java

2013-10-30 Thread Tony Chemit
On Thu, 31 Oct 2013 10:06:07 +1100
Olivier Lamy ol...@apache.org wrote:

 On 31 October 2013 08:01,  tche...@apache.org wrote:
  Author: tchemit
  Date: Wed Oct 30 21:01:01 2013
  New Revision: 1537302
 
  URL: http://svn.apache.org/r1537302
  Log:
  MRAR-34 - provide skip parameter for the plugin
 
  Modified:
  
  maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
 
  Modified: 
  maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
  URL: 
  http://svn.apache.org/viewvc/maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java?rev=1537302r1=1537301r2=1537302view=diff
  ==
  --- 
  maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
   (original)
  +++ 
  maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java
   Wed Oct 30 21:01:01 2013
  @@ -265,12 +265,26 @@ public class RarMojo
   @Parameter( property = warnOnMissingRaXml, defaultValue = true )
   protected boolean warnOnMissingRaXml = true;
 
  +/**
  + * To skip execution of the rar mojo.
  + *
  + * @since 2.4
  + */
  +@Parameter( property = maven.rar.skip )
  +private boolean skip;
  +
   private File buildDir;
 
 
   public void execute()
   throws MojoExecutionException
   {
  +
  +if ( skip )
  +{
  +getLog().info( Skipping rar generation. );
  +}
  +
 
 really skipping? :-)

my bad :( ...

 
   getLog().debug(  === RarMojo settings === );
   getLog().debug( rarSourceDirectory[ + rarSourceDirectory + ] );
   getLog().debug( manifestFile[ + manifestFile + ] );
 
 
 
 
 



-- 
Tony Chemit

tél: +33 (0) 2 40 50 29 28
http://www.codelutin.com
email: che...@codelutin.com
twitter: https://twitter.com/tchemit

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: svn commit: r1537302 - /maven/plugins/trunk/maven-rar-plugin/src/main/java/org/apache/maven/plugin/rar/RarMojo.java

2013-10-30 Thread Bernd Eckenfels

Am 31.10.2013, 00:06 Uhr, schrieb Olivier Lamy ol...@apache.org:

On 31 October 2013 08:01,  tche...@apache.org wrote:

+@Parameter( property = maven.rar.skip )
+private boolean skip;


Does it make sense to add a expression=${maven.rar.skip} (or maybe  
${skipMavenRar}?). Especially the skip function is usefull from the  
command line.


Bernd


+if ( skip )
+{
+getLog().info( Skipping rar generation. );
+}
+


really skipping? :-)


 getLog().debug(  === RarMojo settings === );
 getLog().debug( rarSourceDirectory[ + rarSourceDirectory +  
] );

 getLog().debug( manifestFile[ + manifestFile + ] );


Is there a best practise for printing parameters before or after early  
return?


Gruss
Bernd
--
http://www.zusammenkunft.net

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org