Re: Processing Pull Request
Am 2014-05-26 14:54, schrieb Daniel Kulp: On May 24, 2014, at 9:18 AM, Michael Osipov wrote: Hi, does it take special permissions on Github to process pull requests? Neither am I allowed to perform the merge from the website directly, nor does it display the command line steps as described in the GH help. Close is not available to me too. I simply pulled (PL 14) into my local repo and then pushed, asfgit processed but the PL is still on "merged" but not closed. Is there any writeup how a PL should happen in the project? Maven Git Convention [1] does not provide any valueable information. If it doesn’t auto close for whatever reason (likely a rebase or something), then you would need to put a comment on the pull request like: Can you verify that the functionality ha been merged correctly and close this if it has. or similar to get the requestor to close it. OR Make a simple commit with: This closes #14 in the log message and the asf bot will close it. OR File a request with INFRA to close it. In general, if you pull a pull request and it ends up rebating or similar so the sha1 is different, then you should likely do a “git -a —amend” and edit the commit message to to add the “This closes #XX” line to the message before you push. Hi Daniel, I have amended the last commit, see https://github.com/apache/maven/pull/14#ref-commit-0499d1d. But I have simply merged that PR manually and then pushed to git.apache.org. Thus, I cannot have an additional commit w/o doing bogus. There must be some better way to process PRs. The best solution is to produce a commit like this [1] but I do not have the knowledge how to perform this with git means. That's is why I have for an improvements of the docs. Michael [1] https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=bef7fac6e3495dae57a44e6a5902afd89c74b196 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [ANN] The Git branch for Maven 3.2.x has unreleased changes that look OK to release
good idea: there are a good number of little fixes and improvements that deserve a release, 3 monthes after the last one Regards, Hervé Le lundi 26 mai 2014 10:17:59 Stephen Connolly a écrit : > Are there plans for a 3.2.2 release any time soon? > > On 26 May 2014 03:54, Apache Jenkins Server wrote: > > This is an automated email to notify the Maven developer list that there > > are unreleased changes in the Maven 3.2.x GIT branch that have passed all > > the integration tests and are therefore potentially releasable. > > > > https://builds.apache.org/job/maven-3.2-release-status > > > > This email does not indicate whether the changes should be released, only > > that there is something that could be released. > > > > -Jenkins - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-scm pull request: [SCM-750]: support TFS checkin-policies
Github user asfgit closed the pull request at: https://github.com/apache/maven-scm/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Processing Pull Request
On May 24, 2014, at 9:18 AM, Michael Osipov wrote: > Hi, > > does it take special permissions on Github to process pull requests? > > Neither am I allowed to perform the merge from the website directly, nor does > it display the command line steps as described in the GH help. Close is not > available to me too. > > I simply pulled (PL 14) into my local repo and then pushed, asfgit processed > but the PL is still on "merged" but not closed. > > Is there any writeup how a PL should happen in the project? > Maven Git Convention [1] does not provide any valueable information. If it doesn’t auto close for whatever reason (likely a rebase or something), then you would need to put a comment on the pull request like: Can you verify that the functionality ha been merged correctly and close this if it has. or similar to get the requestor to close it. OR Make a simple commit with: This closes #14 in the log message and the asf bot will close it. OR File a request with INFRA to close it. In general, if you pull a pull request and it ends up rebating or similar so the sha1 is different, then you should likely do a “git -a —amend” and edit the commit message to to add the “This closes #XX” line to the message before you push. -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: [ANN] The Git branch for Maven 3.2.x has unreleased changes that look OK to release
Maybe next week. There are a few fixes that would be nice to make available, and a few more that should be fixed before the next release. On May 26, 2014, at 5:17 AM, Stephen Connolly wrote: > Are there plans for a 3.2.2 release any time soon? > > > On 26 May 2014 03:54, Apache Jenkins Server wrote: > >> This is an automated email to notify the Maven developer list that there >> are unreleased changes in the Maven 3.2.x GIT branch that have passed all >> the integration tests and are therefore potentially releasable. >> >> https://builds.apache.org/job/maven-3.2-release-status >> >> This email does not indicate whether the changes should be released, only >> that there is something that could be released. >> >> -Jenkins Thanks, Jason -- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io - A language that doesn’t affect the way you think about programming is not worth knowing. -- Alan Perlis
Re: [ANN] The Git branch for Maven 3.2.x has unreleased changes that look OK to release
Are there plans for a 3.2.2 release any time soon? On 26 May 2014 03:54, Apache Jenkins Server wrote: > This is an automated email to notify the Maven developer list that there > are unreleased changes in the Maven 3.2.x GIT branch that have passed all > the integration tests and are therefore potentially releasable. > > https://builds.apache.org/job/maven-3.2-release-status > > This email does not indicate whether the changes should be released, only > that there is something that could be released. > > -Jenkins
