Re: [VOTE] Release Apache Maven Archiver version 3.6.2

2024-03-25 Thread zhongming hua
+1

Olivier Lamy  于2024年3月26日周二 12:51写道:
>
> +1
>
> On Mon, 25 Mar 2024 at 08:36, Slawomir Jaranowski
>  wrote:
> >
> > Hi,
> >
> > We solved 3 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12353577
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-archiver
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-2076/
> > https://repository.apache.org/content/repositories/maven-2076/org/apache/maven/maven-archiver/3.6.2/maven-archiver-3.6.2-source-release.zip
> >
> > Source release checksum(s):
> > [NAME-OF]-source-release.zip sha512: [SHA512SUM]
>
> the sources doesn't match this checksum :P
>
> >
> > Staging site:
> > https://maven.apache.org/shared-archives/maven-archiver-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > --
> > Sławomir Jaranowski
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven GPG Plugin 3.2.2

2024-03-25 Thread zhongming hua
+1

Olivier Lamy  于2024年3月26日周二 12:49写道:
>
> +1
>
> On Sun, 24 Mar 2024 at 08:06, Tamás Cservenák  wrote:
> >
> > Howdy,
> >
> > Note: this is a bugfix release for
> > https://issues.apache.org/jira/browse/MGPG-113
> >
> > We solved 3 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521=12354419
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/projects/MGPG/issues
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-2075/
> >
> > Source release checksum SHA512:
> > 1bb3d9dbf6992ec58b6f08f8cd39d8f002c0ac7be4b7197bbb54057152824a400acebd77e6366e20c5d30a10575be1607e66bdf3a5667c2efef812826b877d8c
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Archiver version 3.6.2

2024-03-25 Thread Olivier Lamy
+1

On Mon, 25 Mar 2024 at 08:36, Slawomir Jaranowski
 wrote:
>
> Hi,
>
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12353577
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-archiver
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2076/
> https://repository.apache.org/content/repositories/maven-2076/org/apache/maven/maven-archiver/3.6.2/maven-archiver-3.6.2-source-release.zip
>
> Source release checksum(s):
> [NAME-OF]-source-release.zip sha512: [SHA512SUM]

the sources doesn't match this checksum :P

>
> Staging site:
> https://maven.apache.org/shared-archives/maven-archiver-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> --
> Sławomir Jaranowski

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven GPG Plugin 3.2.2

2024-03-25 Thread Olivier Lamy
+1

On Sun, 24 Mar 2024 at 08:06, Tamás Cservenák  wrote:
>
> Howdy,
>
> Note: this is a bugfix release for
> https://issues.apache.org/jira/browse/MGPG-113
>
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521=12354419
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MGPG/issues
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2075/
>
> Source release checksum SHA512:
> 1bb3d9dbf6992ec58b6f08f8cd39d8f002c0ac7be4b7197bbb54057152824a400acebd77e6366e20c5d30a10575be1607e66bdf3a5667c2efef812826b877d8c
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Relax resolver for snapshots in offline mode

2024-03-25 Thread Delany
Hi,

I have a bunch of plugins like enforcer that I want to run with `mvn
validate -o` but I get
Cannot access *repo* in offline mode and the artifact
*artifact*:jar:2.4.1-20240322.141808-12 has not been downloaded from it
before

There are snapshots of that artifact available in local maven repo, just
not that specific one.
I thought changing the updatePolicy to NEVER would solve this, but the new
enforcer (which now uses resolver) fails nonetheless.

Is there a way to get resolver to treat all snapshots as equal in offline
mode? Is there a reason this isn't the default?

Thanks,
Delany


Re: [VOTE] Release Apache Maven Archiver version 3.6.2

2024-03-25 Thread Sylwester Lachiewicz
+1

pon., 25 mar 2024, 08:45 użytkownik Herve Boutemy 
napisał:

> +1
>
> Reproducible Build ok: reference done with JDK 21 on *nix and umask=022
>
> Regards,
>
> Hervé
>
> On 2024/03/24 22:36:30 Slawomir Jaranowski wrote:
> > Hi,
> >
> > We solved 3 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12353577
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-archiver
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-2076/
> >
> https://repository.apache.org/content/repositories/maven-2076/org/apache/maven/maven-archiver/3.6.2/maven-archiver-3.6.2-source-release.zip
> >
> > Source release checksum(s):
> > [NAME-OF]-source-release.zip sha512: [SHA512SUM]
> >
> > Staging site:
> > https://maven.apache.org/shared-archives/maven-archiver-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > --
> > Sławomir Jaranowski
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>


Re: Revert commit 740dae43ca3ccf7692f37edf3184387e5666ca6b

2024-03-25 Thread Hervé Boutemy
Hi Konrad,

I saw the fork between Maven 3.9.x where I started the documentation job and 
Maven 4:

- Maven 3.9.x: https://github.com/apache/maven/pull/1444
as you can see, requiredMavenVersion exists since 3.0.2
https://issues.apache.org/jira/browse/MNG-4840

- Maven 4: https://github.com/apache/maven/pull/1445
yes, I had to merge and saw you did some improvements

AFAIK, in Maven 4, only requiredJavaVersion was added
what is not clear to me is that it seeems you updated the semantics fo 
requiredMavenVersion in plugin descriptor to be better

i see you found https://github.com/apache/maven/pull/1444 , let's continue the 
discussion here, as I don't know where the issue is yet, but sure, we need to 
clarify

Regards,

Hervé

Le lundi 25 mars 2024, 07:43:18 CET Konrad Windszus a écrit :
> Hi,
> I consider
> https://github.com/apache/maven/commit/740dae43ca3ccf7692f37edf3184387e5666
> ca6b wrong, as in fact the field requiredMavenVersion has been added quite
> recently and is only supported since Maven 4 (for details refer to
> https://issues.apache.org/jira/browse/MNG-7570). The referenced ticket
> https://issues.apache.org/jira/browse/MNG-4840 is only about the
> prerequisites section in the POM. Herve can you revert please? I propose to
> use PRs (even for changes like this) to prevent mistakes like this. Thanks,
> Konrad
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven Archiver version 3.6.2

2024-03-25 Thread Herve Boutemy
+1

Reproducible Build ok: reference done with JDK 21 on *nix and umask=022

Regards,

Hervé

On 2024/03/24 22:36:30 Slawomir Jaranowski wrote:
> Hi,
> 
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922=12353577
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MSHARED%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20maven-archiver
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2076/
> https://repository.apache.org/content/repositories/maven-2076/org/apache/maven/maven-archiver/3.6.2/maven-archiver-3.6.2-source-release.zip
> 
> Source release checksum(s):
> [NAME-OF]-source-release.zip sha512: [SHA512SUM]
> 
> Staging site:
> https://maven.apache.org/shared-archives/maven-archiver-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 
> -- 
> Sławomir Jaranowski
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: [VOTE] Release Apache Maven GPG Plugin 3.2.2

2024-03-25 Thread Herve Boutemy
+1

Reproducible Build ok: reference done with JDK 21 on *nix and umask=022

Regards,

Hervé

On 2024/03/23 22:06:12 Tamás Cservenák wrote:
> Howdy,
> 
> Note: this is a bugfix release for
> https://issues.apache.org/jira/browse/MGPG-113
> 
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317521=12354419
> 
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/projects/MGPG/issues
> 
> Staging repo:
> https://repository.apache.org/content/repositories/maven-2075/
> 
> Source release checksum SHA512:
> 1bb3d9dbf6992ec58b6f08f8cd39d8f002c0ac7be4b7197bbb54057152824a400acebd77e6366e20c5d30a10575be1607e66bdf3a5667c2efef812826b877d8c
> 
> Staging site:
> https://maven.apache.org/plugins-archives/maven-gpg-plugin-LATEST/
> 
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
> 
> Vote open for at least 72 hours.
> 
> [ ] +1
> [ ] +0
> [ ] -1
> 

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: release of maven-source-plugin

2024-03-25 Thread Hervé Boutemy
PR ready for review:
https://github.com/apache/maven-source-plugin/pull/24

I think it does the right job at differentiating 2 cases that the initial 
MSOURCES-121 merged too aggressively:
1. do not fail when executed twice with the same output file
2. but fail when re-attach happens to another output file = another classifier 
has to be configured

Regards,

Hervé

Le lundi 25 mars 2024, 07:31:53 CET Hervé Boutemy a écrit :
> IIUC, this is an explanation of the mystery failure that started the
> MSOURCE-121 update
> 
> but after MSOURCE-121, the plugin itself stops with a failure when detecting
> re-addition: that's why Gary can't upgrade, the failure is now happening at
> plugin level, and always
> "mvn install deploy" (with source enabled) is a simple test to see the
> failure introduced by MSOURCE-121
> 
> I'm starting to understand the many aspects of this issue: I think I know
> how to update the goal to be more tolerant
> 
> Thanks for the help
> 
> Hervé
> 
> Le dimanche 24 mars 2024, 20:39:55 CET Romain Manni-Bucau a écrit :
> > Hi,
> > 
> > I think it is fixed for v4 serie.
> > Main issue comes from the default v3 pom (
> > https://github.com/apache/maven/blob/maven-3.9.2/maven-model-builder/src/m
> > ai n/resources/org/apache/maven/model/pom-4.0.0.xml#L113) which is no more
> > a thing in v4 so the merge of the plugin executions does not happen the
> > same and the issue disappeared.
> > The easiest is likely to either let the default be merged and not use
> > "jar"
> > (implicit jar-no-fork instead) or just not use the default id
> > (attach-sources) and skip the default one.
> > 
> > So there is no source plugin issue (as the plugin will never fix it by
> > "bug
> > design") so no reason to hold a release IMHO.
> > 
> > Guess it silently overrided the already built artifact for years - until
> > we
> > just fail cause it is a broken design - after this change of goal
> > https://issues.apache.org/jira/browse/MNG-5940.
> > 
> > So long story short: we are on track and release can be done I think.
> > 
> > Romain Manni-Bucau
> > @rmannibucau  |  Blog
> >  | Old Blog
> >  | Github
> > > 
> > | LinkedIn  | Book
> > 
> >  > ce
> > 
> > 
> > 
> > Le dim. 24 mars 2024 à 18:44, Gary Gregory  a
> > 
> > écrit :
> > > Hi All,
> > > 
> > > As long as https://issues.apache.org/jira/browse/MSOURCES-143 is in
> > > play, Commons will stay on a pre-3.3.0 version.
> > > 
> > > I re-read the comments, I still don't know what we can do in Commons
> > > to address this as this feels like some deep Maven Magic.
> > > 
> > > Gary
> > > 
> > > On Sun, Mar 24, 2024 at 11:48 AM Hervé Boutemy 
> > > 
> > > wrote:
> > > > I'd like to release maven-source-plugin 3.3.1 to drop the umask
> > > 
> > > sensitivity
> > > 
> > > > during Reproducible Builds :)1
> > > > 
> > > > but there are a few issues open
> > > > 
> > > >  https://issues.apache.org/jira/projects/MSOURCES/versions/12353471
> > > > 
> > > > they are related to https://issues.apache.org/jira/browse/
MSOURCES-121:
> > > I
> > > 
> > > > don't get what conditions made the build fail previously, but
> > > 
> > > MSOURCES-121
> > > 
> > > > make it fail now always.
> > > > Should we just change the ERROR into WARNING?
> > > > Should we do something smarter, for example not re-add if it's the
> > > > same
> > > 
> > > file?
> > > 
> > > > Or warn only if the second file addition is different from the first?
> > > 
> > > Then
> > > 
> > > > replace instead of add?
> > > > 
> > > > Please help clarifying and fixing this issue that seems ignored for a
> > > 
> > > long time
> > > 
> > > > Regards,
> > > > 
> > > > Hervé
> > > > 
> > > > 
> > > > 
> > > > -
> > > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > > For additional commands, e-mail: dev-h...@maven.apache.org
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Revert commit 740dae43ca3ccf7692f37edf3184387e5666ca6b

2024-03-25 Thread Konrad Windszus
Hi,
I consider 
https://github.com/apache/maven/commit/740dae43ca3ccf7692f37edf3184387e5666ca6b 
wrong, as in fact the field requiredMavenVersion has been added quite recently 
and is only supported since Maven 4 (for details refer to 
https://issues.apache.org/jira/browse/MNG-7570).
The referenced ticket https://issues.apache.org/jira/browse/MNG-4840 is only 
about the prerequisites section in the POM.
Herve can you revert please? I propose to use PRs (even for changes like this) 
to prevent mistakes like this.
Thanks,
Konrad
-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



Re: release of maven-source-plugin

2024-03-25 Thread Hervé Boutemy
IIUC, this is an explanation of the mystery failure that started the 
MSOURCE-121 update

but after MSOURCE-121, the plugin itself stops with a failure when detecting 
re-addition: that's why Gary can't upgrade, the failure is now happening at 
plugin level, and always
"mvn install deploy" (with source enabled) is a simple test to see the failure 
introduced by MSOURCE-121

I'm starting to understand the many aspects of this issue: I think I know how 
to update the goal to be more tolerant

Thanks for the help

Hervé

Le dimanche 24 mars 2024, 20:39:55 CET Romain Manni-Bucau a écrit :
> Hi,
> 
> I think it is fixed for v4 serie.
> Main issue comes from the default v3 pom (
> https://github.com/apache/maven/blob/maven-3.9.2/maven-model-builder/src/mai
> n/resources/org/apache/maven/model/pom-4.0.0.xml#L113) which is no more a
> thing in v4 so the merge of the plugin executions does not happen the same
> and the issue disappeared.
> The easiest is likely to either let the default be merged and not use "jar"
> (implicit jar-no-fork instead) or just not use the default id
> (attach-sources) and skip the default one.
> 
> So there is no source plugin issue (as the plugin will never fix it by "bug
> design") so no reason to hold a release IMHO.
> 
> Guess it silently overrided the already built artifact for years - until we
> just fail cause it is a broken design - after this change of goal
> https://issues.apache.org/jira/browse/MNG-5940.
> 
> So long story short: we are on track and release can be done I think.
> 
> Romain Manni-Bucau
> @rmannibucau  |  Blog
>  | Old Blog
>  | Github 
> | LinkedIn  | Book
>  >
> 
> 
> Le dim. 24 mars 2024 à 18:44, Gary Gregory  a
> 
> écrit :
> > Hi All,
> > 
> > As long as https://issues.apache.org/jira/browse/MSOURCES-143 is in
> > play, Commons will stay on a pre-3.3.0 version.
> > 
> > I re-read the comments, I still don't know what we can do in Commons
> > to address this as this feels like some deep Maven Magic.
> > 
> > Gary
> > 
> > On Sun, Mar 24, 2024 at 11:48 AM Hervé Boutemy 
> > 
> > wrote:
> > > I'd like to release maven-source-plugin 3.3.1 to drop the umask
> > 
> > sensitivity
> > 
> > > during Reproducible Builds :)1
> > > 
> > > but there are a few issues open
> > > 
> > >  https://issues.apache.org/jira/projects/MSOURCES/versions/12353471
> > > 
> > > they are related to https://issues.apache.org/jira/browse/MSOURCES-121:
> > I
> > 
> > > don't get what conditions made the build fail previously, but
> > 
> > MSOURCES-121
> > 
> > > make it fail now always.
> > > Should we just change the ERROR into WARNING?
> > > Should we do something smarter, for example not re-add if it's the same
> > 
> > file?
> > 
> > > Or warn only if the second file addition is different from the first?
> > 
> > Then
> > 
> > > replace instead of add?
> > > 
> > > Please help clarifying and fixing this issue that seems ignored for a
> > 
> > long time
> > 
> > > Regards,
> > > 
> > > Hervé
> > > 
> > > 
> > > 
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > 
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org





-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org