RE: [GitHub] maven-plugins pull request #91: MCHANGES-373

[Mikael Petterson]

Hi,

My mistake :-)

Br,

//mikael



-Original Message-
From: Benedikt Ritter [mailto:brit...@apache.org] 
Sent: den 7 september 2016 11:36
To: Maven Developers List <dev@maven.apache.org>
Subject: Re: [GitHub] maven-plugins pull request #91: MCHANGES-373

Hello Mikael,

Michael Osipov has asked two times why the change set shows the whole class as 
changed. So there has been feedback.

Regards,
Benedikt

Mikael Petterson <mikael.petter...@ericsson.com> schrieb am Mi., 7. Sep.
2016 um 08:08 Uhr:

> Hi,
>
> Is there no one that can help out with my pull request or is the 
> maven-changes plugin "dead"?
> We really need this fix to be able to use the plugin. And also we want 
> to be able to help out.
> It is a bit frustrating when nothing happens
>
> //mikael
>
>
> -Original Message-
> From: Mikael Petterson [mailto:mikael.petter...@ericsson.com]
> Sent: den 5 september 2016 14:48
> To: Maven Developers List <dev@maven.apache.org>
> Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> Hi,
>
> Just a friendly reminder to review code and if ok commit.
>
> Br,
>
> //mikael
>
> -Original Message-
> From: mpet [mailto:g...@git.apache.org]
> Sent: den 29 augusti 2016 13:51
> To: dev@maven.apache.org
> Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373
>
> GitHub user mpet opened a pull request:
>
> https://github.com/apache/maven-plugins/pull/91
>
> MCHANGES-373
>
>
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/mpet/maven-plugins MCHANGES-373
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/maven-plugins/pull/91.patch
>
> To close this pull request, make a commit to your master/trunk branch 
> with (at least) the following in the commit message:
>
> This closes #91
>
> 
> commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
> Author: mike <mikaelpetter...@hotmail.com>
> Date:   2016-08-29T11:39:24Z
>
> MCHANGES-373
>
> 
>
>
> ---
> If your project is set up for it, you can reply to this email and have 
> your reply appear on GitHub as well. If your project does not have 
> this feature enabled and wishes so, or if the feature is enabled but 
> not working, please contact infrastructure at 
> infrastruct...@apache.org or file a JIRA ticket with INFRA.
> ---
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For 
> additional commands, e-mail: dev-h...@maven.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For 
> additional commands, e-mail: dev-h...@maven.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For 
> additional commands, e-mail: dev-h...@maven.apache.org
>
>

RE: [GitHub] maven-plugins pull request #91: MCHANGES-373

[Mikael Petterson]

Hi,

Is there no one that can help out with my pull request or is the maven-changes 
plugin "dead"?
We really need this fix to be able to use the plugin. And also we want to be 
able to help out.
It is a bit frustrating when nothing happens

//mikael


-Original Message-----
From: Mikael Petterson [mailto:mikael.petter...@ericsson.com] 
Sent: den 5 september 2016 14:48
To: Maven Developers List <dev@maven.apache.org>
Subject: RE: [GitHub] maven-plugins pull request #91: MCHANGES-373

Hi,

Just a friendly reminder to review code and if ok commit.

Br,

//mikael

-Original Message-
From: mpet [mailto:g...@git.apache.org]
Sent: den 29 augusti 2016 13:51
To: dev@maven.apache.org
Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373

GitHub user mpet opened a pull request:

https://github.com/apache/maven-plugins/pull/91

MCHANGES-373



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mpet/maven-plugins MCHANGES-373

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/91.patch

To close this pull request, make a commit to your master/trunk branch with (at 
least) the following in the commit message:

This closes #91


commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
Author: mike <mikaelpetter...@hotmail.com>
Date:   2016-08-29T11:39:24Z

MCHANGES-373




---
If your project is set up for it, you can reply to this email and have your 
reply appear on GitHub as well. If your project does not have this feature 
enabled and wishes so, or if the feature is enabled but not working, please 
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with 
INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional 
commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional 
commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

RE: [GitHub] maven-plugins pull request #91: MCHANGES-373

[Mikael Petterson]

Hi,

Just a friendly reminder to review code and if ok commit.

Br,

//mikael

-Original Message-
From: mpet [mailto:g...@git.apache.org] 
Sent: den 29 augusti 2016 13:51
To: dev@maven.apache.org
Subject: [GitHub] maven-plugins pull request #91: MCHANGES-373

GitHub user mpet opened a pull request:

https://github.com/apache/maven-plugins/pull/91

MCHANGES-373



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mpet/maven-plugins MCHANGES-373

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/maven-plugins/pull/91.patch

To close this pull request, make a commit to your master/trunk branch with (at 
least) the following in the commit message:

This closes #91


commit 699dd3bf3649c150913a0dd1eda25966bc6f6f1c
Author: mike 
Date:   2016-08-29T11:39:24Z

MCHANGES-373




---
If your project is set up for it, you can reply to this email and have your 
reply appear on GitHub as well. If your project does not have this feature 
enabled and wishes so, or if the feature is enabled but not working, please 
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with 
INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional 
commands, e-mail: dev-h...@maven.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

RE: Help to submit fix in maven-changes-plugin

[Mikael Petterson]

Hi,

I have now created a pull request for it:

https://github.com/apache/maven-plugins/pull/91

What will happen now?

Br,

//mikael

-Original Message-
From: Tibor Digana [mailto:tibordig...@apache.org] 
Sent: den 28 augusti 2016 11:09
To: dev@maven.apache.org
Subject: Re: Help to submit fix in maven-changes-plugin

Mikael, your patch should appear in
https://github.com/apache/maven-plugins/pulls
Many people do this.
Please read tutorial on GitHub to push a new pull request.

On 8/28/16, Mikael Petterson [via Maven] 
<ml-node+s40175n5878947...@n5.nabble.com> wrote:
>
>
> Hi,
>
> We are trying to use 2.12 of this plugin.
>
> I notice that the filter that we set in not applied at all.
>
> I found the following bug report:
>
> MCHANGES-373: It is not possible to use "filter" parameter
>
> I checked code and I can see that the jql query is missing the filter 
> parameter to be set in the builder.
> Easy fix.
>
> I checked out the code:
>
> https://github.com/apache/maven-plugins
>
> I changed the code.
>
> How can I submit a patch and integrate it and test it? Make a release 2.13.
> What is the process? Is there a guide?
>
> Br,
>
> //mikael
>
>
>
>
>
>
>
>
> ___
> If you reply to this email, your message will be added to the 
> discussion
> below:
> http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-p
> lugin-tp5878947.html To start a new topic under Maven Developers, 
> email
> ml-node+s40175n142166...@n5.nabble.com
> To unsubscribe from Maven Developers, visit 
> http://maven.40175.n5.nabble.com/template/NamlServlet.jtp?macro=unsubs
> cribe_by_code=142166=dGlib3JkaWdhbmFAYXBhY2hlLm9yZ3wxNDIxNjZ
> 8LTI4OTQ5MjEwMg==


--
Cheers
Tibor




--
View this message in context: 
http://maven.40175.n5.nabble.com/Help-to-submit-fix-in-maven-changes-plugin-tp5878947p5878960.html
Sent from the Maven Developers mailing list archive at Nabble.com.

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Help to submit fix in maven-changes-plugin

[Mikael Petterson]

Hi,

We are trying to use 2.12 of this plugin.

I notice that the filter that we set in not applied at all.

I found the following bug report:

MCHANGES-373: It is not possible to use "filter" parameter

I checked code and I can see that the jql query is missing the filter parameter 
to be set in the builder.
Easy fix.

I checked out the code:

https://github.com/apache/maven-plugins

I changed the code.

How can I submit a patch and integrate it and test it? Make a release 2.13. 
What is the process? Is there a guide?

Br,

//mikael