[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...

2017-07-19 Thread etzelc
Github user etzelc commented on the issue:

https://github.com/apache/maven-integration-testing/pull/23
  
Thanks for your testing effort. I am surprised both tests pass in your 
Windows environment with 3.5.0. I tested the IT with two different clients 
(Windows 7 and Windows 10) and while `folder-with- -space/pom.xml` passes, the 
`folder-with-)-closing-bracket/pom.xml` test fails. 
The `folder-with- -space/pom.xml` test was developed to cover MNG-6177 
(https://issues.apache.org/jira/browse/MNG-6177), which has no IT and was 
already targeting "special" characters like spaces and more.

I have implemented the IT in a way to perform a successful maven run, since 
this is what you usually expect from maven. The example `mvn -f 
"folderWithClosing)Bracket/pomFolder"` from issue MNG-6256 
(https://issues.apache.org/jira/browse/MNG-6256) was chosen to have a very 
short example with no prerequisites. With 3.5.0 you should see the same error 
even if a well formed POM exist at the specified location and you set 
additionally a goal (see IT test `folder-with-)-closing-bracket/pom.xml`).
I did not implement a dedicated test for the error message, because it may 
change over the time and the purpose of my patch was not to have a correct 
error message (which is included in the patch implicitly), but have a 
successful maven run.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



[GitHub] maven-integration-testing issue #23: [MNG-6265] Integration test for Maven s...

2017-07-17 Thread Tunaki
Github user Tunaki commented on the issue:

https://github.com/apache/maven-integration-testing/pull/23
  
I ran the IT with 3.5.0 on Windows, but it passed. Since the issue resolves 
around the error message that is printed on the console, I think the two files 
`folder-with- -space/pom.xml` and `folder-with-)-closing-bracket/pom.xml` 
should be removed, and instead it should be tested that the correct error 
message is printed, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org