[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 @Tibor17 Wouldn't it be better to rebase junit5 branch onto master? I don't have push access to maven-surefire, so you would have to do the trick. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Finally please merge master to junit5 branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 Okay, this is reintegrated. I will fix it in another PR. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter The only problem is with workspace for the `Junit4VersionsIT` which is `/target/Junit4VersionsIT_testJunit` same for all parameters. Therefore we should not take the only single parameter for `unpack( "/junit4" );`. There should be used a suffix as the second parameter which segregates the workspaces by parameterized runner. You may fix it in a new PR. This would be helpful in order we want to download a zip of workspaces in Jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/126 @britter Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #126: Make Junit4VersionsIT parameterized
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/126 We need to rebase the junit5 branch after this has been merged in order to pick up this changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
