[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user mgreau commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter Hi FYI I have create a PR (#146) to finalize the updates proposed by @marcphilipp At @exoplatform we are working on UI automation tests with Maven JUnit5 and Selenide, so let me know how I can help on the maven-surefire:3.0.0 version ð Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @sbrannen It looks like we will rename 2.19.2 to 2.20.0, but this is not official yet. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user sbrannen commented on the issue: https://github.com/apache/maven-surefire/pull/142 Very happy to hear that the Surefire team has taken over the provider for the JUnit Platform!!! Thanks! ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user sbrannen commented on the issue: https://github.com/apache/maven-surefire/pull/142 @marcphilipp, 2.19.2 will support "*Tests" by default as well: https://twitter.com/sam_brannen/status/766979129954570240 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 awesome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter @marcphilipp Done. We are preparing a new release version of Maven and Surefire was examined last days. We still investigate some issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 Thank you! I will continue then with the detection code in ABstractSurefireMojo. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter Sure I will do it, no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 @Tibor17 this PR is for 3.0-rc1 branch not for master. Can't we integrate it into 3.0-rc1 branch right away? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/142 @britter LGTM We have to wait for release 2.19.2. After that I will squash previous changes into one and commit to master which will be 3.0 RC1. Meanwhile we can continue on both branches, means this 3.0-rc1 and junit5 integration tests. I am pushed two other branches which were reverted before and one more is pending. So I am in progress as well and I hope the Maven colleagues would give me go-ahead and finalize release 2.19.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user britter commented on the issue: https://github.com/apache/maven-surefire/pull/142 Resolved comments by @marcphilipp WDYT @Tibor17? Looks good for merge? behavior of surefire is currently not changed since we don't have automatic look up code. Would like to implement this on a separate branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
[GitHub] maven-surefire issue #142: SUREFIRE-1330: Import provider code donated by JU...
Github user marcphilipp commented on the issue: https://github.com/apache/maven-surefire/pull/142 > It may be possible to the the tests running by explicitly declaring the already released provider by the JUnit team as described in their documentation. I gave that a try but was unable to get it working. Did you change the include pattern? I think Surefire only not pickup `*Tests` by default (see http://maven.apache.org/components/surefire/maven-surefire-plugin/test-mojo.html#includes). > @marcphilipp please let us know who we should attribute this donation to. Please use the list in junit-team/junit5#541. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
