MPMD-192: Just skip the IT with Maven 2.2.1
Hello everybody. I am really out of ideas here. MPMD-89 is a test to ensure that test classes whose name *does not* end on Test are recognized as tests by inspecting their inheritage. I do not think that this is a a major use case. Succeeds with Maven = 3, but fails with Maven 2.2.1. I have spent 6 hours, downloaded PMD itself and ran it on the CLI. PMD 5.2.1 did not detect the errors from the CLI either. PMD 5.1.2 did, so users of the maven plugin are even better off as long as the use Maven = 3. To get maven-pmd-plugin-3.3 out of the door I would like to skip this test for Maven 2.2.1 by means of invoker.properties. I would guess anyone still using Maven 2.2.1 does not need the JDK 8 ability of PMD 5.2.1 and should either stay with maven-pmd-plugin-3.2 or adapt her test cases. I would reference MPMD-192 in MPMD-89. What do you think? Regards Mirko http://jira.codehaus.org/browse/MPMD-192 http://jira.codehaus.org/browse/MPMD-89 -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/ - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: MPMD-192: Just skip the IT with Maven 2.2.1
Am 2014-11-13 um 22:01 schrieb Mirko Friedenhagen: Hello everybody. I am really out of ideas here. MPMD-89 is a test to ensure that test classes whose name *does not* end on Test are recognized as tests by inspecting their inheritage. I do not think that this is a a major use case. Succeeds with Maven = 3, but fails with Maven 2.2.1. I have spent 6 hours, downloaded PMD itself and ran it on the CLI. PMD 5.2.1 did not detect the errors from the CLI either. PMD 5.1.2 did, so users of the maven plugin are even better off as long as the use Maven = 3. To get maven-pmd-plugin-3.3 out of the door I would like to skip this test for Maven 2.2.1 by means of invoker.properties. I would guess anyone still using Maven 2.2.1 does not need the JDK 8 ability of PMD 5.2.1 and should either stay with maven-pmd-plugin-3.2 or adapt her test cases. I would reference MPMD-192 in MPMD-89. What do you think? +1. Especially I would guess anyone still using Maven 2.2.1 does not need the JDK 8... Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: MPMD-192: Just skip the IT with Maven 2.2.1
Hi Mirko, sounds good to me.. Go for it... On 11/13/14 10:01 PM, Mirko Friedenhagen wrote: Hello everybody. I am really out of ideas here. MPMD-89 is a test to ensure that test classes whose name *does not* end on Test are recognized as tests by inspecting their inheritage. I do not think that this is a a major use case. Succeeds with Maven = 3, but fails with Maven 2.2.1. I have spent 6 hours, downloaded PMD itself and ran it on the CLI. PMD 5.2.1 did not detect the errors from the CLI either. PMD 5.1.2 did, so users of the maven plugin are even better off as long as the use Maven = 3. To get maven-pmd-plugin-3.3 out of the door I would like to skip this test for Maven 2.2.1 by means of invoker.properties. I would guess anyone still using Maven 2.2.1 does not need the JDK 8 ability of PMD 5.2.1 and should either stay with maven-pmd-plugin-3.2 or adapt her test cases. I would reference MPMD-192 in MPMD-89. What do you think? Kind Regards Karl Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
