Re: [JAVA 9] Need for review of branch SUREFIRE-1403

[Enrico Olivelli]

Il mar 15 ago 2017, 14:25 Tibor Digana  ha
scritto:

> Ok guys, I am glad too that you are satisfied, so I will push the branch to
> master, and thank you very much for working with me.
> Enrico, I know that you are on vacation right now but I would like to
> kindly ask you to join us on IRC channel, maybe after your vacation.
>
Can you give me the address? I can use my phone. Today I am at home and I
had the opportunity to use my laptop

Enrico

Thx.
>
> On Tue, Aug 15, 2017 at 2:07 PM, Enrico Olivelli 
> wrote:
>
> > +1 for me
> > I have checked out branch SUREFIRE-1403 and I was able to run tests of an
> > application which uses java.sql.Timestamp without changes in code, just
> but
> > upgrading surefire to 21.1-SNAPSHOT
> >
> > Unfortunately I do not use the failsafe plugin so I have to real world
> > project to test
> >
> > I did a brief review on code and it looks good to me
> >
> >
> > Thank you very much Tibor
> >
> > -- Enrico
> >
> >
> > 2017-08-15 0:12 GMT+02:00 Robert Scholte :
> >
> > > +1
> > >
> > > This is looking good.
> > >
> > > Robert
> > >
> > > On Mon, 14 Aug 2017 20:34:11 +0200, Tibor Digana <
> > > tibor.dig...@googlemail.com> wrote:
> > >
> > > Hi devs,
> > >>
> > >> I would like to push the branch and Jira ticket *SUREFIRE-1403* which
> > >> enables Surefire and Failsafe on Java 9.
> > >>
> > >> If you have a little spare time pls start review.
> > >>
> > >> Thx.
> > >>
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > > For additional commands, e-mail: dev-h...@maven.apache.org
> > >
> > >
> >
>
>
>
> --
> Cheers
> Tibor
>
-- 


-- Enrico Olivelli

Re: [JAVA 9] Need for review of branch SUREFIRE-1403

[Tibor Digana]

Ok guys, I am glad too that you are satisfied, so I will push the branch to
master, and thank you very much for working with me.
Enrico, I know that you are on vacation right now but I would like to
kindly ask you to join us on IRC channel, maybe after your vacation.
Thx.

On Tue, Aug 15, 2017 at 2:07 PM, Enrico Olivelli 
wrote:

> +1 for me
> I have checked out branch SUREFIRE-1403 and I was able to run tests of an
> application which uses java.sql.Timestamp without changes in code, just but
> upgrading surefire to 21.1-SNAPSHOT
>
> Unfortunately I do not use the failsafe plugin so I have to real world
> project to test
>
> I did a brief review on code and it looks good to me
>
>
> Thank you very much Tibor
>
> -- Enrico
>
>
> 2017-08-15 0:12 GMT+02:00 Robert Scholte :
>
> > +1
> >
> > This is looking good.
> >
> > Robert
> >
> > On Mon, 14 Aug 2017 20:34:11 +0200, Tibor Digana <
> > tibor.dig...@googlemail.com> wrote:
> >
> > Hi devs,
> >>
> >> I would like to push the branch and Jira ticket *SUREFIRE-1403* which
> >> enables Surefire and Failsafe on Java 9.
> >>
> >> If you have a little spare time pls start review.
> >>
> >> Thx.
> >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> > For additional commands, e-mail: dev-h...@maven.apache.org
> >
> >
>



-- 
Cheers
Tibor

Re: [JAVA 9] Need for review of branch SUREFIRE-1403

[Enrico Olivelli]

+1 for me
I have checked out branch SUREFIRE-1403 and I was able to run tests of an
application which uses java.sql.Timestamp without changes in code, just but
upgrading surefire to 21.1-SNAPSHOT

Unfortunately I do not use the failsafe plugin so I have to real world
project to test

I did a brief review on code and it looks good to me


Thank you very much Tibor

-- Enrico


2017-08-15 0:12 GMT+02:00 Robert Scholte :

> +1
>
> This is looking good.
>
> Robert
>
> On Mon, 14 Aug 2017 20:34:11 +0200, Tibor Digana <
> tibor.dig...@googlemail.com> wrote:
>
> Hi devs,
>>
>> I would like to push the branch and Jira ticket *SUREFIRE-1403* which
>> enables Surefire and Failsafe on Java 9.
>>
>> If you have a little spare time pls start review.
>>
>> Thx.
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: [JAVA 9] Need for review of branch SUREFIRE-1403

[Robert Scholte]

+1

This is looking good.

Robert

On Mon, 14 Aug 2017 20:34:11 +0200, Tibor Digana  
 wrote:



Hi devs,

I would like to push the branch and Jira ticket *SUREFIRE-1403* which
enables Surefire and Failsafe on Java 9.

If you have a little spare time pls start review.

Thx.


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org