Re: svn commit: r1753099 - in /maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features: simple-dir-format/ this & that/

2016-07-18 Thread Guillaume Boué 
Hi,

It turns out there is a bug inside mvn.cmd when evaluating the working
directory with %CD%: this needs to be escaped by enclosing the "set var"
declaration in double quotes. I tested with the mvn.cmd of the latest
3.4.0-SNAPSHOT and this is apparently already fixed (MNG-5962). I reverted
the commit.

Thanks,
Guillaume

2016-07-17 22:50 GMT+02:00 Guillaume Boué :

> Hi Robert,
>
> I see, I will try to debug why the test is failing for spaces and special
> characters. How about naming the folder "space & special char" instead? It
> would make it clearer that this is the purpose of the test.
>
> Regards,
> Guillaume
>
> 2016-07-17 22:39 GMT+02:00 Robert Scholte :
>
>> Hi Guillaume,
>>
>> there's a reason why this directory was called like this (spaces +
>> special character).
>> It is failing on my Windows machine too, but haven't investigated why it
>> is failing, I think the Plexus Commandline doesn't like it...
>> This should be reverted and fixed or excluded for Windows, i.e
>> invoker.family = !windows
>>
>> thanks,
>> Robert
>>
>>
>> On Sun, 17 Jul 2016 20:34:02 +0200,  wrote:
>>
>> Author: gboue
>>> Date: Sun Jul 17 18:34:01 2016
>>> New Revision: 1753099
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1753099=rev
>>> Log:
>>> Renamed "this & that" IT test folder to "simple-dir-format", as this
>>> breaks the ITs when run on Windows: the '&' gets interpreted and Windows
>>> tries to launch the "that" program.
>>>
>>> Added:
>>>
>>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/simple-dir-format/
>>>   - copied from r1753098,
>>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
>>> & that/
>>> Removed:
>>>
>>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
>>> & that/
>>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
>> For additional commands, e-mail: dev-h...@maven.apache.org
>>
>>
>

Re: svn commit: r1753099 - in /maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features: simple-dir-format/ this & that/

2016-07-18 Thread Robert Scholte 

Hi Guillaume,

the next time you see a file or folder with spaces and special characters  
you'll probably recognize the reason. But if you think that it'll help, go  
ahead.


Robert

On Sun, 17 Jul 2016 22:50:20 +0200, Guillaume Boué  
 wrote:



Hi Robert,

I see, I will try to debug why the test is failing for spaces and special
characters. How about naming the folder "space & special char" instead?  
It

would make it clearer that this is the purpose of the test.

Regards,
Guillaume

2016-07-17 22:39 GMT+02:00 Robert Scholte :


Hi Guillaume,

there's a reason why this directory was called like this (spaces +  
special

character).
It is failing on my Windows machine too, but haven't investigated why it
is failing, I think the Plexus Commandline doesn't like it...
This should be reverted and fixed or excluded for Windows, i.e
invoker.family = !windows

thanks,
Robert


On Sun, 17 Jul 2016 20:34:02 +0200,  wrote:

Author: gboue

Date: Sun Jul 17 18:34:01 2016
New Revision: 1753099

URL: http://svn.apache.org/viewvc?rev=1753099=rev
Log:
Renamed "this & that" IT test folder to "simple-dir-format", as this
breaks the ITs when run on Windows: the '&' gets interpreted and  
Windows

tries to launch the "that" program.

Added:

maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/simple-dir-format/
  - copied from r1753098,
maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
& that/
Removed:

maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
& that/



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1753099 - in /maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features: simple-dir-format/ this & that/

2016-07-17 Thread Guillaume Boué 
Hi Robert,

I see, I will try to debug why the test is failing for spaces and special
characters. How about naming the folder "space & special char" instead? It
would make it clearer that this is the purpose of the test.

Regards,
Guillaume

2016-07-17 22:39 GMT+02:00 Robert Scholte :

> Hi Guillaume,
>
> there's a reason why this directory was called like this (spaces + special
> character).
> It is failing on my Windows machine too, but haven't investigated why it
> is failing, I think the Plexus Commandline doesn't like it...
> This should be reverted and fixed or excluded for Windows, i.e
> invoker.family = !windows
>
> thanks,
> Robert
>
>
> On Sun, 17 Jul 2016 20:34:02 +0200,  wrote:
>
> Author: gboue
>> Date: Sun Jul 17 18:34:01 2016
>> New Revision: 1753099
>>
>> URL: http://svn.apache.org/viewvc?rev=1753099=rev
>> Log:
>> Renamed "this & that" IT test folder to "simple-dir-format", as this
>> breaks the ITs when run on Windows: the '&' gets interpreted and Windows
>> tries to launch the "that" program.
>>
>> Added:
>>
>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/simple-dir-format/
>>   - copied from r1753098,
>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
>> & that/
>> Removed:
>>
>> maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
>> & that/
>>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
> For additional commands, e-mail: dev-h...@maven.apache.org
>
>

Re: svn commit: r1753099 - in /maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features: simple-dir-format/ this & that/

2016-07-17 Thread Karl Heinz Marbaise 

Hi,

or those folders should be generated with a setup script during the 
invoker run...


Kind regards
Karl Heinz
On 7/17/16 10:39 PM, Robert Scholte wrote:

Hi Guillaume,

there's a reason why this directory was called like this (spaces +
special character).
It is failing on my Windows machine too, but haven't investigated why it
is failing, I think the Plexus Commandline doesn't like it...
This should be reverted and fixed or excluded for Windows, i.e
invoker.family = !windows

thanks,
Robert

On Sun, 17 Jul 2016 20:34:02 +0200,  wrote:


Author: gboue
Date: Sun Jul 17 18:34:01 2016
New Revision: 1753099

URL: http://svn.apache.org/viewvc?rev=1753099=rev
Log:
Renamed "this & that" IT test folder to "simple-dir-format", as this
breaks the ITs when run on Windows: the '&' gets interpreted and
Windows tries to launch the "that" program.

Added:

maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/simple-dir-format/

  - copied from r1753098,
maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
& that/
Removed:

maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this
& that/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Re: svn commit: r1753099 - in /maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features: simple-dir-format/ this & that/

2016-07-17 Thread Robert Scholte 

Hi Guillaume,

there's a reason why this directory was called like this (spaces + special  
character).
It is failing on my Windows machine too, but haven't investigated why it  
is failing, I think the Plexus Commandline doesn't like it...
This should be reverted and fixed or excluded for Windows, i.e  
invoker.family = !windows


thanks,
Robert

On Sun, 17 Jul 2016 20:34:02 +0200,  wrote:


Author: gboue
Date: Sun Jul 17 18:34:01 2016
New Revision: 1753099

URL: http://svn.apache.org/viewvc?rev=1753099=rev
Log:
Renamed "this & that" IT test folder to "simple-dir-format", as this  
breaks the ITs when run on Windows: the '&' gets interpreted and Windows  
tries to launch the "that" program.


Added:

maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/simple-dir-format/
  - copied from r1753098,  
maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this  
& that/

Removed:
maven/plugins/trunk/maven-assembly-plugin/src/it/projects/basic-features/this  
& that/


-
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org