Re: Who evaluates menu ref=parent|modules / in site.xml?
Am 2014-10-29 um 22:48 schrieb Barrie Treloar: On 30 October 2014 07:33, Michael Osipov micha...@apache.org wrote: [del] I did a code analysis now. [del] Is that a manual inspection - or are you using tooling? Purely manual - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Who evaluates menu ref=parent|modules / in site.xml?
Am 2014-10-29 um 02:39 schrieb Hervé BOUTEMY: see doxia-integration-tools DefaultSiteTool populateParentMenu(...) [1] and populateModulesMenu(...) [2] called by getDecorationModel(...) then getDecorationModel(...) is called from AbstractSiteRenderingMojo.createSiteRenderingContext(...) But looking at MPIR-279, I fear you're fighting against a non-bug, just some unexpected consequences of not using the standard directory layout from modules (ie directory = artifactId) without manually updating a serie of POM elements which are calculated with the convention Perhaps what can help is documenting what POM elements to be manually defined in case of non-standard module directory path: I never tried to do so, always fighting about what was told as a bug Regards, Hervé [1] http://maven.apache.org/doxia/doxia-tools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L638 [2] http://maven.apache.org/doxia/doxia-tools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L733 Salut Hervé, the code snippets look like the stuff I was looking for. I don't think that MPIR-279 follows some non-default layout therefore I have marked two issues as duplicates. I ran into this issue at work, so I have a bigger project to test with. I'll take a look at some demo code in the next couple of days. Thanks for the pointers, Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Who evaluates menu ref=parent|modules / in site.xml?
Am 2014-10-29 um 02:39 schrieb Hervé BOUTEMY: see doxia-integration-tools DefaultSiteTool populateParentMenu(...) [1] and populateModulesMenu(...) [2] called by getDecorationModel(...) then getDecorationModel(...) is called from AbstractSiteRenderingMojo.createSiteRenderingContext(...) But looking at MPIR-279, I fear you're fighting against a non-bug, just some unexpected consequences of not using the standard directory layout from modules (ie directory = artifactId) without manually updating a serie of POM elements which are calculated with the convention Perhaps what can help is documenting what POM elements to be manually defined in case of non-standard module directory path: I never tried to do so, always fighting about what was told as a bug I did a code analysis now. At first glace, the SiteTool code is exactly what I need to adapt. The problem lays in the ModulesReport. It should be an exact copy of ref=modules/SiteTool behavior. I'll try a patch to report to the watches, additionally, I'll try to create a IT for that. Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Who evaluates menu ref=parent|modules / in site.xml?
On 30 October 2014 07:33, Michael Osipov micha...@apache.org wrote: [del] I did a code analysis now. [del] Is that a manual inspection - or are you using tooling? http://www.plan.org.au/
Who evaluates menu ref=parent|modules / in site.xml?
Hi, I'd like to fix MPIR-279 and by applying the logic from above. I am having a hard time to find that spot which actually evalutes the snippet above. Does someone know? Thanks, Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: Who evaluates menu ref=parent|modules / in site.xml?
see doxia-integration-tools DefaultSiteTool populateParentMenu(...) [1] and populateModulesMenu(...) [2] called by getDecorationModel(...) then getDecorationModel(...) is called from AbstractSiteRenderingMojo.createSiteRenderingContext(...) But looking at MPIR-279, I fear you're fighting against a non-bug, just some unexpected consequences of not using the standard directory layout from modules (ie directory = artifactId) without manually updating a serie of POM elements which are calculated with the convention Perhaps what can help is documenting what POM elements to be manually defined in case of non-standard module directory path: I never tried to do so, always fighting about what was told as a bug Regards, Hervé [1] http://maven.apache.org/doxia/doxia-tools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L638 [2] http://maven.apache.org/doxia/doxia-tools/doxia-integration-tools/xref/org/apache/maven/doxia/tools/DefaultSiteTool.html#L733 Le mardi 28 octobre 2014 20:05:12 Michael Osipov a écrit : Hi, I'd like to fix MPIR-279 and by applying the logic from above. I am having a hard time to find that spot which actually evalutes the snippet above. Does someone know? Thanks, Michael - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
