Re: svn commit: r1049118 - in /maven/surefire/trunk: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/ maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/ maven-s
The way I understand you this is halfway a documentation issue; any non-legal value including the string filesystem will actually give you filesystem order. So I could solve this by just adding filesystem to the list of legal options, right ? Another issue is that Dennis actually converted the default value to alphabetical in his original fix. When introducing more options I reverted to the old-style behaviour as default (filesystem). Actually changing the default order will break some people's tests, but I have a marginal preference for alphabetical. But it's sufficiently marginal taht I prefer compatibility ;) KRistian ti., 14.12.2010 kl. 17.32 +0100, skrev Benjamin Bentmann: Hi Kristian, Author: krosenvold Date: Tue Dec 14 14:55:52 2010 New Revision: 1049118 URL: http://svn.apache.org/viewvc?rev=1049118view=rev Log: [SUREFIRE-321] Added runOrder mojo attribute, including documentation. [...] @@ -595,6 +595,20 @@ public class IntegrationTestMojo private Boolean parallelMavenExecution; /** + * Defines the order the tests will be run in. Supported values are alphabetical, reversealphabetical + * random, hourly (alphabetical on even hours, reverse alphabetical on odd hours). + * + * Not supplying a value for this setting will run tests in filesystem order. + * + * Odd/Even is determined at the time the of scanning the classpath, meaning it could change during + * a multi-module build. + * + * @parameter + * @since 2.7 + */ + private String runOrder; Should there be an explicit value for the filesystem order? I'm thinking about a parent POM where runOrder gets set to say hourly but a child project wants to stick with the (current) filesystem order. Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: svn commit: r1049118 - in /maven/surefire/trunk: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/ maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/ maven-s
Kristian Rosenvold wrote: The way I understand you this is halfway a documentation issue; any non-legal value including the string filesystem will actually give you filesystem order. Oh I see, I didn't properly read the diff. So I could solve this by just adding filesystem to the list of legal options, right ? Yes, I think this is a good idea. Another issue is that Dennis actually converted the default value to alphabetical in his original fix. When introducing more options I reverted to the old-style behaviour as default (filesystem). Yah, better safe than sorry. Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
Re: svn commit: r1049118 - in /maven/surefire/trunk: maven-failsafe-plugin/src/main/java/org/apache/maven/plugin/failsafe/ maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/ maven-s
On 2010-12-14 20:03, Kristian Rosenvold wrote: The way I understand you this is halfway a documentation issue; any non-legal value including the string filesystem will actually give you filesystem order. So I could solve this by just adding filesystem to the list of legal options, right ? Another issue is that Dennis actually converted the default value to alphabetical in his original fix. When introducing more options I reverted to the old-style behaviour as default (filesystem). That's good. It didn't occur to me at the time to make it configurable. Actually changing the default order will break some people's tests, but I have a marginal preference for alphabetical. But it's sufficiently marginal taht I prefer compatibility ;) Me too KRistian ti., 14.12.2010 kl. 17.32 +0100, skrev Benjamin Bentmann: Hi Kristian, Author: krosenvold Date: Tue Dec 14 14:55:52 2010 New Revision: 1049118 URL: http://svn.apache.org/viewvc?rev=1049118view=rev Log: [SUREFIRE-321] Added runOrder mojo attribute, including documentation. [...] @@ -595,6 +595,20 @@ public class IntegrationTestMojo private Boolean parallelMavenExecution; /** + * Defines the order the tests will be run in. Supported values are alphabetical, reversealphabetical + * random, hourly (alphabetical on even hours, reverse alphabetical on odd hours). + * + * Not supplying a value for this setting will run tests in filesystem order. + * + * Odd/Even is determined at the time the of scanning the classpath, meaning it could change during + * a multi-module build. + * + * @parameter + * @since 2.7 + */ + private String runOrder; Should there be an explicit value for the filesystem order? I'm thinking about a parent POM where runOrder gets set to say hourly but a child project wants to stick with the (current) filesystem order. Benjamin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org -- Dennis Lundberg - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
