[GitHub] mesos pull request #281: Add alg RS256 support for JWT generator and validat...

[clems4ever]

Github user clems4ever closed the pull request at:

https://github.com/apache/mesos/pull/281


---

[GitHub] mesos issue #281: Add alg RS256 support for JWT generator and validator.

[clems4ever]

Github user clems4ever commented on the issue:

https://github.com/apache/mesos/pull/281
  
Closing this PR since reviews are in the review board.


---

[GitHub] mesos issue #284: Remove accent from first name of clems4ever contributor.

[clems4ever]

Github user clems4ever commented on the issue:

https://github.com/apache/mesos/pull/284
  
Hello @tillt , there is an issue with the review bot applying my review: 
https://reviews.apache.org/r/66621/. I think it is due to the accent in my 
first name.
So, I created this review to remove the accent. Can you please merge it? 
Thanks.


---

[GitHub] mesos pull request #284: Remove accent from first name of clems4ever contrib...

[clems4ever]

GitHub user clems4ever opened a pull request:

https://github.com/apache/mesos/pull/284

Remove accent from first name of clems4ever contributor.

Review bot fails to apply reviews (with ./support/apply-review.py script) 
because of the accent in my first name.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clems4ever/mesos clems4ever-contributor

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mesos/pull/284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #284


commit 9751c6eacbedca7e48e595f5d0a97eb0981748f4
Author: Clement Michaud 
Date:   2018-04-17T21:11:10Z

Remove accent from first name of clems4ever contributor.




---

[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...

[zhitaoli]

Github user zhitaoli commented on a diff in the pull request:

https://github.com/apache/mesos/pull/283#discussion_r182226462
  
--- Diff: src/slave/task_status_update_manager.cpp ---
@@ -881,11 +881,21 @@ void TaskStatusUpdateStream::_handle(
 // Add it to the pending updates queue.
 pending.push(update);
   } else {
-// Record this ACK.
-acknowledged.insert(id::UUID::fromBytes(update.uuid()).get());
+StatusUpdate& pendingUpdate = pending.front();
--- End diff --

Make this const &


---

[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...

[zhitaoli]

Github user zhitaoli commented on a diff in the pull request:

https://github.com/apache/mesos/pull/283#discussion_r182227665
  
--- Diff: src/slave/task_status_update_manager.cpp ---
@@ -881,11 +881,21 @@ void TaskStatusUpdateStream::_handle(
 // Add it to the pending updates queue.
 pending.push(update);
   } else {
-// Record this ACK.
-acknowledged.insert(id::UUID::fromBytes(update.uuid()).get());
+StatusUpdate& pendingUpdate = pending.front();
 
-// Remove the corresponding update from the pending queue.
-pending.pop();
+if (pendingUpdate.uuid() == update.uuid()) {
--- End diff --

Can we use the _operator==()_ on the _id::UUID_ to compare the two fields 
instead?


---

[GitHub] mesos pull request #283: Ignore acknowledge for task status update, received...

[vargup]

GitHub user vargup opened a pull request:

https://github.com/apache/mesos/pull/283

Ignore acknowledge for task status update, received out of order.

Ignore acknowledge for task status update, received out of order.

WIP: Integration test.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vargup/mesos 
ignore-outoforder-statusupdate-ack

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/mesos/pull/283.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #283


commit d74550cce5ae4dfd23b59efad7b5baa498d4eb49
Author: Varun Gupta 
Date:   2018-04-17T20:39:34Z

Ignore task status update acknowledge received out of order.




---

Performance Working Group Agenda for Tomorrow

[Benjamin Mahler]

Do folks have any agenda items they would like to discuss for tomorrow's
performance working group meeting?

There haven't been a lot of performance related activity in the past month,
so will cancel this one unless folks chime in here.

Ben

[GitHub] mesos pull request #:

[qianzhangxa]

Github user qianzhangxa commented on the pull request:


https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28615233
  
@shuizz `protobuf::internal::parse(google::protobuf::Message* message, 
const JSON::Object& object)` is used to convert a JSON object to a protobuf 
message, can you please show me your JSON which caused the error: `Not 
expecting a JSON string for field 'value' `.

Actually, we already have a [unit 
test](https://github.com/apache/mesos/blob/master/3rdparty/stout/tests/protobuf_tests.cpp#L803:L806)
 to verify the case that the value of map is a protobuf message, and I see it 
works well now.


---

[GitHub] mesos pull request #:

[shuizz]

Github user shuizz commented on the pull request:


https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28612799
  
add follow code to resolve it in 
protobuf::internal::parse(google::protobuf::Message* message, const 
JSON::Object& object)
case google::protobuf::FieldDescriptor::TYPE_MESSAGE:
if (field->is_repeated()) {
  reflection->AddMessage(message, field);
} else {
  reflection->MutableMessage(message, field);
}
break;


---

[GitHub] mesos pull request #:

[shuizz]

Github user shuizz commented on the pull request:


https://github.com/apache/mesos/commit/5b2261409e2b391d9182c5579e1df481c7f0779f#commitcomment-28612339
  
if value of protobuf map is any protobuf 
message，protobuf::internal::parse(google::protobuf::Message* message, const 
JSON::Object& object) will return error: Not expecting a JSON string for field 
'value'


---

[API WG] Meeting tomorrow

[Greg Mann]

Hey folks,
The API working group will be meeting tomorrow at 11am PST. We'll be
chatting about CPU guarantees and limits.

Feel free to add items to the agenda

!

Cheers,
Greg