Re: Review Request 26056: Normalize enforce 3rdparty/libprocess conditional include style.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/ --- (Updated Sept. 25, 2014, 11:04 p.m.) Review request for mesos and Niklas Nielsen. Changes --- Changing from synchronized.hpp specific to normalizing all of 3rdparty/libprocess conditional includes. Summary (updated) - Normalize enforce 3rdparty/libprocess conditional include style. Repository: mesos-git Description (updated) --- Normalize 3rdparty/libprocess conditional include style. Diffs (updated) - 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 3rdparty/libprocess/src/config.hpp cbaf41d 3rdparty/libprocess/src/fatal.hpp 38646f3 3rdparty/libprocess/src/net.hpp 1ba3dbb 3rdparty/libprocess/src/process_reference.hpp 4964107 3rdparty/libprocess/src/synchronized.hpp 577a5fc Diff: https://reviews.apache.org/r/26056/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 26056: Normalize enforce 3rdparty/libprocess conditional include style.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/#review54625 --- Ship it! Ship It! - Niklas Nielsen On Sept. 25, 2014, 4:04 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/ --- (Updated Sept. 25, 2014, 4:04 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Normalize 3rdparty/libprocess conditional include style. Diffs - 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 3rdparty/libprocess/src/config.hpp cbaf41d 3rdparty/libprocess/src/fatal.hpp 38646f3 3rdparty/libprocess/src/net.hpp 1ba3dbb 3rdparty/libprocess/src/process_reference.hpp 4964107 3rdparty/libprocess/src/synchronized.hpp 577a5fc Diff: https://reviews.apache.org/r/26056/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 26056: Normalize enforce 3rdparty/libprocess conditional include style.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/#review54626 --- 3rdparty/libprocess/src/net.hpp https://reviews.apache.org/r/26056/#comment94856 Missed this one s/HH/HPP/ - Niklas Nielsen On Sept. 25, 2014, 4:04 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/ --- (Updated Sept. 25, 2014, 4:04 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Normalize 3rdparty/libprocess conditional include style. Diffs - 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 3rdparty/libprocess/src/config.hpp cbaf41d 3rdparty/libprocess/src/fatal.hpp 38646f3 3rdparty/libprocess/src/net.hpp 1ba3dbb 3rdparty/libprocess/src/process_reference.hpp 4964107 3rdparty/libprocess/src/synchronized.hpp 577a5fc Diff: https://reviews.apache.org/r/26056/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
Re: Review Request 26056: Normalize enforce 3rdparty/libprocess conditional include style.
On Sept. 25, 2014, 4:35 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/net.hpp, line 232 https://reviews.apache.org/r/26056/diff/2/?file=705786#file705786line232 Missed this one s/HH/HPP/ Fixed it when committing - thanks! - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/#review54626 --- On Sept. 25, 2014, 4:04 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26056/ --- (Updated Sept. 25, 2014, 4:04 p.m.) Review request for mesos and Niklas Nielsen. Repository: mesos-git Description --- Normalize 3rdparty/libprocess conditional include style. Diffs - 3rdparty/libprocess/include/process/metrics/metrics.hpp 0a97f12 3rdparty/libprocess/include/process/tuples/details.hpp 80b0539 3rdparty/libprocess/src/config.hpp cbaf41d 3rdparty/libprocess/src/fatal.hpp 38646f3 3rdparty/libprocess/src/net.hpp 1ba3dbb 3rdparty/libprocess/src/process_reference.hpp 4964107 3rdparty/libprocess/src/synchronized.hpp 577a5fc Diff: https://reviews.apache.org/r/26056/diff/ Testing --- make check in 3rdparty/libprocess support/mesos-style.py Thanks, Joris Van Remoortere
