[jira] [Commented] (DIRMINA-1146) TLS enabled session got disconnected when outbound messages add up to the value of maxscheduledwriterequests
[ https://issues.apache.org/jira/browse/DIRMINA-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17794057#comment-17794057 ] Eissam Yassin commented on DIRMINA-1146: Hi [~elecharny] Sorry for the delay. Here attached classes extending IoHandler used by our application: [^EmDsectProtocolIoHandlare.java] and [^ConnectionEndPointIoHandler.java] ConnectEndPointIoHandler extends IoHandlerAdapter EmDsectProtolcolIoHandler extends ConnectionEndPointIoHandler Looking forward to hear from you. Many Thanks, Eissam Yassin > TLS enabled session got disconnected when outbound messages add up to the > value of maxscheduledwriterequests > > > Key: DIRMINA-1146 > URL: https://issues.apache.org/jira/browse/DIRMINA-1146 > Project: MINA > Issue Type: Bug >Reporter: Chily >Assignee: Jonathan Valliere >Priority: Blocker > Fix For: 2.2.2 > > Attachments: ConnectionEndPointIoHandler.java, > EmDsectProtocolIoHandlare.java > > > Slow Consumer Protection Feature does not work on TLS enabled session > -> ioSession.getScheduledWriteMessages() never decreases in > IoSessionResponder#send method > internal.engine.session.maxscheduledwriterequests=1 > Our TLS enabled session got disconneced when the outbound messages added up > to 1. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1146) TLS enabled session got disconnected when outbound messages add up to the value of maxscheduledwriterequests
[ https://issues.apache.org/jira/browse/DIRMINA-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eissam Yassin updated DIRMINA-1146: --- Attachment: ConnectionEndPointIoHandler.java > TLS enabled session got disconnected when outbound messages add up to the > value of maxscheduledwriterequests > > > Key: DIRMINA-1146 > URL: https://issues.apache.org/jira/browse/DIRMINA-1146 > Project: MINA > Issue Type: Bug >Reporter: Chily >Assignee: Jonathan Valliere >Priority: Blocker > Fix For: 2.2.2 > > Attachments: ConnectionEndPointIoHandler.java, > EmDsectProtocolIoHandlare.java > > > Slow Consumer Protection Feature does not work on TLS enabled session > -> ioSession.getScheduledWriteMessages() never decreases in > IoSessionResponder#send method > internal.engine.session.maxscheduledwriterequests=1 > Our TLS enabled session got disconneced when the outbound messages added up > to 1. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1146) TLS enabled session got disconnected when outbound messages add up to the value of maxscheduledwriterequests
[ https://issues.apache.org/jira/browse/DIRMINA-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eissam Yassin updated DIRMINA-1146: --- Attachment: EmDsectProtocolIoHandlare.java > TLS enabled session got disconnected when outbound messages add up to the > value of maxscheduledwriterequests > > > Key: DIRMINA-1146 > URL: https://issues.apache.org/jira/browse/DIRMINA-1146 > Project: MINA > Issue Type: Bug >Reporter: Chily >Assignee: Jonathan Valliere >Priority: Blocker > Fix For: 2.2.2 > > Attachments: EmDsectProtocolIoHandlare.java > > > Slow Consumer Protection Feature does not work on TLS enabled session > -> ioSession.getScheduledWriteMessages() never decreases in > IoSessionResponder#send method > internal.engine.session.maxscheduledwriterequests=1 > Our TLS enabled session got disconneced when the outbound messages added up > to 1. > -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [PR] GH-429: Support GIT protocol-v2 [mina-sshd]
lgoldstein commented on code in PR #430:
URL: https://github.com/apache/mina-sshd/pull/430#discussion_r1418394044
##
sshd-git/src/main/java/org/apache/sshd/git/transport/GitSshdSession.java:
##
@@ -133,7 +132,16 @@ public Process exec(String commandName, int timeout)
throws IOException {
log.trace("exec({}) session={}, timeout={} sec.", commandName,
session, timeout);
}
-ChannelExec channel = session.createExecChannel(commandName, null,
version2Env);
+ChannelExec channel;
+Optional protocolVer =
GitModuleProperties.GIT_PROTOCOL_VERSION.get(session);
+if (protocolVer.isPresent()) {
Review Comment:
Recommend using the following code:
```java
Optional protocolVer =
GitModuleProperties.GIT_PROTOCOL_VERSION.get(session);
String protocol = protocolVer.orElse(null);
if (GenericUtils.isNotBlank(protocol)) {
...
}
```
```
##
sshd-git/src/main/java/org/apache/sshd/git/pack/GitPackCommand.java:
##
@@ -80,9 +80,10 @@ public void run() {
String subCommand = args[0];
if (RemoteConfig.DEFAULT_UPLOAD_PACK.equals(subCommand)) {
UploadPack uploadPack = new UploadPack(db);
-String protocol = this.getEnvironment().getEnv()
-
.getOrDefault(GitProtocolConstants.PROTOCOL_ENVIRONMENT_VARIABLE, "version=0");
-uploadPack.setExtraParameters(Collections.singleton(protocol));
+String protocol =
this.getEnvironment().getEnv().get(GitProtocolConstants.PROTOCOL_ENVIRONMENT_VARIABLE);
+if (protocol != null) {
Review Comment:
Recommend using
```java
if (GenericUtils.isNotBlank(protocol)) {
...
}
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
Re: [PR] GH-429: Support GIT protocol-v2 [mina-sshd]
lgoldstein commented on PR #430: URL: https://github.com/apache/mina-sshd/pull/430#issuecomment-1844520166 Almost there - the only (minor) issue is assuming that the protocol property is either *null* or valid - as a matter of "safety" unless empty/blank strings have special semantics we treat them as "equivalent" to *null*. See my 2 comments - once you fix this I would be happy to merge this in. Good job on the whole... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
