[jira] [Commented] (SSHD-1338) SSHD 2.12 not binary compatible with JGIT 5.13

2024-01-23 Thread Tomas Hofman (Jira)


[ 
https://issues.apache.org/jira/browse/SSHD-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17809887#comment-17809887
 ] 

Tomas Hofman commented on SSHD-1338:


The issues that I identified so far are around {{VerifiableFuture#verify(...)}} 
methods:

https://github.com/apache/mina-sshd/compare/sshd-2.9.3...sshd-2.12.0#diff-2677740efc7588ab5882de60562ee8d2ae99db843052880ef8187747f87d2f1bL42

E.g. {{default T verify() throws IOException}} was changed to {{default T 
verify(CancelOption... options) throws IOException}}, which is source 
compatible, but not binary compatible.

> SSHD 2.12 not binary compatible with JGIT 5.13
> --
>
> Key: SSHD-1338
> URL: https://issues.apache.org/jira/browse/SSHD-1338
> Project: MINA SSHD
>  Issue Type: Improvement
>Reporter: Tomas Hofman
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 2.12.1
>
>
> Current version of SSHD still contains a dependency on JGIT 5.13. This is to 
> keep SSHD compatible with Java 1.8, as JGIT 6.x requires Java 11.
> However SSHD 2.12 is not binary compatible with 2.9.x versions, which is the 
> version that JGIT 5.13.x were build against. The result is that when SSHD 
> 2.12 and JGIT 5.13 are used together, one can get NoSuchMethodErrors like 
> here:
> {code}
> Caused by: java.lang.NoSuchMethodError: 'java.lang.Object 
> org.apache.sshd.client.future.ConnectFuture.verify()'
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:189)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:142)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:99)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSessionFactory.getSession(SshdSessionFactory.java:235)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Created] (SSHD-1338) SSHD 2.12 not binary compatible with JGIT 5.13

2024-01-23 Thread Tomas Hofman (Jira)
Tomas Hofman created SSHD-1338:
--

 Summary: SSHD 2.12 not binary compatible with JGIT 5.13
 Key: SSHD-1338
 URL: https://issues.apache.org/jira/browse/SSHD-1338
 Project: MINA SSHD
  Issue Type: Improvement
Reporter: Tomas Hofman


Current version of SSHD still contains a dependency on JGIT 5.13. This is to 
keep SSHD compatible with Java 1.8, as JGIT 6.x requires Java 11.

However SSHD 2.12 is not binary compatible with 2.9.x versions, which is the 
version that JGIT 5.13.x were build against. The result is that when SSHD 2.12 
and JGIT 5.13 are used together, one can get NoSuchMethodErrors like here:

{code}
Caused by: java.lang.NoSuchMethodError: 'java.lang.Object 
org.apache.sshd.client.future.ConnectFuture.verify()'
at 
org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:189)
at 
org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:142)
at 
org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:99)
at 
org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSessionFactory.getSession(SshdSessionFactory.java:235)
{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org