Re: [VOTE] Release Tobago 1.5.10
Hi, +1 Regards, Volker Weber 2013/5/26 Bernd Bohmann bernd.bohm...@googlemail.com Hello Mark, from the webpage http://www.jboss.org/javassist the License is MPL, LGPL, or Apache License. I think this has changed about 2 years ago Regards Bernd On Sat, May 25, 2013 at 6:19 PM, Mark Struberg strub...@yahoo.de wrote: +1 rat is fine, licenses are ok, key is fine, source builds locally. Side note: You currently ship an examples WAR file which contains quite some binaries in WEB-INF/lib. Some of them are MPL (javassist) thus you might need a NOTICE file in your sample. We had the same issue in OWB and we solved this by not shipping the samples as WAR binaries at all. Users can still build it themselfs but we don't ship any WARs anymore. It's not a blocker right now, but those WAR files are most times useless for users and just fill up the repo anyway. Imo it's not worth the hassle to include them in the distribution and my suggestion is to just configure the maven-deploy-plugin to skip deployment for the samples. I'm not 100% sure about the license of jsf-facelets-1.1.14.jar and if you need this at all. I'd rather remove it from the dependencies, or does your sample still target JSF 2.0? LieGrue, strub - Original Message - From: Werner Punz werner.p...@gmail.com To: MyFaces Development dev@myfaces.apache.org Cc: Sent: Friday, 24 May 2013, 22:56 Subject: Re: [VOTE] Release Tobago 1.5.10 +1 Werner Am 24.05.13 13:52, schrieb Bernd Bohmann: Hello, I would like to release Tobago 1.5.10 For a detail list please consult the release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273version=12324008 The version is available at the nexus staging repository. Staging repository: https://repository.apache.org/content/repositories/orgapachemyfaces-040 The Vote is open for 72h. [ ] +1 [ ] +0 [ ] -1 Regards Bernd -- inexso - information exchange solutions GmbH Ofener Str. 30 | 26121 Oldenburg Tel.: +49 441 219 730 0 | FAX: +49 441 219 730 66 | eMail: v.we...@inexso.de Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 Geschäftsführer: Stefan Schulte, Michael Terschüren
[RESULT] [VOTE] Release Tobago 1.5.10
The vote has passed with the following results: +1 werpu (binding) struberg (binding) lofwyr (binding) weber (binding) I will proceed with the next steps. Regards, Bernd On Mon, May 27, 2013 at 9:03 AM, Volker Weber v.we...@inexso.de wrote: Hi, +1 Regards, Volker Weber 2013/5/26 Bernd Bohmann bernd.bohm...@googlemail.com Hello Mark, from the webpage http://www.jboss.org/javassist the License is MPL, LGPL, or Apache License. I think this has changed about 2 years ago Regards Bernd On Sat, May 25, 2013 at 6:19 PM, Mark Struberg strub...@yahoo.de wrote: +1 rat is fine, licenses are ok, key is fine, source builds locally. Side note: You currently ship an examples WAR file which contains quite some binaries in WEB-INF/lib. Some of them are MPL (javassist) thus you might need a NOTICE file in your sample. We had the same issue in OWB and we solved this by not shipping the samples as WAR binaries at all. Users can still build it themselfs but we don't ship any WARs anymore. It's not a blocker right now, but those WAR files are most times useless for users and just fill up the repo anyway. Imo it's not worth the hassle to include them in the distribution and my suggestion is to just configure the maven-deploy-plugin to skip deployment for the samples. I'm not 100% sure about the license of jsf-facelets-1.1.14.jar and if you need this at all. I'd rather remove it from the dependencies, or does your sample still target JSF 2.0? LieGrue, strub - Original Message - From: Werner Punz werner.p...@gmail.com To: MyFaces Development dev@myfaces.apache.org Cc: Sent: Friday, 24 May 2013, 22:56 Subject: Re: [VOTE] Release Tobago 1.5.10 +1 Werner Am 24.05.13 13:52, schrieb Bernd Bohmann: Hello, I would like to release Tobago 1.5.10 For a detail list please consult the release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273version=12324008 The version is available at the nexus staging repository. Staging repository: https://repository.apache.org/content/repositories/orgapachemyfaces-040 The Vote is open for 72h. [ ] +1 [ ] +0 [ ] -1 Regards Bernd -- inexso - information exchange solutions GmbH Ofener Str. 30 | 26121 Oldenburg Tel.: +49 441 219 730 0 | FAX: +49 441 219 730 66 | eMail: v.we...@inexso.de Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 Geschäftsführer: Stefan Schulte, Michael Terschüren
[jira] [Commented] (MYFACES-3726) root context induces wrong urls
[
https://issues.apache.org/jira/browse/MYFACES-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13668085#comment-13668085
]
Leonardo Uribe commented on MYFACES-3726:
-
I can see the justification behind this. It is an special case and it should be
fixed at every location where the contextPath is used. I tried a simple jsf
application running as root and I can't see any difference, but that does not
means the fix is not valid, maybe here a combination of factors that at the end
cause the problem.
I have attached a patch with the changes to be commited. Thanks for report it.
root context induces wrong urls
---
Key: MYFACES-3726
URL: https://issues.apache.org/jira/browse/MYFACES-3726
Project: MyFaces Core
Issue Type: Bug
Reporter: Romain Manni-Bucau
When the webapp context is root (/) its name is still appended before the
urls (i didn't check all cases) so we end up with urls like //index.xhtml
which makes the navigation not working anymore.
I'm sure it happens at least in
org.apache.myfaces.shared.application.DefaultViewHandlerSupport#calculateActionURL
where
builder.append(contextPath);
should be replaced by
if (!/.equals(contextPath)) {
builder.append(contextPath);
}
We saw this issue in tomee (here a sample to reproduce it
https://github.com/maxtorzito/tomee-codi)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MYFACES-3726) root context induces wrong urls
[
https://issues.apache.org/jira/browse/MYFACES-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3726.
-
Resolution: Fixed
Fix Version/s: 2.1.12
2.0.18
Assignee: Leonardo Uribe
root context induces wrong urls
---
Key: MYFACES-3726
URL: https://issues.apache.org/jira/browse/MYFACES-3726
Project: MyFaces Core
Issue Type: Bug
Reporter: Romain Manni-Bucau
Assignee: Leonardo Uribe
Fix For: 2.0.18, 2.1.12
When the webapp context is root (/) its name is still appended before the
urls (i didn't check all cases) so we end up with urls like //index.xhtml
which makes the navigation not working anymore.
I'm sure it happens at least in
org.apache.myfaces.shared.application.DefaultViewHandlerSupport#calculateActionURL
where
builder.append(contextPath);
should be replaced by
if (!/.equals(contextPath)) {
builder.append(contextPath);
}
We saw this issue in tomee (here a sample to reproduce it
https://github.com/maxtorzito/tomee-codi)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
