[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520828#comment-16520828 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399597447 I also thought a bit about it, i think it would be better if we discuss it first on the mailing list. And details about it would be great. You know, we already have a buffer. So could you maybe split the sb/out commits from the other improvements? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399597447 I also thought a bit about it, i think it would be better if we discuss it first on the mailing list. And details about it would be great. You know, we already have a buffer. So could you maybe split the sb/out commits from the other improvements? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520449#comment-16520449 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399469835 I'll refactor a bit to use the SharedStringBuilder. Thanks for the information / review! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399469835 I'll refactor a bit to use the SharedStringBuilder. Thanks for the information / review! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (TOBAGO-1879) tc:date does not support Calendar and DateTime
[ https://issues.apache.org/jira/browse/TOBAGO-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520446#comment-16520446 ] Hudson commented on TOBAGO-1879: FAILURE: Integrated in Jenkins build Tobago Trunk #1468 (See [https://builds.apache.org/job/Tobago%20Trunk/1468/]) TOBAGO-1879 tc:date does not support Calendar and DateTime (hnoeth: rev d02f1d834a39139a15743ce676ce50b200e0275b) * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/1041-date-tobagoConverter/date-tobagoConverter.test.js * (add) tobago-core/src/main/java/org/apache/myfaces/tobago/internal/taglib/component/ConvertDateTimeTagDeclaration.java * (add) tobago-core/src/main/java/org/apache/myfaces/tobago/convert/DateTimeConverter.java * (add) tobago-example/tobago-example-demo/src/main/java/org/apache/myfaces/tobago/example/demo/ConvertDateTimeController.java * (add) tobago-example/tobago-example-demo/src/main/webapp/content/40-test/1041-date-tobagoConverter/date-tobagoConverter.xhtml * (add) tobago-core/src/main/java/org/apache/myfaces/tobago/facelets/ConvertDateTimeHandler.java > tc:date does not support Calendar and DateTime > -- > > Key: TOBAGO-1879 > URL: https://issues.apache.org/jira/browse/TOBAGO-1879 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 4.1.0 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.3.0 > > > Implement support for java.util.Calendar and java.time.DateTime. > MyFaces 2.3 has implemented java.time.DateTime for f:convertDateTime already. > This issue is mainly for backporting this functionality to JSF 2.2 and lower. > Usage is: -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520440#comment-16520440 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a must-have for this change, also those methods are called really often This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a must-have for this change, also those methods are called really often This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465769 All other changes looks fine of course. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520435#comment-16520435 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a must-have for this change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520436#comment-16520436 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465769 All other changes looks fine of course. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399465655 JFYI: we avoided new objects so much in the past that we even switched from for-each to for loops, so the SharedStringBuilder is IMO a must-have for this change This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520431#comment-16520431 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464821 ok, i see i'm ok for it if you use the SharedStringBuilder This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464821 ok, i see i'm ok for it if you use the SharedStringBuilder This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520424#comment-16520424 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464056 @tandraschko , we've been running some performance tests and can see a .5 - 1% increase in our testing in performance with an application that is only about 15% JSF , with a larger application and more JSF within it , the gain could be even greater. Basically we want to avoid the writer.write path , it is quite a long path to call over and over again if it isn't necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements
pnicolucci commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399464056 @tandraschko , we've been running some performance tests and can see a .5 - 1% increase in our testing in performance with an application that is only about 15% JSF , with a larger application and more JSF within it , the gain could be even greater. Basically we want to avoid the writer.write path , it is quite a long path to call over and over again if it isn't necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder? You know, this are always new object instances... And we have something like a SharedStringBuilder This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520399#comment-16520399 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder? You know, this are always new object instances... And we have something like a SharedString This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520400#comment-16520400 ] ASF GitHub Bot commented on MYFACES-4239: - tandraschko edited a comment on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder? You know, this are always new object instances... And we have something like a SharedStringBuilder This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements
tandraschko commented on issue #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8#issuecomment-399456368 @pnicolucci i'm not sure about this changes out.write vs sb.append... Why do you switchted from out.write to a new StringBuilder? You know, this are always new object instances... And we have something like a SharedString This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements
pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4239) [perf] Additional performance improvements
[ https://issues.apache.org/jira/browse/MYFACES-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520385#comment-16520385 ] ASF GitHub Bot commented on MYFACES-4239: - pnicolucci opened a new pull request #8: MYFACES-4239: Multiple performance improvements URL: https://github.com/apache/myfaces/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Additional performance improvements > -- > > Key: MYFACES-4239 > URL: https://issues.apache.org/jira/browse/MYFACES-4239 > Project: MyFaces Core > Issue Type: Improvement > Components: JSR-372 >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Some performance improvements in : > 1) ApplicationImpl.java > 2) ServletExternalContextImpl.java > 3) HtmlResponseWriterImpl.java > 4) HTMLEncoder.java, we also discussed on the mailing list changing > encodeURIAtributte to encodeUriAttribute to fix the typo in the method name > so I'll do that here as well. > 5) CDataEndEscapeFilterWriter.java > 6) ResourceValidationUtils.java > The following changes were made: > - Skip calling ConcurrentHashMap.containsKey since we will call get > afterward if containsKey == true. > - Change to use StringBuilders instead of calling Writer.write so often. > - Stop using Boolean for variables that don't have a null meaning. If > null == false, then just use boolean with a default of false. > - Don't call String.length() constantly for String variables that aren't > re-assigned. > - Change conditional order to avoid calling validateResourceName unless the > other conditions are true -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4227) Dynamic Resource Loading doesn't work
[ https://issues.apache.org/jira/browse/MYFACES-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520338#comment-16520338 ] Thomas Andraschko commented on MYFACES-4227: Seems like the following happens: The new component will correctly be created by Application#createComponent and our ApplicationImpl#_handleResourceDependencyAnnotations + #_handleResourceDependency correctly adds the resource to the viewroot via context.getViewRoot().addComponentResource. Our PartialViewContextImpl#processRenderResource would also render the diff but it seems that the bridge between "we have a new resource" and "render the new resource" is not called. It seems that this bridge should be HtmlScriptRenderer#processEvent and the equivalent StylesheetRenderer, but it isn't called. > Dynamic Resource Loading doesn't work > - > > Key: MYFACES-4227 > URL: https://issues.apache.org/jira/browse/MYFACES-4227 > Project: MyFaces Core > Issue Type: Bug > Components: JSR-372 >Affects Versions: 2.3.0, 2.3.1 >Reporter: Thomas Andraschko >Priority: Major > Fix For: 2.3.2 > > > [https://github.com/martin654/primefaces-test] > Just run the example via jetty:run > For MyFaces, you need to exchange Mojarra with MyFaces. > It works fine in Mojarra but in MyFaces, the "javax.faces.Resource" update is > never rendered. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TOBAGO-1905) Upgrade to Bootstrap 4.1.1
[ https://issues.apache.org/jira/browse/TOBAGO-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520302#comment-16520302 ] Hudson commented on TOBAGO-1905: SUCCESS: Integrated in Jenkins build Tobago Trunk #1464 (See [https://builds.apache.org/job/Tobago%20Trunk/1464/]) TOBAGO-1905 Upgrade to Bootstrap 4.1.1 (hnoeth: rev 9d4bf5a54b1259180503ac0e445e0a05e5b991d8) * (edit) tobago-theme/tobago-theme-speyside/src/main/scss/_speyside-overwrites.scss * (edit) tobago-theme/tobago-theme-standard/src/main/patches/append-tobago-theme-to-bootstrap.patch * (edit) tobago-core/src/main/resources/scss/_tobago.scss * (edit) tobago-theme/pom.xml > Upgrade to Bootstrap 4.1.1 > -- > > Key: TOBAGO-1905 > URL: https://issues.apache.org/jira/browse/TOBAGO-1905 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Themes >Affects Versions: 4.2.1 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.3.0 > > > Have a look at sheet with dark-markup. There were some changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (TOBAGO-1905) Upgrade to Bootstrap 4.1.1
[ https://issues.apache.org/jira/browse/TOBAGO-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Noeth resolved TOBAGO-1905. --- Resolution: Fixed > Upgrade to Bootstrap 4.1.1 > -- > > Key: TOBAGO-1905 > URL: https://issues.apache.org/jira/browse/TOBAGO-1905 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Themes >Affects Versions: 4.2.1 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Major > Fix For: 4.3.0 > > > Have a look at sheet with dark-markup. There were some changes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MYFACES-4241) MF 2.3 crashes without CDI
[ https://issues.apache.org/jira/browse/MYFACES-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Andraschko resolved MYFACES-4241. Resolution: Fixed Fix Version/s: 2.3.2 > MF 2.3 crashes without CDI > -- > > Key: MYFACES-4241 > URL: https://issues.apache.org/jira/browse/MYFACES-4241 > Project: MyFaces Core > Issue Type: Bug >Reporter: Thomas Andraschko >Assignee: Thomas Andraschko >Priority: Major > Fix For: 2.3.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MYFACES-4241) MF 2.3 crashes without CDI
Thomas Andraschko created MYFACES-4241: -- Summary: MF 2.3 crashes without CDI Key: MYFACES-4241 URL: https://issues.apache.org/jira/browse/MYFACES-4241 Project: MyFaces Core Issue Type: Bug Reporter: Thomas Andraschko Assignee: Thomas Andraschko -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Migrate all MyFaces projects to Git
Also deleted the unused branches now! 2018-06-21 17:23 GMT+02:00 Dennis Kieselhorst : > Great, thank you! > > On 2018/06/21 13:59:15, Werner Punz wrote: > > Just deleted it...> > >
