Re: 2.3.2 Release
I'll start on a release later this week for MyFaces 2.3.2. Stay tuned for updates as I make progress. Thanks, Paul From: Thomas Andraschko To: MyFaces Development Date: 08/06/2018 05:47 PM Subject:Re: 2.3.2 Release What about a release soon? Paul?! 2018-07-07 13:19 GMT+02:00 Dennis Kieselhorst : Hi! > In the meantime, I have some questions after the move to Git. I'm not sure > if after the move, we have to modify some pom.xml files, do you guys know > if we have to make any modification? Does the release process stay the > same? Any help here would be great. I've changed the scm section from svn to git directly after the migration but you're right there may be other places where we have to modify something. My suggestion is to cut a release and let the list know if there are some problems. We have some experiences from the Tobago migration, afaik there were no big problems. Please note that the site/ publishing stuff is still in SVN, so no changes required in this area. Regards Dennis
Re: 2.3.2 Release
What about a release soon? Paul?! 2018-07-07 13:19 GMT+02:00 Dennis Kieselhorst : > Hi! > > > In the meantime, I have some questions after the move to Git. I'm not > sure > > if after the move, we have to modify some pom.xml files, do you guys know > > if we have to make any modification? Does the release process stay the > > same? Any help here would be great. > > I've changed the scm section from svn to git directly after the migration > but you're right there may be other places where we have to modify > something. My suggestion is to cut a release and let the list know if there > are some problems. We have some experiences from the Tobago migration, > afaik there were no big problems. > > Please note that the site/ publishing stuff is still in SVN, so no changes > required in this area. > > Regards > Dennis >
[jira] [Reopened] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[ https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Nicolucci reopened MYFACES-4244: - > [perf] Use StringBuilder rather than calling write many times to increase > performance > - > > Key: MYFACES-4244 > URL: https://issues.apache.org/jira/browse/MYFACES-4244 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > > Using StringBuilder.append performs better than calling Writer.write multiple > times because the path length for a StringBuffer.append is less than the path > length of a Writer.write operation. By using StringBuilder, you only have to > call the write method once instead of N number of times per method. > The Shared StringBuilder may have some issues as well if there is any > multi-threaded use of the Shared StringBuilder. If multiple threads could > use a particular StringBuilder you would end up getting incorrect output. > Another issue with the Shared StringBuilder for performance is it requires a > call to get it which can be more expensive than just newing up a new > StringBuilder. > From looking at the myfaces code, the Shared StringBuilder is used only for > special cases presently and not widely used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
[ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Nicolucci resolved MYFACES-4249. - Resolution: Fixed > [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt > multiple times > --- > > Key: MYFACES-4249 > URL: https://issues.apache.org/jira/browse/MYFACES-4249 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Currently we calll c2 = (char) str.charAt(off+i); when (char) > str.charAt(off+i) was previously stored in the write method to variable c so > we can easily just do the following c2=c and save some string manipulation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
[ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570674#comment-16570674 ] ASF GitHub Bot commented on MYFACES-4249: - pnicolucci closed pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java index 155d17882..a72403036 100644 --- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java +++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java @@ -69,7 +69,7 @@ public void write(char[] cbuf, int off, int len) throws IOException
[GitHub] pnicolucci closed pull request #15: MYFACES-4249: Don't call charAt more than needed
pnicolucci closed pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java index 155d17882..a72403036 100644 --- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java +++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java @@ -69,7 +69,7 @@ public void write(char[] cbuf, int off, int len) throws IOException
[jira] [Commented] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
[ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570671#comment-16570671 ] ASF GitHub Bot commented on MYFACES-4249: - pnicolucci closed pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java index 155d17882..a72403036 100644 --- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java +++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java @@ -69,7 +69,7 @@ public void write(char[] cbuf, int off, int len) throws IOException
[GitHub] pnicolucci closed pull request #14: MYFACES-4249: Don't call charAt more than needed
pnicolucci closed pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java index 155d17882..a72403036 100644 --- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java +++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java @@ -69,7 +69,7 @@ public void write(char[] cbuf, int off, int len) throws IOException
[jira] [Commented] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
[ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570643#comment-16570643 ] ASF GitHub Bot commented on MYFACES-4249: - pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt > multiple times > --- > > Key: MYFACES-4249 > URL: https://issues.apache.org/jira/browse/MYFACES-4249 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Currently we calll c2 = (char) str.charAt(off+i); when (char) > str.charAt(off+i) was previously stored in the write method to variable c so > we can easily just do the following c2=c and save some string manipulation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed
pnicolucci opened a new pull request #15: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/15 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] pnicolucci opened a new pull request #14: MYFACES-4249: Don't call charAt more than needed
pnicolucci opened a new pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
[ https://issues.apache.org/jira/browse/MYFACES-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570632#comment-16570632 ] ASF GitHub Bot commented on MYFACES-4249: - pnicolucci opened a new pull request #14: MYFACES-4249: Don't call charAt more than needed URL: https://github.com/apache/myfaces/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt > multiple times > --- > > Key: MYFACES-4249 > URL: https://issues.apache.org/jira/browse/MYFACES-4249 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > Fix For: 2.2.13, 2.3.2 > > > Currently we calll c2 = (char) str.charAt(off+i); when (char) > str.charAt(off+i) was previously stored in the write method to variable c so > we can easily just do the following c2=c and save some string manipulation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MYFACES-4249) [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times
Paul Nicolucci created MYFACES-4249: --- Summary: [perf] minor change in CDataEndEscapeFilterWriter to not call str.charAt multiple times Key: MYFACES-4249 URL: https://issues.apache.org/jira/browse/MYFACES-4249 Project: MyFaces Core Issue Type: Improvement Affects Versions: 2.3.1, 2.2.12 Reporter: Paul Nicolucci Assignee: Paul Nicolucci -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[
https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570612#comment-16570612
]
ASF GitHub Bot commented on MYFACES-4244:
-
pnicolucci closed pull request #10: MYFACES-4244:Use StringBuilder rather than
calling write multiple times
URL: https://github.com/apache/myfaces/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
index 155d17882..63c3cc55c 100644
--- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
+++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
@@ -59,22 +59,35 @@ public void write(int c) throws IOException
public void write(char[] cbuf, int off, int len) throws IOException
{
int index = off;
+StringBuilder sb = null;
for (int i = 0; i < len; i++)
{
char c = cbuf[off+i];
if (c1 == ']' && c2 == ']' && c == '>')
{
-super.write(cbuf, index, i+1 - ( index - off ) );
+if (sb == null)
+{
+sb = new StringBuilder(len + 16);
+}
+sb.append(cbuf, index, i+1 - ( index - off ));
index = off+i+1;
-
[jira] [Commented] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[ https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570611#comment-16570611 ] ASF GitHub Bot commented on MYFACES-4244: - pnicolucci commented on issue #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10#issuecomment-410808355 After additional investigation we've determined this change is not necessary so I'm closing this Pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [perf] Use StringBuilder rather than calling write many times to increase > performance > - > > Key: MYFACES-4244 > URL: https://issues.apache.org/jira/browse/MYFACES-4244 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > > Using StringBuilder.append performs better than calling Writer.write multiple > times because the path length for a StringBuffer.append is less than the path > length of a Writer.write operation. By using StringBuilder, you only have to > call the write method once instead of N number of times per method. > The Shared StringBuilder may have some issues as well if there is any > multi-threaded use of the Shared StringBuilder. If multiple threads could > use a particular StringBuilder you would end up getting incorrect output. > Another issue with the Shared StringBuilder for performance is it requires a > call to get it which can be more expensive than just newing up a new > StringBuilder. > From looking at the myfaces code, the Shared StringBuilder is used only for > special cases presently and not widely used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] pnicolucci commented on issue #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times
pnicolucci commented on issue #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times URL: https://github.com/apache/myfaces/pull/10#issuecomment-410808355 After additional investigation we've determined this change is not necessary so I'm closing this Pull request. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[ https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Nicolucci resolved MYFACES-4244. - Resolution: Not A Bug > [perf] Use StringBuilder rather than calling write many times to increase > performance > - > > Key: MYFACES-4244 > URL: https://issues.apache.org/jira/browse/MYFACES-4244 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > > Using StringBuilder.append performs better than calling Writer.write multiple > times because the path length for a StringBuffer.append is less than the path > length of a Writer.write operation. By using StringBuilder, you only have to > call the write method once instead of N number of times per method. > The Shared StringBuilder may have some issues as well if there is any > multi-threaded use of the Shared StringBuilder. If multiple threads could > use a particular StringBuilder you would end up getting incorrect output. > Another issue with the Shared StringBuilder for performance is it requires a > call to get it which can be more expensive than just newing up a new > StringBuilder. > From looking at the myfaces code, the Shared StringBuilder is used only for > special cases presently and not widely used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] pnicolucci closed pull request #10: MYFACES-4244:Use StringBuilder rather than calling write multiple times
pnicolucci closed pull request #10: MYFACES-4244:Use StringBuilder rather than
calling write multiple times
URL: https://github.com/apache/myfaces/pull/10
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
index 155d17882..63c3cc55c 100644
--- a/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
+++ b/impl/src/main/java/org/apache/myfaces/util/CDataEndEscapeFilterWriter.java
@@ -59,22 +59,35 @@ public void write(int c) throws IOException
public void write(char[] cbuf, int off, int len) throws IOException
{
int index = off;
+StringBuilder sb = null;
for (int i = 0; i < len; i++)
{
char c = cbuf[off+i];
if (c1 == ']' && c2 == ']' && c == '>')
{
-super.write(cbuf, index, i+1 - ( index - off ) );
+if (sb == null)
+{
+sb = new StringBuilder(len + 16);
+}
+sb.append(cbuf, index, i+1 - ( index - off ));
index = off+i+1;
-
[jira] [Commented] (MYFACES-4244) [perf] Use StringBuilder rather than calling write many times to increase performance
[ https://issues.apache.org/jira/browse/MYFACES-4244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570606#comment-16570606 ] Paul Nicolucci commented on MYFACES-4244: - After additional investigation we've determined this change is not necessary and as such I'm going to cancel this issue. > [perf] Use StringBuilder rather than calling write many times to increase > performance > - > > Key: MYFACES-4244 > URL: https://issues.apache.org/jira/browse/MYFACES-4244 > Project: MyFaces Core > Issue Type: Improvement >Affects Versions: 2.2.12, 2.3.1 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Minor > > Using StringBuilder.append performs better than calling Writer.write multiple > times because the path length for a StringBuffer.append is less than the path > length of a Writer.write operation. By using StringBuilder, you only have to > call the write method once instead of N number of times per method. > The Shared StringBuilder may have some issues as well if there is any > multi-threaded use of the Shared StringBuilder. If multiple threads could > use a particular StringBuilder you would end up getting incorrect output. > Another issue with the Shared StringBuilder for performance is it requires a > call to get it which can be more expensive than just newing up a new > StringBuilder. > From looking at the myfaces code, the Shared StringBuilder is used only for > special cases presently and not widely used. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (TOBAGO-1897) Tooltip for badge component
[ https://issues.apache.org/jira/browse/TOBAGO-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Noeth resolved TOBAGO-1897. --- Resolution: Fixed > Tooltip for badge component > --- > > Key: TOBAGO-1897 > URL: https://issues.apache.org/jira/browse/TOBAGO-1897 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 4.2.0 >Reporter: Henning Noeth >Assignee: Henning Noeth >Priority: Minor > Fix For: 4.3.0 > > > Add a tooltip-attribute for tc:badge. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
