[GitHub] [myfaces] volosied commented on pull request #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier
volosied commented on PR #504: URL: https://github.com/apache/myfaces/pull/504#issuecomment-1405997332 This code addresses the issue found in the TCK, but it fails in our tests. You can find the failures in the build log, for example: ``` Error: Tests run: 5, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 2.055 s <<< FAILURE! - in org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase Error: org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1 Time elapsed: 0.369 s <<< FAILURE! java.lang.AssertionError: expected null, but was:< /flow1_1.xhtml content /flow1/content.xhtml > at org.junit.Assert.fail(Assert.java:89) at org.junit.Assert.failNotNull(Assert.java:756) at org.junit.Assert.assertNull(Assert.java:738) at org.junit.Assert.assertNull(Assert.java:748) at org.apache.myfaces.application.flow.FlowMyFacesCDIRequestTestCase.testFlow1_1(FlowMyFacesCDIRequestTestCase.java:72) ``` https://github.com/apache/myfaces/blob/93a47f3c78716f0ff3c01227ee1cd5972aeb965b/impl/src/test/java/org/apache/myfaces/application/flow/FlowMyFacesCDIRequestTestCase.java#L59-L72 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4553) TCK spec/flows/intermediate failure: WELD-001303: No active contexts for scope type jakarta.faces.flow.FlowScoped
[
https://issues.apache.org/jira/browse/MYFACES-4553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17681175#comment-17681175
]
Volodymyr Siedlecki commented on MYFACES-4553:
--
I've pushed my draft PR, but I'm at a loss on how to properly address this
problem. I keep getting failures in one test suite or another.
[~tandraschko], is there any chance you could look into this? I saw you had
refactored the flow code a while ago and maybe you have a better idea of
addressing this error? It's one of the last TCK failures left.
Thanks!
> TCK spec/flows/intermediate failure: WELD-001303: No active contexts for
> scope type jakarta.faces.flow.FlowScoped
> -
>
> Key: MYFACES-4553
> URL: https://issues.apache.org/jira/browse/MYFACES-4553
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC4
>Reporter: Volodymyr Siedlecki
>Priority: Major
> Attachments: faces_flows_intermediate_web.war
>
>
> {color:#0e101a}The WELD-001303 error occurs because we are still in a flow,
> which means that the contextual storage for the flows has yet to be created.
> {color}
>
> {color:#0e101a}As MyFaces starts to look at the nodes, it first checks the
> switch condition: {color}
>
> {color:#0e101a}Switch Case: {color}
> [{color:#4a6ee0}https://github.com/jakartaee/faces/blob/3fae98234692ec16545a6d27cf36fabaeb883f9b/tck/old-tck/source/src/web/jsf/spec/flows/intermediate/maintain-customer-record/maintain-customer-record-flow.xml#L39{color}]
>
> {color:#0e101a}MyFace Check: {color}
> [{color:#4a6ee0}https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L645{color}]
>
>
> {color:#0e101a}This is a problem because the context for flowScope still
> needs to be created, as mentioned above. This flow transition, which causes
> the scope to be activated, doesn't happen
> until[applyFlowTransition|https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L368]
> which is much later. {color}
>
> {color:#0e101a}My only idea is to force a transition call before we check the
> nodes, which causes myfaces unit test failures. {color}
>
> {color:#0e101a}I also believe this is an issue in previous versions -- we
> were lucky since the flowScope implicit object was evaluated to null (since
> no scope was active), and the "flowScope.customerId == null" check
> passed.{color}
>
> {color:#0e101a}Unit Test Code:{color}
> *{color:#0e101a}spec/flows/intermediate:{color}*
> {color:#0e101a}Test:
> {color}[{color:#4a6ee0}https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/intermediate/URLClient.java#L59{color}]
> {color:#0e101a}
> {color}[{color:#4a6ee0}https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/intermediate/URLClient.java#L91{color}]
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] volosied opened a new pull request, #504: MYFACES-4553: Fix WELD-001303 By Forcing Flow Transition Earlier
volosied opened a new pull request, #504: URL: https://github.com/apache/myfaces/pull/504 Draft fix for https://issues.apache.org/jira/browse/MYFACES-4553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MYFACES-4553) TCK spec/flows/intermediate failure: WELD-001303: No active contexts for scope type jakarta.faces.flow.FlowScoped
Volodymyr Siedlecki created MYFACES-4553:
Summary: TCK spec/flows/intermediate failure: WELD-001303: No
active contexts for scope type jakarta.faces.flow.FlowScoped
Key: MYFACES-4553
URL: https://issues.apache.org/jira/browse/MYFACES-4553
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 4.0.0-RC4
Reporter: Volodymyr Siedlecki
Attachments: faces_flows_intermediate_web.war
{color:#0e101a}The WELD-001303 error occurs because we are still in a flow,
which means that the contextual storage for the flows has yet to be created.
{color}
{color:#0e101a}As MyFaces starts to look at the nodes, it first checks the
switch condition: {color}
{color:#0e101a}Switch Case: {color}
[{color:#4a6ee0}https://github.com/jakartaee/faces/blob/3fae98234692ec16545a6d27cf36fabaeb883f9b/tck/old-tck/source/src/web/jsf/spec/flows/intermediate/maintain-customer-record/maintain-customer-record-flow.xml#L39{color}]
{color:#0e101a}MyFace Check: {color}
[{color:#4a6ee0}https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L645{color}]
{color:#0e101a}This is a problem because the context for flowScope still needs
to be created, as mentioned above. This flow transition, which causes the scope
to be activated, doesn't happen
until[applyFlowTransition|https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L368]
which is much later. {color}
{color:#0e101a}My only idea is to force a transition call before we check the
nodes, which causes myfaces unit test failures. {color}
{color:#0e101a}I also believe this is an issue in previous versions -- we were
lucky since the flowScope implicit object was evaluated to null (since no scope
was active), and the "flowScope.customerId == null" check passed.{color}
{color:#0e101a}Unit Test Code:{color}
*{color:#0e101a}spec/flows/intermediate:{color}*
{color:#0e101a}Test:
{color}[{color:#4a6ee0}https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/intermediate/URLClient.java#L59{color}]
{color:#0e101a}
{color}[{color:#4a6ee0}https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/intermediate/URLClient.java#L91{color}]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MYFACES-4552) TCK spec/flows/basicswitch failure caused by
[
https://issues.apache.org/jira/browse/MYFACES-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Siedlecki updated MYFACES-4552:
-
Status: Patch Available (was: Open)
> TCK spec/flows/basicswitch failure caused by
> -
>
> Key: MYFACES-4552
> URL: https://issues.apache.org/jira/browse/MYFACES-4552
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC4
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Switch case test failed for flow b / switch c in the test.
> Test:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L61]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L95]
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}switch{color}{color:#d4d4d4}
> {color}{color:#9cdcfe}id{color}{color:#d4d4d4}={color}{color:#ce9178}"switchC"{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case01}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page01{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case02}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page02{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case03}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page03{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}default-outcome{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.defaultOutcome}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> The switch conditions were false so the code should have used the default
> outcome.
> [https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L838-L849]
> However, the outcome was null because it was improperly set during the
> [FacesConfigUnmarshallerImpl.java|https://github.com/volosied/myfaces/commit/497627a32428302687ff5ca16cc3010730e222e5#diff-1de16b2e8a076b0f0b951eddf5a4ab698d1c5e7d88e1565cd997c3569d5f6305]
> code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MYFACES-4552) TCK spec/flows/basicswitch failure caused by
[
https://issues.apache.org/jira/browse/MYFACES-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Siedlecki updated MYFACES-4552:
-
Status: Open (was: Patch Available)
> TCK spec/flows/basicswitch failure caused by
> -
>
> Key: MYFACES-4552
> URL: https://issues.apache.org/jira/browse/MYFACES-4552
> Project: MyFaces Core
> Issue Type: Bug
>Affects Versions: 4.0.0-RC4
>Reporter: Volodymyr Siedlecki
>Priority: Major
>
> Switch case test failed for flow b / switch c in the test.
> Test:
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L61]
> [https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L95]
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}switch{color}{color:#d4d4d4}
> {color}{color:#9cdcfe}id{color}{color:#d4d4d4}={color}{color:#ce9178}"switchC"{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case01}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page01{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case02}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page02{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case03}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page03{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}<{color}{color:#569cd6}default-outcome{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.defaultOutcome}{color}{color:#808080}{color}
> {color:#d4d4d4}
> {color}{color:#808080}{color}
> The switch conditions were false so the code should have used the default
> outcome.
> [https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L838-L849]
> However, the outcome was null because it was improperly set during the
> [FacesConfigUnmarshallerImpl.java|https://github.com/volosied/myfaces/commit/497627a32428302687ff5ca16cc3010730e222e5#diff-1de16b2e8a076b0f0b951eddf5a4ab698d1c5e7d88e1565cd997c3569d5f6305]
> code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces] volosied opened a new pull request, #503: Fix correct attribute
volosied opened a new pull request, #503: URL: https://github.com/apache/myfaces/pull/503 https://issues.apache.org/jira/browse/MYFACES-4552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MYFACES-4552) TCK spec/flows/basicswitch failure caused by
Volodymyr Siedlecki created MYFACES-4552:
Summary: TCK spec/flows/basicswitch failure caused by
Key: MYFACES-4552
URL: https://issues.apache.org/jira/browse/MYFACES-4552
Project: MyFaces Core
Issue Type: Bug
Affects Versions: 4.0.0-RC4
Reporter: Volodymyr Siedlecki
Switch case test failed for flow b / switch c in the test.
Test:
[https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L61]
[https://github.com/jakartaee/faces/blob/4.0.1/tck/old-tck/source/src/com/sun/ts/tests/jsf/spec/flows/basicswitch/URLClient.java#L95]
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}switch{color}{color:#d4d4d4}
{color}{color:#9cdcfe}id{color}{color:#d4d4d4}={color}{color:#ce9178}"switchC"{color}{color:#808080}>{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case01}{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page01{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case02}{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page02{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}case{color}{color:#808080}>{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}if{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.switchC_Case03}{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}from-outcome{color}{color:#808080}>{color}{color:#d4d4d4}page03{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}<{color}{color:#569cd6}default-outcome{color}{color:#808080}>{color}{color:#d4d4d4}#\{flow_b_Bean.defaultOutcome}{color}{color:#808080}{color}
{color:#d4d4d4}
{color}{color:#808080}{color}
The switch conditions were false so the code should have used the default
outcome.
[https://github.com/apache/myfaces/blob/8956fd167f797a4e32511e268a6520715cb132a5/impl/src/main/java/org/apache/myfaces/application/NavigationHandlerImpl.java#L838-L849]
However, the outcome was null because it was improperly set during the
[FacesConfigUnmarshallerImpl.java|https://github.com/volosied/myfaces/commit/497627a32428302687ff5ca16cc3010730e222e5#diff-1de16b2e8a076b0f0b951eddf5a4ab698d1c5e7d88e1565cd997c3569d5f6305]
code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [myfaces-homepage] volosied merged pull request #49: Update for 4.0.0-RC4
volosied merged PR #49: URL: https://github.com/apache/myfaces-homepage/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
+1 from me. We have the required number of votes for this release, so I'll conclude voting now and finalize this release. Thank you all! On 2023/01/26 12:54:08 Paul Nicolucci wrote: > +1 > > Regards, > Paul Nicolucci > > On Thu, Jan 26, 2023, 7:41 AM Werner Punz wrote: > > > +1 > > > > > > > > Am Do., 26. Jan. 2023 um 11:19 Uhr schrieb Thomas Andraschko < > > andraschko.tho...@gmail.com>: > > > >> +1 > >> > >> Bernd Bohmann schrieb am Do., 26. Jan. 2023, 10:25: > >> > >>> Here is my +1 > >>> > >>> Regards Bernd > >>> > >>> > >>> > >>> > >>> Melloware schrieb am Mi., 25. Jan. 2023, 13:57: > >>> > +1 from me it looks like all the Quarkus JARS are there this time! > > > On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: > > Hi, > > > > I was running the needed tasks to get the 4.0.0-RC4 release of Apache > > MyFaces core out. > > > > Please note that this vote concerns all of the following parts: > >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] > > > > The artifacts were deployed on nexus repo [1] for binary and source > > packages. > > > > The release notes could be found at [4]. > > > > The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 > when > > compared to 4.0.0-RC3. Please take a look at the attached > results.html. > > > > This release has not yet been run against the TCK. > > > > Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) > > > > Please note: This vote is "majority approval" with a minimum of three > > +1 votes (see [2]). > > > > > > [ ] +1 for community members who have reviewed the bits > > [ ] +0 > > [ ] -1 for fatal flaws that should cause these bits not to be > > released, and why. > > > > > > Thanks, > > > > Volodymyr > > > > [1] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ > > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > > [3] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ > > [4] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > > < > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > > > > >>> >
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
+1 Regards, Paul Nicolucci On Thu, Jan 26, 2023, 7:41 AM Werner Punz wrote: > +1 > > > > Am Do., 26. Jan. 2023 um 11:19 Uhr schrieb Thomas Andraschko < > andraschko.tho...@gmail.com>: > >> +1 >> >> Bernd Bohmann schrieb am Do., 26. Jan. 2023, 10:25: >> >>> Here is my +1 >>> >>> Regards Bernd >>> >>> >>> >>> >>> Melloware schrieb am Mi., 25. Jan. 2023, 13:57: >>> +1 from me it looks like all the Quarkus JARS are there this time! On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: > Hi, > > I was running the needed tasks to get the 4.0.0-RC4 release of Apache > MyFaces core out. > > Please note that this vote concerns all of the following parts: >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] > > The artifacts were deployed on nexus repo [1] for binary and source > packages. > > The release notes could be found at [4]. > > The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 when > compared to 4.0.0-RC3. Please take a look at the attached results.html. > > This release has not yet been run against the TCK. > > Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) > > Please note: This vote is "majority approval" with a minimum of three > +1 votes (see [2]). > > > [ ] +1 for community members who have reviewed the bits > [ ] +0 > [ ] -1 for fatal flaws that should cause these bits not to be > released, and why. > > > Thanks, > > Volodymyr > > [1] > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > [3] > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ > [4] > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > < https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > >>>
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
+1 Am Do., 26. Jan. 2023 um 11:19 Uhr schrieb Thomas Andraschko < andraschko.tho...@gmail.com>: > +1 > > Bernd Bohmann schrieb am Do., 26. Jan. 2023, 10:25: > >> Here is my +1 >> >> Regards Bernd >> >> >> >> >> Melloware schrieb am Mi., 25. Jan. 2023, 13:57: >> >>> +1 from me it looks like all the Quarkus JARS are there this time! >>> >>> >>> On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: >>> > Hi, >>> > >>> > I was running the needed tasks to get the 4.0.0-RC4 release of Apache >>> > MyFaces core out. >>> > >>> > Please note that this vote concerns all of the following parts: >>> >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] >>> > >>> > The artifacts were deployed on nexus repo [1] for binary and source >>> > packages. >>> > >>> > The release notes could be found at [4]. >>> > >>> > The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 when >>> > compared to 4.0.0-RC3. Please take a look at the attached results.html. >>> > >>> > This release has not yet been run against the TCK. >>> > >>> > Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) >>> > >>> > Please note: This vote is "majority approval" with a minimum of three >>> > +1 votes (see [2]). >>> > >>> > >>> > [ ] +1 for community members who have reviewed the bits >>> > [ ] +0 >>> > [ ] -1 for fatal flaws that should cause these bits not to be >>> > released, and why. >>> > >>> > >>> > Thanks, >>> > >>> > Volodymyr >>> > >>> > [1] >>> > >>> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ >>> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes >>> > [3] >>> > >>> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ >>> > [4] >>> > >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 >>> > < >>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 >>> > >>> >>
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
+1 Bernd Bohmann schrieb am Do., 26. Jan. 2023, 10:25: > Here is my +1 > > Regards Bernd > > > > > Melloware schrieb am Mi., 25. Jan. 2023, 13:57: > >> +1 from me it looks like all the Quarkus JARS are there this time! >> >> >> On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: >> > Hi, >> > >> > I was running the needed tasks to get the 4.0.0-RC4 release of Apache >> > MyFaces core out. >> > >> > Please note that this vote concerns all of the following parts: >> >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] >> > >> > The artifacts were deployed on nexus repo [1] for binary and source >> > packages. >> > >> > The release notes could be found at [4]. >> > >> > The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 when >> > compared to 4.0.0-RC3. Please take a look at the attached results.html. >> > >> > This release has not yet been run against the TCK. >> > >> > Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) >> > >> > Please note: This vote is "majority approval" with a minimum of three >> > +1 votes (see [2]). >> > >> > >> > [ ] +1 for community members who have reviewed the bits >> > [ ] +0 >> > [ ] -1 for fatal flaws that should cause these bits not to be >> > released, and why. >> > >> > >> > Thanks, >> > >> > Volodymyr >> > >> > [1] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ >> > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes >> > [3] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ >> > [4] >> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 >> > < >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 >> > >> >
Re: [VOTE] Release of MyFaces Core 4.0.0-RC4
Here is my +1 Regards Bernd Melloware schrieb am Mi., 25. Jan. 2023, 13:57: > +1 from me it looks like all the Quarkus JARS are there this time! > > > On 1/24/2023 10:08 PM, Volodymyr Siedlecki wrote: > > Hi, > > > > I was running the needed tasks to get the 4.0.0-RC4 release of Apache > > MyFaces core out. > > > > Please note that this vote concerns all of the following parts: > >1. Maven artifact group "org.apache.myfaces.core" v4.0.0-RC4 [1] > > > > The artifacts were deployed on nexus repo [1] for binary and source > > packages. > > > > The release notes could be found at [4]. > > > > The japicmp tool shows no binary incompatibilities with 4.0.0-RC4 when > > compared to 4.0.0-RC3. Please take a look at the attached results.html. > > > > This release has not yet been run against the TCK. > > > > Please take a look at the "4.0.0-RC4" artifacts and vote! (see [3]) > > > > Please note: This vote is "majority approval" with a minimum of three > > +1 votes (see [2]). > > > > > > [ ] +1 for community members who have reviewed the bits > > [ ] +0 > > [ ] -1 for fatal flaws that should cause these bits not to be > > released, and why. > > > > > > Thanks, > > > > Volodymyr > > > > [1] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/ > > [2] http://www.apache.org/foundation/voting.html#ReleaseVotes > > [3] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1222/org/apache/myfaces/core/myfaces-core-assembly/ > > [4] > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > > < > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600=12352692 > > >
Re: [VOTE] Release Tobago 5.5.0 and checkstyle-rules 21
Here my +1 Regards Bernd Volker Weber schrieb am Do., 26. Jan. 2023, 09:18: > Hi, > > +1 > > Regards, > > Volker > > Am Mi., 25. Jan. 2023 um 20:54 Uhr schrieb Henning Nöth < > henning.no...@irian.eu>: > >> +1 >> >> Am 24.01.23 um 23:30 schrieb Udo Schnurpfeil: >> > Hello, >> > >> > we would like to release: >> > * Tobago 5.5.0 >> > * checkstyle-rules 21 >> > >> > The artifacts were deployed on nexus repository for binary and source >> > packages: >> > * Tobago 5.5.0 [1] & checkstyle-rules 21 [2] >> > >> > The release notes are in Jira: >> > * Tobago 5.5.0 [3] >> > >> > The artifacts are available at the staging repository (Nexus) at: >> > >> > * Tobago 5.5.0 [4] (sha-256 >> > eddd3525cd7588078eb9a470e20ccc6f815d3435031783a6942461c57de621e9) >> > * checkstyle-rules 21 [5] (sha-256 >> > 4cd46e160afc8e8687e20153410042566bde0c04d2dc256836490af2dc4b5935) >> > >> > Please vote now! (The vote is open for 72h.) >> > >> > [ ] +1 >> > [ ] +0 >> > [ ] -1 >> > >> > Regards, >> > >> > Udo >> > >> > [1] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1221 >> > [1] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1220 >> > [2] https://issues.apache.org/jira/projects/TOBAGO/versions/12352597 >> > [3] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1221/org/apache/myfaces/tobago/tobago/5.5.0/tobago-5.5.0-source-release.zip >> > [4] >> > >> https://repository.apache.org/content/repositories/orgapachemyfaces-1220/org/apache/myfaces/buildtools/checkstyle-rules/21/checkstyle-rules-21-source-release.zip >> > >> > >> > >> > > > -- > inexso - information exchange solutions GmbH > Ofener Straße 30 | 26121 Oldenburg > www.inexso.de >
Re: [VOTE] Release Tobago 5.5.0 and checkstyle-rules 21
Hi, +1 Regards, Volker Am Mi., 25. Jan. 2023 um 20:54 Uhr schrieb Henning Nöth < henning.no...@irian.eu>: > +1 > > Am 24.01.23 um 23:30 schrieb Udo Schnurpfeil: > > Hello, > > > > we would like to release: > > * Tobago 5.5.0 > > * checkstyle-rules 21 > > > > The artifacts were deployed on nexus repository for binary and source > > packages: > > * Tobago 5.5.0 [1] & checkstyle-rules 21 [2] > > > > The release notes are in Jira: > > * Tobago 5.5.0 [3] > > > > The artifacts are available at the staging repository (Nexus) at: > > > > * Tobago 5.5.0 [4] (sha-256 > > eddd3525cd7588078eb9a470e20ccc6f815d3435031783a6942461c57de621e9) > > * checkstyle-rules 21 [5] (sha-256 > > 4cd46e160afc8e8687e20153410042566bde0c04d2dc256836490af2dc4b5935) > > > > Please vote now! (The vote is open for 72h.) > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > Regards, > > > > Udo > > > > [1] > > https://repository.apache.org/content/repositories/orgapachemyfaces-1221 > > [1] > > https://repository.apache.org/content/repositories/orgapachemyfaces-1220 > > [2] https://issues.apache.org/jira/projects/TOBAGO/versions/12352597 > > [3] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1221/org/apache/myfaces/tobago/tobago/5.5.0/tobago-5.5.0-source-release.zip > > [4] > > > https://repository.apache.org/content/repositories/orgapachemyfaces-1220/org/apache/myfaces/buildtools/checkstyle-rules/21/checkstyle-rules-21-source-release.zip > > > > > > > -- inexso - information exchange solutions GmbH Ofener Straße 30 | 26121 Oldenburg www.inexso.de
