Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied merged PR #675: URL: https://github.com/apache/myfaces/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825840 Oh yeah I tested 17 first. All working once I removed that `javax.validation` depenendency which was not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825706 It looks to work now with 17 ( new terminal). I guess something got messed up. Let me clean up the PR and we can merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904822695 *head shake* Sorry, I mean 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904821489 switching to 11 in Showcase pom.xml still works for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904814371 Thanks for looking at this. Can you also try again but with `11`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904774469 I just built your branch locally and its working for me now.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904765314 I just removed it i don't even think its needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904755648 In the Quarkus Showcase pom.xml shouldn't this be changed to Jakarta? ```xml javax.validation validation-api 2.0.1.Final ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462380480 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: let me take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462378661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Correct -- 4.0 is still 11. 4.1 is now part of EE11 which requires a minimum of Java 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462379648 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Hmm -- I tried again and it failed? :( Not sure what's going on Once I get past this, I think I can get some releases out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376946 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376233 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Reverting this change make the tests pass: ``` [INFO] [INFO] Reactor Summary for Apache MyFaces Core 4.1 - Extensions 4.1.0-SNAPSHOT: [INFO] [INFO] Apache MyFaces Core 4.1 - Extensions ... SUCCESS [ 1.078 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus . SUCCESS [ 0.201 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Runtime SUCCESS [ 2.328 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Deployment SUCCESS [ 1.365 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Showcase SUCCESS [ 9.112 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.224 s [INFO] Finished at: 2024-01-22T15:23:22-05:00 [INFO] ``` @melloware -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462375420 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Nope i was just making sure 4.1 minimum version would be 17 now. I know 4.0 we are keeping at 11 right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462374031 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Do you need Quarkus on Java 11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462373170 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: It would. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462372661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Will this make 4.1 JDK 17 only for users? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Depdency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904738198 @melloware @tandraschko I'm getting the following error. Could either of figure out why? ``` [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.393 s <<< FAILURE! - in org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest [ERROR] org.apache.myfaces.core.extensions.quarkus.showcase.QuarkusMyFacesShowcaseTest Time elapsed: 1.393 s <<< ERROR! java.lang.RuntimeException: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.myfaces.core.extensions.quarkus.deployment.MyFacesProcessor Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: org.apache.myfaces.core.extensions.quarkus.deployment.MyFacesProcessor Caused by: java.lang.ClassNotFoundException: org.apache.myfaces.core.extensions.quarkus.deployment.MyFacesProcessor [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] QuarkusMyFacesShowcaseTest » Runtime java.lang.RuntimeException: java.lang.Cla... [INFO] [ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] 4.1.x: Support Java 17 & Depdency Updates [myfaces]
volosied opened a new pull request, #675: URL: https://github.com/apache/myfaces/pull/675 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[VOTE] Release Tobago 6.2.0 and Tobago 5.10.0
Hello, we would like to release: * Tobago 6.2.0 * Tobago 5.10.0 The artifacts were deployed on nexus repository for binary and source packages: * Tobago 6.2.0 [1] * Tobago 5.10.0 [1] The release notes are in Jira: * Tobago 6.2.0 [2] * Tobago 5.10.0 [3] The artifacts are available at the staging repository (Nexus) at: * Tobago 6.2.0 [4] (sha-256 ba72c8d3aae905779bd13567eb4f65eba9b340b5af2fa8645eb05991a0249e32) * Tobago 5.10.0 [5] (sha-256 c35090d3154c304ab67adfece69e5b545ee5263a7a06be3f00d8b915279c747a) Please vote now! (The vote is open for 72h.) [ ] +1 [ ] +0 [ ] -1 Regards, Henning [1] https://repository.apache.org/content/repositories/orgapachemyfaces-1239/ [2] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353966 [3] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353965 [4] https://repository.apache.org/content/repositories/orgapachemyfaces-1239/org/apache/myfaces/tobago/tobago/6.2.0/tobago-6.2.0-source-release.zip [5] https://repository.apache.org/content/repositories/orgapachemyfaces-1239/org/apache/myfaces/tobago/tobago/5.10.0/tobago-5.10.0-source-release.zip
Re: [PR] chore(deps): bump actions/cache from 3 to 4 [myfaces-master-pom]
melloware merged PR #101: URL: https://github.com/apache/myfaces-master-pom/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: update to minor version [myfaces-tobago]
henningn merged PR #4803: URL: https://github.com/apache/myfaces-tobago/pull/4803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] chore: update to minor version [myfaces-tobago]
henningn merged PR #4802: URL: https://github.com/apache/myfaces-tobago/pull/4802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] chore: update to minor version [myfaces-tobago]
henningn opened a new pull request, #4803: URL: https://github.com/apache/myfaces-tobago/pull/4803 Update to minor version because of: * https://issues.apache.org/jira/browse/TOBAGO-2272 * https://issues.apache.org/jira/browse/TOBAGO-2276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] refactor: update to minor version [myfaces-tobago]
henningn opened a new pull request, #4802: URL: https://github.com/apache/myfaces-tobago/pull/4802 Update to minor version because of: * https://issues.apache.org/jira/browse/TOBAGO-2272 * https://issues.apache.org/jira/browse/TOBAGO-2276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] WIP feat: Support for PassThroughAttributes in Tobago [myfaces-tobago]
bohmber opened a new pull request, #4801: URL: https://github.com/apache/myfaces-tobago/pull/4801 issue: TOBAGO-2277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (TOBAGO-2277) Support for PassthroughAttributes in Tobago
Bernd Bohmann created TOBAGO-2277: - Summary: Support for PassthroughAttributes in Tobago Key: TOBAGO-2277 URL: https://issues.apache.org/jira/browse/TOBAGO-2277 Project: MyFaces Tobago Issue Type: Improvement Components: Core Affects Versions: 6.1.0, 5.9.0 Reporter: Bernd Bohmann Assignee: Bernd Bohmann -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix: test-scenarios-locally.sh [myfaces-tobago]
henningn merged PR #4800: URL: https://github.com/apache/myfaces-tobago/pull/4800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix: test-scenarios-locally.sh [myfaces-tobago]
henningn opened a new pull request, #4800: URL: https://github.com/apache/myfaces-tobago/pull/4800 * use context path for Tomcat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (TOBAGO-2273) Avoid warning log message for required|converter|validatorMessage attribute
[ https://issues.apache.org/jira/browse/TOBAGO-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-2273. --- Resolution: Fixed > Avoid warning log message for required|converter|validatorMessage attribute > --- > > Key: TOBAGO-2273 > URL: https://issues.apache.org/jira/browse/TOBAGO-2273 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 5.9.0, 6.1.0 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 5.9.1, 6.1.1 > > > Can't find enum for Attributes with name 'requiredMessage' > I think the warning is useless. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2276) Allow selectionMode only for columnSelector
[ https://issues.apache.org/jira/browse/TOBAGO-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bernd Bohmann resolved TOBAGO-2276. --- Resolution: Fixed > Allow selectionMode only for columnSelector > --- > > Key: TOBAGO-2276 > URL: https://issues.apache.org/jira/browse/TOBAGO-2276 > Project: MyFaces Tobago > Issue Type: Improvement > Components: Core >Affects Versions: 5.9.0, 6.1.0 >Reporter: Bernd Bohmann >Assignee: Bernd Bohmann >Priority: Major > Fix For: 5.9.1, 6.1.1 > > > You can configure selectionMode none for the sheet and define a selectionMode > for the columnSelector only. Use case is rowSelection for show details and > columnSelector for executing action on rows. Selection will change with a > click inside the columnSelector column only. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (TOBAGO-2275) Lazy loading sheet: user cannot change width of columns
[ https://issues.apache.org/jira/browse/TOBAGO-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2275. -- Fix Version/s: 5.9.1 6.1.1 Resolution: Fixed > Lazy loading sheet: user cannot change width of columns > --- > > Key: TOBAGO-2275 > URL: https://issues.apache.org/jira/browse/TOBAGO-2275 > Project: MyFaces Tobago > Issue Type: Bug > Components: JavaScript >Affects Versions: 5.9.0, 6.1.0 >Reporter: Henning Nöth >Assignee: Henning Nöth >Priority: Major > Fix For: 5.9.1, 6.1.1 > > > A lazy sheet renders column-resize-buttons. But it doesn't work, except for > column one. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] fix(lazy-sheet): change column width [myfaces-tobago]
henningn merged PR #4798: URL: https://github.com/apache/myfaces-tobago/pull/4798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(lazy-sheet): change column width [myfaces-tobago]
henningn merged PR #4799: URL: https://github.com/apache/myfaces-tobago/pull/4799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix(lazy-sheet): change column width [myfaces-tobago]
henningn opened a new pull request, #4799: URL: https://github.com/apache/myfaces-tobago/pull/4799 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix(lazy-sheet): change column width [myfaces-tobago]
henningn opened a new pull request, #4798: URL: https://github.com/apache/myfaces-tobago/pull/4798 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
