Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
pnicolucci commented on PR #680: URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986145309 > OK cool so this should be forward ported to 5.x once its accepted. @melloware I can create a PR for 5.x once I merge here. Let me add @tandraschko and @volosied as reviewers as well to make sure they don't have any comment and I'll plan to merge this on Monday if no further feedback! Thanks for the quick review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
melloware commented on PR #680: URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986140168 OK cool so this should be forward ported to 5.x once its accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
pnicolucci commented on PR #680: URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986136436 > So is `AccessController.doPrivileged` just completely not needed anymore in JDK17? It is still in Java17 and accessible. One theme of Jakarta EE11 was to work on removing the references to the SecurityManager in anticipation of it being removed in a future Java version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MYFACES-4653) Faces 4.1 Spec Issue 1838: Remove references to the Java SecurityManager and associated APIs
[ https://issues.apache.org/jira/browse/MYFACES-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824840#comment-17824840 ] Paul Nicolucci commented on MYFACES-4653: - 4.1.x PR: https://github.com/apache/myfaces/pull/680 > Faces 4.1 Spec Issue 1838: Remove references to the Java SecurityManager and > associated APIs > > > Key: MYFACES-4653 > URL: https://issues.apache.org/jira/browse/MYFACES-4653 > Project: MyFaces Core > Issue Type: Bug > Components: General >Affects Versions: 4.1.0-RC1, 5.0.0 >Reporter: Paul Nicolucci >Assignee: Paul Nicolucci >Priority: Major > > Link to specification issue: [https://github.com/jakartaee/faces/issues/1838] > > We need to clean up our references to the SecurityManager and associated APIs. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MYFACES-4653: Remove SecurityManager and assocaited APIs [myfaces]
melloware commented on PR #680: URL: https://github.com/apache/myfaces/pull/680#issuecomment-1986132931 So is `AccessController.doPrivileged` just completely not needed anymore in JDK17? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Remove security manager [myfaces]
pnicolucci opened a new pull request, #680: URL: https://github.com/apache/myfaces/pull/680 https://issues.apache.org/jira/browse/MYFACES-4653 1. I've removed all the references to the SecurityManager and associated APIs in both the API and IMPL code. 2. I've cleaned up the SPI in general to have more consistent naming conventions for some variables. 3. I removed one comment in `DefaultFaceletFactory` that didn't look to be necessary any longer. Please give this one a good review to ensure I didn't miss anything as there are many changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [VOTE] Release Tobago 2.5.1
Here is my +1 Regards Bernd Werner Punz schrieb am Fr., 8. März 2024, 09:48: > +1 > > Werner > > > Am Do., 7. März 2024 um 10:23 Uhr schrieb Henning Nöth < > henning.no...@irian.eu>: > >> Hello, >> >> I've fixed the issue with the "forceVerticalScrollbar" attribute and >> want to start another vote for a Tobago 2.5.1 release. >> >> Changes since last release are: >> * fix: DuplicateIdException with TabGroup navigation Menu >> * fix: Sheet column header doesn't align with column content >> >> This is a PATCH release with backwards-compatible bug fixes. >> >> For a detail list please consult the release notes at: >> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353364 >> >> The version is available at the staging repository (Nexus) at: >> https://repository.apache.org/content/repositories/orgapachemyfaces-1246/ >> >> Source (sha-256 >> 41074d8c833f711fbc468bc560c490f3ee5ed2dac2dd4b6193395e0af5e07a65): >> >> https://repository.apache.org/content/repositories/orgapachemyfaces-1246/org/apache/myfaces/tobago/tobago/2.5.1/tobago-2.5.1-source-release.zip >> >> >> Please vote now! (The vote is open for 72h.) >> >> [ ] +1 >> [ ] +0 >> [ ] -1 >> >> Regards, >> Henning >> >
Re: [VOTE] Release Tobago 2.5.1
+1 Werner Am Do., 7. März 2024 um 10:23 Uhr schrieb Henning Nöth < henning.no...@irian.eu>: > Hello, > > I've fixed the issue with the "forceVerticalScrollbar" attribute and > want to start another vote for a Tobago 2.5.1 release. > > Changes since last release are: > * fix: DuplicateIdException with TabGroup navigation Menu > * fix: Sheet column header doesn't align with column content > > This is a PATCH release with backwards-compatible bug fixes. > > For a detail list please consult the release notes at: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273=12353364 > > The version is available at the staging repository (Nexus) at: > https://repository.apache.org/content/repositories/orgapachemyfaces-1246/ > > Source (sha-256 > 41074d8c833f711fbc468bc560c490f3ee5ed2dac2dd4b6193395e0af5e07a65): > > https://repository.apache.org/content/repositories/orgapachemyfaces-1246/org/apache/myfaces/tobago/tobago/2.5.1/tobago-2.5.1-source-release.zip > > > Please vote now! (The vote is open for 72h.) > > [ ] +1 > [ ] +0 > [ ] -1 > > Regards, > Henning >
