Re: [Facelets] deploying old Facelets templates with MyFaces 2
dojofaces testing is now possible on a snapshot I've built from trunk. Minor bugs do occur, I'll bring them in through JIRA. Cool stuff, great work, thank you. Best regards, Ganesh Matthias Wessendorf schrieb: that's great! The more feedback (from different lib) we get, the better On Fri, Feb 26, 2010 at 9:16 AM, Ganesh gan...@j4fry.org wrote: Thank you so much everyone for your efforts. I will instantly start testing with dojofaces and report my progres. Matthias Wessendorf schrieb: can you try, now ? On Thu, Feb 25, 2010 at 7:53 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Great! 2010/2/27 Ganesh gan...@j4fry.org dojofaces testing is now possible on a snapshot I've built from trunk. Minor bugs do occur, I'll bring them in through JIRA. Cool stuff, great work, thank you. Best regards, Ganesh Matthias Wessendorf schrieb: that's great! The more feedback (from different lib) we get, the better On Fri, Feb 26, 2010 at 9:16 AM, Ganesh gan...@j4fry.org wrote: Thank you so much everyone for your efforts. I will instantly start testing with dojofaces and report my progres. Matthias Wessendorf schrieb: can you try, now ? On Thu, Feb 25, 2010 at 7:53 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Thank you so much everyone for your efforts. I will instantly start testing with dojofaces and report my progres. Matthias Wessendorf schrieb: can you try, now ? On Thu, Feb 25, 2010 at 7:53 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
that's great! The more feedback (from different lib) we get, the better On Fri, Feb 26, 2010 at 9:16 AM, Ganesh gan...@j4fry.org wrote: Thank you so much everyone for your efforts. I will instantly start testing with dojofaces and report my progres. Matthias Wessendorf schrieb: can you try, now ? On Thu, Feb 25, 2010 at 7:53 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
+1 on sooner arrival as later. Current behavior is just lame On Thu, Feb 25, 2010 at 1:33 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
It works now ;) 2010/2/25 Matthias Wessendorf mat...@apache.org +1 on sooner arrival as later. Current behavior is just lame On Thu, Feb 25, 2010 at 1:33 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
but... the spec *clearly* says that if you extend from OLD facelet classes, you have to have to ship it. On Thu, Feb 25, 2010 at 1:37 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi, But the users DO want to run the old facelets taglibs and, as discussed before, 95% of the old taglibs don't rely on com.sun.facelets classes, they just define tags via xhtml files. If they get a ClassCastException the just have to use the old facelets-1.1.x. This is excatly what the spec says! Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi The problem is the spec is not explicit about that. I think the way it this written those paragraph are as if it was a guideline and that's is the problem because this should be explicit. The behavior proposed (throw ClassNotFoundException or ClassCastException and kick all users to use facelets 1.1.x) is valid, so it is ok to commit it. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi, But the users DO want to run the old facelets taglibs and, as discussed before, 95% of the old taglibs don't rely on com.sun.facelets classes, they just define tags via xhtml files. If they get a ClassCastException the just have to use the old facelets-1.1.x. This is excatly what the spec says! Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
From the spec (10.1.2): A decision was made early in this process to strive for backwards compatibility between the latest popular version of Facelets and Facelets in JSF 2.0. The sole determinant to backwards compatibility lies in the answer to the question, === is there any Java code in the application, or in libraries used by the application, that extends from or depends on any class in package com.sun.facelets and/or its sub-packages? If the answer to this question is yes, Facelets in JSF 2.0 is not backwards compatibile with Facelets and such an application must continue to bundle the Facelets jar file along with the application, continue to set the Facelets configuration parameters, and also set the javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER context-param to true. Please see Section 11.1.3 Application Configuration Parameters for details on this option. Any code that extends or depends on any class in package com.sun.facelets and/or its sub-packages must be modified to depend on the appropriate classes in package javax.faces.webapp.vdl and/or its subpackages. === Also note the *java* in java code. -Matthias On Thu, Feb 25, 2010 at 1:56 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi The problem is the spec is not explicit about that. I think the way it this written those paragraph are as if it was a guideline and that's is the problem because this should be explicit. The behavior proposed (throw ClassNotFoundException or ClassCastException and kick all users to use facelets 1.1.x) is valid, so it is ok to commit it. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi, But the users DO want to run the old facelets taglibs and, as discussed before, 95% of the old taglibs don't rely on com.sun.facelets classes, they just define tags via xhtml files. If they get a ClassCastException the just have to use the old facelets-1.1.x. This is excatly what the spec says! Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Note that this behavior implies that all applications that are using JSP and are upgraded to JSF 2.0 needs to add javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER to work correctly, otherwise if the parser reads a bad facelet taglib file it could throw ClassXXXExceptions. I would like to prevent that. And the code on ViewDeclarationLanguageFactoryImpl does not take into consideration the trinidad + facelets ViewHandler config style (check for class to know if facelets is on is a bad idea). In few words, we have to solve MYFACES-2564 too. regards, Leonardo Uribe The code reverted on MYFACES-2564 needs to be applied too, but care must be taken into account 2010/2/25 Matthias Wessendorf mat...@apache.org From the spec (10.1.2): A decision was made early in this process to strive for backwards compatibility between the latest popular version of Facelets and Facelets in JSF 2.0. The sole determinant to backwards compatibility lies in the answer to the question, === is there any Java code in the application, or in libraries used by the application, that extends from or depends on any class in package com.sun.facelets and/or its sub-packages? If the answer to this question is yes, Facelets in JSF 2.0 is not backwards compatibile with Facelets and such an application must continue to bundle the Facelets jar file along with the application, continue to set the Facelets configuration parameters, and also set the javax.faces.DISABLE_FACELET_JSF_VIEWHANDLER context-param to true. Please see Section 11.1.3 Application Configuration Parameters for details on this option. Any code that extends or depends on any class in package com.sun.facelets and/or its sub-packages must be modified to depend on the appropriate classes in package javax.faces.webapp.vdl and/or its subpackages. === Also note the *java* in java code. -Matthias On Thu, Feb 25, 2010 at 1:56 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi The problem is the spec is not explicit about that. I think the way it this written those paragraph are as if it was a guideline and that's is the problem because this should be explicit. The behavior proposed (throw ClassNotFoundException or ClassCastException and kick all users to use facelets 1.1.x) is valid, so it is ok to commit it. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi, But the users DO want to run the old facelets taglibs and, as discussed before, 95% of the old taglibs don't rely on com.sun.facelets classes, they just define tags via xhtml files. If they get a ClassCastException the just have to use the old facelets-1.1.x. This is excatly what the spec says! Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi If we read every facelet 1.1.x tag lib xml file, it is possible to get ClassNotFoundException. The problem with this behavior is that it does not give the chance to users to fix it without change the original jar file. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com Hi Leo, It is a really easy fix - I just removed the version check in TagLibraryConfig to make old libraries work. If the EG changes the spec in this field we can apply this later. In the meantime, I think we clearly should support old facelets taglibs. Regards, Jakob 2010/2/25 Leonardo Uribe lu4...@gmail.com Hi Before commit it I would like to have the description about how this should work and ask or notify the EG about this behavior (so if they decide something different we have a chance to do it right). Since ri is doing something in this field, I think we can commit a solution for that. regards, Leonardo Uribe 2010/2/25 Jakob Korherr jakob.korh...@gmail.com I'll do it! I also have a working version running locally at the moment, I just have to test it a little more. Then I'll commit it ;) Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias On Thu, Feb 25, 2010 at 8:47 AM, Ganesh gan...@j4fry.org wrote: Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter:
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Leo, Did you check the solution I proposed? Best regards, Ganesh Leonardo Uribe schrieb: In few words, we have to solve MYFACES-2564 too.
Re: [Facelets] deploying old Facelets templates with MyFaces 2
can you try, now ? On Thu, Feb 25, 2010 at 7:53 PM, Jakob Korherr jakob.korh...@gmail.com wrote: Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi, I implemented the lookup for the presence of the facelets-1.1.x view-handler in the faces-config.xml in the factory, so that the users don't have to explicitly set the related web.xml config parameter when they already said that they want to use facelets-1.1.x in faces-config.xml (via defining the facelets-1.1.x view-handler). Mojarra actually does exactly the same. Regards, Jakob 2010/2/25 Matthias Wessendorf mat...@apache.org On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
On Thu, Feb 25, 2010 at 7:15 PM, Leonardo Uribe lu4...@gmail.com wrote: Hi Ganesh I think dojofaces will not work until apply the patch on MYFACES-2564 (look on subversion commits). This change was reverted but now we need it to complete the solution. Anyway we need to change it a little and maybe remove the code that checks for facelets view handler and takes into account to right, as I understand it users are asked/forced to get rid of that. -M check if it is facelets for jsf 2.0 working or not. regards, Leonardo Uribe 2010/2/25 Matthias Wessendorf mat...@apache.org it should work, by now, just go svn up on trunk. I am interested in the results of testing your project. thx On Thu, Feb 25, 2010 at 7:08 PM, Ganesh gan...@j4fry.org wrote: Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Hi Matthias, Currently I'm putting my effords into dojofaces, so interest is there, but time is scarce ... sorry. Best regards, Ganesh Matthias Wessendorf schrieb: Yeah, I understand that. Any interest in helping with the fix ? :) -Matthias
[Facelets] deploying old Facelets templates with MyFaces 2
Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: [Facelets] deploying old Facelets templates with MyFaces 2
Also this blocks me from testing the beta with DojoFaces which might reveal other issues ... Best regards, Ganesh Matthias Wessendorf schrieb: Again... MYFACES-2543 *snip* If the answer to this question is no, Facelets in JSF 2.0 is backwards compatible with pre-JSF 2.0 Facelets and such an application must not continue to bundle the Facelets jar file along with the application, and must not continue to set the Facelets configuration parameters. *snip* So, this is actually blocking a reasonable use-case. Please keep the bug open ;-) -Matthias
