[jira] [Commented] (MYFACES-4227) Dynamic Resource Loading doesn't work

2018-06-22 Thread Thomas Andraschko (JIRA)


[ 
https://issues.apache.org/jira/browse/MYFACES-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520338#comment-16520338
 ] 

Thomas Andraschko commented on MYFACES-4227:


Seems like the following happens:
The new component will correctly be created by Application#createComponent and 
our ApplicationImpl#_handleResourceDependencyAnnotations + 
#_handleResourceDependency correctly adds the resource to the viewroot via 
context.getViewRoot().addComponentResource.


Our PartialViewContextImpl#processRenderResource would also render the diff but 
it seems that the bridge between "we have a new resource" and "render the new 
resource" is not called.
It seems that this bridge should be HtmlScriptRenderer#processEvent and the 
equivalent StylesheetRenderer, but it isn't called.

> Dynamic Resource Loading doesn't work
> -
>
> Key: MYFACES-4227
> URL: https://issues.apache.org/jira/browse/MYFACES-4227
> Project: MyFaces Core
>  Issue Type: Bug
>  Components: JSR-372
>Affects Versions: 2.3.0, 2.3.1
>Reporter: Thomas Andraschko
>Priority: Major
> Fix For: 2.3.2
>
>
> [https://github.com/martin654/primefaces-test]
> Just run the example via jetty:run
> For MyFaces, you need to exchange Mojarra with MyFaces.
> It works fine in Mojarra but in MyFaces, the "javax.faces.Resource" update is 
> never rendered.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MYFACES-4227) Dynamic Resource Loading doesn't work

2018-05-03 Thread Thomas Andraschko (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462371#comment-16462371
 ] 

Thomas Andraschko commented on MYFACES-4227:


HtmlStylesheetRenderer and HtmlScriptRenderer#processEvent are also not called.

Not sure how it was designed
[~lu4242] Do you have some minutes to explain how it should be implemented (how 
the diff is calculcated) or can check the bug itself?

> Dynamic Resource Loading doesn't work
> -
>
> Key: MYFACES-4227
> URL: https://issues.apache.org/jira/browse/MYFACES-4227
> Project: MyFaces Core
>  Issue Type: Improvement
>  Components: JSR-372
>Affects Versions: 2.3.0, 2.3.1
>Reporter: Thomas Andraschko
>Priority: Major
> Fix For: 2.3.2
>
>
> [https://github.com/martin654/primefaces-test]
> Just run the example via jetty:run
> For MyFaces, you need to exchange Mojarra with MyFaces.
> It works fine in Mojarra but in MyFaces, the "javax.faces.Resource" update is 
> never rendered.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MYFACES-4227) Dynamic Resource Loading doesn't work

2018-05-03 Thread Thomas Andraschko (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462369#comment-16462369
 ] 

Thomas Andraschko commented on MYFACES-4227:


PartialViewContextImpl#processRenderResource is called for head but 
isRenderTarget returns false and getRenderTargetComponentList is empty, too.

> Dynamic Resource Loading doesn't work
> -
>
> Key: MYFACES-4227
> URL: https://issues.apache.org/jira/browse/MYFACES-4227
> Project: MyFaces Core
>  Issue Type: Improvement
>  Components: JSR-372
>Affects Versions: 2.3.0, 2.3.1
>Reporter: Thomas Andraschko
>Priority: Major
> Fix For: 2.3.2
>
>
> [https://github.com/martin654/primefaces-test]
> Just run the example via jetty:run
> For MyFaces, you need to exchange Mojarra with MyFaces.
> It works fine in Mojarra but in MyFaces, the "javax.faces.Resource" update is 
> never rendered.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)