Re: New faces.js/ts code ready for merge
Bug is fixed, I also added 3 unit tests to cover this part of the spec on unit test level on our side. Please test, if everything is ok we can start to merge. Cheers and happy evening Werner Am Mi., 2. Nov. 2022 um 10:31 Uhr schrieb Werner Punz : > HI I just got a small bug report in via a comment, I must have missed this > morning (thanks for pointing me towards it) > I just need to fix this (it is a small protocol part which is rarely used > which needs implementation) > I also will add the missing test. > > Once I am done with it I will wait a little bit for further comments and > objections and then go ahead. > > Am Mi., 2. Nov. 2022 um 10:27 Uhr schrieb Bernd Bohmann >: > >> Thanks Werner >> >> please go ahead. I will do some testing in the next 2 weeks as well. I >> think minor issues can be solved after the merge >> >> Regards >> >> Bernd >> >> On Wed, Nov 2, 2022 at 9:35 AM Werner Punz wrote: >> > >> > Hello >> > >> > I am back from my vacation, following. In my opinion the code is ready >> for merge and the target has been RC3 which would be, now. >> > Given I still have one pending review, did anyone test already, are >> there any objections to do so? >> > >> > I just wanted to ask before I go ahead with it. >> > >> > Werner >> > >> > PS: The integration testsuite will follow once the core code is in, >> because I have to retarget the tests then towards the implementation instead >> > of the embedded faces.js coming from my github package. >> > >> >
Re: New faces.js/ts code ready for merge
HI I just got a small bug report in via a comment, I must have missed this morning (thanks for pointing me towards it) I just need to fix this (it is a small protocol part which is rarely used which needs implementation) I also will add the missing test. Once I am done with it I will wait a little bit for further comments and objections and then go ahead. Am Mi., 2. Nov. 2022 um 10:27 Uhr schrieb Bernd Bohmann : > Thanks Werner > > please go ahead. I will do some testing in the next 2 weeks as well. I > think minor issues can be solved after the merge > > Regards > > Bernd > > On Wed, Nov 2, 2022 at 9:35 AM Werner Punz wrote: > > > > Hello > > > > I am back from my vacation, following. In my opinion the code is ready > for merge and the target has been RC3 which would be, now. > > Given I still have one pending review, did anyone test already, are > there any objections to do so? > > > > I just wanted to ask before I go ahead with it. > > > > Werner > > > > PS: The integration testsuite will follow once the core code is in, > because I have to retarget the tests then towards the implementation instead > > of the embedded faces.js coming from my github package. > > >
Re: New faces.js/ts code ready for merge
Thanks Werner please go ahead. I will do some testing in the next 2 weeks as well. I think minor issues can be solved after the merge Regards Bernd On Wed, Nov 2, 2022 at 9:35 AM Werner Punz wrote: > > Hello > > I am back from my vacation, following. In my opinion the code is ready for > merge and the target has been RC3 which would be, now. > Given I still have one pending review, did anyone test already, are there any > objections to do so? > > I just wanted to ask before I go ahead with it. > > Werner > > PS: The integration testsuite will follow once the core code is in, because I > have to retarget the tests then towards the implementation instead > of the embedded faces.js coming from my github package. >
New faces.js/ts code ready for merge
Hello I am back from my vacation, following. In my opinion the code is ready for merge and the target has been RC3 which would be, now. Given I still have one pending review, did anyone test already, are there any objections to do so? I just wanted to ask before I go ahead with it. Werner PS: The integration testsuite will follow once the core code is in, because I have to retarget the tests then towards the implementation instead of the embedded faces.js coming from my github package.
