Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied merged PR #675: URL: https://github.com/apache/myfaces/pull/675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825840 Oh yeah I tested 17 first. All working once I removed that `javax.validation` depenendency which was not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904825706 It looks to work now with 17 ( new terminal). I guess something got messed up. Let me clean up the PR and we can merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904822695 *head shake* Sorry, I mean 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904821489 switching to 11 in Showcase pom.xml still works for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904814371 Thanks for looking at this. Can you also try again but with `11`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904774469 I just built your branch locally and its working for me now.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904765314 I just removed it i don't even think its needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on PR #675: URL: https://github.com/apache/myfaces/pull/675#issuecomment-1904755648 In the Quarkus Showcase pom.xml shouldn't this be changed to Jakarta? ```xml javax.validation validation-api 2.0.1.Final ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462380480 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: let me take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462378661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Correct -- 4.0 is still 11. 4.1 is now part of EE11 which requires a minimum of Java 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462379648 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Hmm -- I tried again and it failed? :( Not sure what's going on Once I get past this, I think I can get some releases out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376946 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462376233 ## extensions/quarkus/showcase/pom.xml: ## @@ -34,7 +34,7 @@ 2.22.0 UTF-8 -11 +17 Review Comment: Reverting this change make the tests pass: ``` [INFO] [INFO] Reactor Summary for Apache MyFaces Core 4.1 - Extensions 4.1.0-SNAPSHOT: [INFO] [INFO] Apache MyFaces Core 4.1 - Extensions ... SUCCESS [ 1.078 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus . SUCCESS [ 0.201 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Runtime SUCCESS [ 2.328 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Deployment SUCCESS [ 1.365 s] [INFO] Apache MyFaces Core 4.1 - Extensions - Quarkus - Showcase SUCCESS [ 9.112 s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 14.224 s [INFO] Finished at: 2024-01-22T15:23:22-05:00 [INFO] ``` @melloware -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462375420 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Nope i was just making sure 4.1 minimum version would be 17 now. I know 4.0 we are keeping at 11 right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462374031 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Do you need Quarkus on Java 11? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
volosied commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462373170 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: It would. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] 4.1.x: Support Java 17 & Dependency Updates [myfaces]
melloware commented on code in PR #675: URL: https://github.com/apache/myfaces/pull/675#discussion_r1462372661 ## parent/pom.xml: ## @@ -510,7 +507,7 @@ -11 +17 Review Comment: Will this make 4.1 JDK 17 only for users? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myfaces.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
